* fix(studio): set HIP_VISIBLE_DEVICES in apply_gpu_ids for ROCm training workers Training workers are spawned via multiprocessing spawn before detect_hardware() runs, so IS_ROCM is still False. If the user never set HIP_VISIBLE_DEVICES in their shell, _inherits_rocm_visibility is also False, leaving the worker with only CUDA_VISIBLE_DEVICES set. On ROCm hosts the HIP runtime honors HIP_VISIBLE_DEVICES over CUDA_VISIBLE_DEVICES, so the worker saw the full device list and torch raised "no usable HIP accelerator" on some setups. Fall back to probing torch.version.hip (a build-time attribute, safe to read before GPU init) to detect ROCm when neither IS_ROCM nor inherited env vars are available. Mirrors the existing fix in llama_cpp.py for llama-server subprocess GPU pinning. Fixes https://github.com/unslothai/unsloth/issues/5180 * test: tighten apply_gpu_ids ROCm fallback assertions Replace loose OR chain with exact string matches, split into three focused tests, and add a guard check for the try/except wrapper. * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix: detect ROCm unified memory (Strix Halo / AMD iGPU) via torch fallback amd-smi on iGPUs with shared/unified memory (e.g. Radeon 8060S on Strix Halo) reports only the dedicated VRAM slice (~512 MB) in its metric output, so get_visible_gpu_utilization() was returning usable_gb ≈ 0.35 GB instead of the full GTT pool (~128 GB). torch.cuda.mem_get_info() already surfaces the correct unified-pool size. Add _reconcile_rocm_unified_memory(): after amd-smi returns a valid result on a ROCm device, cross-check each device's vram_total_gb against torch.cuda.mem_get_info(). When torch reports a larger total, replace the amd-smi VRAM fields in-place. No-op for discrete AMD GPUs where the two sources agree. Fixes: "Falling back to all visible GPUs -- model may not fit" on AMD iGPU machines even when 100+ GB of unified memory is available. * Apply unified-memory reconciliation in get_gpu_utilization too The visible-GPU path was already corrected for AMD iGPUs with unified memory (Strix Halo / Radeon 8060S), but get_gpu_utilization was still returning the raw 512 MB amd-smi VRAM slice. Studio's /api/train/hardware endpoint and the live GPU monitor read from this primary path, so users continued seeing the wrong total even after auto_select_gpu_ids picked the right device. Refactor to share the per-device correction: * _apply_unified_memory_correction(metrics, torch_info) -- the actual replacement logic, in-place on a single metrics dict. * _reconcile_rocm_unified_memory(...) -- multi-device, iterates utilization["devices"] (visible-GPU path). * _reconcile_primary_rocm_unified_memory(...) -- single flat metrics dict (primary-GPU path), uses parent_visible_spec to pick the primary index, falls back to ordinal 0 when no visibility env is set. get_gpu_utilization now calls the primary reconciler under IS_ROCM, so both endpoints surface the real unified-memory pool on iGPUs while leaving discrete AMD GPUs untouched (torch_total <= smi_total -> no replace). * Use 'is not None' and log debug on torch.version.hip probe failures Two small follow-ups to the apply_gpu_ids ROCm fallback: 1. Match detect_hardware()'s 'getattr(torch.version, "hip", None) is not None' form so the entire codebase has one canonical 'this torch was built with HIP' check. On every shipping torch wheel hip is either None or a non-empty version string, so the new form agrees with the old bool() form on every real install. 2. Log the probe failure at debug level instead of swallowing it silently. The broad 'except Exception' is intentional (we never want apply_gpu_ids to crash a worker over a probe), but the silent pass made it impossible to tell whether the fallback was firing or being skipped. * fix(studio): honour HIP_VISIBLE_DEVICES in _get_parent_visible_gpu_spec before IS_ROCM is set When a user has HIP_VISIBLE_DEVICES set in their shell (e.g. "1" to select GPU 1) but detect_hardware() has not yet run in the Studio parent process, IS_ROCM is still False. _get_parent_visible_gpu_spec() was gated on IS_ROCM so it fell through to CUDA_VISIBLE_DEVICES (unset), saw all physical GPUs, and auto-selected index 0. apply_gpu_ids then overwrote HIP_VISIBLE_DEVICES with "0", making the intended GPU invisible to ROCm torch in the worker, which triggered the "no usable HIP accelerator" error (issue #5180). Apply the same _inherits_rocm_visibility pattern already used in apply_gpu_ids: check for HIP_VISIBLE_DEVICES / ROCR_VISIBLE_DEVICES in the environment regardless of IS_ROCM so the correct GPU index is preserved. * fix(install): harden AMD ROCm GPU detection for multi-GPU and env-filtered setups The previous rocminfo awk pattern could miss discrete GPUs on machines where HIP_VISIBLE_DEVICES/ROCR_VISIBLE_DEVICES is used to mask an integrated GPU — the env vars filter rocminfo output but may not propagate into the install script subprocess, causing detection to fail entirely. Two changes: - Tighten rocminfo pattern from /gfx[0-9]/ && !/gfx000/ to /gfx[1-9][0-9]/ — simpler and correctly excludes the CPU agent (gfx000) without a negative lookahead - Add sysfs KFD topology fallback: reads /sys/class/kfd/kfd/topology/nodes/*/gpu_id which is a kernel-level view unaffected by HIP_VISIBLE_DEVICES or ROCR_VISIBLE_DEVICES Fixes detection failure reported in Discord by Chains (gfx1201 + iGPU machine where env var exclusion of the iGPU caused rocminfo to return no usable device). * Fix KFD sysfs awk fallback to read properties file The fallback added by this PR reads /sys/class/kfd/kfd/topology/nodes/*/gpu_id files but matches the literal token 'gpu_id' against their content. Those files contain only a single decimal value (e.g. '0' for CPU agents, '50432' for GPU agents), so the regex never matches and 'found' stays 0, making the fallback a no-op on every host. The properties file in the same directory contains key/value lines like 'gpu_id 50432' which is what the existing awk pattern expects. Reproduced with a synthetic sysfs layout: against gpu_id files awk exits 1; against properties files awk exits 0 when any node reports gpu_id > 0. * fix(setup.ps1): detect AMD ROCm GPU on Windows, bring to parity with setup.sh setup.ps1 only checked nvidia-smi and fell straight to "gpu: none" on AMD machines. setup.sh already probed rocminfo/amd-smi/hipconfig/hipinfo. Add three-tier detection mirroring install_llama_prebuilt.py's detect_host(): 1. hipinfo: gcnArchName in output confirms a real HIP GPU (not just SDK) 2. amd-smi list: "GPU: <digit>" data rows as fallback 3. WMI Win32_VideoController: last resort -- detects AMD GPU even without HIP SDK, then guides user to install it rather than silently going CPU Also corrects the "none" message to mention AMD ROCm alongside NVIDIA so users with AMD hardware understand the requirement. Fixes: rohit-style install where Strix Halo (Radeon 8060S) showed "gpu: none" even with the HIP SDK present. * fix(install.ps1): detect AMD ROCm GPU on Windows, bring to parity with setup.ps1 install.ps1 had the same nvidia-smi-only GPU detection as setup.ps1 before the setup.ps1 fix. Applies the same three-tier AMD detection: 1. hipinfo: gcnArchName confirms real HIP GPU 2. amd-smi list: GPU data rows as fallback 3. WMI Win32_VideoController: detects AMD GPU without HIP SDK and guides user to install it Fixes: install.ps1 showing "gpu: none" while setup.ps1 correctly showed "AMD GPU detected" on the same machine (reported by rohit, RX 7600 XT). * fix(install.ps1): suppress 'No NVIDIA GPU detected' when AMD GPU is present * feat: add Windows AMD ROCm PyTorch wheel installation install_python_stack.py: - Add _ROCM_WINDOWS_WHEEL_BASE and _ROCM_WINDOWS_RELEASES constants pointing to AMD repo.radeon.com (ROCm 7.2 -> torch 2.9.1+rocm7.2.1) - Extend _ensure_rocm_torch() with a Windows branch: detects ROCm via _has_rocm_gpu() / _detect_rocm_version(), requires Python 3.12 (cp312 is the only ABI AMD publishes for Windows), installs the direct wheel URL from repo.radeon.com install.ps1: - Capture ROCmVersion during AMD detection via hipconfig --version / amd-smi version (needed for wheel URL selection) - After Get-TorchIndexUrl, add an AMD wheel override block: when HasROCm and Python 3.12 detected, set ROCmTorchWheelUrl to AMD wheel URL - Expand torch install branch to handle ROCmTorchWheelUrl with uv pip install --force-reinstall --no-cache-dir * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix: also install torchvision and torchaudio from AMD Windows repo AMD publishes matching torchvision-0.24.1+rocm7.2.1 and torchaudio-2.9.1+rocm7.2.1 cp312 wheels at the same repo.radeon.com release folder. Install all three in both install.ps1 and install_python_stack.py Windows ROCm path. * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * feat: add ROCm 7.1.1 Windows wheel mapping AMD uses a different version string for 7.1.1 wheels: 2.9.0+rocmsdk20251116 (date-tagged) instead of +rocm7.1.1. Adds the 7.1.1 release folder to both install.ps1 and install_python_stack.py so users with ROCm 7.1 get ROCm torch instead of falling back to CPU. * fix: install rocm_sdk_core and rocm_sdk_libraries_custom alongside torch The AMD Windows torch wheels declare rocm[libraries]==<ver> as a hard dependency. Without installing rocm_sdk_core and rocm_sdk_libraries_custom from the same AMD release folder, uv cannot resolve the dependency and fails with 'No solution found'. Include all 5 wheels in one install call. * fix: expand ROCm wheel array to scalars for Invoke-InstallCommand @array splatting inside a scriptblock only works when the native command is prefixed with '&'. Invoke-InstallCommand uses '& $Command' to run the block, so @ROCmAllWheelUrls was not being expanded. Extract to scalar variables $rw0-$rw4 which are captured correctly by the closure. * fix: use --no-deps for AMD Windows torch wheel install uv's resolver looks up rocm[libraries]==0.1.dev0 on PyPI during dependency resolution before downloading any wheels, and fails because the package doesn't exist on PyPI. --no-deps skips resolution entirely and installs all 5 AMD wheels directly. The GPU runtime dependency is satisfied by the HIP SDK, not a Python package. * fix: setup.ps1 and install_python_stack.py now install ROCm torch on Windows setup.ps1 was always setting CuTag='cpu' for non-NVIDIA hosts and installing cpu-only PyTorch, overwriting the ROCm torch installed by install.ps1. Adds the same AMD wheel selection logic (ROCm version detection, Python 3.12 check, 5-wheel install with --no-deps) to setup.ps1's torch install block. install_python_stack.py: remove IS_WINDOWS guard from _ensure_rocm_torch() call site so the Windows path in _ensure_rocm_torch() is reachable during 'unsloth studio update' as well. * fix: suppress manual-install warning when ROCm torch already present; fix progress counter - Gate the 'must be installed manually' warning on torch.version.hip being empty so it doesn't fire when our ROCm torch install succeeded - Update _TOTAL counter to include the 3 ROCm steps on Windows now that _ensure_rocm_torch() is called there (fixes 10/9 display) * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * feat: add rocm step display in setup.ps1; fix warning and progress counter - Add 'rocm' step after 'cuda' in setup.ps1 showing ROCm version or HIP SDK missing - Move ROCm version detection up to GPU detection block so it's available early - Suppress 'must be installed manually' warning when torch.version.hip is set - Fix _TOTAL counter to include ROCm steps on Windows (fixes 10/9 display) * fix: detect AMD SDK ROCm torch via __version__ when torch.version.hip is unset AMD's repo.radeon.com wheels (e.g. 2.9.0+rocmsdk20251116) do not set torch.version.hip, leaving it None. All three probes that relied solely on torch.version.hip now also check for 'rocm' in torch.__version__.lower(): - hardware.py detect_hardware(): IS_ROCM was never set, causing the studio to report 'Hardware detected: CPU' even after AMD wheels were installed and HIP DLLs were on PATH. - install_python_stack.py _ensure_rocm_torch(): skip-if-already-installed probe would always reinstall on subsequent runs. - install_python_stack.py Windows AMD warning: suppression check always failed, so the 'must be installed manually' note kept appearing after a successful AMD wheel install. * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * perf: drop --no-cache-dir from AMD ROCm torch wheel installs uv caches downloaded wheels by default; passing --no-cache-dir forced a full redownload of the ~2 GB torch wheel on every install run. CUDA installs never had this flag -- AMD was the only path affected. * fix: use install-state flag instead of subprocess probe for AMD Windows warning Replace the subprocess torch probe in the post-install warning block with a module-level _rocm_windows_torch_installed flag set by _ensure_rocm_torch(). Subprocess re-import of torch is unnecessary and fragile -- the install function already knows whether it succeeded. * fix: hoist global declaration to top of _ensure_rocm_torch Python requires the global statement to appear before any assignment to the variable within a function. Moving it to the function top fixes the SyntaxError on line 354. * fix: pass AMD torch install status via env var to suppress false warning setup.ps1 now sets UNSLOTH_ROCM_TORCH_INSTALLED=1 after a successful AMD wheel install. install_python_stack.py reads this at the top of _ensure_rocm_torch() to skip both the subprocess probe and the warning -- no re-import of torch needed, and the warning message now correctly says 'could not be auto-installed' rather than 'must be installed manually'. * fix: register ROCm DLL directory before torch import on Windows Python 3.8+ ignores PATH for extension DLL loading on Windows; amdhip64.dll and other HIP runtime DLLs must be registered via os.add_dll_directory(). Without this, torch.cuda.is_available() always returns False on AMD ROCm Windows even when HIP_PATH is correctly set in system environment variables. Reads HIP_PATH / ROCM_PATH env vars first, then falls back to scanning common ROCm install roots (C:\Program Files\AMD\ROCm, F:\ROCm, C:\ROCm). * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix: remove hardcoded non-standard ROCm paths from DLL directory scan Only use HIP_PATH/ROCM_PATH (set by AMD installer) and the standard C:\Program Files\AMD\ROCm\<version>\bin location. Custom drive paths like F:\ROCm are user-specific and should not be hardcoded. * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix: prevent torchao overrides step from overwriting AMD ROCm torch torchao==0.14.0 in overrides.txt declares torch as a dependency. Without --no-deps, uv resolves torch from PyPI and installs 2.11.0+cpu on top of the AMD ROCm wheels (2.9.0+rocmsdk20251116). This was the root cause of 'Hardware detected: CPU' -- the AMD wheels were installed but then immediately overwritten by the overrides step. When _rocm_windows_torch_installed is True, add --no-deps to the overrides pip_install call so torchao is installed without pulling in CPU torch. * fix: add rocm_sdk namespace tarball to Windows ROCm wheel installs torch/_rocm_init.py calls `import rocm_sdk` at startup, which requires the rocm namespace tarball (rocm-*.tar.gz) in addition to the SDK wheel packages. This tarball was missing from both install.ps1 and setup.ps1, causing ModuleNotFoundError on first torch import. - Add rocm-0.1.dev0.tar.gz to ROCm 7.1.1 install (provides rocm_sdk namespace) - Add rocm-7.2.1.tar.gz + rocm_sdk_devel to ROCm 7.2.1 install - Install tarball in a dedicated step before main SDK/torch wheels - Switch to @array splatting in install.ps1 scriptblock for dynamic wheel count - Remove --no-cache-dir from Python-side ROCm wheel install (prevents ~2GB redownload) * feat: enable ROCm 7.2 torch install + warn on gfx1151 with ROCm < 7.2 Chigoma333 (AMD Radeon 8060S / gfx1151, Strix Halo) confirmed that ROCm 7.1 segfaults when tensors are moved to GPU, but ROCm 7.2 + torch 2.11.0+rocm7.2 works fully including training. Changes: - Uncomment (7,2): "rocm7.2" in _ROCM_TORCH_INDEX (was blocked by <2.11.0) - Add _ROCM_TORCH_PKG_SPECS dict with per-tag version bounds: rocm7.2 → torch>=2.11.0,<2.12.0; all older tags → <2.11.0 - Add _detect_amd_gfx_codes() helper that parses rocminfo output - Warn on gfx1151/gfx1150 (Strix Halo) when ROCm < 7.2 is installed, pointing users at the known segfault and recommending upgrade - install.sh get_torch_index_url(): enable rocm7.2 case (previously capped to rocm7.1), cap unknown future tags to rocm7.2 - install.sh: override TORCH_CONSTRAINT to >=2.11.0,<2.12.0 when rocm7.2 index is selected, so pip can actually resolve torch 2.11.0 * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix: prefer Python 3.12 for AMD ROCm users when 3.13 is also installed After GPU detection, if ROCm HIP SDK is found and the selected Python is not 3.12, run a second pass to locate a 3.12 install via py.exe and PATH (catches uv-managed installs). Switch $DetectedPython to 3.12 so the venv is created with a compatible interpreter for the cp312-only AMD Windows torch wheels. NVIDIA and Intel GPU paths are unaffected -- the re-detection block only runs when $HasROCm is true. Fixes: #5301 * fix: also check uv-managed Python 3.12 for AMD ROCm #5301 * fix: hide amd-smi console popups on Windows, guard torch.distributed.is_initialized for ROCm #5301 * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix: suppress remaining console popups on Windows, patch torch.distributed.is_initialized for ROCm #5301 * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix: stub all missing torch.distributed attrs for ROCm Windows wheel #5301 * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix: inject torch.distributed stub when C backend missing in ROCm Windows wheel #5301 * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix(rocm/windows): pre-stub torch._C._distributed_c10d + raise amd-smi timeout Two fixes for Windows ROCm regressions reported by electroglyph on #5301: 1. worker.py — torch.distributed stub now fires unconditionally on Windows The previous stub only injected sys.modules in the except branch, meaning it was silently skipped when `import torch.distributed` happened to succeed (the C backend is lazily resolved). The crash then hit later when transformers/trl triggered the lazy load. Fix: on win32 we pre-populate sys.modules['torch._C._distributed_c10d'] AND set the attribute on the torch._C extension module *before* attempting the import, covering both the early-ImportError and lazy-load failure modes. 2. amd.py — increase amd-smi timeout from 5 s to 30 s on Windows (10 s Linux) amd-smi on Windows must cold-init the ROCm runtime on first invocation; 5 s was consistently too short, producing repeated 'Command timed out' warnings in the server log. 30 s gives enough headroom without blocking indefinitely on broken installs. 3. install.ps1 — widen Python 3.12 enforcement to ROCmGpuLabel (WMI-only path) Users whose HIP SDK is not on PATH were detected via WMI but not switched to Python 3.12 before the install started, causing a second pass. Guard now fires on (HasROCm -or ROCmGpuLabel). * fix(rocm): guard c10d stub, fix TorchIndexFamily for 7.1, clean dead code + comments - worker.py: wrap c10d stub injection in `if _c10d_key not in sys.modules` so Windows NVIDIA users with a real torch.distributed are never affected - install.ps1: fix Get-TauriTorchIndexFamily receiving hardcoded "rocm7.2" even when ROCm 7.1 wheels are installed; now branches on $ROCmVersion - main.py: remove dead `import ctypes as _ctypes` (ctypes is never called) - hardware.py, install_python_stack.py, worker.py, install.ps1: shorten verbose multi-line comment blocks throughout - tests: update 4 stale assertions that expected rocm7.2 to be absent/capped * fix(tests): match windows AMD warning assertion to actual source string * chore: trim verbose comment blocks across all ROCm-related files * fix: guard reconcile call against None numeric_ids; add torchvision lower bounds * fix(install.ps1): recreate venv with Python 3.12 after ROCm switch Venv was created with 3.13 before GPU detection ran; switching $DetectedPython to 3.12 had no effect since $VenvPython still pointed to the 3.13 interpreter inside the already-created venv. * ux: detect AMD GPU before Python selection to avoid double venv creation - Early hipinfo + WMI probe runs before Find-CompatiblePython so Python 3.12 is selected upfront when AMD is detected; venv is now created exactly once instead of 3.13 then immediately 3.12. - Post-venv recreation block replaced with a simple warning for the rare case where AMD was missed by the early probe. - setup.ps1: show venv's actual Python version (e.g. 3.12) instead of the system Python found by the pre-activation search (was showing 3.13). * fix(rocm/win): auto-stub all _distributed_c10d symbols via PEP-562 __getattr__ The bare ModuleType stub caused ImportError when torch._dynamo was imported (triggered by trainer.py accessing torch._dynamo.config at load time). torch._dynamo pulls in torch.distributed.fsdp._flat_param which does: from torch._C._distributed_c10d import FakeProcessGroup and potentially other symbols. Adding module __getattr__ auto-creates a stub class for any missing symbol so all such imports succeed without enumerating every individual symbol. Applied to both the primary stub and the fallback stub in the except branch. * chore: trim c10d stub comment * fix(rocm/win): auto-stub missing torch.distributed attrs (Store, ProcessGroup, …) * fix(rocm/win): pre-stub fsdp submodules in sys.modules; fix __getattr__ subpackage clash * feat(rocm/win): arch-aware wheel selector always picks newest ROCm release Replace HIP-SDK-version-gated wheel selection with GPU arch-based logic. Select-ROCmWheelRelease (PS) and _select_windows_rocm_release (Python) map gcnArchName → minimum ROCm version, then pick the newest available release that satisfies it (currently always rocm-rel-7.2.1 for any supported GPU). Wheels bundle their own ROCm runtime so the installed HIP SDK 7.1 does not prevent using 7.2.1 wheels on gfx1200 (RX 9060 XT) and similar RDNA 4 GPUs. Also installs the bitsandbytes Windows ROCm continuous-release wheel and sets BNB_ROCM_VERSION=72 in worker.py before ML imports so bnb loads the libbitsandbytes_rocm72.dll that ships in that wheel. * fix(rocm/win): stub class metaclass for ProcessGroup.BackendType; amd-smi circuit breaker torchao.float8.inference accesses ProcessGroup.BackendType as a class-level attribute. Plain type() stubs have no __getattr__ on the metaclass so this raises AttributeError. Introduce _StubClassMeta whose __getattr__ returns child stub classes, fixing the torchao import chain. Add an amd-smi circuit breaker in amd.py: after 3 consecutive failures the module stops spawning the process, eliminating the repeated Windows UAC / DiskPart elevation prompts caused by polling a non-functional amd-smi. Also guard BNB_ROCM_VERSION=72 behind a DLL existence check so bitsandbytes fails with its own detection message rather than a harder "DLL not found" when the Windows ROCm bnb wheel is not yet installed. * fix: stub __members__ so torchao float8 enum check doesn't crash on ROCm Windows torchao.float8.inference accesses ProcessGroup.BackendType.__members__ expecting a Python Enum registry dict. _StubClassMeta.__getattr__ was blocking all dunder attributes, causing AttributeError. Return {} for __members__ specifically so the isinstance/iteration checks pass cleanly. * fix: stub distributed tensor/functional_collectives to prevent missing C++ op crash on ROCm Windows torch._dynamo.trace_rules eagerly loads torch.distributed.tensor at import time, which pulls in _functional_collectives.py. That file registers Meta kernels for _c10d_functional C++ ops, but those ops are only registered by torch._C._distributed_c10d — a C extension absent from ROCm Windows wheels. Pre-stubbing the affected modules in sys.modules prevents the real import chain from running and avoids the "operator does not exist" crash. * fix: give mod stubs __path__ and pre-stub _tensor to fix 'not a package' import error _make_mod_stub now sets __path__=[] so Python treats stub modules as packages. Without it, any import of a submodule raises "is not a package". Also pre-stub torch.distributed._tensor and its submodules so that _tensor/__init__.py (which re-exports from torch.distributed.tensor) never runs and torchao's `from torch.distributed._tensor import DTensor` gets a harmless stub instead of crashing. * fix: stub torch.ops._c10d_functional namespace with hashable op sentinels torchao.dtypes.nf4tensor uses _c10d_functional ops as dict keys at import time (all_gather_into_tensor.default, wait_tensor.default) and torch.ops.c10d.scatter_.default. None of these ops are registered on ROCm Windows because torch._C._distributed_c10d (the C extension) doesn't ship. Replace the whole _c10d_functional namespace with a custom stub whose ops return hashable .default objects, so dict-key construction doesn't crash. Also inject a scatter_ stub into torch.ops.c10d if it's missing. * fix: stub entire torchao package on ROCm Windows instead of individual ops torchao is not supported on ROCm Windows and its import chain transitively requires torch._C._distributed_c10d (absent from the ROCm Windows wheel). Rather than stub each missing op one by one, stub the whole torchao package upfront. Unsloth uses bitsandbytes for quantization, not torchao, so this has no functional impact. transformers gracefully handles an importable-but- empty torchao by disabling TorchAoHfQuantizer. * fix: set __spec__ on mod stubs so importlib.util.find_spec doesn't raise Manually-injected sys.modules entries have __spec__=None by default. importlib.util.find_spec() raises ValueError when it finds a module in sys.modules with __spec__=None (transformers.utils.import_utils hits this when checking if torchao is available). Give every stub a minimal ModuleSpec(name, loader=None, is_package=True) to satisfy find_spec. * fix: add meta path finder to auto-stub subpackages of stub modules `import torchao.prototype` goes through the import machinery, not __getattr__, so an empty __path__ means ModuleNotFoundError. Rather than list every submodule explicitly, register a MetaPathFinder that intercepts any import whose parent is one of our stubs (detected by loader=None in the parent's ModuleSpec). Real installed packages always have a SourceFileLoader so they are never intercepted. Also register child stubs in sys.modules from __getattr__ as a belt-and-suspenders measure. * fix: use _unsloth_stub sentinel instead of loader=None for stub detection The import machinery overwrites module.__spec__ with the spec returned by find_spec (which has loader=_StubSubpackageLoader, not None), so the loader=None check broke for second-level subpackages. Switch to a custom _unsloth_stub object identity sentinel set directly on each stub module -- it survives __spec__ being replaced and correctly identifies stubs at any depth (torchao.prototype.safetensors, etc.). * refactor(rocm/win): switch to repo.amd.com arch-aware index, remove stubs AMD recommends repo.amd.com/rocm/whl/{arch}/ as the Windows ROCm wheel source. These wheels bundle their own ROCm runtime, support all Python versions (not just cp312), and include the full torch._C extension set (including _distributed_c10d) that the old repo.radeon.com wheel omitted. Changes: - install.ps1: remove Select-ROCmWheelRelease + hardcoded cp312 wheel URLs; remove Python 3.12 forced-preference logic; install via --index-url repo.amd.com/rocm/whl/{arch-family}/ - studio/setup.ps1: same -- remove Select-ROCmWheelRelease, switch to repo.amd.com arch-aware index URL - studio/install_python_stack.py: replace _ROCM_WINDOWS_RELEASES / _select_windows_rocm_release with _windows_rocm_index_url() using the _GFX_TO_AMD_INDEX_ARCH map; drop Python 3.12 restriction - studio/backend/core/training/worker.py: remove all stub machinery (_make_mod_stub, _StubSubpackageFinder, _StubSubpackageLoader, _StubClassMeta, torchao/fsdp/dtensor stubs, _c10d_functional ops stubs, BNB DLL detection) -- no longer needed with new wheel source * fix(rocm/win): restore _distributed_c10d + torchao stubs; fix BNB install repo.amd.com torch wheels also omit torch._C._distributed_c10d on Windows (RCCL is not shipped on Windows). torch/distributed/__init__.py imports from it unconditionally at module level, so the stub must land in sys.modules before any torch.distributed import. torchao (pulled in by transformers.quantizers) walks torchao.float8.distributed_utils -> torch.distributed._functional_collectives -> distributed_c10d at import time. Stubbing torchao up-front short-circuits that chain. worker.py: - Restore _make_mod_stub / _StubSubpackageFinder / _StubSubpackageLoader - Restore _StubClassMeta for ProcessGroup.BackendType attribute access - Restore _distributed_c10d stub with __getattr__ (Windows only) - Restore torchao stubs (5 modules, Windows only) install_python_stack.py: - BNB AMD wheel install was inside the early-return branch that fires when torch is already a ROCm build (installed by install.ps1). Move BNB install outside that branch so it always runs on Windows ROCm — the PyPI bitsandbytes has only CUDA DLLs and fails to load on ROCm. * worker: remove _distributed_c10d stub; stub only torchao The installed torch/distributed/__init__.py from repo.amd.com (torch==2.10.0+rocm7.12.0) is now properly guarded with `if is_available():`, so `import torch.distributed` alone is safe. The crash only comes via torchao's import chain: torchao.float8.distributed_utils → torch.distributed._functional_collectives (unguarded import) → torch.distributed.distributed_c10d → torch._C._distributed_c10d ← absent on Windows ROCm Stubbing torchao short-circuits the chain entirely. No need to stub _distributed_c10d. Remove _StubClassMeta and the _c10d stub block; keep only _make_mod_stub + _StubSubpackageFinder + torchao seeds. * fix: BNB AMD wheel skipped + torch.compile segfault on Windows ROCm install_python_stack.py: the UNSLOTH_ROCM_TORCH_INSTALLED=1 early-return path (set by setup.ps1 when it installed torch itself) returned before ever reaching the AMD BNB prerelease wheel install. The PyPI bitsandbytes==0.49.x ships only CUDA DLLs, so loading it on ROCm fails with "libbitsandbytes_rocm72.dll not found". Now installs the AMD Windows BNB wheel before returning on that path too. worker.py: torch._grouped_mm crashes on gfx1200 (null HIP kernel pointer, 0xC0000005) when torch.compile's JitDecomp system dispatches it during the first forward pass. Detect Windows ROCm via torch.version.hip (already in sys.modules from section 1e) and set TORCHDYNAMO_DISABLE=1 to bypass the broken kernel dispatch. * fix: BNB AMD wheel install fails uv wheel filename check The bitsandbytes continuous-release wheel is intentionally mismatched: filename encodes 1.33.7.preview (= 1.33.7rc0 in PEP 440) but wheel metadata reports 0.50.0.dev0. uv rejects this by default. Introduce _install_bnb_windows_rocm() helper that sets UV_SKIP_WHEEL_FILENAME_CHECK=1 only for this specific install, then restores the previous env value. Both BNB install call sites (the UNSLOTH_ROCM_TORCH_INSTALLED early-return path and the normal Windows ROCm path) now use this helper. * worker: patch _grouped_mm CUDA dispatch on Windows ROCm (gfx1200 null kernel) TORCHDYNAMO_DISABLE=1 stopped the compiler frontend but not the autograd JitDecomp system, which also dispatches _grouped_mm and hits the same null HIP kernel crash (0xC0000005). Verified that torch.library.Library("aten","IMPL").impl("_grouped_mm", fn, "CUDA") successfully overrides the broken HIP kernel with a Python mm fallback on torch==2.10.0+rocm7.12.0. Schema: _grouped_mm(Tensor self, Tensor mat2, Tensor? offs=None, Tensor? bias=None, ScalarType? out_dtype=None) -> Tensor The fallback handles both the simple case (offs=None → torch.mm) and the grouped case (offs provided → split self by offsets, multiply each group against the corresponding slice of mat2, then cat results). Keep _WINDOWS_ROCM_GROUPED_MM_LIB alive at function scope to prevent the C++ dispatch registration from being freed by GC. * worker: fix torchao stub — return stub classes not modules for isinstance() peft/tuners/lora/torchao.py does: from torchao.dtypes import AffineQuantizedTensor, LinearActivationQuantizedTensor isinstance(weight, (AffineQuantizedTensor, LinearActivationQuantizedTensor)) The stub __getattr__ was returning stub modules, which isinstance() rejects with "arg 2 must be a type, a tuple of types, or a union". Add _StubTypeMeta metaclass whose __instancecheck__ always returns False, and _make_stub_type() to create stub classes via it. Change _make_mod_stub __getattr__ to return stub classes instead of stub modules for leaf attribute access, so isinstance() gets a valid type and returns False. _StubSubpackageFinder still handles import-style subpackage creation (those still need module objects in sys.modules); __getattr__ only fires for from-import or direct attribute access, which are the isinstance paths. * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * tests: add coverage for Windows ROCm install paths and worker patches Add conftest.py to fix pre-existing sys.path issue that prevented test_rocm_support.py from running at all (install_python_stack.py imports from backend.utils.wheel_utils which needs studio/ on sys.path). New test classes cover everything added in this session: - TestWindowsRocmIndexUrl: arch → AMD pip index URL mapping (gfx120X-all, gfx1151, gfx1150, gfx110X-all, unknown → None, trailing slash) - TestDetectWindowsGfxArch: hipinfo output parsing, missing/timeout/bad returncode/no-gcnArchName paths - TestInstallBnbWindowsRocm: UV_SKIP_WHEEL_FILENAME_CHECK set+restored, env restored on exception, no-op when URL missing - TestRocmTorchInstalledEnvVar: UNSLOTH_ROCM_TORCH_INSTALLED=1 skips pip_install, calls _install_bnb_windows_rocm, sets flag - TestWorkerWindowsRocmPatches: _grouped_mm CUDA dispatch override, offs/grouped variant handling, GC-prevention sentinel, _StubTypeMeta __instancecheck__, _StubSubpackageFinder registration, torchao key submodule pre-stubbing, TORCHDYNAMO_DISABLE guard - TestRocmTorchPkgSpecs: rocm7.2 torch 2.11.x spec, default <2.11 cap, 3-tuple shape, _GFX_TO_AMD_INDEX_ARCH RDNA4/3.5/3 coverage * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * tests: fix encoding, IS_WINDOWS patching, and wrong assertion - Add encoding="utf-8" to all read_text() calls (54 occurrences) so tests pass on Windows where the default codec is cp1252 and source files contain UTF-8 emoji (e.g. ⚠️ in install_python_stack.py) - Add @patch.object(stack_mod, "IS_WINDOWS", False) to Linux-path TestEnsureRocmTorch tests so they reach the Linux code path when run on a Windows machine instead of short-circuiting into the Windows branch - Fix test_grouped_mm_patch_guarded_by_windows_and_hip_check: the source uses getattr(_torch_for_rocm, "version", None) not torch.version, so check for '"version"' and '"hip"' substrings instead 137 passed, 2 skipped * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix: pin BNB_ROCM_VERSION=72 for torch==2.11.0+rocm7.13.0 compatibility AMD's pip index now ships torch==2.11.0+rocm7.13.0 (ROCm 7.13). bitsandbytes auto-detects HIP 7.13 from torch.version.hip and looks for libbitsandbytes_rocm713.dll, which the AMD Windows prerelease wheel does not ship (it only ships rocm72.dll), causing a load error at training start. Fix: - worker.py section 1f: set BNB_ROCM_VERSION=72 (via setdefault) before section 2 ML imports, so bitsandbytes always loads rocm72.dll on Windows ROCm - install_python_stack.py: set BNB_ROCM_VERSION=72 in _install_bnb_windows_rocm() for any post-install imports; update comment to document root cause - tests: 4 new assertions covering the fix (141 passed, 2 skipped) * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix: detect BNB ROCm DLL suffix dynamically instead of hardcoding '72' BNB_ROCM_VERSION was pinned to '72' which works today (AMD wheel ships rocm72.dll) but would break again if AMD ships a future wheel with a different DLL suffix (e.g. rocm713.dll). Add _detect_bnb_rocm_dll_ver() to install_python_stack.py: scans the installed bitsandbytes package dir for libbitsandbytes_rocm{VER}.dll using importlib.util.find_spec (no BNB import needed) and returns the suffix. '72' remains the fallback when detection fails. Apply the same detection inline in worker.py section 1f. Both paths still respect a pre-set BNB_ROCM_VERSION (caller override wins). Tests: +8 cases covering detection logic and fallback (147 passed, 2 skipped). * fix: patch torch.distributed stubs in server process for Windows ROCm On Windows ROCm, torch.distributed ships without process-group helpers (is_initialized, is_available, get_rank, get_world_size). The worker subprocess already patches these in section 1e, but the main server process calls _determine_attention_impl_for_gpu_estimate() which calls unsloth's resolve_attention_implementation() → is_initialized(), causing: "Could not resolve attention implementation for '...': module 'torch.distributed' has no attribute 'is_initialized'" Fix: patch the missing attrs onto torch.distributed at the top of _determine_attention_impl_for_gpu_estimate, matching the same stubs already applied in worker.py section 1e. No-ops on Linux/CUDA where torch.distributed is fully populated. * fix: gate _grouped_mm dispatch patch on HIP < 7.13 AMD fixed the gfx1200 null HIP kernel in ROCm 7.13 (torch 2.11+). Users on the new wheel now get the real GPU _grouped_mm kernel for MoE workloads instead of the Python mm fallback. Changes: - worker.py: add _hip_ver_at_least() helper; wrap full _grouped_mm patch in `if not _hip_ver_at_least(7, 13):` with else branch that logs the skip reason; update section-1f comment to document the fix - test_rocm_support.py: add 5 tests covering the helper definition, the (7, 13) gate expression, the else branch, the skip log message, and the AMD-format version string parsing (.split(".")[:2]) Verified: torch==2.11.0+rocm7.13.0 — 3D batch and grouped (offs) variants both succeed; null crash only present on rocm7.12 and earlier. * fix: stub is_torchelastic_launched on torch.distributed for Windows ROCm resolve_attention_implementation calls is_torchelastic_launched() which does not exist in the incomplete torch.distributed shipped with the Windows ROCm wheel, causing a warning on every model config load in the server process. Add it to the stub table alongside the four helpers already patched in _determine_attention_impl_for_gpu_estimate. Also adds two tests: one confirming the new stub and one confirming all five core distributed helpers are covered. * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix: explicit warnings on AMD ROCm arch/version fallbacks + Fast-Install arg order setup.ps1: - Fix Fast-Install argument order: packages before flags, consistent with all other Fast-Install calls in the file (was: Fast-Install --force-reinstall --index-url $url torch ...) (now: Fast-Install torch torchvision torchaudio --force-reinstall --index-url $url) - Add explicit [WARN] substep when $HasROCm is true but arch mapping fails: - GPU arch detected but not in supported wheel list → names the arch and lists supported families so user knows exactly what to report - HIP SDK present (amd-smi path) but gcnArchName unreadable → instructs user to re-install the HIP SDK; previously fell back silently to CPU install.sh: - Add [WARN] to stderr before silent CPU fallback when AMD GPU is confirmed (rocminfo/amd-smi) but ROCm version cannot be read from any source (amd-smi, /opt/rocm/.info/version, hipconfig, dpkg, rpm) - Add [WARN] to stderr when ROCm version is too old (< 6.0) with upgrade link install.ps1 and setup.sh: no changes needed (already handle these paths correctly) * fix: robust gfx arch detection for Strix Halo / HIP-runtime-only installs Covers users who have the HIP runtime (amd-smi available) but not the full HIP SDK (no hipinfo), which is common on Strix Halo iGPU systems. Without this, $ROCmGfxArch stays null and the installer silently falls back to CPU-only PyTorch despite a working GPU. Detection waterfall (setup.ps1 + install.ps1): 1. hipinfo gcnArchName -- full HIP SDK (existing, unchanged) 2. amd-smi list gfx pattern -- newer amd-smi versions embed arch 3. amd-smi static --asic -- ROCm 6+ ASIC details with GFX target 4. UNSLOTH_ROCM_GFX_ARCH env -- manual override escape hatch 5. GPU name → arch table -- best-effort from marketing name: 890M / Strix Halo → gfx1151 (RDNA 3.5 iGPU, Strix Halo) 880M / Strix Point → gfx1150 (RDNA 3.5 iGPU, Strix Point) 780M / Phoenix → gfx1103 (RDNA 3 iGPU) RX 7900/7800/7700 → gfx1100 (RDNA 3 desktop) RX 9070 XT / 9080 → gfx1201 (RDNA 4) RX 9070 / 9060 XT → gfx1200 (RDNA 4) When arch is inferred from name, a Cyan substep tells the user to set UNSLOTH_ROCM_GFX_ARCH to skip inference on future installs. WMI block intentionally does not set $HasROCm (no runtime confirmation). Tests: 11 new tests in TestStrixHaloGfxArchDetection covering all five detection levels, WMI safety, and gfx regex in both ps1 files. * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix: resolve hipinfo/hipconfig via HIP_PATH/ROCM_PATH when not on PATH AMD HIP SDK sets HIP_PATH on Windows but does not always add the bin directory to PATH. Get-Command hipinfo therefore silently fails and detection falls through to WMI, which cannot provide a gfx arch, leaving the user with a CPU-only PyTorch install and no warning. Changes: - setup.ps1 / install.ps1: before falling through to amd-smi, attempt to locate hipinfo.exe and hipconfig.exe under $env:HIP_PATH\bin (then $env:ROCM_PATH\bin) when Get-Command returns nothing - Emit a [WARN] with the resolved path and a one-liner to permanently fix PATH via SetEnvironmentVariable - Emit a [WARN] when HIP_PATH/ROCM_PATH is set but the exe is still not found (incomplete SDK install) - Emit a [WARN] with the first hipinfo output line when hipinfo runs but returns a non-zero exit code (e.g. "no ROCm-capable device detected") - 18 new tests in TestHipSdkEnvPathResolution; total 183 passed, 2 skipped * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * feat: print HIP SDK path and full hipconfig version in terminal on AMD detection Both install.ps1 and setup.ps1 now emit substeps under the gpu step when AMD ROCm is detected: gpu AMD ROCm (gfx1200) HIP SDK: C:\Program Files\AMD\ROCm\7.1 hipconfig: 7.1.51803-d3a86bd04 Previously only the gpu label (e.g. "AMD ROCm (gfx1200)") was shown with no indication of where the SDK was found or which exact build was active. The full hipconfig build string (e.g. 7.1.51803-d3a86bd04 instead of just 7.1) is now stored in ROCmVersionFull and also used in setup.ps1's 'rocm' step label. 9 new tests in TestHipSdkDetectedSubstep; total 192 passed, 2 skipped * fix: Strix rocm7.1 segfault bypass + Ubuntu 24.04 HIP gcc-install-dir Issue 1 (install.sh): gfx1151/gfx1150 + ROCm 7.1 causes a segfault in torch._grouped_mm (moe_utils.py:167). The Radeon repo now ships cp313 wheels for rocm-rel-7.1, so _amd_gpu_radeon=true silently lands on the broken combo. When Strix Halo/Point is detected and TORCH_INDEX_URL is rocm7.1, override to rocm7.2 PyTorch index, update TORCH_CONSTRAINT, and set _amd_gpu_radeon=false to bypass the Radeon repo entirely. Emits a clear [WARN] explaining the segfault and linking to the ROCm upgrade docs. Issue 2 (setup.sh): ROCm 7.x ships clang-20 which on Ubuntu 24.04+ picks /usr/lib/gcc/x86_64-linux-gnu/14/ (runtime dir, no C++ headers), causing 'cstdlib file not found' and a failed llama.cpp HIP build. Iterate gcc versions 14→11 to find the first install dir that has both runtime and /usr/include/c++/<ver> headers, then pass --gcc-install-dir to clang via CMAKE_HIP_FLAGS. Fix confirmed by h34v3nzc0dex (llama.cpp 417/417 clean). 11 new tests across TestStrixRocm71Override and TestSetupShGccInstallDir; total 203 passed, 2 skipped * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix: BNB_ROCM_VERSION in server process + torch._C._distributed_c10d stubs Two errors visible in training logs on Windows ROCm: 1. Server process bitsandbytes crash: "Configured ROCm binary not found at libbitsandbytes_rocm713.dll" The installed BNB wheel ships rocm72.dll (not rocm713.dll). The training worker already sets BNB_ROCM_VERSION=72 via DLL detection but the server process (main.py) imported bitsandbytes before that ran. Fix: add the same DLL-scan + BNB_ROCM_VERSION assignment to main.py inside the existing win32 guard, before any downstream import can pull in bitsandbytes. 2. torch.distributed import failure: "No module named 'torch._C._distributed_c10d'; torch._C is not a package" torch._C is a C extension on Windows ROCm — Python cannot do submodule imports from it, so torch.distributed fails to import before our attribute stubs could ever run. Fix: inject empty ModuleType stubs for _distributed_c10d, _distributed_autograd and _distributed_rpc into sys.modules inside the win32 guard in hardware.py BEFORE importing torch.distributed, so the import succeeds and our attribute stubs take effect. 9 new tests in TestServerStartupRocmFixes; total 212 passed, 2 skipped * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix(win32): populate distributed c10d stub with dummy symbols torch.distributed tries to `from torch._C._distributed_c10d import FakeProcessGroup` (and ProcessGroup, Work, Store, etc.). The previous empty ModuleType stub caused an AttributeError on those names. Populate every stub with a _Dummy class for each known symbol so the import chain completes silently on Windows ROCm where torch._C is a compiled extension and its _distributed_c10d submodule doesn't exist. Adds four new tests in TestServerStartupRocmFixes covering FakeProcessGroup, ProcessGroup, setattr population, and all three _distributed_* siblings. * fix(win32): distinguish HIP SDK installed vs GPU not ROCm-accessible Previously, when hipinfo was found but exited non-zero (e.g. "no ROCm-capable device detected"), both install.ps1 and setup.ps1 fell through to the WMI-label-only branch and printed "AMD GPU detected -- HIP SDK not found" -- factually wrong since the SDK binary is present. Add $HipSdkInstalled flag (set true when hipinfo binary is found, regardless of exit code). When HipSdkInstalled && !HasROCm: - Show "AMD GPU detected -- not ROCm-accessible (HIP <ver>)" instead - Explain this is a driver issue, not an SDK issue, with a link - Still run hipconfig version capture so version shows in output - CPU-only hint now says "GPU not ROCm-accessible" not "require HIP SDK" Also applies to setup.ps1 (same detection block, same branches). Adds TestHipSdkInstalledButDeviceInaccessible (11 tests). * fix(win32): scope ROCm workarounds to AMD hosts only Three Codex-flagged issues where Windows ROCm workarounds incorrectly applied to Windows CUDA (NVIDIA) machines: main.py (P1): BNB_ROCM_VERSION was set unconditionally on all win32 hosts. On NVIDIA, bitsandbytes sees BNB_ROCM_VERSION and looks for a ROCm DLL that doesn't exist, breaking bitsandbytes initialisation. Fix: gate the block on HIP_PATH/ROCM_PATH being present (ROCm hosts only). worker.py (P2): torchao stubs were seeded for all win32 runs, shadowing real torchao on Windows CUDA and silently disabling torchao quantization for NVIDIA users. Fix: gate on HIP_PATH/ROCM_PATH (win32 ROCm only). install_python_stack.py (P1): _detect_windows_gfx_arch() only checked shutil.which("hipinfo"), skipping the HIP_PATH/ROCM_PATH fallback that the PowerShell installers use. On installs where the HIP SDK bin dir is not on PATH, _ensure_rocm_torch() returned early without installing ROCm wheels or bitsandbytes. Fix: mirror the env-var fallback. * fix(linux): route Strix + ROCm 7.1 to AMD arch-specific index Instead of falling back to pytorch.org/rocm7.2, the Strix override now routes to repo.amd.com/rocm/whl/gfx1151/ (or gfx1150/) which serves torch 2.11.0+rocm7.13.0 -- AMD's build containing the actual _grouped_mm kernel fix, verified on real gfx1151 hardware by h34v3nzc0dex. This exercises the real GPU kernel path rather than the rocm7.2 workaround. UNSLOTH_AMD_ROCM_MIRROR can override the base URL for air-gapped installs. Also teaches _tauri_torch_index_family to recognise AMD arch-specific URLs (repo.amd.com/rocm/whl/gfx*) and return the rocm7.13 family label so _tauri_gpu_branch correctly classifies these installs as rocm. Suggested by h34v3nzc0dex based on hardware-verified probe results. * fix(studio/rocm): gate ROCm-only side-effects on active torch runtime Address five edge cases flagged during PR review: 1. studio/backend/main.py: BNB_ROCM_VERSION was set whenever HIP_PATH or ROCM_PATH was present in the environment. A Windows CUDA user who once installed the HIP SDK and reverted to a CUDA torch wheel still has those env vars set, so bitsandbytes would try to load libbitsandbytes_rocm72.dll against a CUDA torch and crash. Now probe torch.version.hip inside the env-var guard (worker.py already does this). 2. studio/backend/main.py: os.add_dll_directory returned handles were discarded. Per CPython docs, the directory leaves the DLL search list when the handle is garbage collected. Retain handles in module-level _ROCM_DLL_HANDLES list so they survive process lifetime. 3. studio/install_python_stack.py: _install_bnb_windows_rocm() returned None regardless of pip_install_try outcome, and the caller flipped _rocm_windows_torch_installed to True unconditionally. On a failed BNB install the post-install "manual install may be required" warning was suppressed and the user was misled. Helper now returns bool; caller gates on it. 4. studio/install_python_stack.py: _detect_windows_gfx_arch returned the raw capture group, so mixed-case hipinfo output ("Gfx1151") missed the lowercase keys in _GFX_TO_AMD_INDEX_ARCH and silently fell back to CPU torch. Lowercase the token. 5. studio/install_python_stack.py: UNSLOTH_ROCM_TORCH_INSTALLED=1 early- return trusted the env var even when the venv was wiped between runs. Subprocess-probe torch importability first; fall through to the full install path if the probe fails. Tests: 231 passed, 1 skipped in tests/studio/install/test_rocm_support.py (adds one new test for case 5 fall-through). * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix(studio/rocm): worker.py parity + don't roll back ROCm torch on bnb failure Addresses findings from a 10x reviewer pass on the prior fix commit: 1. studio/backend/core/training/worker.py (parity with main.py): - Gate the torchao stub block on torch.version.hip / 'rocm' in torch.__version__ instead of HIP_PATH / ROCM_PATH env-var presence. Same root cause as main.py: HIP SDK env vars stick around on CUDA hosts. - Add module-level Windows ROCm DLL registration block. Worker subprocesses inherit env vars but not the parent's add_dll_directory handles, so the first `import torch` in the worker could fail to find amdhip64.dll when HIP_PATH\bin is not on PATH. Mirrors main.py setup. Handles retained at module scope via _ROCM_DLL_HANDLES. - Promote _WINDOWS_ROCM_GROUPED_MM_LIB to module scope with `global` in run_training_process so the torch.library.Library registration survives past function return / mid-run garbage collection. - Harden _torch_has_hip() to also accept 'rocm' in torch.__version__ (AMD SDK / Radeon wheels may not set torch.version.hip). 2. studio/install_python_stack.py: - Don't roll back ROCm torch when bitsandbytes install fails. The prior commit gated _rocm_windows_torch_installed on _install_bnb_windows_rocm() returning True; if torch installed successfully but bnb failed, the flag stayed False and later install steps could overwrite ROCm torch with the generic CPU torch wheel. Set the flag after torch install; surface bnb failure as a separate warning instead. - _detect_windows_gfx_arch now probes in three tiers: UNSLOTH_ROCM_GFX_ARCH env-var override (matches the PowerShell installer), then hipinfo (PATH or HIP_PATH\bin), then amd-smi (`static --asic`, `list`). Without the amd-smi fallback, runtime-only Radeon installs without hipinfo on PATH made `studio update` return early and leave the venv on CPU torch. - Linux torch-already-rocm probe in _ensure_rocm_torch now matches the Windows probe shape: accepts torch.version.hip OR 'rocm' in torch.__version__ to cover AMD SDK / Radeon Linux wheels. 3. studio/backend/utils/hardware/hardware.py: - apply_gpu_ids() final-fallback torch probe accepts 'rocm' in torch.__version__ in addition to torch.version.hip, matching detect_hardware(). AMD SDK wheels could otherwise leak through with CUDA-only visibility masks on a spawned ROCm worker. Tests: 231 passed, 1 skipped in tests/studio/install/test_rocm_support.py (no test changes needed; the probe shape that prints the hip version (or 'rocm' sentinel) preserves the existing non-empty-string contract). Not addressed in this commit (deferred or out of scope): - Tag drift / lemonade checksum (PR 5303 surface, not this PR). - install.sh rocm7.2.1 URL: small fix, separate. - install.ps1 / setup.ps1 'Radeon 8060S' marketing-name fallback table. - Strix Halo + ROCm 7.1 routing asymmetry in Python update path. * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix(studio/rocm): robustness pass - rocm tag normalisation, Strix routing parity, hardened detection Robustness pass on top of76137b2d. Four targeted fixes: 1. install.sh ROCm-tag routing normalisation. `rocm7.2.1` would route to https://download.pytorch.org/whl/rocm7.2.1 which does not exist (PyTorch publishes major.minor URLs only). Same for any future patch-level tag. Normalise every rocm{maj.min}* pattern to the bare {maj.min} index URL. 2. install.ps1 + studio/setup.ps1 marketing-name fallback. The gfx1151 row matched 890M / Strix Halo / HX 37x / HX 38x / AI 9 HX but not the actual retail name 'AMD Radeon 8060S Graphics' shipped by OEMs (Ryzen AI MAX+ 395). Add '8060S' to the regex. 3. install_python_stack.py Strix + ROCm 7.1 routing parity with install.sh. The shell installer reroutes Strix Halo / Point + ROCm 7.1 to repo.amd.com/rocm/whl/{gfx}/ (which serves torch 2.11.0+rocm7.13.0 with the upstream _grouped_mm fix). The Python `studio update` path only warned and still installed the broken generic rocm7.1 wheel. Mirror the override: detect gfx1151/gfx1150 on ROCm 7.1, route to the AMD per-gfx index, honour UNSLOTH_AMD_ROCM_MIRROR override. 4. _detect_windows_gfx_arch amd-smi parsing tightened. The amd-smi fallback added in the prior commit used a bare `\bgfx[1-9][0-9a-z]{2,3}\b` match against the lowercased stdout, which could pick up stray gfx references in warnings / device-name strings. Anchor on labelled lines first (Target_Graphics_Version, ASIC, Arch, gfx) and fall back to the bare match only when no labelled line is present. Tests: 231 passed, 1 skipped in tests/studio/install/test_rocm_support.py; sim_5301 23 cases pass (6 new sims for the Strix override + amd-smi parsing). * fix(studio/rocm): multi-GPU selection, Strix sibling handling, defensive cleanups Round 4 robustness pass based on 5 parallel Opus reviewers of head21773215. Seven items from across regression / edge-case / error-paths / architecture reviews: 1. studio/backend/main.py BNB gate: aligned with the broad ROCm check used everywhere else in this PR (torch.version.hip OR 'rocm' in __version__). AMD SDK / Radeon Linux wheels do not always populate torch.version.hip; without this, main.py would silently skip BNB_ROCM_VERSION while worker.py set it. 2. studio/install_python_stack.py _install_bnb_windows_rocm: init _ok = False before the try block. Without this, if pip_install_try itself raises (e.g. OSError on uv binary missing), the finally block restored env vars correctly but the subsequent `if not _ok:` raised UnboundLocalError, masking the original exception. 3. studio/install_python_stack.py _detect_windows_gfx_arch: - Rewrote to use re.findall (not re.search) on both hipinfo and amd-smi output, dedup tokens preserving order, and select via new _pick_visible_index() helper. - HIP_VISIBLE_DEVICES / ROCR_VISIBLE_DEVICES (first comma entry, integer) now picks the right GPU on multi-AMD-GPU hosts. Out-of-range or non-int values fall back to the first GPU (matches detect_host behaviour in install_llama_prebuilt.py). 4. studio/install_python_stack.py Strix override now consults the runtime target before flipping: - Previous behaviour intersected gfx_codes with {gfx1151, gfx1150} and picked the first Strix arch, ignoring whether HIP_VISIBLE_DEVICES selected a non-Strix sibling (e.g. discrete RX 7900 in a mixed APU+dGPU box). Could install Strix-specific wheels onto a gfx1100 dGPU. - Now resolves the runtime gfx via _pick_visible_index() and only overrides when that runtime target is in the Strix set. 5. studio/backend/main.py + studio/backend/core/training/worker.py: ROCm version dir scan no longer sorts lexically. Previous sort placed "10.0" before "7.0" alphabetically, which would mis-prioritise ROCm 10.x bin dirs once AMD ships them. New _ver_key() splits on "." and sorts numerically with a string fallback. 6. install.sh Strix override URL: replaced ${var%/} (strips one trailing slash) with a while-loop that strips all trailing slashes, matching Python's .rstrip("/"). A user setting UNSLOTH_AMD_ROCM_MIRROR with "http://corp/whl///" no longer ends up with "http://corp/whl///gfx1151/" which strict pip proxies (artifactory, sonatype) 404 on. 7. studio/install_python_stack.py: bumped torch import probe timeout from 30s to 90s. PyTorch's lazy .so loading can take 60-90s on cold NFS or USB-backed venvs. The shorter timeout was producing a false "torch missing" classification and reinstalling a working ROCm torch. Tests: 231 passed, 1 skipped. sim_5301 30 cases pass (added 7 new sims for multi-GPU detection, Strix sibling handling, and _ok-init regression). * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix(studio/rocm): worker BNB/grouped_mm broad gate, install.sh Strix visibility, runtime-only ROCm detection Round-5 robustness pass based on 20 parallel reviewers of head96b9e465. 1. studio/backend/core/training/worker.py - BNB version pin / dynamo disable / _grouped_mm fallback block was still gated on torch.version.hip alone despite the torchao stub block above already using the broad check. AMD SDK / Radeon Windows wheels (torch.__version__ contains "rocm" but torch.version.hip is None) silently skipped the Windows ROCm runtime patches. Aligned to the same broad check (8/20 reviewers). 2. studio/backend/core/training/worker.py - _hip_ver_at_least() now also parses the ROCm version out of torch.__version__ (e.g. "2.11.0+rocm7.13.0") when torch.version.hip is missing, so the kernel-fix gate is correct for SDK / Radeon wheels too. 3. studio/backend/core/training/worker.py - _grouped_mm_safe_impl with offs=None now picks torch.bmm/matmul for 3-D inputs instead of always calling torch.mm. The real _grouped_mm accepts 3-D batched matmul; the prior fallback raised "self must be a matrix" on MoE workloads (2/20). 4. studio/backend/main.py - dropped the HIP_PATH / ROCM_PATH env-var gate from the BNB block; probe torch directly. Runtime-only Radeon / AMD SDK Windows installs do not set those SDK env vars but still ship ROCm torch (5/20 reviewers). 5. install.sh - Strix override now collects every gfx token from rocminfo / amd-smi (in enumeration order), then indexes by HIP_VISIBLE_DEVICES / ROCR_VISIBLE_DEVICES so a mixed Strix iGPU + non- Strix dGPU host where the user selected the dGPU does NOT get rerouted to the Strix per-gfx index. Mirrors the Python update path (5/20 reviewers). 6. install.sh - Strix detection chain now also probes `amd-smi static --asic`, matching the PowerShell installer (1/20). Closes the gap on runtime-only Strix hosts where `amd-smi list` does not surface a gfx token. 7. studio/install_python_stack.py - _has_rocm_gpu() now has the sysfs KFD topology fallback (/sys/class/kfd/kfd/topology/nodes/*/gpu_id), matching install.sh. On minimal package-managed installs without rocminfo / amd-smi GUI tools, `studio update` can now detect the GPU and repair the venv instead of returning early (2/20). 8. studio/install_python_stack.py - _detect_amd_gfx_codes() now falls back to `amd-smi list` and `amd-smi static --asic` when rocminfo is missing (2/20). Strix routing on runtime-only Radeon hosts now matches what install.sh has done for a while. 9. studio/install_python_stack.py - Strix override now applies even when has_hip_torch is True. The whole point of the override is to repair an existing broken torch.version.hip == "7.1" install; skipping the reinstall left users on the known _grouped_mm segfaulting stack (3/20). Tests: 231 passed, 1 skipped. sim_5301 30 cases pass. sim_cross 12 pass. * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix(studio/rocm): code review hardening pass - main.py: numeric DLL sort (string sort picked rocm72 over rocm713); add basename() to regex; log warning on detection failure; log info when BNB_ROCM_VERSION is set (mirrors worker.py) - worker.py: explicit len-guard in _hip_ver_at_least() with warning logs instead of silent IndexError/ValueError swallow - hardware.py: isinstance(result, dict) guard before result.get() in _smi_query() to prevent AttributeError on non-dict backend returns - amd.py: round() before int() on parsed GPU IDs; log warning when truncation occurs (defensive against malformed amd-smi output) - setup.sh: quote --gcc-install-dir value in CMAKE_HIP_FLAGS so paths with spaces do not break the CMake argument - install.ps1, setup.ps1: apply colon-split + ToLower() to hipinfo gcnArchName match (consistent with each other and with setup.sh) - install.sh: tighten ROCm tag case patterns to explicit rocmX.Y|rocmX.Y.* to avoid unintended prefix matches * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix(studio/training): GPU OOM guard to prevent system freeze on VRAM exhaustion On RDNA 4 (gfx1200/gfx1201) and other ROCm GPUs, exhausting VRAM can cause a HIP driver hang that freezes the entire system rather than raising a recoverable Python exception. Two-part fix: - set_per_process_memory_fraction(0.90) caps the HIP/CUDA allocator at 90% of VRAM so PyTorch raises OutOfMemoryError before hitting the hardware limit, keeping the driver alive and the system responsive - top-level exception handler detects OOM errors by type and message and surfaces a clear actionable message to the UI (reduce max_seq_length, enable gradient_checkpointing, lower batch size) instead of the raw CUDA/HIP error string * fix(studio/rocm): OOM guard ROCm-only + unified memory, multi-GPU arch selection OOM guard (worker.py): - Scope to _hw.IS_ROCM only -- NVIDIA CUDA has a graceful OOM path and does not need the allocator cap - Detect unified memory by comparing torch VRAM against psutil system RAM; use 0.80 on unified-memory APUs (gfx1151 Strix Halo) where the GPU pool is carved from host RAM, 0.90 on discrete cards Multi-GPU arch selection: - install.ps1 / setup.ps1: replace -match (first hit only) with [regex]::Matches() to collect all gcnArchName entries, then index by HIP_VISIBLE_DEVICES / ROCR_VISIBLE_DEVICES - install_python_stack.py: index into full token list before dedup so HIP_VISIBLE_DEVICES=2 on [gfx1100, gfx1100, gfx1151] resolves gfx1151 - install.sh: remove awk dedup from gfx token collection for same reason GCC multiarch (setup.sh): - Only append -linux-gnu when gcc -print-multiarch does not already return the full triple, fixing double-suffix on Ubuntu 24.04 * fix(tests): update ROCm version cap expectations from rocm7.1 to rocm7.2 Daniel's normalisation commit updated the cap from rocm7.1 to rocm7.2 since PyTorch now publishes that index and rocm7.2 ships torch 2.11.0. Test expectations were stale. * fix(tests): correct MLX smoke test losses_per_step assertion logging_steps=1 with max_steps=30 produces 30 loss entries, not 7. The assertion was stale from a previous config. * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix(studio/worker): detect unified-memory APU by GPU name not VRAM/RAM ratio The previous heuristic (VRAM > 50 % of system RAM) false-positived on discrete cards in low-RAM systems — e.g. RX 9060 XT 16 GB on a 16 GB or 24 GB machine would trip the unified-memory path and log "unified memory host" when it should say "discrete". AMD iGPUs (gfx1150/gfx1151 Strix Halo, Strix Point, etc.) expose names with a digit+M suffix ("AMD Radeon 890M"), while discrete cards use "RX NNNN [XT|XTX]" naming. Matching that suffix is reliable across all current ROCm-capable AMD consumer GPUs and does not require psutil. Also includes the device name in the log line to ease future debugging. * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix(install/setup.ps1): force array on hipinfo gcnArchName parse to fix single-GPU arch truncation When [regex]::Matches() finds exactly one match, PowerShell's pipeline unwraps the result to a scalar string. Indexing a scalar string with [0] returns the first *character*, so a one-GPU system would parse gcnArchName "gfx1200" as "g", which is not in the supported arch map and triggers the CPU-only fallback. Wrapping with @() forces the result to remain an array regardless of match count. On a single-GPU machine the arch is now correctly read as "gfx1200" (or whatever the full name is) so the ROCm wheel index is selected. Reproducer: hipinfo exits 0 and outputs exactly one gcnArchName line. Without @(), $_hipAllArches = "gfx1200" (String); $_hipAllArches[0] = 'g'. With @(), $_hipAllArches = @("gfx1200") (Object[]); $_hipAllArches[0] = "gfx1200". * fix(studio/rocm): classify unified-memory APU via VRAM/RAM ratio, not arch list Replace the gcnArchName allowlist {gfx1150, gfx1151} with a psutil-based heuristic: unified APUs expose the entire system RAM as the HIP pool (ratio ≥ 0.90), discrete cards are well below that. No arch name required — future APUs classify correctly without code changes. Also removes the stale import re / \d[Mm]\b device-name regex that5d84704left behind, and logs vram/sys GiB for easier on-hardware verification. Addresses h34v3nzc0dex review: Radeon 8060S (gfx1151, 128 GiB unified) now correctly gets 0.80 cap instead of 0.90. * fix(studio/rocm): revert to gcnArchName for unified-memory APU classification VRAM/RAM ratio >= 0.90 false-positives on machines where discrete VRAM equals system RAM (e.g. RX 9060 XT 16 GB + 16 GB system RAM → ratio 1.0, incorrectly classified as unified → wrong 0.80 cap applied). gcnArchName is the correct signal: naming-independent, stable within a product family, and already parsed throughout this PR. Unified set is {gfx1150, gfx1151} (Strix Point + Strix Halo). * fix(studio/llama-prebuilt): resolve hipinfo via HIP_PATH/ROCM_PATH on Windows shutil.which("hipinfo") returns None when the HIP SDK bin dir is not on PATH -- the HIP SDK installer sets HIP_PATH/ROCM_PATH but does not always add the bin dir to PATH. This caused has_rocm=False in the prebuilt asset selector, so AMD ROCm machines got the CPU llama.cpp zip instead of the HIP one, silently running all chat inference on CPU. Add _resolve_exe() that falls back to %HIP_PATH%\bin and %ROCM_PATH%\bin when shutil.which() finds nothing, mirroring the same fallback already present in setup.ps1. * fix(studio/llama-prebuilt): pass --has-rocm from setup.ps1 to skip re-detection The Python prebuilt installer re-detects ROCm independently via shutil.which("hipinfo"), which fails when hipinfo is not on PATH (HIP SDK sets HIP_PATH but doesn't always add the bin dir to PATH). This caused has_rocm=False and downloaded the CPU llama.cpp zip even on confirmed AMD ROCm machines. setup.ps1 already performs reliable ROCm detection with its own HIP_PATH/ROCM_PATH fallback. Add --has-rocm flag to install_llama_prebuilt.py so setup.ps1 can forward its result directly, and pass it whenever $HasROCm is true. The Python script then overrides has_rocm=True in the HostInfo without re-probing. * fix(studio/llama-prebuilt): add HIP asset to simple-policy Windows path direct_upstream_release_plan (used by --simple-policy, which setup.ps1 always passes) only checked has_usable_nvidia on Windows and fell straight to CPU for AMD ROCm machines, ignoring has_rocm entirely. The --has-rocm override had no effect because the simple-policy code path never reached resolve_asset_choice where has_rocm was checked. Add an elif branch for has_rocm that tries the upstream HIP asset (llama-TAG-bin-win-hip-radeon-x64.zip) before falling through to the CPU fallback, consistent with the non-simple-policy path. * fix(studio/setup.ps1): auto-remove mismatched llama.cpp install kind When an existing llama.cpp install is the wrong kind for the current GPU (e.g. windows-cpu on an AMD ROCm machine that should have windows-hip), the prebuilt installer skips on tag match and never upgrades. Read install_kind from UNSLOTH_PREBUILT_INFO.json before invoking the installer and remove the directory if the kind doesn't match, forcing a fresh download of the correct variant. * fix(studio/setup.ps1): show live PyTorch install output in verbose mode for ROCm The ROCm torch reinstall (setup.ps1 phase) always silently captured output, so in --verbose mode the torch downgrade mid-install (2.11.0+rocm → 2.10.0 → 2.11.0+rocm) looked like the final state was 2.10.0. Match the CPU/CUDA blocks which show live uv output when $script:UnslothVerbose is set. * fix(rocm/windows): set ROCBLAS_TENSILE_LIBPATH for bundled rocblas.dll The llama.cpp ROCm prebuilt bundles rocblas.dll next to the binary but not the Tensile kernel library files it depends on at runtime (rocblas/library/TensileLibrary*.dat + *.hsaco). The bundled DLL searches for these files relative to its own location by default, i.e. <binary_dir>/rocblas/library/, which does not exist in the prebuilt install tree. This causes a silent crash on the very first GEMM (prefill) with no output from llama-server, seen by the caller as WinError 10054 / 10061. Model load and the single-token warmup pass because they use simpler code paths that do not trigger rocBLAS GEMM. Fix: set ROCBLAS_TENSILE_LIBPATH in the subprocess env to <HIP_PATH>/bin/rocblas/library so the bundled DLL finds the kernel files from the system ROCm installation. Uses setdefault so a user- supplied env var is never overwritten. No-ops on CUDA and CPU (no HIP_PATH) and on Linux (win32 branch only). Reproducer log: rocBLAS error: Cannot read .../Release/rocblas/library/TensileLibrary.dat rocBLAS error: Could not initialize Tensile host: directory_iterator: The system cannot find the path specified. * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix(install.sh): restore gfx token dedup in Strix multi-GPU awk indexer536a54dfremoved the per-source `| awk '!seen[$0]++'` dedup from the _gfx_all collection step but left the indexer awk as bare NF, so on a mixed-arch host (e.g. dGPU gfx1100 + Strix iGPU gfx1151) where rocminfo emits each gfx token twice (Name: field + ISA triple), HIP_VISIBLE_DEVICES=1 indexed vals[1] = the second gfx1100 occurrence instead of gfx1151, triggering the Strix routing on the wrong GPU. Add !seen[$0]++ to the indexer awk so duplicate tokens from the same GPU collapse to one entry before the HIP_VISIBLE_DEVICES index is applied -- matching exactly what the Python side does with dict.fromkeys() in _detect_amd_gfx_codes(). The comment above the block ("skip duplicates") already documented this as the intended behaviour. * fix(studio/install): correct _TOTAL progress count on Windows base_total += 3 fired for all non-macOS platforms including Windows, but flash-attn (line 1620) and ROCm torch final (line 1705) are both guarded by 'not IS_WINDOWS and not IS_MACOS', so on Windows with torch enabled _TOTAL was 13 while only 11 _progress() calls actually execute. Split into +1 for the ROCm torch check (all non-macOS) and +2 for the two Linux-only steps, so Windows gets _TOTAL=11 and Linux gets 14. * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix(install.ps1): enforce torch>=2.11.0 for gfx120X and Strix on Windows The AMD arch-specific index (repo.amd.com/rocm/whl/gfx120X-all/ and gfx1151/) publishes torch wheels from 2.7.1 through 2.11.0. Without a version floor pip can resolve to torch 2.10.0+rocm7.12 on RDNA 4 (gfx120X) or torch 2.10.0+rocm7.1 on Strix (gfx1151/gfx1150), both of which have a null-pointer crash in torch._C._grouped_mm (TheRock issues #5284 / #3284). torch 2.11.0+rocm7.13 contains the fix. Add $ROCmTorchFloor alongside $ROCmIndexUrl: set to torch>=2.11.0 for the two affected arch families, null for all others. Wire it into the uv pip install call so the broken wheels are never selected. * fix(rocm/windows): address Codex nits - deterministic DLL suffix, CUDA llama.cpp kind, HIP_VISIBLE_DEVICES arch indexing - install_python_stack.py / worker.py: _detect_bnb_rocm_dll_ver() and the inline worker probe now collect ALL libbitsandbytes_rocm*.dll suffixes and return max() by numeric value instead of stopping at the first glob hit. Filesystem glob order is not guaranteed; this ensures '713' always wins over '72' when both variants are present in the wheel. - setup.ps1 (expectedKind): add 'windows-cuda' branch so NVIDIA hosts are not treated as 'windows-cpu'. Previously an existing windows-cuda prebuilt was always considered a mismatch on non-ROCm machines, forcing an unnecessary re-download on every update. - setup.ps1 (amd-smi gfx arch): collect ALL gfx tokens from amd-smi list output in GPU order and honour HIP_VISIBLE_DEVICES / ROCR_VISIBLE_DEVICES when selecting which arch to use. On mixed-arch AMD systems where the visible GPU is not the first enumerated one, this prevents installing an incompatible wheel index. Falls back to index 0 (same as before) when the visibility var is unset or is a comma-separated list. - test_rocm_support.py: add test_picks_highest_suffix_when_multiple_dlls to cover the multi-DLL case that was previously untested. * fix(rocm): misleading amd-smi log, BNB spec consistency, torch ceiling for AMD index amd.py: split 'returncode != 0 or not stdout' into two separate branches. Previously, exit-0 with empty output logged 'amd-smi returned code 0' (which reads as success, not a warning) and incorrectly incremented the circuit-breaker counter. Now: non-zero exit logs the code and counts toward the limit as before; empty stdout on exit 0 logs at DEBUG level and does not penalise the counter (amd-smi --json always emits at least [] on exit 0, so this branch is rare and is not a tool failure). main.py: replace spec.origin / os.path.dirname() with spec.submodule_search_locations to match install_python_stack.py and worker.py. For normal wheel installs both approaches reach the same directory, but using submodule_search_locations is the canonical way and handles editable bitsandbytes installs correctly. Also use max() by numeric suffix (same as the other two sites) instead of a sort-then-break loop. install.ps1: add <2.12.0 ceiling to the torch constraint for gfx120X (RDNA 4) and gfx1151/gfx1150 (Strix). AMD actively publishes new versions on their per-arch index; without a ceiling, a future 2.12.0+rocmX.Y wheel would be pulled in automatically before being validated on these architectures. The ceiling matches the existing Linux install_python_stack.py constraint for the same arches. Bump both when 2.12.x is confirmed working. * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix(rocm): torch floor in setup.ps1, torchvision pin for Strix, rocmsdk in _hip_ver_at_least setup.ps1: add \ (mirrors install.ps1) and derive \ from it. Previously the AMD index install called 'Fast-Install torch torchvision torchaudio --force-reinstall --index-url \' with no version constraint, so pip could resolve torch 2.10.0+rocm7.12 for gfx1151/gfx1200 -- the exact broken wheel the PR is meant to avoid. Now gfx120X and Strix enforce 'torch>=2.11.0,<2.12.0', matching install.ps1 and the Linux constraint. install_python_stack.py: pin torchvision and torchaudio in _strix_override_pkgs. The Strix Linux override uses --index-url (exclusive, no PyPI fallback); bare unversioned 'torchvision' and 'torchaudio' could resolve a build from AMD's index targeting a different torch major, causing ABI/version mismatches at runtime. Now pinned to '>=0.26.0,<0.27.0' and '>=2.11.0,<2.12.0' respectively, matching _ROCM_TORCH_CONSTRAINT['rocm7.2']. worker.py: extend _hip_ver_at_least to handle AMD SDK wheel version strings. The fallback regex r'rocm(\d+)\.(\d+)' cannot match '2.9.0+rocmsdk20251116' (no rocmX.Y component), so the function always returned False on SDK/Radeon wheels -- installing the Python _grouped_mm workaround on wheels that already have the working HIP kernel. Added a second check: if the version string contains '+rocmsdk', assume >= 7.13 (the rocmsdk format post-dates the gfx120X null-kernel fix) and skip the fallback. * fix(rocm): warn on OOB HIP_VISIBLE_DEVICES, bail on empty numeric_ids mask - setup.ps1: when HIP/ROCR_VISIBLE_DEVICES names an index beyond the detected GPU count, emit a yellow warning and fall back to GPU 0 instead of silently reading allGfxArches[-1] (wrong arch) - hardware.py _reconcile_primary_rocm_unified_memory: distinguish numeric_ids=None (no env var, use torch ordinal 0) from numeric_ids=[] (empty mask / HIP_VISIBLE_DEVICES=-1, no GPU visible); bail out early in the empty case to avoid querying torch.device(0) incorrectly * fix(rocm): gate StubSubpackageFinder on win32 ROCm, add gcnArchName fallbacks - worker.py _StubSubpackageFinder: the meta_path append was running on every platform on every call to run_training_process; moved it inside the if _is_win32_rocm: block since stubs are only seeded there and the finder is a pure accumulation on Linux/Windows CUDA - worker.py OOM guard: AMD SDK / Radeon wheels may not populate gcnArchName, causing Strix Halo to be misclassified as discrete and get the 0.90 cap (12.8 GB OS headroom) instead of 0.80 (25.6 GB); now tries gcn_arch_name / arch_name / gfx_arch_name variants first, then falls back to device-name matching (890M -> Strix Halo, 880M -> Strix Point) with a debug log when the fallback fires * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix(rocm): pin torchvision/torchaudio in setup.ps1, remove -Unique from arch array - setup.ps1 ROCm torch install: torchvision and torchaudio were passed bare alongside pinned torch>=2.11.0,<2.12.0 for gfx1151/gfx1200 arches. AMD publishes packages independently so a future torchvision 0.27 (for torch 2.12) on the same arch index would cause pip ResolutionImpossible or an ABI-incompatible install. Added torchvisionFloorMap and torchaudioFloorMap mirroring install_python_stack.py's strix override (torchvision>=0.26.0,<0.27.0, torchaudio>=2.11.0,<2.12.0) and derived ROCmVisionSpec/ROCmAudioSpec used in all three Fast-Install call sites. - setup.ps1 amd-smi arch detection: Select-Object -Unique was collapsing same-arch multi-GPU arrays (e.g. two gfx1151 APUs -> 1-element array) causing HIP_VISIBLE_DEVICES=1 to trigger a false out-of-range warning and fall back to GPU 0 even though the correct GPU would have been at index 1. Removed -Unique; added comment noting the positional-index assumption and its non-contiguous-GPU limitation. * fix(rocm): add 8060s/8050s to OOM guard device-name fallback, extract classifier helper Path 3 of the OOM guard device-name fallback only checked for 890m/880m (gfx1150 Strix Point SKU names). Strix Halo (gfx1151) ships as Radeon 8060S (Ryzen AI MAX+ 395) and Radeon 8050S (cut-down SKU) -- neither matches, so the fallback returned is_unified=False and applied the 0.90 fraction instead of 0.80, leaving ~12.8 GiB OS headroom on a 128 GiB pool instead of ~25.6 GiB. Fix: add 8060s and 8050s to the name-match set. Also correct the comment that mislabelled 890M as a Strix Halo name (it is Strix Point). Refactor: extract the three-path classifier into _rocm_classify_unified_memory() so it can be unit-tested directly. Add 31 test cases in test_rocm_oom_guard.py covering all three paths and the regression case (Radeon 8060S Graphics). Reported-by: h34v3nzc0dex * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix(rocm): pass explicit dtype on bf16-unsupported hardware (RDNA2) dtype=None lets unsloth auto-detect the model dtype. On RDNA2 (gfx103x, e.g. RX 6600) is_bfloat16_supported() incorrectly returns True, so unsloth picks bf16 and the first bf16 kernel dispatch triggers: LLVM ERROR: Cannot select: intrinsic %llvm.amdgcn.fdot2.bf16.bf16 Replace every dtype=None in load_model() with _auto_dtype which resolves to None when bf16 is supported (all modern NVIDIA + RDNA3+) and torch.float16 otherwise. This gives RDNA2 users a working float16 training path without touching NVIDIA behaviour at all. Fixes: https://github.com/unslothai/unsloth/issues/5337 * fix: reduce log noise for expected non-issues on Windows ROCm Three log lines fired at warning/error level for conditions that are completely expected on a Windows HIP SDK-only setup: amd.py - amd-smi WinError 2 (FileNotFoundError): downgrade warning -> debug. amd-smi ships with Adrenalin, not the HIP SDK; absence is normal. - 'disabling' message: downgrade warning -> info with clearer text 'not available (not installed; expected on HIP SDK-only systems); GPU VRAM polling disabled' hardware.py - torch.distributed.Store missing: downgrade warning -> debug. The distributed stub added in this PR intentionally omits Store; the attention-impl fallback to eager is expected and non-actionable. worker.py - causal-conv1d: add early Windows exit (info) in both _ensure_causal_conv1d_fast_path and _causal_conv1d_install hook; no cp313/win_amd64 wheel exists, so the install always fails. - FLA: add early Windows exit (info) in _ensure_flash_linear_attention_unconditional; triton dependency has no cp313/win_amd64 wheel. - Defense-in-depth: _install_package_wheel_first non-HIP PyPI failure logs info+debug on Windows instead of error; FLA failure logs info+debug on Windows instead of warning. * [AMD] FIx installation of bitsandbytes when it's from .dev and skip rebuilding llama.cpp if we build it manually. * fix: use force_pip for Windows ROCm bitsandbytes prebuilt wheel install uv rejects the bnb continuous-release wheel due to filename/metadata version mismatch (1.33.7.preview vs 0.50.0.dev0). Switch to force_pip=True (pip bypass) instead of the UV_SKIP_WHEEL_FILENAME_CHECK env var workaround -- cleaner and consistent with how the Linux path handles it. BNB_ROCM_VERSION is still set post-install to the detected DLL suffix so the worker subprocess loads the correct libbitsandbytes_rocm{VER}.dll even when torch.version.hip reports a newer HIP version than the wheel ships. * fix: three small correctness fixes found in PR review - _install_bnb_windows_rocm: use UV_SKIP_WHEEL_FILENAME_CHECK=1 with try/finally instead of force_pip=True so the env var is always restored and the failing CI test passes - _determine_attention_impl_for_gpu_estimate: gate torch._C distributed stubs on IS_ROCM so Windows CUDA users keep the real extension - install.ps1 amd-smi fallback: collect all gfx tokens and index by HIP_VISIBLE_DEVICES, matching the hipinfo path on multi-GPU hosts * fix: stub torchao in export subprocess on Windows ROCm On Windows, the ROCm build of PyTorch ships without the distributed C extension (torch._C._distributed_c10d). torchao, which is pulled in transitively by transformers.quantizers at import time, walks into torch.distributed._functional_collectives -> distributed_c10d and crashes with: No module named 'torch._C._distributed_c10d'; 'torch._C' is not a package This only affected the export subprocess because the training subprocess already applied an identical torchao stub (introduced separately to fix the same root cause). The export subprocess had no such guard and died during 'Importing Unsloth...' before any model loading could happen. Fix: apply the same _StubSubpackageFinder / torchao stub pattern to the export subprocess entry point, gated on Windows ROCm detection, before any import of transformers or unsloth_zoo. Root cause tracked in ROCm/TheRock#3284 (libuv / torch.distributed missing on Windows ROCm builds). Ref: https://github.com/ROCm/TheRock/issues/3284 * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * install.sh, setup.sh: add GPU arch step logging to match PS1 scripts Both shell scripts were missing the step "gpu" terminal log block that install.ps1 and setup.ps1 emit. This adds equivalent output: GPU label with gfx arch (e.g. "AMD ROCm (gfx1151)"), ROCm root path, hipconfig version, and marketing name substep. Includes the same gfx arch detection chain (rocminfo → amd-smi list → amd-smi static --asic), UNSLOTH_ROCM_GFX_ARCH env override, and name-based arch inference table (Strix Halo/Point, RDNA 3/4) as the PS1 versions. install.sh also replaces bare echo blocks for the AMD ROCm and CPU-only cases with formatted substep output. * Fix BNB_ROCM_VERSION gate, ROCm GPU mask preference, APU unified memory and Release build for PR #5301 - main.py: gate BNB_ROCM_VERSION on the rocm bnb DLL or HIP_PATH/ROCM_PATH instead of importing torch on every Windows host - hardware.py: prefer HIP/ROCR visible-device masks only on ROCm hosts so a stale mask cannot override CUDA_VISIBLE_DEVICES on NVIDIA - llama_cpp.py: set GGML_CUDA_ENABLE_UNIFIED_MEMORY=1 only for unified-memory APUs (gfx1150/gfx1151) - setup.sh: pass -DCMAKE_BUILD_TYPE=Release for the HIP source build - add test_amd_apu_unified_memory.py * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix: guard recompile_limit + fix AMD VRAM monitor fallback trainer.py: torch._dynamo.config.recompile_limit does not exist in some ROCm torch builds (e.g. pytorch.org/whl/rocm6.2 wheels). Guard the assignment so training doesn't crash on RDNA2/RDNA3. hardware.py: when amd-smi/nvidia-smi is unavailable or returns no usable data (HIP SDK-only Windows, Docker, unexpected JSON format), the existing fallback used torch.cuda.memory_allocated() which is process-specific and reads near-zero even with a fully loaded model. Switch to torch.cuda.mem_get_info() via _torch_get_per_device_info() which reports system-wide VRAM occupancy so the GPU monitor shows real usage on all AMD systems without requiring amd-smi. * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix: Windows VRAM monitor via Performance Counter API When amd-smi/nvidia-smi is unavailable on Windows, query dedicated GPU VRAM via Windows Performance Counters (same source as Task Manager). This gives system-wide cross-process usage, fixing the near-zero reading caused by torch.cuda.mem_get_info only seeing the Studio server process. Linux fallback path unchanged (mem_get_info is system-wide on ROCm). * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix: rename to _rocm_windows_perf_counter_vram_gb, scope to IS_ROCM Function is AMD ROCm specific — amd-smi absent on Windows when only the HIP SDK is installed. Scoped to IS_ROCM so NVIDIA Windows path is untouched (nvidia-smi handles that case). * fix: AMD VRAM monitor — Linux DRM sysfs + Windows perf counter Linux: read /sys/class/drm/card*/device/mem_info_vram_used|total for system-wide GPU memory across all processes. No tools required, always present on Linux AMD systems. Windows: Windows Performance Counter API (already added). Both paths are gated on IS_ROCM and only fire when amd-smi is absent. torch mem_get_info remains as last resort (process-local). * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix: AMD GPU monitor — utilization, temperature, and power for Windows and Linux fallback paths - Windows: GPU utilization via \GPU Engine(*engtype_3D*)\Utilization Percentage perf counter - Windows: temperature and power via ADL (atiadlxx.dll, ships with Adrenalin) - Linux: GPU utilization via DRM sysfs gpu_busy_percent - Linux: temperature via hwmon temp1_input (millidegrees C) - Linux: power via hwmon power1_average / power1_input (microwatts) All paths are no-op fallbacks (None) when the source is unavailable. Mirrors what nvidia-smi provides on the CUDA path. * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix: remove ADL ctypes — does not support AMD iGPU (Strix Halo) * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Daniel Han <danielhanchen@gmail.com> Co-authored-by: Lee Jackson <130007945+Imagineer99@users.noreply.github.com> Co-authored-by: Erland366 <erland.pg366@gmail.com> Co-authored-by: danielhanchen <michaelhan2050@gmail.com>
3391 lines
131 KiB
Python
3391 lines
131 KiB
Python
# SPDX-License-Identifier: AGPL-3.0-only
|
||
# Copyright 2026-present the Unsloth AI Inc. team. All rights reserved. See /studio/LICENSE.AGPL-3.0
|
||
|
||
"""
|
||
Training subprocess entry point.
|
||
|
||
Each training job runs in a fresh subprocess (mp.get_context("spawn")).
|
||
This gives us a clean Python interpreter with no stale module state —
|
||
solving the transformers version-switching problem completely.
|
||
|
||
Pattern follows core/data_recipe/jobs/worker.py.
|
||
"""
|
||
|
||
from __future__ import annotations
|
||
|
||
import structlog
|
||
from loggers import get_logger
|
||
import math
|
||
import os
|
||
import shutil
|
||
import sys
|
||
import time
|
||
import traceback
|
||
import subprocess as _sp
|
||
from pathlib import Path
|
||
from typing import Any, Callable
|
||
|
||
logger = get_logger(__name__)
|
||
from utils.hardware import apply_gpu_ids
|
||
from utils.wheel_utils import (
|
||
direct_wheel_url,
|
||
flash_attn_wheel_url,
|
||
has_blackwell_gpu,
|
||
install_wheel,
|
||
probe_torch_wheel_env,
|
||
url_exists,
|
||
)
|
||
|
||
|
||
def _output_dir_from_resume_checkpoint(
|
||
resume_from_checkpoint: str | None,
|
||
) -> str | None:
|
||
if not resume_from_checkpoint:
|
||
return None
|
||
path = Path(resume_from_checkpoint)
|
||
return str(path.parent if path.name.startswith("checkpoint-") else path)
|
||
|
||
|
||
_CAUSAL_CONV1D_RELEASE_TAG = "v1.6.1.post4"
|
||
_CAUSAL_CONV1D_PACKAGE_VERSION = "1.6.1"
|
||
_MAMBA_SSM_RELEASE_TAG = "v2.3.1"
|
||
_MAMBA_SSM_PACKAGE_VERSION = "2.3.1"
|
||
_FLASH_ATTN_RUNTIME_MIN_SEQ_LEN = 32768
|
||
_FLASH_ATTN_SKIP_ENV = "UNSLOTH_STUDIO_SKIP_FLASHATTN_INSTALL"
|
||
# apache-tvm-ffi 0.1.10/0.1.11 crash Triton with "CUDA: misaligned address" on sm_100.
|
||
_TILELANG_PACKAGE_VERSION = "0.1.8"
|
||
_APACHE_TVM_FFI_PACKAGE_VERSION = "0.1.9"
|
||
_TILELANG_SKIP_ENV = "UNSLOTH_STUDIO_SKIP_TILELANG_INSTALL"
|
||
# Pin both so plain pip cannot silently upgrade torch under the worker (fla-core needs torch>=2.7).
|
||
_FLA_PACKAGE_VERSION = "0.5.0"
|
||
_FLA_CORE_PACKAGE_VERSION = "0.5.0"
|
||
_FLA_SKIP_ENV = "UNSLOTH_STUDIO_SKIP_FLA_INSTALL"
|
||
# `--no-deps` saves torch but loses fla-core's transitive deps; `packaging` is also undeclared upstream.
|
||
_FLA_RUNTIME_DEPS = ("einops", "packaging", "triton")
|
||
_FLA_MIN_TORCH = (2, 7)
|
||
_FLA_MIN_PYTHON = (3, 10)
|
||
# tilelang 0.1.8 ships wheels only for these Linux arches and macOS arm64; never fall back to its 93MB sdist.
|
||
_TILELANG_SUPPORTED_LINUX_MACHINES = frozenset(("x86_64", "amd64", "aarch64", "arm64"))
|
||
_TILELANG_INSTALL_TIMEOUT_S = 600
|
||
_TVM_FFI_BROKEN_VERSIONS = ("0.1.10", "0.1.11")
|
||
_FAST_PATH_HOOKS_SKIP_ENV = "UNSLOTH_STUDIO_SKIP_FAST_PATH_HOOKS"
|
||
|
||
# Module-level handle so the torch.library.Library registration survives past
|
||
# run_training_process() and is not garbage collected mid-run.
|
||
_WINDOWS_ROCM_GROUPED_MM_LIB = None
|
||
|
||
# Worker subprocesses inherit the parent env but not the parent's
|
||
# os.add_dll_directory registrations. Replicate main.py's Windows ROCm DLL
|
||
# setup at module load so the first `import torch` can find amdhip64.dll even
|
||
# when HIP_PATH\bin is not on the system PATH. Handles retained at module
|
||
# scope so they are not garbage collected.
|
||
_ROCM_DLL_HANDLES: list = []
|
||
if sys.platform == "win32":
|
||
|
||
def _add_rocm_dll_dirs_worker() -> None:
|
||
_candidates: list[str] = []
|
||
for _var in ("HIP_PATH", "ROCM_PATH"):
|
||
_val = os.environ.get(_var)
|
||
if _val:
|
||
_candidates.append(os.path.join(_val, "bin"))
|
||
_default_root = os.path.join(
|
||
os.environ.get("ProgramFiles", r"C:\Program Files"), "AMD", "ROCm"
|
||
)
|
||
|
||
def _ver_key(name: str) -> tuple:
|
||
# Numeric tuple key so "10.0" sorts after "7.0"; non-numeric chunks fall back to string.
|
||
parts = []
|
||
for chunk in name.split("."):
|
||
try:
|
||
parts.append((0, int(chunk)))
|
||
except ValueError:
|
||
parts.append((1, chunk))
|
||
return tuple(parts)
|
||
|
||
try:
|
||
if os.path.isdir(_default_root):
|
||
for _ver in sorted(
|
||
os.listdir(_default_root), key = _ver_key, reverse = True
|
||
):
|
||
_bin = os.path.join(_default_root, _ver, "bin")
|
||
if os.path.isdir(_bin):
|
||
_candidates.append(_bin)
|
||
except OSError:
|
||
pass
|
||
for _d in _candidates:
|
||
if os.path.isdir(_d):
|
||
try:
|
||
_ROCM_DLL_HANDLES.append(os.add_dll_directory(_d))
|
||
except (OSError, AttributeError):
|
||
pass
|
||
|
||
_add_rocm_dll_dirs_worker()
|
||
del _add_rocm_dll_dirs_worker
|
||
|
||
|
||
def _model_wants_causal_conv1d(model_name: str) -> bool:
|
||
name = model_name.lower()
|
||
return any(
|
||
key in name
|
||
for key in (
|
||
"qwen3.5",
|
||
"qwen3_5",
|
||
"qwen3.6",
|
||
"qwen3_6",
|
||
"qwen3-next",
|
||
"qwen3_next",
|
||
"nemotron_h",
|
||
"nemotron-h",
|
||
"nemotron-3-nano",
|
||
"falcon_h1",
|
||
"falcon-h1",
|
||
"granite-4.0-h",
|
||
"granitemoehybrid",
|
||
"lfm2",
|
||
)
|
||
)
|
||
|
||
|
||
def _hipcc_gcc_install_dir() -> str | None:
|
||
"""Return the highest-numbered ``/usr/lib/gcc/x86_64-linux-gnu/<N>`` that has
|
||
BOTH the gcc runtime dir AND the corresponding ``/usr/include/c++/<N>`` C++
|
||
headers, or ``None`` if no match (or non-Linux / non-x86_64).
|
||
|
||
Ubuntu 24.04 ships ``/usr/lib/gcc/x86_64-linux-gnu/14/`` (gcc-14 runtime
|
||
objects) but does NOT ship ``/usr/include/c++/14`` in its default apt set;
|
||
libstdc++ headers come from ``libstdc++-13-dev``. ROCm clang-20 picks the
|
||
highest-numbered runtime dir by default, finds no ``<cstdlib>``, and the
|
||
HIP source build fails with::
|
||
|
||
/opt/rocm-X.Y/lib/llvm/lib/clang/20/include/__clang_hip_runtime_wrapper.h:112:10:
|
||
fatal error: 'cstdlib' file not found
|
||
|
||
Returning a path lets the caller pass ``--gcc-install-dir=<path>`` to clang
|
||
via ``HIPCC_COMPILE_FLAGS_APPEND``. Mirrors the same loop ``bbf004c`` added
|
||
to ``studio/setup.sh`` for the llama.cpp HIP build branch (PR #5301).
|
||
"""
|
||
if not sys.platform.startswith("linux"):
|
||
return None
|
||
import platform as _platform
|
||
|
||
if _platform.machine().lower() != "x86_64":
|
||
return None
|
||
for _ver in (14, 13, 12, 11):
|
||
_runtime = f"/usr/lib/gcc/x86_64-linux-gnu/{_ver}/include"
|
||
_headers = f"/usr/include/c++/{_ver}"
|
||
if os.path.isdir(_runtime) and os.path.isdir(_headers):
|
||
return f"/usr/lib/gcc/x86_64-linux-gnu/{_ver}"
|
||
return None
|
||
|
||
|
||
def _install_package_wheel_first(
|
||
*,
|
||
event_queue: Any,
|
||
import_name: str,
|
||
display_name: str,
|
||
pypi_name: str,
|
||
pypi_version: str | None = None,
|
||
filename_prefix: str | None = None,
|
||
release_tag: str | None = None,
|
||
release_base_url: str | None = None,
|
||
wheel_url_builder: Callable[[dict[str, str] | None], str | None] | None = None,
|
||
pypi_spec: str | None = None,
|
||
pypi_status_message: str | None = None,
|
||
) -> bool:
|
||
try:
|
||
__import__(import_name)
|
||
logger.info("%s already installed", display_name)
|
||
return True
|
||
except ImportError:
|
||
pass
|
||
|
||
env = probe_torch_wheel_env(timeout = 30)
|
||
if wheel_url_builder is not None:
|
||
wheel_url = wheel_url_builder(env)
|
||
else:
|
||
wheel_url = direct_wheel_url(
|
||
filename_prefix = filename_prefix,
|
||
package_version = pypi_version,
|
||
release_tag = release_tag,
|
||
release_base_url = release_base_url,
|
||
env = env,
|
||
)
|
||
|
||
if wheel_url is None:
|
||
logger.info("No compatible %s wheel candidate", display_name)
|
||
elif url_exists(wheel_url):
|
||
_send_status(event_queue, f"Installing {display_name} for faster training...")
|
||
for installer, result in install_wheel(
|
||
wheel_url,
|
||
python_executable = sys.executable,
|
||
use_uv = bool(shutil.which("uv")),
|
||
run = _sp.run,
|
||
):
|
||
if result.returncode == 0:
|
||
logger.info("Installed prebuilt %s wheel successfully", display_name)
|
||
return True
|
||
logger.warning(
|
||
"%s failed to install %s wheel:\n%s",
|
||
installer,
|
||
display_name,
|
||
result.stdout,
|
||
)
|
||
else:
|
||
logger.info("No published %s wheel found: %s", display_name, wheel_url)
|
||
|
||
is_hip = env and env.get("hip_version")
|
||
if is_hip and not shutil.which("hipcc"):
|
||
logger.error(
|
||
"%s requires hipcc for source compilation on ROCm. "
|
||
"Install the ROCm HIP SDK: https://rocm.docs.amd.com",
|
||
display_name,
|
||
)
|
||
_send_status(
|
||
event_queue,
|
||
f"{display_name}: hipcc not found (ROCm HIP SDK required)",
|
||
)
|
||
return False
|
||
|
||
if pypi_spec is None:
|
||
pypi_spec = f"{pypi_name}=={pypi_version}"
|
||
|
||
if pypi_status_message is None:
|
||
if is_hip:
|
||
pypi_status_message = (
|
||
f"Compiling {display_name} from source for ROCm "
|
||
"(this may take several minutes)..."
|
||
)
|
||
else:
|
||
pypi_status_message = (
|
||
f"Installing {display_name} from PyPI for faster training..."
|
||
)
|
||
|
||
_send_status(event_queue, pypi_status_message)
|
||
|
||
# Prefer uv for faster dependency resolution when available
|
||
plain_pypi_install = pypi_version is None
|
||
if plain_pypi_install:
|
||
if shutil.which("uv"):
|
||
pypi_cmd = [
|
||
"uv",
|
||
"pip",
|
||
"install",
|
||
"--python",
|
||
sys.executable,
|
||
pypi_spec,
|
||
]
|
||
else:
|
||
pypi_cmd = [sys.executable, "-m", "pip", "install", pypi_spec]
|
||
else:
|
||
if shutil.which("uv"):
|
||
pypi_cmd = [
|
||
"uv",
|
||
"pip",
|
||
"install",
|
||
"--python",
|
||
sys.executable,
|
||
"--no-build-isolation",
|
||
"--no-deps",
|
||
]
|
||
# Avoid stale cache artifacts from partial HIP source builds
|
||
if is_hip:
|
||
pypi_cmd.append("--no-cache")
|
||
pypi_cmd.append(pypi_spec)
|
||
else:
|
||
pypi_cmd = [
|
||
sys.executable,
|
||
"-m",
|
||
"pip",
|
||
"install",
|
||
"--no-build-isolation",
|
||
"--no-deps",
|
||
"--no-cache-dir",
|
||
pypi_spec,
|
||
]
|
||
|
||
# Source compilation on ROCm can take 10-30 minutes; use a generous
|
||
# timeout. Non-HIP installs preserve the pre-existing "no timeout"
|
||
# behaviour so unrelated slow installs (e.g. causal-conv1d source
|
||
# build on Linux aarch64 or unsupported torch/CUDA combinations)
|
||
# are not aborted at 5 minutes by this PR.
|
||
_run_kwargs: dict[str, Any] = {
|
||
"stdout": _sp.PIPE,
|
||
"stderr": _sp.STDOUT,
|
||
"text": True,
|
||
}
|
||
if is_hip:
|
||
_run_kwargs["timeout"] = 1800
|
||
# On Ubuntu 24.04 + ROCm clang-20, the HIP source build (causal-conv1d,
|
||
# mamba-ssm source fallback, flash-attn source fallback) defaults to
|
||
# /usr/lib/gcc/x86_64-linux-gnu/14/ which has the runtime dir but no
|
||
# /usr/include/c++/14 headers, and dies at:
|
||
# __clang_hip_runtime_wrapper.h:112:10:
|
||
# fatal error: 'cstdlib' file not found
|
||
# Inject --gcc-install-dir for a gcc whose C++ headers actually exist.
|
||
# Respect any pre-existing --gcc-install-dir in HIPCC_COMPILE_FLAGS_APPEND
|
||
# (user knows best); otherwise append. Mirrors the same fix bbf004c
|
||
# added to studio/setup.sh for the llama.cpp HIP build (PR #5301).
|
||
_existing_flags = os.environ.get("HIPCC_COMPILE_FLAGS_APPEND", "")
|
||
if "--gcc-install-dir" not in _existing_flags:
|
||
_gcc_dir = _hipcc_gcc_install_dir()
|
||
if _gcc_dir is not None:
|
||
_appended = (f"{_existing_flags} --gcc-install-dir={_gcc_dir}").strip()
|
||
_env = _run_kwargs.get("env", os.environ).copy()
|
||
_env["HIPCC_COMPILE_FLAGS_APPEND"] = _appended
|
||
_run_kwargs["env"] = _env
|
||
logger.info(
|
||
"HIP source build for %s: appended "
|
||
"--gcc-install-dir=%s to HIPCC_COMPILE_FLAGS_APPEND",
|
||
display_name,
|
||
_gcc_dir,
|
||
)
|
||
|
||
try:
|
||
result = _sp.run(pypi_cmd, **_run_kwargs)
|
||
except _sp.TimeoutExpired:
|
||
logger.error(
|
||
"%s installation timed out after %ds",
|
||
display_name,
|
||
_run_kwargs.get("timeout"),
|
||
)
|
||
_send_status(
|
||
event_queue,
|
||
f"{display_name} installation timed out after "
|
||
f"{_run_kwargs.get('timeout')}s",
|
||
)
|
||
return False
|
||
|
||
if result.returncode != 0:
|
||
if is_hip:
|
||
# Surface a clear error for ROCm source build failures
|
||
error_lines = (result.stdout or "").strip().splitlines()
|
||
snippet = "\n".join(error_lines[-5:]) if error_lines else "(no output)"
|
||
logger.error(
|
||
"Failed to compile %s for ROCm:\n%s",
|
||
display_name,
|
||
result.stdout,
|
||
)
|
||
_send_status(
|
||
event_queue,
|
||
f"Failed to compile {display_name} for ROCm. "
|
||
"Check that hipcc and ROCm development headers are installed.\n"
|
||
f"{snippet}",
|
||
)
|
||
else:
|
||
if sys.platform == "win32":
|
||
# No prebuilt wheel and no source build toolchain on Windows --
|
||
# this is expected for packages like causal-conv1d. Log at
|
||
# info so users aren't alarmed by what looks like an error.
|
||
logger.info(
|
||
"%s is not available on Windows (no prebuilt wheel); skipping",
|
||
display_name,
|
||
)
|
||
logger.debug("Install output:\n%s", result.stdout)
|
||
else:
|
||
logger.error(
|
||
"Failed to install %s from PyPI:\n%s",
|
||
display_name,
|
||
result.stdout,
|
||
)
|
||
return False
|
||
|
||
if is_hip:
|
||
logger.info("Compiled and installed %s from source for ROCm", display_name)
|
||
else:
|
||
logger.info("Installed %s from PyPI", display_name)
|
||
return True
|
||
|
||
|
||
def _ensure_causal_conv1d_fast_path(event_queue: Any, model_name: str) -> None:
|
||
if not _model_wants_causal_conv1d(model_name):
|
||
return
|
||
if sys.platform == "win32":
|
||
logger.info("causal-conv1d: no prebuilt wheel for Windows; skipping")
|
||
return
|
||
|
||
_install_package_wheel_first(
|
||
event_queue = event_queue,
|
||
import_name = "causal_conv1d",
|
||
display_name = "causal-conv1d",
|
||
pypi_name = "causal-conv1d",
|
||
pypi_version = _CAUSAL_CONV1D_PACKAGE_VERSION,
|
||
filename_prefix = "causal_conv1d",
|
||
release_tag = _CAUSAL_CONV1D_RELEASE_TAG,
|
||
release_base_url = "https://github.com/Dao-AILab/causal-conv1d/releases/download",
|
||
)
|
||
|
||
|
||
def _installed_torch_version_tuple() -> tuple[int, int] | None:
|
||
"""Return ``(major, minor)`` of the installed torch, else None."""
|
||
try:
|
||
from importlib.metadata import version as _pkg_version
|
||
|
||
raw = _pkg_version("torch").split("+", 1)[0]
|
||
parts = raw.split(".")
|
||
return (int(parts[0]), int(parts[1]))
|
||
except Exception:
|
||
return None
|
||
|
||
|
||
def _flash_linear_attention_importable() -> bool:
|
||
"""Catch any exception (not just ImportError) so a broken native lib doesn't abort the worker."""
|
||
try:
|
||
import fla.modules # noqa: F401
|
||
import fla.ops.gated_delta_rule # noqa: F401
|
||
|
||
return True
|
||
except Exception as exc:
|
||
logger.warning(
|
||
"flash-linear-attention is not importable; continuing with install/fallback: %s",
|
||
exc,
|
||
)
|
||
return False
|
||
|
||
|
||
def _flash_linear_attention_current(already_importable: bool | None = None) -> bool:
|
||
"""True iff FLA imports AND is at the pinned version (older FLA lacks gated_delta_rule kernels)."""
|
||
if already_importable is None:
|
||
already_importable = _flash_linear_attention_importable()
|
||
if not already_importable:
|
||
return False
|
||
try:
|
||
from importlib.metadata import version as _pkg_version
|
||
from packaging.version import Version
|
||
|
||
fla_v = Version(_pkg_version("flash-linear-attention"))
|
||
core_v = Version(_pkg_version("fla-core"))
|
||
return fla_v >= Version(_FLA_PACKAGE_VERSION) and core_v >= Version(
|
||
_FLA_CORE_PACKAGE_VERSION
|
||
)
|
||
except Exception as exc:
|
||
logger.warning(
|
||
"flash-linear-attention importable but version check failed; treating as stale: %s",
|
||
exc,
|
||
)
|
||
return False
|
||
|
||
|
||
def _ensure_flash_linear_attention_unconditional(event_queue: Any) -> bool:
|
||
"""Install pinned FLA + fla-core with --no-deps. Returns True iff importable post-call."""
|
||
if os.getenv(_FLA_SKIP_ENV) == "1":
|
||
return False
|
||
if sys.platform == "win32":
|
||
logger.info(
|
||
"Skipping flash-linear-attention install: no prebuilt wheel for Windows"
|
||
)
|
||
return False
|
||
if sys.version_info < _FLA_MIN_PYTHON:
|
||
logger.info(
|
||
"Skipping flash-linear-attention install: requires Python >= %d.%d, have %s",
|
||
_FLA_MIN_PYTHON[0],
|
||
_FLA_MIN_PYTHON[1],
|
||
sys.version.split()[0],
|
||
)
|
||
return False
|
||
torch_ver = _installed_torch_version_tuple()
|
||
if torch_ver is not None and torch_ver < _FLA_MIN_TORCH:
|
||
_send_status(
|
||
event_queue,
|
||
(
|
||
f"Skipping flash-linear-attention install: fla-core requires "
|
||
f"torch>={_FLA_MIN_TORCH[0]}.{_FLA_MIN_TORCH[1]}, have "
|
||
f"{torch_ver[0]}.{torch_ver[1]}"
|
||
),
|
||
)
|
||
return False
|
||
|
||
# Probe once; reuse result so the --force-reinstall decision and the short-circuit
|
||
# share the same call count (stable for tests).
|
||
already_importable = _flash_linear_attention_importable()
|
||
if already_importable and _flash_linear_attention_current(already_importable = True):
|
||
logger.info("flash-linear-attention already importable at the pinned version")
|
||
return True
|
||
|
||
_send_status(
|
||
event_queue,
|
||
f"Installing flash-linear-attention=={_FLA_PACKAGE_VERSION} for faster training...",
|
||
)
|
||
|
||
# `--no-deps` blocks the silent torch upgrade; we bring the non-torch runtime deps in by hand.
|
||
specs = [
|
||
*_FLA_RUNTIME_DEPS,
|
||
f"fla-core=={_FLA_CORE_PACKAGE_VERSION}",
|
||
f"flash-linear-attention=={_FLA_PACKAGE_VERSION}",
|
||
]
|
||
extra_args = ["--no-deps"]
|
||
if already_importable:
|
||
# Older FLA already imported; pip skips reinstall without this flag.
|
||
extra_args.append("--force-reinstall")
|
||
|
||
if shutil.which("uv"):
|
||
pypi_cmd = [
|
||
"uv",
|
||
"pip",
|
||
"install",
|
||
"--python",
|
||
sys.executable,
|
||
*extra_args,
|
||
*specs,
|
||
]
|
||
else:
|
||
pypi_cmd = [
|
||
sys.executable,
|
||
"-m",
|
||
"pip",
|
||
"install",
|
||
*extra_args,
|
||
*specs,
|
||
]
|
||
|
||
try:
|
||
result = _sp.run(
|
||
pypi_cmd,
|
||
stdout = _sp.PIPE,
|
||
stderr = _sp.STDOUT,
|
||
text = True,
|
||
timeout = _TILELANG_INSTALL_TIMEOUT_S,
|
||
)
|
||
except _sp.TimeoutExpired:
|
||
logger.warning("flash-linear-attention install timed out; continuing")
|
||
_send_status(
|
||
event_queue, "flash-linear-attention install timed out; continuing"
|
||
)
|
||
return False
|
||
|
||
if result.returncode != 0:
|
||
if sys.platform == "win32":
|
||
logger.info(
|
||
"flash-linear-attention not available on Windows (no prebuilt wheel); "
|
||
"continuing on torch fallback"
|
||
)
|
||
logger.debug("Install output:\n%s", result.stdout)
|
||
else:
|
||
logger.warning(
|
||
"flash-linear-attention install failed (continuing on torch fallback):\n%s",
|
||
result.stdout,
|
||
)
|
||
_send_status(
|
||
event_queue,
|
||
"flash-linear-attention install failed; continuing without it",
|
||
)
|
||
return False
|
||
|
||
# pip can exit 0 with a missing transitive runtime dep; verify the import.
|
||
if not _flash_linear_attention_importable():
|
||
_send_status(
|
||
event_queue,
|
||
"flash-linear-attention installed but is not importable; continuing without it",
|
||
)
|
||
return False
|
||
|
||
logger.info("Installed flash-linear-attention for the FLA fast path")
|
||
return True
|
||
|
||
|
||
def _ensure_flash_linear_attention(event_queue: Any, model_name: str) -> None:
|
||
"""Legacy model-name-gated FLA install, used when UNSLOTH_STUDIO_SKIP_FAST_PATH_HOOKS=1."""
|
||
if not _model_wants_tilelang(model_name):
|
||
return
|
||
_ensure_flash_linear_attention_unconditional(event_queue)
|
||
|
||
|
||
_SSM_MODEL_SUBSTRINGS = (
|
||
"nemotron_h",
|
||
"nemotron-h",
|
||
"nemotron-3-nano",
|
||
"falcon_h1",
|
||
"falcon-h1",
|
||
"granite-4.0-h",
|
||
"granitemoehybrid",
|
||
)
|
||
|
||
|
||
def _ensure_mamba_ssm(event_queue: Any, model_name: str) -> None:
|
||
if not any(sub in model_name.lower() for sub in _SSM_MODEL_SUBSTRINGS):
|
||
return
|
||
|
||
logger.info("SSM model detected; setting up mamba-ssm after causal-conv1d")
|
||
_install_package_wheel_first(
|
||
event_queue = event_queue,
|
||
import_name = "mamba_ssm",
|
||
display_name = "mamba-ssm",
|
||
pypi_name = "mamba-ssm",
|
||
pypi_version = _MAMBA_SSM_PACKAGE_VERSION,
|
||
filename_prefix = "mamba_ssm",
|
||
release_tag = _MAMBA_SSM_RELEASE_TAG,
|
||
release_base_url = "https://github.com/state-spaces/mamba/releases/download",
|
||
)
|
||
|
||
|
||
# Auto-derived from installed transformers: model_types whose modeling_*.py imports `from fla.*`.
|
||
# Cached per process. Empty when transformers can't be inspected -> we skip tilelang pre-install
|
||
# (the FLA Triton path still runs via the runtime hook).
|
||
_TRANSFORMERS_FLA_MODEL_TYPES_CACHE: frozenset[str] | None = None
|
||
_MODEL_NAME_SEP_CHARS = ("-", ".", "/", " ")
|
||
|
||
|
||
def _discover_fla_model_types() -> frozenset[str]:
|
||
"""Model_types in the installed transformers whose modeling file imports `from fla.*`."""
|
||
global _TRANSFORMERS_FLA_MODEL_TYPES_CACHE
|
||
if _TRANSFORMERS_FLA_MODEL_TYPES_CACHE is not None:
|
||
return _TRANSFORMERS_FLA_MODEL_TYPES_CACHE
|
||
found: set[str] = set()
|
||
try:
|
||
import transformers
|
||
|
||
models_root = Path(transformers.__file__).parent / "models"
|
||
for modeling in models_root.glob("*/modeling_*.py"):
|
||
try:
|
||
src = modeling.read_text(encoding = "utf-8", errors = "ignore")
|
||
except OSError:
|
||
continue
|
||
if "from fla." in src:
|
||
found.add(modeling.parent.name)
|
||
except Exception as exc:
|
||
logger.debug("FLA model-type discovery skipped: %s", exc)
|
||
_TRANSFORMERS_FLA_MODEL_TYPES_CACHE = frozenset(found)
|
||
return _TRANSFORMERS_FLA_MODEL_TYPES_CACHE
|
||
|
||
|
||
def _model_wants_tilelang(model_name: str) -> bool:
|
||
"""True iff model_name normalizes to contain a discovered FLA model_type."""
|
||
types = _discover_fla_model_types()
|
||
if not types:
|
||
return False
|
||
name = model_name.lower()
|
||
for sep in _MODEL_NAME_SEP_CHARS:
|
||
name = name.replace(sep, "_")
|
||
return any(t in name for t in types)
|
||
|
||
|
||
def _installed_tvm_ffi_version() -> str | None:
|
||
"""Installed apache-tvm-ffi version, or None if missing/unimportable."""
|
||
try:
|
||
from importlib.metadata import version as _pkg_version
|
||
|
||
return _pkg_version("apache-tvm-ffi")
|
||
except Exception:
|
||
return None
|
||
|
||
|
||
def _tilelang_importable() -> bool:
|
||
"""Catch any exception (not just ImportError) so a broken native lib doesn't abort the worker."""
|
||
try:
|
||
import tilelang # noqa: F401
|
||
import tvm_ffi # noqa: F401
|
||
|
||
return True
|
||
except Exception as exc:
|
||
logger.warning(
|
||
"tilelang/tvm_ffi is not importable; continuing with install/fallback: %s",
|
||
exc,
|
||
)
|
||
return False
|
||
|
||
|
||
def _torch_has_hip() -> bool:
|
||
"""True iff torch is a ROCm build.
|
||
|
||
`torch.version.hip` covers official PyTorch ROCm wheels; AMD SDK / Radeon
|
||
wheels can leave it unset but still encode "rocm" in `torch.__version__`.
|
||
"""
|
||
try:
|
||
import torch as _torch
|
||
|
||
return bool(
|
||
getattr(_torch.version, "hip", None)
|
||
or "rocm" in getattr(_torch, "__version__", "").lower()
|
||
)
|
||
except Exception:
|
||
return False
|
||
|
||
|
||
def _rocm_classify_unified_memory(props: Any) -> tuple[str, bool]:
|
||
"""Classify a ROCm device as unified-memory (APU) or discrete.
|
||
|
||
Returns ``(gcn_arch, is_unified)`` where:
|
||
- ``gcn_arch`` is the canonical arch string (e.g. ``"gfx1151"``) when a
|
||
known attribute is present, or ``""`` when all arch attrs are absent.
|
||
- ``is_unified`` is ``True`` for AMD APUs with a shared GPU/system-RAM pool
|
||
(gfx1150 Strix Point, gfx1151 Strix Halo) — these need a lower
|
||
``set_per_process_memory_fraction`` cap to leave headroom for the OS.
|
||
|
||
Classification priority:
|
||
1. ``gcnArchName`` / variant spellings (stable, naming-independent).
|
||
2. Device-name substring match as a last-resort fallback when all arch
|
||
attrs are absent (AMD SDK / Radeon wheels may not populate them):
|
||
- gfx1150 Strix Point: ``Radeon 890M``, ``Radeon 880M``
|
||
- gfx1151 Strix Halo: ``Radeon 8060S`` (Ryzen AI MAX+ 395),
|
||
``Radeon 8050S`` (cut-down SKU)
|
||
"""
|
||
gcn_arch = ""
|
||
for _attr in ("gcnArchName", "gcn_arch_name", "arch_name", "gfx_arch_name"):
|
||
_v = (getattr(props, _attr, "") or "").split(":")[0].strip()
|
||
if _v:
|
||
gcn_arch = _v
|
||
break
|
||
|
||
if gcn_arch:
|
||
return gcn_arch, gcn_arch in {"gfx1150", "gfx1151"}
|
||
|
||
# Arch attrs absent — fall back to device-name matching.
|
||
dev_lower = (getattr(props, "name", "") or "").lower()
|
||
is_unified = (
|
||
"890m" in dev_lower
|
||
or "880m" in dev_lower
|
||
or "8060s" in dev_lower
|
||
or "8050s" in dev_lower
|
||
)
|
||
return gcn_arch, is_unified
|
||
|
||
|
||
def _tilelang_platform_supported() -> bool:
|
||
"""True iff a tilelang 0.1.8 wheel will load: Linux x86_64/aarch64, non-HIP torch.
|
||
|
||
HIP excluded because tilelang 0.1.8 has no HIP GEMM instruction and crashes mid-backward.
|
||
"""
|
||
import platform as _platform
|
||
|
||
if not sys.platform.startswith("linux"):
|
||
return False
|
||
if _platform.machine().lower() not in _TILELANG_SUPPORTED_LINUX_MACHINES:
|
||
return False
|
||
if _torch_has_hip():
|
||
return False
|
||
return True
|
||
|
||
|
||
def _pip_install_cmd(*args: str) -> list[str]:
|
||
"""`uv pip install` if uv is on PATH, else `python -m pip install`."""
|
||
if shutil.which("uv"):
|
||
return ["uv", "pip", "install", "--python", sys.executable, *args]
|
||
return [sys.executable, "-m", "pip", "install", *args]
|
||
|
||
|
||
def _run_pip(cmd: list[str], event_queue: Any, label: str) -> bool:
|
||
"""Run a pip install and surface success/failure via status events."""
|
||
try:
|
||
result = _sp.run(
|
||
cmd,
|
||
stdout = _sp.PIPE,
|
||
stderr = _sp.STDOUT,
|
||
text = True,
|
||
timeout = _TILELANG_INSTALL_TIMEOUT_S,
|
||
)
|
||
except _sp.TimeoutExpired:
|
||
logger.warning("%s install timed out; continuing", label)
|
||
_send_status(event_queue, f"{label} install timed out; continuing")
|
||
return False
|
||
if result.returncode != 0:
|
||
logger.warning(
|
||
"%s install failed (continuing without it):\n%s", label, result.stdout
|
||
)
|
||
_send_status(event_queue, f"{label} install failed; continuing")
|
||
return False
|
||
return True
|
||
|
||
|
||
def _ensure_tilelang_backend_unconditional(event_queue: Any) -> bool:
|
||
"""Install pinned tilelang + apache-tvm-ffi; two-step repair if a broken tvm-ffi is present.
|
||
|
||
Returns True iff both import post-call. Step 1 surgically downgrades a broken tvm-ffi
|
||
with --force-reinstall --no-deps so torch / CUDA stay untouched; step 2 is a regular
|
||
install for missing transitive deps. Bypass via UNSLOTH_STUDIO_SKIP_TILELANG_INSTALL=1.
|
||
"""
|
||
if os.getenv(_TILELANG_SKIP_ENV) == "1":
|
||
return False
|
||
if sys.version_info < _FLA_MIN_PYTHON:
|
||
logger.info(
|
||
"Skipping tilelang install: requires Python >= %d.%d, have %s",
|
||
_FLA_MIN_PYTHON[0],
|
||
_FLA_MIN_PYTHON[1],
|
||
sys.version.split()[0],
|
||
)
|
||
return False
|
||
if not _tilelang_platform_supported():
|
||
import platform as _platform
|
||
|
||
logger.info(
|
||
"Skipping tilelang install: no prebuilt wheel for %s/%s",
|
||
sys.platform,
|
||
_platform.machine(),
|
||
)
|
||
return False
|
||
|
||
existing_tvm_ffi = _installed_tvm_ffi_version()
|
||
needs_repair = existing_tvm_ffi in _TVM_FFI_BROKEN_VERSIONS
|
||
|
||
if not needs_repair and _tilelang_importable():
|
||
logger.info("tilelang + apache-tvm-ffi already installed")
|
||
return True
|
||
|
||
# Step 1: --no-deps keeps --force-reinstall from touching torch/CUDA via the dep graph.
|
||
if needs_repair:
|
||
logger.info(
|
||
"Forcing apache-tvm-ffi downgrade: %s is on the broken list",
|
||
existing_tvm_ffi,
|
||
)
|
||
_send_status(
|
||
event_queue,
|
||
(
|
||
f"Downgrading apache-tvm-ffi {existing_tvm_ffi} -> "
|
||
f"{_APACHE_TVM_FFI_PACKAGE_VERSION} (broken-versions list)"
|
||
),
|
||
)
|
||
repair_cmd = _pip_install_cmd(
|
||
"--only-binary=:all:",
|
||
"--force-reinstall",
|
||
"--no-deps",
|
||
f"apache-tvm-ffi=={_APACHE_TVM_FFI_PACKAGE_VERSION}",
|
||
)
|
||
if not _run_pip(repair_cmd, event_queue, "TileLang backend repair"):
|
||
return False
|
||
|
||
# Step 2: regular install pulls in transitive deps (z3-solver, ml-dtypes) without touching torch.
|
||
_send_status(
|
||
event_queue,
|
||
f"Installing TileLang=={_TILELANG_PACKAGE_VERSION} for faster training...",
|
||
)
|
||
install_cmd = _pip_install_cmd(
|
||
"--only-binary=:all:",
|
||
f"apache-tvm-ffi=={_APACHE_TVM_FFI_PACKAGE_VERSION}",
|
||
f"tilelang=={_TILELANG_PACKAGE_VERSION}",
|
||
)
|
||
if not _run_pip(install_cmd, event_queue, "TileLang backend"):
|
||
return False
|
||
|
||
# pip can exit 0 while a native lib (libz3.so) is missing; verify the import.
|
||
if not _tilelang_importable():
|
||
_send_status(
|
||
event_queue,
|
||
"TileLang backend installed but is not importable; continuing on the FLA Triton path",
|
||
)
|
||
return False
|
||
|
||
logger.info("Installed TileLang backend for FLA fast path")
|
||
return True
|
||
|
||
|
||
def _ensure_tilelang_backend(event_queue: Any, model_name: str) -> None:
|
||
"""Legacy substring-gated tilelang installer (opt-out path)."""
|
||
if not _model_wants_tilelang(model_name):
|
||
return
|
||
_ensure_tilelang_backend_unconditional(event_queue)
|
||
|
||
|
||
# ── Fast-path hooks ──
|
||
# Wrap transformers' is_{flash_linear_attention,causal_conv1d}_available so the first call
|
||
# (at modeling import time) drives the install. Any model that queries the gate gets the
|
||
# install; models that never query it (Llama, Gemma, dense Qwen) pay nothing.
|
||
# UNSLOTH_STUDIO_SKIP_FAST_PATH_HOOKS=1 falls back to the legacy substring path.
|
||
|
||
|
||
def _rebind_in_already_imported_modules(
|
||
*, attr_name: str, old_obj: Any, new_obj: Any
|
||
) -> int:
|
||
"""Rebind `attr_name -> new_obj` in every module that already imported `old_obj`.
|
||
|
||
`from X import Y` creates a local binding that reassigning X.Y won't reach.
|
||
Uses `__dict__.get` (not `getattr`) to skip lazy `__getattr__` aliases.
|
||
"""
|
||
count = 0
|
||
missing = object()
|
||
for mod_name, mod in list(sys.modules.items()):
|
||
if mod is None:
|
||
continue
|
||
module_dict = getattr(mod, "__dict__", None)
|
||
if not isinstance(module_dict, dict):
|
||
continue
|
||
existing = module_dict.get(attr_name, missing)
|
||
if existing is old_obj:
|
||
try:
|
||
setattr(mod, attr_name, new_obj)
|
||
count += 1
|
||
except Exception as exc:
|
||
logger.debug("Could not rebind %s in %s: %s", attr_name, mod_name, exc)
|
||
return count
|
||
|
||
|
||
def _install_fast_path_hooks(event_queue: Any, model_name: str) -> None:
|
||
"""Hook transformers' is_*_available gates so the first call drives the install.
|
||
|
||
Idempotent. UNSLOTH_STUDIO_SKIP_FAST_PATH_HOOKS=1 falls back to the substring gate.
|
||
"""
|
||
if os.getenv(_FAST_PATH_HOOKS_SKIP_ENV) == "1":
|
||
logger.info("Fast-path hooks disabled via env; using substring fallback")
|
||
return
|
||
|
||
# On HIP torch, even already-installed tilelang crashes FLA's TileLang dispatch.
|
||
# User can override with FLA_TILELANG=1.
|
||
if _torch_has_hip() and os.environ.get("FLA_TILELANG") is None:
|
||
os.environ["FLA_TILELANG"] = "0"
|
||
logger.info(
|
||
"HIP/ROCm torch detected; setting FLA_TILELANG=0 (no HIP GEMM in tilelang 0.1.8)"
|
||
)
|
||
|
||
try:
|
||
from transformers.utils import import_utils as _iu
|
||
except Exception as exc:
|
||
logger.warning(
|
||
"transformers.utils.import_utils not importable; skipping fast-path hooks: %s",
|
||
exc,
|
||
)
|
||
return
|
||
|
||
def _make_wrapper(
|
||
original: Callable[[], bool],
|
||
install_fn: Callable[[Any], bool],
|
||
gate_name: str,
|
||
post_available_fn: Callable[[Any], None] | None = None,
|
||
) -> Callable[[], bool]:
|
||
state = {"installed": False}
|
||
|
||
def wrapper() -> bool:
|
||
if state["installed"]:
|
||
return original()
|
||
try:
|
||
original.cache_clear() # defensive; worker subprocess is fresh
|
||
except AttributeError:
|
||
pass
|
||
ok = original()
|
||
ran_install = False
|
||
if not ok:
|
||
ran_install = True
|
||
logger.info("Hook fired for %s; triggering install", gate_name)
|
||
try:
|
||
ok = bool(install_fn(event_queue))
|
||
except Exception as exc:
|
||
logger.warning(
|
||
"%s install raised: %s; falling back to torch", gate_name, exc
|
||
)
|
||
ok = False
|
||
logger.info("%s hook done; available=%s", gate_name, ok)
|
||
# post_available_fn handles "gate already True but ancillary kernel broken" (e.g. tilelang
|
||
# missing while FLA imports fine); skip when install_fn already chained the follow-up.
|
||
if ok and not ran_install and post_available_fn is not None:
|
||
try:
|
||
post_available_fn(event_queue)
|
||
except Exception as exc:
|
||
logger.warning(
|
||
"%s post-available step raised: %s; continuing", gate_name, exc
|
||
)
|
||
state["installed"] = True
|
||
return ok
|
||
|
||
wrapper.__wrapped__ = original # type: ignore[attr-defined]
|
||
wrapper.cache_clear = getattr(original, "cache_clear", lambda: None) # type: ignore[attr-defined]
|
||
return wrapper
|
||
|
||
def _fla_install(eq: Any) -> bool:
|
||
# FLA alone ~2.35x; +tilelang adds ~26%. tilelang is GDN-only (Qwen3.5 family).
|
||
if not _ensure_flash_linear_attention_unconditional(eq):
|
||
logger.info(
|
||
"FLA install did not produce an importable runtime; skipping TileLang"
|
||
)
|
||
return False
|
||
if _model_wants_tilelang(model_name):
|
||
_ensure_tilelang_backend_unconditional(eq)
|
||
else:
|
||
logger.info(
|
||
"Model %r outside TileLang allowlist; FLA Triton path is sufficient",
|
||
model_name,
|
||
)
|
||
return True
|
||
|
||
def _fla_post_available(eq: Any) -> None:
|
||
# FLA already imports; repair tilelang if missing or on the broken tvm-ffi list.
|
||
if not _model_wants_tilelang(model_name):
|
||
return
|
||
if (
|
||
_installed_tvm_ffi_version() not in _TVM_FFI_BROKEN_VERSIONS
|
||
and _tilelang_importable()
|
||
):
|
||
return
|
||
_ensure_tilelang_backend_unconditional(eq)
|
||
|
||
def _causal_conv1d_install(eq: Any) -> bool:
|
||
if sys.platform == "win32":
|
||
logger.info("causal-conv1d: no prebuilt wheel for Windows; skipping")
|
||
return False
|
||
ok = _install_package_wheel_first(
|
||
event_queue = eq,
|
||
import_name = "causal_conv1d",
|
||
display_name = "causal-conv1d",
|
||
pypi_name = "causal-conv1d",
|
||
pypi_version = _CAUSAL_CONV1D_PACKAGE_VERSION,
|
||
filename_prefix = "causal_conv1d",
|
||
release_tag = _CAUSAL_CONV1D_RELEASE_TAG,
|
||
release_base_url = (
|
||
"https://github.com/Dao-AILab/causal-conv1d/releases/download"
|
||
),
|
||
)
|
||
return bool(ok)
|
||
|
||
for gate_name, install_fn, post_fn in (
|
||
("is_flash_linear_attention_available", _fla_install, _fla_post_available),
|
||
("is_causal_conv1d_available", _causal_conv1d_install, None),
|
||
):
|
||
original = getattr(_iu, gate_name, None)
|
||
if original is None:
|
||
logger.info(
|
||
"%s missing on transformers.utils.import_utils; skipping hook",
|
||
gate_name,
|
||
)
|
||
continue
|
||
wrapped = _make_wrapper(original, install_fn, gate_name, post_fn)
|
||
setattr(_iu, gate_name, wrapped)
|
||
rebound = _rebind_in_already_imported_modules(
|
||
attr_name = gate_name, old_obj = original, new_obj = wrapped
|
||
)
|
||
logger.info(
|
||
"Installed fast-path hook on %s (rebound %d modules)", gate_name, rebound
|
||
)
|
||
|
||
|
||
def _should_try_runtime_flash_attn_install(max_seq_length: int) -> bool:
|
||
if os.getenv(_FLASH_ATTN_SKIP_ENV) == "1":
|
||
return False
|
||
if max_seq_length < _FLASH_ATTN_RUNTIME_MIN_SEQ_LEN:
|
||
return False
|
||
return sys.platform.startswith("linux")
|
||
|
||
|
||
def _ensure_flash_attn_for_long_context(event_queue: Any, max_seq_length: int) -> None:
|
||
if not _should_try_runtime_flash_attn_install(max_seq_length):
|
||
return
|
||
if has_blackwell_gpu():
|
||
_send_status(
|
||
event_queue,
|
||
"Skipping flash-attn install: Blackwell GPU detected (sm_100+); no compatible prebuilt wheel",
|
||
)
|
||
return
|
||
|
||
installed = _install_package_wheel_first(
|
||
event_queue = event_queue,
|
||
import_name = "flash_attn",
|
||
display_name = "flash-attn",
|
||
pypi_name = "flash-attn",
|
||
wheel_url_builder = flash_attn_wheel_url,
|
||
pypi_spec = "flash-attn",
|
||
pypi_status_message = "Installing flash-attn from PyPI for long-context training...",
|
||
)
|
||
if not installed:
|
||
_send_status(event_queue, "Continuing without flash-attn")
|
||
|
||
|
||
def _activate_transformers_version(model_name: str) -> None:
|
||
"""Activate the correct transformers version BEFORE any ML imports."""
|
||
# Ensure backend is on path for utils imports
|
||
backend_path = str(Path(__file__).resolve().parent.parent.parent)
|
||
if backend_path not in sys.path:
|
||
sys.path.insert(0, backend_path)
|
||
|
||
from utils.transformers_version import activate_transformers_for_subprocess
|
||
|
||
activate_transformers_for_subprocess(model_name)
|
||
|
||
|
||
def _mlx_vlm_max_resized_size(width: int, height: int, target: int) -> tuple[int, int]:
|
||
if width <= 0 or height <= 0 or target <= 0:
|
||
return width, height
|
||
largest_side = max(width, height)
|
||
if largest_side <= target:
|
||
return width, height
|
||
# Integer formula matches unsloth_zoo's collator (Python round() differs
|
||
# by 1px on half-pixel cases). max(1, _) avoids zero-side degenerate output.
|
||
new_w = max(1, (width * target + largest_side // 2) // largest_side)
|
||
new_h = max(1, (height * target + largest_side // 2) // largest_side)
|
||
return new_w, new_h
|
||
|
||
|
||
def _resize_mlx_vlm_image(image, resize):
|
||
if resize is None:
|
||
return image
|
||
try:
|
||
from PIL import Image
|
||
import numpy as np
|
||
except ImportError:
|
||
return image
|
||
if not isinstance(image, Image.Image):
|
||
return image
|
||
image = image.convert("RGB")
|
||
new_size = _mlx_vlm_max_resized_size(*image.size, int(resize))
|
||
if new_size != image.size:
|
||
resampling = getattr(Image, "Resampling", Image).LANCZOS
|
||
image = image.resize(new_size, resampling)
|
||
# When a resize is requested, hand mlx-vlm a writable RGB ndarray so its
|
||
# PIL-path square-resize is skipped and HF processors don't warn on
|
||
# non-writable views. resize=None (Default) above keeps the original PIL.
|
||
return np.array(image, copy = True)
|
||
|
||
|
||
def _resize_mlx_vlm_images(value, resize):
|
||
if isinstance(value, list):
|
||
return [_resize_mlx_vlm_image(image, resize) for image in value]
|
||
return _resize_mlx_vlm_image(value, resize)
|
||
|
||
|
||
def _adapt_for_mlx_vlm(items, resize = None):
|
||
"""Adapt GPU-path VLM dataset output for mlx-vlm consumption.
|
||
|
||
The GPU path embeds PIL images inside messages content as
|
||
{"type": "image", "image": PIL_Image}. mlx-vlm's prepare_inputs
|
||
needs images at top-level to produce pixel_values — regardless of
|
||
model type. Extract them and leave bare {"type": "image"} placeholders.
|
||
"""
|
||
adapted = []
|
||
for item in items:
|
||
images = []
|
||
messages = []
|
||
for msg in item.get("messages", []):
|
||
content = msg.get("content", "")
|
||
if isinstance(content, list):
|
||
new_content = []
|
||
for part in content:
|
||
if isinstance(part, dict) and part.get("type") == "image":
|
||
img = part.get("image")
|
||
if img is not None:
|
||
images.append(_resize_mlx_vlm_image(img, resize))
|
||
new_content.append({"type": "image"})
|
||
else:
|
||
new_content.append(part)
|
||
messages.append({"role": msg["role"], "content": new_content})
|
||
else:
|
||
messages.append(msg)
|
||
out = {"messages": messages}
|
||
if images:
|
||
out["image"] = images[0] if len(images) == 1 else images
|
||
elif "image" in item:
|
||
out["image"] = _resize_mlx_vlm_images(item["image"], resize)
|
||
elif "images" in item:
|
||
out["images"] = _resize_mlx_vlm_images(item["images"], resize)
|
||
adapted.append(out)
|
||
return adapted
|
||
|
||
|
||
_MLX_STUDIO_OPTIM_MAP = {
|
||
"adamw_8bit": "adamw",
|
||
"paged_adamw_8bit": "adamw",
|
||
"adamw_bnb_8bit": "adamw",
|
||
"paged_adamw_32bit": "adamw",
|
||
"adamw_torch": "adamw",
|
||
"adamw_torch_fused": "adamw",
|
||
"adamw": "adamw",
|
||
"adafactor": "adafactor",
|
||
"sgd": "sgd",
|
||
"adam": "adam",
|
||
"muon": "muon",
|
||
"lion": "lion",
|
||
}
|
||
_MLX_STUDIO_LR_SCHEDULERS = {"linear", "cosine", "constant"}
|
||
|
||
|
||
def _normalize_mlx_studio_optimizer(value):
|
||
raw = str(value or "adamw_8bit").strip().lower()
|
||
try:
|
||
return _MLX_STUDIO_OPTIM_MAP[raw]
|
||
except KeyError:
|
||
supported = ", ".join(sorted(_MLX_STUDIO_OPTIM_MAP))
|
||
raise ValueError(
|
||
f"Unsupported optimizer for MLX training: {value!r}. "
|
||
f"Supported values: {supported}."
|
||
)
|
||
|
||
|
||
def _normalize_mlx_studio_scheduler(value):
|
||
raw = str(value or "linear").strip().lower()
|
||
if raw not in _MLX_STUDIO_LR_SCHEDULERS:
|
||
supported = ", ".join(sorted(_MLX_STUDIO_LR_SCHEDULERS))
|
||
raise ValueError(
|
||
f"Unsupported LR scheduler for MLX training: {value!r}. "
|
||
f"Supported values: {supported}."
|
||
)
|
||
return raw
|
||
|
||
|
||
def _resolve_mlx_local_dataset_files(file_paths: list) -> list[str]:
|
||
"""Resolve Studio local dataset uploads without importing the GPU trainer."""
|
||
from utils.paths import resolve_dataset_path
|
||
|
||
all_files: list[str] = []
|
||
for dataset_file in file_paths or []:
|
||
file_path = (
|
||
dataset_file
|
||
if os.path.isabs(dataset_file)
|
||
else str(resolve_dataset_path(dataset_file))
|
||
)
|
||
file_path_obj = Path(file_path)
|
||
|
||
if file_path_obj.is_dir():
|
||
parquet_dir = (
|
||
file_path_obj / "parquet-files"
|
||
if (file_path_obj / "parquet-files").exists()
|
||
else file_path_obj
|
||
)
|
||
parquet_files = sorted(parquet_dir.glob("*.parquet"))
|
||
if parquet_files:
|
||
all_files.extend(str(p) for p in parquet_files)
|
||
continue
|
||
|
||
candidates: list[Path] = []
|
||
for ext in (".json", ".jsonl", ".csv", ".parquet"):
|
||
candidates.extend(sorted(file_path_obj.glob(f"*{ext}")))
|
||
if candidates:
|
||
all_files.extend(str(c) for c in candidates)
|
||
continue
|
||
|
||
raise ValueError(f"No supported data files in directory: {file_path_obj}")
|
||
|
||
all_files.append(str(file_path_obj))
|
||
|
||
return all_files
|
||
|
||
|
||
def _mlx_local_dataset_loader_for_files(files: list[str]) -> str:
|
||
first_ext = Path(files[0]).suffix.lower()
|
||
if first_ext in (".json", ".jsonl"):
|
||
return "json"
|
||
if first_ext == ".csv":
|
||
return "csv"
|
||
if first_ext == ".parquet":
|
||
return "parquet"
|
||
raise ValueError(f"Unsupported dataset format: {files[0]}")
|
||
|
||
|
||
def _run_mlx_training(event_queue, stop_queue, config):
|
||
"""Self-contained MLX training path for Apple Silicon.
|
||
|
||
Uses MLXTrainer from unsloth_zoo directly -- no torch/SFTTrainer needed.
|
||
Mirrors the event_queue protocol so the parent process pump works unchanged.
|
||
"""
|
||
import time
|
||
import gc
|
||
import math
|
||
import threading
|
||
import queue as _queue
|
||
from pathlib import Path
|
||
|
||
def _send(event_type, **kwargs):
|
||
if event_type == "status" and "message" not in kwargs:
|
||
sm = kwargs.get("status_message")
|
||
if sm is not None:
|
||
kwargs["message"] = sm
|
||
event_queue.put({"type": event_type, "ts": time.time(), **kwargs})
|
||
|
||
_send("status", status_message = "Loading MLX libraries...")
|
||
|
||
import mlx.core as mx
|
||
|
||
try:
|
||
from unsloth_zoo.mlx.loader import FastMLXModel
|
||
from unsloth_zoo.mlx.trainer import (
|
||
MLXTrainer,
|
||
MLXTrainingConfig,
|
||
train_on_responses_only,
|
||
)
|
||
except ImportError as e:
|
||
raise ImportError(
|
||
"Unsloth: MLX training requires unsloth-zoo with the MLX modules "
|
||
"(unsloth_zoo.mlx.loader / unsloth_zoo.mlx.trainer). Reinstall via "
|
||
"install.sh on Apple Silicon."
|
||
) from e
|
||
from datasets import load_dataset
|
||
|
||
if mx.metal.is_available():
|
||
info = mx.device_info()
|
||
rec_bytes = info.get("max_recommended_working_set_size", 0) or 0
|
||
if rec_bytes > 0:
|
||
memory_cap = int(rec_bytes * 0.85)
|
||
wired_cap = min(int(rec_bytes), memory_cap)
|
||
mx.set_memory_limit(memory_cap)
|
||
mx.set_wired_limit(wired_cap)
|
||
|
||
model_name = config["model_name"]
|
||
hf_token = config.get("hf_token") or None
|
||
if hf_token:
|
||
os.environ["HF_TOKEN"] = hf_token
|
||
|
||
if config.get("use_loftq"):
|
||
message = "LoftQ is not supported for MLX training yet."
|
||
_send("error", error = message)
|
||
raise NotImplementedError(message)
|
||
|
||
optim_name = _normalize_mlx_studio_optimizer(config.get("optim", "adamw_8bit"))
|
||
lr_scheduler_type = _normalize_mlx_studio_scheduler(
|
||
config.get("lr_scheduler_type", "linear")
|
||
)
|
||
|
||
# ── 1. Load model ──
|
||
# Force text-only if the dataset is not an image dataset, even if the model
|
||
# has vision capabilities (e.g. Qwen3.5-VL trained on plain alpaca text).
|
||
_send("status", status_message = f"Loading {model_name}...")
|
||
is_dataset_image = bool(config.get("is_dataset_image", False))
|
||
training_type = config.get("training_type", "LoRA/QLoRA")
|
||
use_lora = training_type == "LoRA/QLoRA"
|
||
model, tokenizer = FastMLXModel.from_pretrained(
|
||
model_name,
|
||
load_in_4bit = config.get("load_in_4bit", True),
|
||
full_finetuning = not use_lora,
|
||
text_only = None if is_dataset_image else True,
|
||
token = hf_token,
|
||
trust_remote_code = bool(config.get("trust_remote_code", False)),
|
||
random_state = config.get("random_seed", 3407),
|
||
)
|
||
|
||
is_vlm = bool(is_dataset_image and getattr(model, "_is_vlm_model", False))
|
||
model._is_vlm_model = is_vlm
|
||
vision_image_size = config.get("vision_image_size")
|
||
# DeepSeek OCR uses a coupled preset tuple; skip resize like the Torch path.
|
||
_model_name_lower = str(config.get("model_name", "")).lower()
|
||
_is_deepseek_ocr = "deepseek" in _model_name_lower and "ocr" in _model_name_lower
|
||
if is_vlm and vision_image_size is not None and _is_deepseek_ocr:
|
||
_send(
|
||
"status",
|
||
status_message = (
|
||
"MLX vision image resize ignored for DeepSeek OCR "
|
||
"(uses fixed Gundam preset)."
|
||
),
|
||
)
|
||
vision_image_size = None
|
||
elif is_vlm and vision_image_size is not None:
|
||
vision_image_size = int(vision_image_size)
|
||
_send(
|
||
"status",
|
||
status_message = f"MLX vision image resize: {vision_image_size} (max dimension)",
|
||
)
|
||
|
||
# ── 2. Apply LoRA / full FT ──
|
||
# Pass gradient_checkpointing as string ("mlx"/"unsloth"/"none"/etc.)
|
||
# get_peft_model and MLXTrainer both accept strings and handle them.
|
||
gc_setting = config.get("gradient_checkpointing", "mlx")
|
||
if isinstance(gc_setting, str):
|
||
use_grad_checkpoint = (
|
||
gc_setting if gc_setting.lower() not in ("false", "") else False
|
||
)
|
||
else:
|
||
use_grad_checkpoint = gc_setting
|
||
|
||
if use_lora:
|
||
_send("status", status_message = "Configuring LoRA adapters...")
|
||
peft_kwargs = dict(
|
||
r = config.get("lora_r", 16),
|
||
lora_alpha = config.get("lora_alpha", 16),
|
||
lora_dropout = config.get("lora_dropout", 0.0),
|
||
use_rslora = config.get("use_rslora", False),
|
||
init_lora_weights = config.get("init_lora_weights", True),
|
||
random_state = config.get("random_seed", 3407),
|
||
target_modules = config.get("target_modules")
|
||
or [
|
||
"q_proj",
|
||
"k_proj",
|
||
"v_proj",
|
||
"o_proj",
|
||
"gate_proj",
|
||
"up_proj",
|
||
"down_proj",
|
||
],
|
||
use_gradient_checkpointing = use_grad_checkpoint,
|
||
)
|
||
finetune_language = config.get("finetune_language_layers", True)
|
||
finetune_attention = config.get("finetune_attention_modules", True)
|
||
finetune_mlp = config.get("finetune_mlp_modules", True)
|
||
finetune_vision = (
|
||
config.get("finetune_vision_layers", False) if is_vlm else False
|
||
)
|
||
|
||
if (
|
||
(finetune_attention or finetune_mlp)
|
||
and not finetune_language
|
||
and not finetune_vision
|
||
):
|
||
finetune_language = True
|
||
|
||
peft_kwargs["finetune_language_layers"] = finetune_language
|
||
peft_kwargs["finetune_attention_modules"] = finetune_attention
|
||
peft_kwargs["finetune_mlp_modules"] = finetune_mlp
|
||
if is_vlm:
|
||
peft_kwargs["finetune_vision_layers"] = finetune_vision
|
||
model = FastMLXModel.get_peft_model(model, **peft_kwargs)
|
||
|
||
# ── 3. Load dataset ──
|
||
_send("status", status_message = "Loading dataset...")
|
||
hf_dataset = config.get("hf_dataset", "")
|
||
subset = config.get("subset")
|
||
train_split = config.get("train_split", "train") or "train"
|
||
eval_split = config.get("eval_split")
|
||
slice_start = config.get("dataset_slice_start")
|
||
slice_end = config.get("dataset_slice_end")
|
||
|
||
def _slice(ds):
|
||
if slice_start is not None or slice_end is not None:
|
||
start = slice_start if slice_start is not None else 0
|
||
end = slice_end if slice_end is not None else len(ds) - 1
|
||
if end < start:
|
||
return ds.select([])
|
||
ds = ds.select(range(start, min(end + 1, len(ds))))
|
||
return ds
|
||
|
||
def _load_local(file_paths):
|
||
from datasets import load_from_disk
|
||
|
||
if len(file_paths) == 1:
|
||
p = Path(file_paths[0])
|
||
if p.is_dir() and (
|
||
(p / "dataset_info.json").exists() or (p / "state.json").exists()
|
||
):
|
||
return load_from_disk(str(p))
|
||
all_files = _resolve_mlx_local_dataset_files(file_paths)
|
||
if not all_files:
|
||
raise ValueError("No local dataset files found")
|
||
loader = _mlx_local_dataset_loader_for_files(all_files)
|
||
return load_dataset(loader, data_files = all_files, split = "train")
|
||
|
||
if hf_dataset:
|
||
load_kwargs = {"split": train_split, "token": hf_token}
|
||
if subset:
|
||
load_kwargs["name"] = subset
|
||
dataset = load_dataset(hf_dataset, **load_kwargs)
|
||
dataset = _slice(dataset)
|
||
elif config.get("local_datasets"):
|
||
dataset = _load_local(config["local_datasets"])
|
||
dataset = _slice(dataset)
|
||
else:
|
||
raise ValueError("No dataset specified")
|
||
|
||
# Eval dataset (separate split or local file)
|
||
eval_dataset = None
|
||
if eval_split and hf_dataset:
|
||
eval_kwargs = {"split": eval_split, "token": hf_token}
|
||
if subset:
|
||
eval_kwargs["name"] = subset
|
||
try:
|
||
eval_dataset = load_dataset(hf_dataset, **eval_kwargs)
|
||
except Exception as e:
|
||
_send("status", status_message = f"Eval split load failed: {e}")
|
||
eval_dataset = None
|
||
elif config.get("local_eval_datasets"):
|
||
eval_dataset = _load_local(config["local_eval_datasets"])
|
||
|
||
# ── 3b. Format dataset (VLM or text) ──
|
||
# Reuse the GPU path's format pipeline for both VLM (auto-detects OCR/caption/
|
||
# llava/sharegpt+images) and text (alpaca/sharegpt/chatml → "text" column).
|
||
format_type = config.get("format_type", "")
|
||
try:
|
||
from utils.datasets import format_and_template_dataset
|
||
|
||
def _fmt_progress(status_message = "", **_kw):
|
||
_send("status", status_message = status_message)
|
||
|
||
if is_vlm:
|
||
_send("status", status_message = "Formatting VLM dataset...")
|
||
vlm_info = format_and_template_dataset(
|
||
dataset,
|
||
model_name = model_name,
|
||
tokenizer = tokenizer,
|
||
is_vlm = True,
|
||
dataset_name = hf_dataset or "local",
|
||
progress_callback = _fmt_progress,
|
||
)
|
||
if vlm_info.get("success"):
|
||
dataset = _adapt_for_mlx_vlm(
|
||
vlm_info["dataset"],
|
||
resize = vision_image_size,
|
||
)
|
||
else:
|
||
errors = vlm_info.get("errors", [])
|
||
raise ValueError(
|
||
f"VLM dataset format conversion failed: {'; '.join(errors)}"
|
||
)
|
||
if eval_dataset is not None:
|
||
ev_info = format_and_template_dataset(
|
||
eval_dataset,
|
||
model_name = model_name,
|
||
tokenizer = tokenizer,
|
||
is_vlm = True,
|
||
dataset_name = hf_dataset or "local",
|
||
)
|
||
if ev_info.get("success"):
|
||
eval_dataset = _adapt_for_mlx_vlm(
|
||
ev_info["dataset"],
|
||
resize = vision_image_size,
|
||
)
|
||
|
||
elif format_type:
|
||
_send("status", status_message = f"Formatting dataset ({format_type})...")
|
||
info = format_and_template_dataset(
|
||
dataset,
|
||
model_name = model_name,
|
||
tokenizer = tokenizer,
|
||
is_vlm = False,
|
||
format_type = format_type,
|
||
dataset_name = hf_dataset or "local",
|
||
)
|
||
if info.get("success", True):
|
||
dataset = info.get("dataset", dataset)
|
||
if eval_dataset is not None:
|
||
ev = format_and_template_dataset(
|
||
eval_dataset,
|
||
model_name = model_name,
|
||
tokenizer = tokenizer,
|
||
is_vlm = False,
|
||
format_type = format_type,
|
||
dataset_name = hf_dataset or "local",
|
||
)
|
||
if ev.get("success", True):
|
||
eval_dataset = ev.get("dataset", eval_dataset)
|
||
except ImportError:
|
||
_send("status", status_message = "Format helper unavailable, using raw dataset")
|
||
|
||
# ── 4. Resolve training steps ──
|
||
max_steps = config.get("max_steps", 0) or 0
|
||
num_epochs = config.get("num_epochs", 3)
|
||
max_seq_length = config.get("max_seq_length", 2048)
|
||
batch_size = config.get("batch_size", 4)
|
||
grad_accum = config.get("gradient_accumulation_steps", 4)
|
||
|
||
if max_steps <= 0:
|
||
max_steps = max(
|
||
1,
|
||
math.ceil(len(dataset) / batch_size / grad_accum) * num_epochs,
|
||
)
|
||
|
||
lr_value = float(config.get("learning_rate", "2e-4"))
|
||
|
||
# Warmup: prefer warmup_steps; fall back to warmup_ratio
|
||
warmup_steps = config.get("warmup_steps")
|
||
warmup_ratio = config.get("warmup_ratio")
|
||
if warmup_steps is None and warmup_ratio is not None:
|
||
warmup_steps = int(round(warmup_ratio * max_steps))
|
||
if warmup_steps is None:
|
||
warmup_steps = 5
|
||
|
||
# ── 5. Build output dir ──
|
||
output_dir = config.get("output_dir", "")
|
||
if not output_dir:
|
||
output_dir = f"{model_name.replace('/', '_')}_{int(time.time())}"
|
||
# Resolve to ~/.unsloth/studio/outputs/ so the export page can find it
|
||
from utils.paths import resolve_output_dir, ensure_dir
|
||
|
||
output_dir = str(resolve_output_dir(output_dir))
|
||
ensure_dir(Path(output_dir))
|
||
|
||
# ── 6. Create trainer ──
|
||
eval_steps_val = config.get("eval_steps", 0) or 0
|
||
if isinstance(eval_steps_val, float) and 0 < eval_steps_val < 1:
|
||
# Studio sometimes sends fraction-of-total-steps
|
||
eval_steps_val = max(1, int(eval_steps_val * max_steps))
|
||
else:
|
||
eval_steps_val = int(eval_steps_val)
|
||
|
||
# MLX: per-element clip to [-1, 1]; norm clip disabled (it needs a
|
||
# global reduction that breaks MLX's eager pipeline). 1.0 (not 5.0):
|
||
# |g_i| > 5 rarely fires, so the historical 5.0 was effectively no-op.
|
||
max_grad_norm = 0.0
|
||
max_grad_value = 1.0 # TODO: expose MLX grad-clip in Studio UI for power users
|
||
|
||
trainer = MLXTrainer(
|
||
model = model,
|
||
tokenizer = tokenizer,
|
||
train_dataset = dataset,
|
||
eval_dataset = eval_dataset,
|
||
args = MLXTrainingConfig(
|
||
per_device_train_batch_size = batch_size,
|
||
gradient_accumulation_steps = grad_accum,
|
||
max_steps = max_steps,
|
||
learning_rate = lr_value,
|
||
warmup_steps = warmup_steps,
|
||
lr_scheduler_type = lr_scheduler_type,
|
||
optim = optim_name,
|
||
weight_decay = float(config.get("weight_decay", 0.001) or 0.001),
|
||
max_grad_norm = max_grad_norm,
|
||
max_grad_value = max_grad_value,
|
||
logging_steps = 1,
|
||
max_seq_length = max_seq_length,
|
||
seed = config.get("random_seed", 3407),
|
||
use_cce = True,
|
||
compile = True,
|
||
gradient_checkpointing = use_grad_checkpoint,
|
||
streaming = is_vlm,
|
||
packing = bool(config.get("packing", False)),
|
||
output_dir = output_dir,
|
||
save_steps = int(config.get("save_steps", 0) or 0),
|
||
eval_steps = eval_steps_val,
|
||
),
|
||
)
|
||
|
||
# Tell the parent that eval is configured so the frontend shows the eval chart
|
||
if eval_dataset is not None and eval_steps_val > 0:
|
||
_send("eval_configured")
|
||
|
||
# ── 7. Apply train_on_responses_only if requested ──
|
||
if config.get("train_on_completions", False):
|
||
_send("status", status_message = "Configuring response-only training...")
|
||
try:
|
||
from utils.datasets import (
|
||
MODEL_TO_TEMPLATE_MAPPER,
|
||
TEMPLATE_TO_RESPONSES_MAPPER,
|
||
)
|
||
|
||
template_name = MODEL_TO_TEMPLATE_MAPPER.get(model_name.lower())
|
||
markers = (
|
||
TEMPLATE_TO_RESPONSES_MAPPER.get(template_name)
|
||
if template_name
|
||
else None
|
||
)
|
||
if markers:
|
||
trainer = train_on_responses_only(
|
||
trainer,
|
||
instruction_part = markers["instruction"],
|
||
response_part = markers["response"],
|
||
)
|
||
else:
|
||
_send(
|
||
"status",
|
||
status_message = f"train_on_completions skipped (no template for {model_name})",
|
||
)
|
||
except Exception as e:
|
||
_send("status", status_message = f"train_on_completions failed: {e}")
|
||
|
||
# ── 8. Setup wandb / tensorboard ──
|
||
wandb_run = None
|
||
tb_writer = None
|
||
if config.get("enable_wandb", False):
|
||
try:
|
||
import wandb as _wandb
|
||
|
||
wandb_token = config.get("wandb_token")
|
||
if wandb_token:
|
||
os.environ["WANDB_API_KEY"] = wandb_token
|
||
_wandb_sensitive = {"hf_token", "wandb_token"}
|
||
wandb_run = _wandb.init(
|
||
project = config.get("wandb_project") or "unsloth-mlx",
|
||
config = {k: v for k, v in config.items() if k not in _wandb_sensitive},
|
||
reinit = True,
|
||
)
|
||
except Exception as e:
|
||
_send("status", status_message = f"wandb init failed: {e}")
|
||
if config.get("enable_tensorboard", False):
|
||
try:
|
||
from tensorboardX import SummaryWriter
|
||
except ImportError:
|
||
try:
|
||
from torch.utils.tensorboard import SummaryWriter
|
||
except ImportError:
|
||
SummaryWriter = None
|
||
if SummaryWriter is not None:
|
||
try:
|
||
tb_dir = config.get("tensorboard_dir") or f"{output_dir}/runs"
|
||
tb_writer = SummaryWriter(log_dir = tb_dir)
|
||
except Exception as e:
|
||
_send("status", status_message = f"tensorboard init failed: {e}")
|
||
else:
|
||
_send(
|
||
"status",
|
||
status_message = "tensorboard unavailable (install tensorboardX)",
|
||
)
|
||
|
||
# ── 9. Real-time progress callback ──
|
||
_send("status", status_message = f"Training {model_name}...")
|
||
|
||
def _on_step(
|
||
step,
|
||
total,
|
||
loss,
|
||
lr,
|
||
tok_s,
|
||
peak_gb,
|
||
elapsed,
|
||
num_tokens,
|
||
grad_norm = None,
|
||
):
|
||
eta = (elapsed / step * (total - step)) if step > 0 else 0
|
||
_send(
|
||
"progress",
|
||
step = step,
|
||
epoch = round(step / total * num_epochs, 2) if total > 0 else 0,
|
||
loss = loss,
|
||
learning_rate = lr,
|
||
total_steps = total,
|
||
elapsed_seconds = elapsed,
|
||
eta_seconds = max(0, eta),
|
||
grad_norm = grad_norm,
|
||
num_tokens = num_tokens,
|
||
eval_loss = None,
|
||
status_message = None,
|
||
peak_memory_gb = peak_gb,
|
||
)
|
||
if wandb_run is not None:
|
||
try:
|
||
wandb_run.log(
|
||
{
|
||
"train/loss": loss,
|
||
"train/learning_rate": lr,
|
||
"train/tokens_per_sec": tok_s,
|
||
"train/peak_gb": peak_gb,
|
||
"train/num_tokens": num_tokens,
|
||
**(
|
||
{"train/grad_norm": grad_norm}
|
||
if grad_norm is not None
|
||
else {}
|
||
),
|
||
},
|
||
step = step,
|
||
)
|
||
except Exception:
|
||
pass
|
||
if tb_writer is not None:
|
||
try:
|
||
tb_writer.add_scalar("train/loss", loss, step)
|
||
tb_writer.add_scalar("train/learning_rate", lr, step)
|
||
tb_writer.add_scalar("train/tokens_per_sec", tok_s, step)
|
||
tb_writer.add_scalar("train/peak_gb", peak_gb, step)
|
||
if grad_norm is not None:
|
||
tb_writer.add_scalar("train/grad_norm", grad_norm, step)
|
||
except Exception:
|
||
pass
|
||
|
||
trainer.add_step_callback(_on_step)
|
||
|
||
def _on_eval(step, eval_loss, perplexity):
|
||
_send("progress", step = step, eval_loss = eval_loss)
|
||
if wandb_run is not None:
|
||
try:
|
||
wandb_run.log(
|
||
{"eval/loss": eval_loss, "eval/perplexity": perplexity}, step = step
|
||
)
|
||
except Exception:
|
||
pass
|
||
if tb_writer is not None:
|
||
try:
|
||
tb_writer.add_scalar("eval/loss", eval_loss, step)
|
||
tb_writer.add_scalar("eval/perplexity", perplexity, step)
|
||
except Exception:
|
||
pass
|
||
|
||
trainer.add_eval_callback(_on_eval)
|
||
|
||
# ── 10. Stop signal polling ──
|
||
_stop_save = [True] # mutable so thread can update; [save_flag]
|
||
|
||
def _poll_stop():
|
||
while True:
|
||
try:
|
||
msg = stop_queue.get(timeout = 1.0)
|
||
if msg and msg.get("type") == "stop":
|
||
_stop_save[0] = msg.get("save", True)
|
||
trainer.stop_requested = True
|
||
return
|
||
except _queue.Empty:
|
||
continue
|
||
except (EOFError, OSError):
|
||
# why safe: pipe permanently broken, no further messages can arrive
|
||
return
|
||
|
||
stop_thread = threading.Thread(target = _poll_stop, daemon = True)
|
||
stop_thread.start()
|
||
|
||
# ── 11. Run training ──
|
||
gc.collect()
|
||
mx.synchronize()
|
||
trainer.train()
|
||
|
||
# ── 12. Save and finalize ──
|
||
if trainer.stop_requested and not _stop_save[0]:
|
||
# User clicked "Cancel" (save=False) — skip saving
|
||
_send("complete", output_dir = None, status_message = "Training cancelled")
|
||
else:
|
||
_send("status", status_message = "Saving model...")
|
||
mx.synchronize()
|
||
trainer.save_model(output_dir)
|
||
_send("complete", output_dir = output_dir, status_message = "Training completed")
|
||
|
||
if tb_writer is not None:
|
||
try:
|
||
tb_writer.close()
|
||
except Exception:
|
||
pass
|
||
if wandb_run is not None:
|
||
try:
|
||
wandb_run.finish()
|
||
except Exception:
|
||
pass
|
||
|
||
|
||
def run_training_process(
|
||
*,
|
||
event_queue: Any,
|
||
stop_queue: Any,
|
||
config: dict,
|
||
) -> None:
|
||
"""Subprocess entrypoint. Fresh Python — no stale module state.
|
||
|
||
Args:
|
||
event_queue: mp.Queue for sending progress/status/error events to parent.
|
||
stop_queue: mp.Queue for receiving stop commands from parent.
|
||
config: Training configuration dict with all parameters.
|
||
"""
|
||
os.environ["TOKENIZERS_PARALLELISM"] = "false"
|
||
os.environ["PYTHONWARNINGS"] = (
|
||
"ignore" # Suppress warnings at C-level before imports
|
||
)
|
||
|
||
# Offline auto-detect: skip ~25s of HF retries per call when DNS is
|
||
# dead. Scoped to this subprocess (orchestrator spawns a fresh one).
|
||
if "HF_HUB_OFFLINE" not in os.environ:
|
||
import socket as _socket
|
||
import threading as _threading
|
||
|
||
# Daemon thread so we don't mutate process-wide setdefaulttimeout.
|
||
_result: list = [None]
|
||
|
||
def _probe() -> None:
|
||
try:
|
||
_socket.gethostbyname("huggingface.co")
|
||
_result[0] = False
|
||
except Exception:
|
||
_result[0] = True
|
||
|
||
_t = _threading.Thread(target = _probe, daemon = True)
|
||
_t.start()
|
||
_t.join(2.0)
|
||
if _result[0] is None or _result[0] is True:
|
||
os.environ["HF_HUB_OFFLINE"] = "1"
|
||
os.environ.setdefault("TRANSFORMERS_OFFLINE", "1")
|
||
os.environ.setdefault("HF_DATASETS_OFFLINE", "1")
|
||
# logger isn't configured yet; print to stderr instead.
|
||
print(
|
||
"huggingface.co unreachable; HF_HUB_OFFLINE=1 set for this worker.",
|
||
file = sys.stderr,
|
||
flush = True,
|
||
)
|
||
|
||
import warnings
|
||
from loggers.config import LogConfig
|
||
|
||
if os.getenv("ENVIRONMENT_TYPE", "production") == "production":
|
||
warnings.filterwarnings("ignore")
|
||
|
||
LogConfig.setup_logging(
|
||
service_name = "unsloth-studio-training-worker",
|
||
env = os.getenv("ENVIRONMENT_TYPE", "production"),
|
||
)
|
||
|
||
apply_gpu_ids(config.get("resolved_gpu_ids"))
|
||
|
||
model_name = config["model_name"]
|
||
|
||
# ── 0. MLX FAST-PATH (must run before any torch/transformers imports) ──
|
||
# Apple Silicon uses MLXTrainer directly -- skip transformers version
|
||
# activation, causal-conv1d install, and torch imports entirely.
|
||
backend_path = str(Path(__file__).resolve().parent.parent.parent)
|
||
if backend_path not in sys.path:
|
||
sys.path.insert(0, backend_path)
|
||
|
||
from utils.hardware import hardware as _hw
|
||
|
||
_hw.detect_hardware()
|
||
if _hw.DEVICE == _hw.DeviceType.MLX:
|
||
if config.get("is_dataset_audio"):
|
||
event_queue.put(
|
||
{
|
||
"type": "error",
|
||
"error": "Audio dataset training is not yet supported on Apple Silicon.",
|
||
"stack": "",
|
||
"ts": time.time(),
|
||
}
|
||
)
|
||
return
|
||
# Activate correct transformers version (Gemma-4 needs 5.5.0, etc.)
|
||
# Must happen before any transformers/mlx-lm imports in _run_mlx_training.
|
||
try:
|
||
_activate_transformers_version(model_name)
|
||
except Exception:
|
||
pass # Non-fatal: fall through with whatever version is installed
|
||
try:
|
||
_run_mlx_training(event_queue, stop_queue, config)
|
||
except Exception as exc:
|
||
event_queue.put(
|
||
{
|
||
"type": "error",
|
||
"error": str(exc),
|
||
"stack": traceback.format_exc(limit = 20),
|
||
"ts": time.time(),
|
||
}
|
||
)
|
||
return
|
||
|
||
# ── 1. Activate correct transformers version BEFORE any ML imports ──
|
||
try:
|
||
_activate_transformers_version(model_name)
|
||
except Exception as exc:
|
||
event_queue.put(
|
||
{
|
||
"type": "error",
|
||
"error": f"Failed to activate transformers version: {exc}",
|
||
"stack": traceback.format_exc(limit = 20),
|
||
"ts": time.time(),
|
||
}
|
||
)
|
||
return
|
||
|
||
# ── 1a. Auto-enable trust_remote_code for NemotronH/Nano models ──
|
||
# NemotronH has config parsing bugs in transformers that require
|
||
# trust_remote_code=True as a workaround. Other transformers 5.x models
|
||
# (Qwen3.5, Gemma 4, etc.) are native and do NOT need it — enabling it
|
||
# bypasses the compiler (disabling fused CE).
|
||
# NOTE: Must NOT match Llama-Nemotron (standard Llama architecture).
|
||
_NEMOTRON_TRUST_SUBSTRINGS = ("nemotron_h", "nemotron-h", "nemotron-3-nano")
|
||
_lowered = model_name.lower()
|
||
if (
|
||
any(sub in _lowered for sub in _NEMOTRON_TRUST_SUBSTRINGS)
|
||
and (_lowered.startswith("unsloth/") or _lowered.startswith("nvidia/"))
|
||
and not config.get("trust_remote_code", False)
|
||
):
|
||
config["trust_remote_code"] = True
|
||
logger.info(
|
||
"Auto-enabled trust_remote_code for Nemotron model: %s",
|
||
model_name,
|
||
)
|
||
|
||
# ── 1b. Install fast-path kernel libraries for the chosen model.
|
||
#
|
||
# 1) causal-conv1d ALWAYS runs eagerly via the substring path.
|
||
# Some SSM modeling files (nemotron_h, falcon_h1, granitemoehybrid)
|
||
# use `lazy_load_kernel("causal-conv1d")` directly and never call
|
||
# transformers' `is_causal_conv1d_available()`, so the runtime
|
||
# hook on that gate would not fire for them.
|
||
# 2) FLA + tilelang: primary gate is the runtime hook on transformers'
|
||
# `is_flash_linear_attention_available`. Models whose architecture
|
||
# queries that gate auto-trigger the install; others never pay.
|
||
# `_install_fast_path_hooks` also wraps `is_causal_conv1d_available`
|
||
# as a defence in depth for newer modeling files that do use it.
|
||
# 3) mamba-ssm + flash-attn keep their existing substring / size gates.
|
||
# 4) `UNSLOTH_STUDIO_SKIP_FAST_PATH_HOOKS=1` falls back to the
|
||
# substring path for FLA / tilelang.
|
||
try:
|
||
_ensure_causal_conv1d_fast_path(event_queue, model_name)
|
||
if os.getenv(_FAST_PATH_HOOKS_SKIP_ENV) == "1":
|
||
_ensure_flash_linear_attention(event_queue, model_name)
|
||
_ensure_tilelang_backend(event_queue, model_name)
|
||
else:
|
||
_install_fast_path_hooks(event_queue, model_name)
|
||
_ensure_mamba_ssm(event_queue, model_name)
|
||
_ensure_flash_attn_for_long_context(
|
||
event_queue,
|
||
int(config.get("max_seq_length", 2048)),
|
||
)
|
||
except Exception as exc:
|
||
event_queue.put(
|
||
{
|
||
"type": "error",
|
||
"error": (
|
||
f"Please choose another model to train, since "
|
||
f"a fast-path kernel library "
|
||
f"(causal-conv1d / flash-linear-attention / "
|
||
f"mamba-ssm / tilelang) failed to install "
|
||
f"with error: {exc}"
|
||
),
|
||
"stack": traceback.format_exc(limit = 20),
|
||
"ts": time.time(),
|
||
}
|
||
)
|
||
return
|
||
|
||
# ── 1c. Set fork start method so dataset.map() can multiprocess ──
|
||
# The parent launched us via spawn (clean process), but the compiled
|
||
# SFTTrainer checks get_start_method() and disables num_proc if not "fork".
|
||
# Linux only: fork is the default start method and is safe here (no CUDA
|
||
# context exists yet). macOS defaults to spawn since Python 3.8 because
|
||
# fork is unsafe with macOS frameworks (Metal/MPS, CoreFoundation) --
|
||
# do NOT override on macOS. Windows has no fork at all.
|
||
if sys.platform == "linux":
|
||
import multiprocessing as _mp
|
||
|
||
try:
|
||
_mp.set_start_method("fork", force = True)
|
||
except RuntimeError:
|
||
pass # Already set
|
||
|
||
# ── 1c. On Windows, check Triton availability (must be before import torch) ──
|
||
if sys.platform == "win32":
|
||
try:
|
||
import triton # noqa: F401
|
||
|
||
logger.info("Triton available — torch.compile enabled")
|
||
except ImportError:
|
||
os.environ["TORCHDYNAMO_DISABLE"] = "1"
|
||
logger.warning(
|
||
"Triton not found on Windows — torch.compile disabled. "
|
||
'Install for better performance: pip install "triton-windows<3.7"'
|
||
)
|
||
|
||
# ── 1d. Stub torchao on Windows ROCm ──
|
||
# torchao (pulled in by transformers.quantizers) imports
|
||
# torch.distributed._functional_collectives at module level, which imports
|
||
# distributed_c10d.py unconditionally — that file crashes on Windows ROCm
|
||
# because torch._C._distributed_c10d (the RCCL backend) is absent.
|
||
# torch/distributed/__init__.py itself is guarded by `if is_available()`
|
||
# so `import torch.distributed` alone is safe; the crash only comes via
|
||
# torchao's import chain. Stubbing torchao short-circuits it entirely.
|
||
# _StubSubpackageFinder handles any depth of torchao.xxx.yyy imports.
|
||
import types as _types
|
||
import importlib.machinery as _ilm
|
||
import importlib.abc as _ilabc
|
||
|
||
_STUB_SENTINEL = object()
|
||
|
||
# Metaclass for stub types so that isinstance(x, StubClass) returns False
|
||
# instead of raising TypeError ("arg 2 must be a type").
|
||
# peft/tuners/lora/torchao.py does:
|
||
# from torchao.dtypes import AffineQuantizedTensor, LinearActivationQuantizedTensor
|
||
# isinstance(weight, (AffineQuantizedTensor, LinearActivationQuantizedTensor))
|
||
# If those names resolve to stub modules rather than types, isinstance() raises.
|
||
class _StubTypeMeta(type):
|
||
def __instancecheck__(cls, instance):
|
||
return False
|
||
|
||
def __subclasscheck__(cls, subclass):
|
||
return False
|
||
|
||
def __getattr__(cls, attr):
|
||
if attr.startswith("__"):
|
||
raise AttributeError(attr)
|
||
child = _StubTypeMeta(attr, (), {})
|
||
setattr(cls, attr, child)
|
||
return child
|
||
|
||
def __call__(cls, *args, **kwargs):
|
||
return None
|
||
|
||
def _make_stub_type(name):
|
||
"""Stub class: accepted by isinstance() (always False), supports attr access."""
|
||
return _StubTypeMeta(name, (), {})
|
||
|
||
def _make_mod_stub(mod_name):
|
||
m = _types.ModuleType(mod_name)
|
||
m.__path__ = []
|
||
m.__package__ = mod_name
|
||
m._unsloth_stub = _STUB_SENTINEL
|
||
m.__spec__ = _ilm.ModuleSpec(mod_name, loader = None, is_package = True)
|
||
|
||
def _ga(attr, _m = m, _n = mod_name):
|
||
if attr.startswith("__"):
|
||
raise AttributeError(attr)
|
||
# Return a stub CLASS (not a module) so that isinstance(x, attr)
|
||
# works and returns False instead of raising TypeError.
|
||
child = _make_stub_type(f"{_n}.{attr}")
|
||
setattr(_m, attr, child)
|
||
return child
|
||
|
||
m.__getattr__ = _ga
|
||
return m
|
||
|
||
class _StubSubpackageLoader(_ilabc.Loader):
|
||
def __init__(self, mod_name):
|
||
self._mod_name = mod_name
|
||
|
||
def create_module(self, spec):
|
||
return _make_mod_stub(self._mod_name)
|
||
|
||
def exec_module(self, module):
|
||
pass
|
||
|
||
class _StubSubpackageFinder(_ilabc.MetaPathFinder):
|
||
def find_spec(self, fullname, path, target = None):
|
||
if "." not in fullname:
|
||
return None
|
||
parent = sys.modules.get(fullname.rsplit(".", 1)[0])
|
||
if parent is None:
|
||
return None
|
||
if getattr(parent, "_unsloth_stub", None) is not _STUB_SENTINEL:
|
||
return None
|
||
return _ilm.ModuleSpec(
|
||
fullname, _StubSubpackageLoader(fullname), is_package = True
|
||
)
|
||
|
||
# Only stub torchao on Windows ROCm hosts -- on Windows CUDA (NVIDIA) torchao
|
||
# is real and shadowing it breaks torchao-based quantization paths.
|
||
# Gate on the active torch runtime, not env-var presence -- HIP_PATH /
|
||
# ROCM_PATH stay set after a user installs the HIP SDK and reverts to a
|
||
# CUDA torch wheel. AMD SDK / Radeon ROCm wheels may not set torch.version.hip
|
||
# but still encode "rocm" in torch.__version__, so accept either.
|
||
_is_win32_rocm = False
|
||
if sys.platform == "win32":
|
||
try:
|
||
import torch as _torch_probe
|
||
|
||
_is_win32_rocm = bool(
|
||
getattr(getattr(_torch_probe, "version", None), "hip", None)
|
||
or "rocm" in getattr(_torch_probe, "__version__", "").lower()
|
||
)
|
||
del _torch_probe
|
||
except Exception:
|
||
pass
|
||
if _is_win32_rocm:
|
||
# Register the finder only on Windows ROCm -- on other platforms there
|
||
# are no stub modules seeded, so appending is a pure accumulation.
|
||
sys.meta_path.append(_StubSubpackageFinder())
|
||
# Seed torchao top-level + key submodules; the finder handles the rest.
|
||
for _tao_name in (
|
||
"torchao",
|
||
"torchao.quantization",
|
||
"torchao.dtypes",
|
||
"torchao.float8",
|
||
"torchao.utils",
|
||
):
|
||
if _tao_name not in sys.modules:
|
||
sys.modules[_tao_name] = _make_mod_stub(_tao_name)
|
||
|
||
# ── 1e. Ensure torch.distributed helper attrs are present ──
|
||
# Single-GPU training never initialises the process group, so these helpers
|
||
# are never called — but transformers/trl import them unconditionally.
|
||
_td_stubs = {
|
||
"is_initialized": lambda: False,
|
||
"is_available": lambda: False,
|
||
"is_torchelastic_launched": lambda: False,
|
||
"get_rank": lambda: 0,
|
||
"get_world_size": lambda: 1,
|
||
"barrier": lambda: None,
|
||
}
|
||
|
||
try:
|
||
import torch.distributed as _td
|
||
|
||
for _name, _stub in _td_stubs.items():
|
||
if not hasattr(_td, _name):
|
||
setattr(_td, _name, _stub)
|
||
except Exception:
|
||
_td_mock = _types.ModuleType("torch.distributed")
|
||
for _name, _stub in _td_stubs.items():
|
||
setattr(_td_mock, _name, _stub)
|
||
sys.modules["torch.distributed"] = _td_mock
|
||
try:
|
||
import torch as _torch
|
||
|
||
_torch.distributed = _td_mock
|
||
except Exception:
|
||
pass
|
||
|
||
# ── 1f. Windows ROCm runtime patches ──
|
||
# torch._grouped_mm has a null HIP kernel on gfx1200 (ROCm ≤ 7.12 Windows),
|
||
# causing 0xC0000005 (access violation) during training.
|
||
#
|
||
# Root cause: the JitDecomp autograd decomposition system (NOT torch.compile)
|
||
# dispatches _grouped_mm → _fused_adagrad_ → _grouped_mm HIP → null crash.
|
||
# TORCHDYNAMO_DISABLE=1 stops the compiler frontend but does NOT stop
|
||
# JitDecomp, so we must also override the CUDA dispatch key for _grouped_mm
|
||
# with a safe Python fallback.
|
||
#
|
||
# Fixed in AMD's wheel: torch==2.11.0+rocm7.13.0 — the 3-D batch and grouped
|
||
# (with offs) variants of _grouped_mm now have working HIP kernels on gfx1200.
|
||
# We gate the dispatch override on HIP < 7.13 so users on the fixed wheel get
|
||
# the real GPU kernel rather than our Python fallback.
|
||
#
|
||
# Verified: null on torch==2.10.0+rocm7.12.0; fixed on torch==2.11.0+rocm7.13.0.
|
||
#
|
||
# Schema: _grouped_mm(Tensor self, Tensor mat2, Tensor? offs=None,
|
||
# Tensor? bias=None, ScalarType? out_dtype=None) -> Tensor
|
||
# offs: optional group-split offsets (MoE-style variable-size batches)
|
||
#
|
||
# torch is already in sys.modules from section 1e's `import torch.distributed`.
|
||
# Module-level _WINDOWS_ROCM_GROUPED_MM_LIB keeps the registration alive past
|
||
# function return / mid-run GC.
|
||
global _WINDOWS_ROCM_GROUPED_MM_LIB
|
||
if sys.platform == "win32":
|
||
_torch_for_rocm = sys.modules.get("torch")
|
||
# Broad check: torch.version.hip OR "rocm" in torch.__version__.
|
||
# AMD SDK / Radeon Windows wheels do not always populate
|
||
# torch.version.hip; without the broad check the BNB version pin,
|
||
# dynamo-disable, and _grouped_mm fallback below silently skip
|
||
# (matches the torchao stub gate above and main.py).
|
||
_build_version_for_rocm = (
|
||
getattr(_torch_for_rocm, "__version__", "").lower()
|
||
if _torch_for_rocm is not None
|
||
else ""
|
||
)
|
||
_is_win_rocm_torch = bool(
|
||
_torch_for_rocm is not None
|
||
and (
|
||
getattr(getattr(_torch_for_rocm, "version", None), "hip", None)
|
||
or "rocm" in _build_version_for_rocm
|
||
)
|
||
)
|
||
if _is_win_rocm_torch:
|
||
# Disable dynamo (belt-and-suspenders; JitDecomp patch below is the
|
||
# real fix, but keeping dynamo off avoids any other compile paths).
|
||
if "TORCHDYNAMO_DISABLE" not in os.environ:
|
||
os.environ["TORCHDYNAMO_DISABLE"] = "1"
|
||
logger.info("Windows ROCm: torch.compile (dynamo) disabled")
|
||
|
||
# BNB auto-detects the HIP version from torch.version.hip and uses
|
||
# it to choose which DLL to load (e.g. "7.13" → rocm713.dll).
|
||
# AMD's Windows BNB prerelease wheel ships only one rocm DLL, and its
|
||
# version suffix does not always match the torch HIP version (e.g.
|
||
# torch==2.11.0+rocm7.13.0 ships HIP 7.13, but the BNB wheel still
|
||
# ships rocm72.dll). We detect the actual DLL name from the installed
|
||
# package and override BNB's auto-detection. "72" is a safe fallback
|
||
# if detection fails. Callers may override by pre-setting the var.
|
||
if "BNB_ROCM_VERSION" not in os.environ:
|
||
_bnb_rocm_ver = None
|
||
try:
|
||
import glob as _glob
|
||
import importlib.util as _ilu
|
||
import re as _re
|
||
|
||
_bnb_spec = _ilu.find_spec("bitsandbytes")
|
||
if _bnb_spec and _bnb_spec.submodule_search_locations:
|
||
_all_vers: list[str] = []
|
||
for _pkg_dir in _bnb_spec.submodule_search_locations:
|
||
for _dll in _glob.glob(
|
||
os.path.join(_pkg_dir, "libbitsandbytes_rocm*.dll")
|
||
):
|
||
_m = _re.search(
|
||
r"libbitsandbytes_rocm(\d+)\.dll",
|
||
os.path.basename(_dll),
|
||
)
|
||
if _m:
|
||
_all_vers.append(_m.group(1))
|
||
# Pick the highest numeric suffix so that e.g. "713"
|
||
# wins over "72" when both variants are present.
|
||
# Filesystem glob order is not guaranteed, so always
|
||
# sort rather than stopping at the first match.
|
||
if _all_vers:
|
||
_bnb_rocm_ver = max(_all_vers, key = lambda v: int(v))
|
||
except Exception:
|
||
pass
|
||
_bnb_rocm_ver = _bnb_rocm_ver or "72"
|
||
os.environ["BNB_ROCM_VERSION"] = _bnb_rocm_ver
|
||
logger.info(
|
||
"Windows ROCm: set BNB_ROCM_VERSION=%s "
|
||
"(detected from installed BNB wheel; "
|
||
"overrides torch.version.hip auto-detection)",
|
||
_bnb_rocm_ver,
|
||
)
|
||
|
||
# Parse HIP version for the kernel-fix gate below.
|
||
# torch.version.hip can be "7.13.99004", "7.2.0", etc.
|
||
# AMD SDK / Radeon wheels may leave torch.version.hip unset and
|
||
# encode the ROCm version in torch.__version__ instead
|
||
# (e.g. "2.11.0+rocm7.13.0" or "2.9.0+rocmsdk20251116"); fall back
|
||
# to that string when version.hip is missing.
|
||
def _hip_ver_at_least(major: int, minor: int) -> bool:
|
||
import re as _re_ver
|
||
|
||
_hip_str = getattr(
|
||
getattr(_torch_for_rocm, "version", None), "hip", None
|
||
)
|
||
if not _hip_str:
|
||
# Try the standard "+rocmX.Y.Z" embedded version first
|
||
# (e.g. "2.11.0+rocm7.13.0").
|
||
_ver_match = _re_ver.search(
|
||
r"rocm(\d+)\.(\d+)", _build_version_for_rocm
|
||
)
|
||
if _ver_match:
|
||
return (
|
||
int(_ver_match.group(1)),
|
||
int(_ver_match.group(2)),
|
||
) >= (major, minor)
|
||
# AMD SDK / Radeon Windows wheels encode the build as
|
||
# "+rocmsdk<date>" (e.g. "2.9.0+rocmsdk20251116") with no
|
||
# explicit rocmX.Y component. The rocmsdk format was
|
||
# introduced after the gfx120X null-kernel fix landed in
|
||
# ROCm 7.13, so any wheel with this suffix is new enough to
|
||
# have working HIP kernels. Treat as >= 7.13 rather than
|
||
# falling back to False and installing the Python workaround
|
||
# on a wheel that doesn't need it.
|
||
if "rocmsdk" in _build_version_for_rocm:
|
||
logger.debug(
|
||
"Windows ROCm: AMD SDK wheel detected (%r); "
|
||
"assuming HIP >= %d.%d (rocmsdk wheels post-date "
|
||
"the gfx120X null-kernel fix)",
|
||
_build_version_for_rocm,
|
||
major,
|
||
minor,
|
||
)
|
||
return True
|
||
return False
|
||
try:
|
||
_parts = [int(x) for x in str(_hip_str).split(".")[:2]]
|
||
if len(_parts) < 2:
|
||
logger.warning(
|
||
"Windows ROCm: torch.version.hip %r has fewer than "
|
||
"two components; cannot compare against %d.%d",
|
||
_hip_str,
|
||
major,
|
||
minor,
|
||
)
|
||
return False
|
||
return (_parts[0], _parts[1]) >= (major, minor)
|
||
except ValueError:
|
||
logger.warning(
|
||
"Windows ROCm: could not parse torch.version.hip %r as "
|
||
"a version number; assuming HIP < %d.%d",
|
||
_hip_str,
|
||
major,
|
||
minor,
|
||
)
|
||
return False
|
||
|
||
# _grouped_mm HIP kernel was null on gfx1200 in ROCm ≤ 7.12,
|
||
# causing 0xC0000005. AMD fixed it in ROCm 7.13 (torch 2.11+).
|
||
# Only install the Python fallback on the affected versions so users
|
||
# on 7.13+ get the real GPU kernel for MoE workloads.
|
||
if not _hip_ver_at_least(7, 13):
|
||
try:
|
||
import warnings as _warnings
|
||
|
||
_gm_lib = _torch_for_rocm.library.Library("aten", "IMPL")
|
||
|
||
def _grouped_mm_safe_impl(
|
||
self, mat2, offs = None, bias = None, out_dtype = None
|
||
):
|
||
"""Python mm/bmm fallback for _grouped_mm on gfx1200 (null HIP kernel, ROCm ≤ 7.12)."""
|
||
_t = _torch_for_rocm
|
||
if offs is None:
|
||
# No offsets: behave like the real op, which
|
||
# accepts either (M, K) x (K, N) -> mm, or 3-D
|
||
# batched inputs -> bmm. Picking torch.mm
|
||
# unconditionally previously raised "self must be
|
||
# a matrix" on 3-D MoE workloads.
|
||
if self.dim() == 3 and mat2.dim() == 3:
|
||
result = _t.bmm(self.contiguous(), mat2.contiguous())
|
||
elif self.dim() == 3 and mat2.dim() == 2:
|
||
# Broadcast 2-D mat2 across the batch dim.
|
||
result = _t.matmul(self.contiguous(), mat2.contiguous())
|
||
elif self.dim() == 2 and mat2.dim() == 3:
|
||
# Broadcast 2-D self across batch via matmul semantics.
|
||
result = _t.matmul(self.contiguous(), mat2.contiguous())
|
||
else:
|
||
result = _t.mm(self.contiguous(), mat2.contiguous())
|
||
else:
|
||
# Grouped case: offs[i] is the exclusive end-row of
|
||
# group i in `self`; mat2 may be 3-D or 2-D.
|
||
offs_list = offs.tolist()
|
||
pieces = []
|
||
prev = 0
|
||
for idx, end in enumerate(offs_list):
|
||
end = int(end)
|
||
a_part = self[prev:end].contiguous()
|
||
if mat2.dim() == 3:
|
||
b_part = mat2[idx].contiguous()
|
||
else:
|
||
b_part = mat2.contiguous()
|
||
pieces.append(_t.mm(a_part, b_part))
|
||
prev = end
|
||
# Include any trailing rows not covered by offs
|
||
if prev < self.shape[0]:
|
||
a_tail = self[prev:].contiguous()
|
||
b_tail = (
|
||
mat2[-1].contiguous()
|
||
if mat2.dim() == 3
|
||
else mat2.contiguous()
|
||
)
|
||
pieces.append(_t.mm(a_tail, b_tail))
|
||
result = (
|
||
_t.cat(pieces, dim = 0)
|
||
if pieces
|
||
else _t.zeros(
|
||
0,
|
||
mat2.shape[-1],
|
||
device = self.device,
|
||
dtype = self.dtype,
|
||
)
|
||
)
|
||
if bias is not None:
|
||
result = result + bias
|
||
if out_dtype is not None:
|
||
result = result.to(out_dtype)
|
||
elif result.dtype != self.dtype:
|
||
result = result.to(self.dtype)
|
||
return result
|
||
|
||
with _warnings.catch_warnings():
|
||
_warnings.simplefilter("ignore")
|
||
_gm_lib.impl("_grouped_mm", _grouped_mm_safe_impl, "CUDA")
|
||
|
||
_WINDOWS_ROCM_GROUPED_MM_LIB = _gm_lib # prevent GC
|
||
logger.info(
|
||
"Windows ROCm: patched _grouped_mm CUDA dispatch "
|
||
"(null HIP kernel on gfx1200, ROCm ≤ 7.12 — "
|
||
"bypassed with Python mm fallback)"
|
||
)
|
||
except Exception as _patch_exc:
|
||
logger.warning(
|
||
"Windows ROCm: could not patch _grouped_mm — "
|
||
"training may crash with 0xC0000005: %s",
|
||
_patch_exc,
|
||
)
|
||
else:
|
||
logger.info(
|
||
"Windows ROCm: HIP >= 7.13 — _grouped_mm kernel is functional, "
|
||
"skipping Python fallback (AMD fixed gfx1200 null kernel in ROCm 7.13)"
|
||
)
|
||
|
||
# ── 1g. ROCm OOM guard ──
|
||
# On RDNA 4 (gfx1200/gfx1201) and other ROCm GPUs, exhausting VRAM can
|
||
# cause a HIP driver hang that freezes the entire system rather than
|
||
# raising a Python exception. set_per_process_memory_fraction caps the
|
||
# HIP allocator so PyTorch raises OutOfMemoryError before hitting the
|
||
# hardware limit, giving the UI a clean error instead of a system freeze.
|
||
# Only applied on ROCm -- NVIDIA CUDA has a graceful OOM path and does
|
||
# not need this cap.
|
||
# Unified-memory APUs (gfx1150 Strix Point / gfx1151 Strix Halo) share GPU
|
||
# and system RAM in one pool: 0.90 of 128 GB starves the OS. Use 0.80 there.
|
||
# Primary classifier: gcnArchName from device properties — stable within a
|
||
# product family and naming-independent. AMD SDK / Radeon wheels may omit
|
||
# gcnArchName or expose it under a variant spelling, so we try several attr
|
||
# names then fall back to known device-name markers as a last resort.
|
||
# Non-fatal: silently skipped if torch is not importable.
|
||
if _hw.IS_ROCM:
|
||
try:
|
||
import torch as _torch_mem
|
||
|
||
if _torch_mem.cuda.is_available():
|
||
# Classify unified vs discrete via _rocm_classify_unified_memory.
|
||
# See that function's docstring for classification priority.
|
||
_props = _torch_mem.cuda.get_device_properties(0)
|
||
_dev_name = _props.name
|
||
_gcn_arch, _is_unified = _rocm_classify_unified_memory(_props)
|
||
if _is_unified and not _gcn_arch:
|
||
logger.debug(
|
||
"ROCm OOM guard: gcnArchName absent -- inferred "
|
||
"unified memory from device name %r; applying 0.80 cap",
|
||
_dev_name,
|
||
)
|
||
_mem_fraction = 0.80 if _is_unified else 0.90
|
||
_torch_mem.cuda.set_per_process_memory_fraction(_mem_fraction)
|
||
logger.info(
|
||
"ROCm OOM guard: set_per_process_memory_fraction(%.2f) — "
|
||
"%s memory host (%s, %s)",
|
||
_mem_fraction,
|
||
"unified" if _is_unified else "discrete",
|
||
_dev_name,
|
||
_gcn_arch or "unknown arch",
|
||
)
|
||
except Exception as _oom_guard_err:
|
||
logger.debug("Could not set GPU memory fraction: %s", _oom_guard_err)
|
||
|
||
# ── 2. Now import ML libraries (fresh in this clean process) ──
|
||
try:
|
||
_send_status(event_queue, "Importing Unsloth...")
|
||
|
||
backend_path = str(Path(__file__).resolve().parent.parent.parent)
|
||
if backend_path not in sys.path:
|
||
sys.path.insert(0, backend_path)
|
||
|
||
from core.training.trainer import UnslothTrainer, TrainingProgress
|
||
from utils.paths import (
|
||
ensure_dir,
|
||
resolve_output_dir,
|
||
resolve_tensorboard_dir,
|
||
datasets_root,
|
||
)
|
||
|
||
import transformers
|
||
|
||
logger.info("Subprocess loaded transformers %s", transformers.__version__)
|
||
except Exception as exc:
|
||
event_queue.put(
|
||
{
|
||
"type": "error",
|
||
"error": f"Failed to import ML libraries: {exc}",
|
||
"stack": traceback.format_exc(limit = 20),
|
||
"ts": time.time(),
|
||
}
|
||
)
|
||
return
|
||
|
||
# ── 2b. EMBEDDING MODEL FAST-PATH ──
|
||
# Embedding models use a completely different pipeline (FastSentenceTransformer
|
||
# + SentenceTransformerTrainer + MultipleNegativesRankingLoss) so we branch
|
||
# early and handle the entire flow in a self-contained function.
|
||
if config.get("is_embedding", False):
|
||
try:
|
||
_run_embedding_training(event_queue, stop_queue, config)
|
||
except Exception as exc:
|
||
event_queue.put(
|
||
{
|
||
"type": "error",
|
||
"error": str(exc),
|
||
"stack": traceback.format_exc(limit = 20),
|
||
"ts": time.time(),
|
||
}
|
||
)
|
||
return
|
||
|
||
# ── 3. Create a fresh trainer instance ──
|
||
trainer = UnslothTrainer()
|
||
|
||
# Wire up progress callback → event_queue
|
||
def _on_progress(progress: TrainingProgress):
|
||
has_train_loss = progress.step > 0 and progress.loss is not None
|
||
has_eval_loss = progress.eval_loss is not None
|
||
if has_train_loss or has_eval_loss:
|
||
event_queue.put(
|
||
{
|
||
"type": "progress",
|
||
"step": progress.step,
|
||
"epoch": progress.epoch,
|
||
"loss": progress.loss,
|
||
"learning_rate": progress.learning_rate,
|
||
"total_steps": progress.total_steps,
|
||
"elapsed_seconds": progress.elapsed_seconds,
|
||
"eta_seconds": progress.eta_seconds,
|
||
"grad_norm": progress.grad_norm,
|
||
"num_tokens": progress.num_tokens,
|
||
"eval_loss": progress.eval_loss,
|
||
"status_message": progress.status_message,
|
||
"ts": time.time(),
|
||
}
|
||
)
|
||
if progress.status_message:
|
||
_send_status(event_queue, progress.status_message)
|
||
|
||
trainer.add_progress_callback(_on_progress)
|
||
|
||
# Wire up stop_queue polling to trainer.should_stop
|
||
import threading
|
||
import queue as _queue
|
||
|
||
def _poll_stop():
|
||
while True:
|
||
try:
|
||
msg = stop_queue.get(timeout = 1.0)
|
||
if msg and msg.get("type") == "stop":
|
||
save = msg.get("save", True)
|
||
trainer.should_stop = True
|
||
trainer.save_on_stop = save
|
||
logger.info("Stop signal received (save=%s)", save)
|
||
return
|
||
except _queue.Empty:
|
||
continue
|
||
except (EOFError, OSError):
|
||
return
|
||
|
||
stop_thread = threading.Thread(target = _poll_stop, daemon = True)
|
||
stop_thread.start()
|
||
|
||
# ── 4. Execute the training pipeline ──
|
||
# Order: detect → dataset → model → prepare → train
|
||
# Dataset processing (including LLM-assisted detection) runs BEFORE model
|
||
# loading so both never occupy VRAM at the same time.
|
||
try:
|
||
hf_token = config.get("hf_token", "")
|
||
hf_token = hf_token if hf_token and hf_token.strip() else None
|
||
|
||
# ── 4a. Lightweight detection + tokenizer (no VRAM) ──
|
||
_send_status(event_queue, "Detecting model type...")
|
||
trainer.pre_detect_and_load_tokenizer(
|
||
model_name = model_name,
|
||
max_seq_length = config["max_seq_length"],
|
||
hf_token = hf_token,
|
||
is_dataset_image = config.get("is_dataset_image", False),
|
||
is_dataset_audio = config.get("is_dataset_audio", False),
|
||
trust_remote_code = config.get("trust_remote_code", False),
|
||
)
|
||
if trainer.should_stop:
|
||
event_queue.put({"type": "complete", "output_dir": None, "ts": time.time()})
|
||
return
|
||
|
||
# ── 4b. Load and format dataset (LLM helper may use VRAM briefly) ──
|
||
_send_status(event_queue, "Loading and formatting dataset...")
|
||
hf_dataset = config.get("hf_dataset", "")
|
||
training_type = config.get("training_type", "LoRA/QLoRA")
|
||
_is_cpt_for_dataset = training_type == "Continued Pretraining"
|
||
dataset_result = trainer.load_and_format_dataset(
|
||
dataset_source = hf_dataset if hf_dataset and hf_dataset.strip() else None,
|
||
format_type = config.get("format_type", ""),
|
||
local_datasets = config.get("local_datasets") or None,
|
||
local_eval_datasets = config.get("local_eval_datasets") or None,
|
||
custom_format_mapping = config.get("custom_format_mapping"),
|
||
subset = config.get("subset"),
|
||
train_split = config.get("train_split", "train"),
|
||
eval_split = config.get("eval_split"),
|
||
eval_steps = config.get("eval_steps", 0.00),
|
||
dataset_slice_start = config.get("dataset_slice_start"),
|
||
dataset_slice_end = config.get("dataset_slice_end"),
|
||
is_cpt = _is_cpt_for_dataset,
|
||
)
|
||
|
||
if isinstance(dataset_result, tuple):
|
||
dataset, eval_dataset = dataset_result
|
||
else:
|
||
dataset = dataset_result
|
||
eval_dataset = None
|
||
|
||
# [DEBUG] Print first sample before model is loaded
|
||
# dataset is a dict {"dataset": <Dataset>, "detected_format": ..., ...}
|
||
# or a raw Dataset for audio paths
|
||
# try:
|
||
# ds = dataset["dataset"] if isinstance(dataset, dict) else dataset
|
||
# print(
|
||
# f"\n[DEBUG] Dataset loaded BEFORE model. type={type(ds).__name__}, len={len(ds)}",
|
||
# flush = True,
|
||
# )
|
||
# print(f"[DEBUG] Columns: {ds.column_names}", flush = True)
|
||
# sample = ds[0]
|
||
# preview = {k: str(v)[:300] for k, v in sample.items()}
|
||
# print(f"[DEBUG] First sample: {preview}\n", flush = True)
|
||
# except Exception as e:
|
||
# print(
|
||
# f"[DEBUG] Could not preview first sample: {type(e).__name__}: {e}",
|
||
# flush = True,
|
||
# )
|
||
|
||
# Disable eval if eval_steps <= 0
|
||
eval_steps = config.get("eval_steps", 0.00)
|
||
if eval_steps is not None and float(eval_steps) <= 0:
|
||
eval_dataset = None
|
||
|
||
# Tell the parent process that eval is configured so the frontend
|
||
# shows "Waiting for first evaluation step..." instead of "not configured"
|
||
if eval_dataset is not None:
|
||
event_queue.put(
|
||
{
|
||
"type": "eval_configured",
|
||
"ts": time.time(),
|
||
}
|
||
)
|
||
|
||
if dataset is None or trainer.should_stop:
|
||
if trainer.should_stop:
|
||
event_queue.put(
|
||
{"type": "complete", "output_dir": None, "ts": time.time()}
|
||
)
|
||
else:
|
||
event_queue.put(
|
||
{
|
||
"type": "error",
|
||
"error": trainer.training_progress.error
|
||
or "Failed to load dataset",
|
||
"stack": "",
|
||
"ts": time.time(),
|
||
}
|
||
)
|
||
return
|
||
|
||
# ── Start tqdm monitor early so it captures download + tokenization bars ──
|
||
import threading as _th
|
||
|
||
_tqdm_stop = _th.Event()
|
||
|
||
def _monitor_tqdm():
|
||
from tqdm.auto import tqdm as _tqdm_cls
|
||
|
||
while not _tqdm_stop.is_set():
|
||
for bar in list(getattr(_tqdm_cls, "_instances", set())):
|
||
try:
|
||
n, total = bar.n or 0, bar.total or 0
|
||
desc = getattr(bar, "desc", "") or ""
|
||
if total > 0 and n > 0 and desc:
|
||
pct = min(int(n * 100 / total), 100)
|
||
_send_status(
|
||
event_queue, f"{desc.strip()} {pct}% ({n:,}/{total:,})"
|
||
)
|
||
except (AttributeError, ReferenceError):
|
||
pass
|
||
_tqdm_stop.wait(3)
|
||
|
||
_tqdm_thread = _th.Thread(target = _monitor_tqdm, daemon = True)
|
||
_tqdm_thread.start()
|
||
|
||
training_type = config.get("training_type", "LoRA/QLoRA")
|
||
is_cpt = training_type == "Continued Pretraining"
|
||
use_lora = training_type in ("LoRA/QLoRA", "Continued Pretraining")
|
||
cpt_trains_embeddings = False
|
||
|
||
# ── 4c. Load training model (uses VRAM — dataset already formatted) ──
|
||
_send_status(event_queue, "Loading model...")
|
||
success = trainer.load_model(
|
||
model_name = model_name,
|
||
max_seq_length = config["max_seq_length"],
|
||
load_in_4bit = config["load_in_4bit"],
|
||
full_finetuning = not use_lora,
|
||
hf_token = hf_token,
|
||
is_dataset_image = config.get("is_dataset_image", False),
|
||
is_dataset_audio = config.get("is_dataset_audio", False),
|
||
trust_remote_code = config.get("trust_remote_code", False),
|
||
gpu_ids = config.get("resolved_gpu_ids"),
|
||
)
|
||
if not success or trainer.should_stop:
|
||
if trainer.should_stop:
|
||
event_queue.put(
|
||
{"type": "complete", "output_dir": None, "ts": time.time()}
|
||
)
|
||
else:
|
||
error_msg = trainer.training_progress.error or "Failed to load model"
|
||
event_queue.put(
|
||
{
|
||
"type": "error",
|
||
"error": error_msg,
|
||
"stack": "",
|
||
"ts": time.time(),
|
||
}
|
||
)
|
||
return
|
||
|
||
# ── 4d. Prepare model (LoRA, full finetuning, or CPT) ──
|
||
if is_cpt:
|
||
_send_status(event_queue, "Configuring LoRA for continued pretraining...")
|
||
# embed_tokens (if the user included it) goes to modules_to_save —
|
||
# trained full-precision at embedding_learning_rate. lm_head stays as
|
||
# a LoRA target for merge compatibility (see unsloth PR #4106).
|
||
_user_modules = config.get("target_modules") or []
|
||
wants_embed = "embed_tokens" in _user_modules
|
||
cpt_trains_embeddings = wants_embed
|
||
cpt_target_modules = [m for m in _user_modules if m != "embed_tokens"]
|
||
if not cpt_target_modules:
|
||
cpt_target_modules = [
|
||
"q_proj",
|
||
"k_proj",
|
||
"v_proj",
|
||
"o_proj",
|
||
"gate_proj",
|
||
"up_proj",
|
||
"down_proj",
|
||
"lm_head",
|
||
]
|
||
success = trainer.prepare_model_for_training(
|
||
use_lora = True,
|
||
target_modules = cpt_target_modules,
|
||
modules_to_save = ["embed_tokens"] if wants_embed else None,
|
||
lora_r = config.get("lora_r", 128),
|
||
lora_alpha = config.get("lora_alpha", 32),
|
||
lora_dropout = config.get("lora_dropout", 0.0),
|
||
use_gradient_checkpointing = config.get(
|
||
"gradient_checkpointing", "unsloth"
|
||
),
|
||
use_rslora = config.get("use_rslora", False),
|
||
use_loftq = config.get("use_loftq", False),
|
||
)
|
||
elif use_lora:
|
||
_send_status(event_queue, "Configuring LoRA adapters...")
|
||
success = trainer.prepare_model_for_training(
|
||
use_lora = True,
|
||
finetune_vision_layers = config.get("finetune_vision_layers", True),
|
||
finetune_language_layers = config.get("finetune_language_layers", True),
|
||
finetune_attention_modules = config.get(
|
||
"finetune_attention_modules", True
|
||
),
|
||
finetune_mlp_modules = config.get("finetune_mlp_modules", True),
|
||
target_modules = config.get("target_modules"),
|
||
lora_r = config.get("lora_r", 16),
|
||
lora_alpha = config.get("lora_alpha", 16),
|
||
lora_dropout = config.get("lora_dropout", 0.0),
|
||
use_gradient_checkpointing = config.get(
|
||
"gradient_checkpointing", "unsloth"
|
||
),
|
||
use_rslora = config.get("use_rslora", False),
|
||
use_loftq = config.get("use_loftq", False),
|
||
)
|
||
else:
|
||
_send_status(event_queue, "Preparing model for full finetuning...")
|
||
success = trainer.prepare_model_for_training(use_lora = False)
|
||
|
||
if not success or trainer.should_stop:
|
||
if trainer.should_stop:
|
||
event_queue.put(
|
||
{"type": "complete", "output_dir": None, "ts": time.time()}
|
||
)
|
||
else:
|
||
event_queue.put(
|
||
{
|
||
"type": "error",
|
||
"error": trainer.training_progress.error
|
||
or "Failed to prepare model",
|
||
"stack": "",
|
||
"ts": time.time(),
|
||
}
|
||
)
|
||
return
|
||
|
||
lr_default = "5e-5" if is_cpt else "2e-4"
|
||
try:
|
||
lr_value = float(config.get("learning_rate", lr_default))
|
||
except ValueError:
|
||
event_queue.put(
|
||
{
|
||
"type": "error",
|
||
"error": f"Invalid learning rate: {config.get('learning_rate')}",
|
||
"stack": "",
|
||
"ts": time.time(),
|
||
}
|
||
)
|
||
return
|
||
|
||
# embedding_learning_rate is validated by the Pydantic model (Optional[float],
|
||
# gt=0, lt=1.0); if present it is already a finite float in range.
|
||
embedding_lr_value = config.get("embedding_learning_rate")
|
||
if is_cpt:
|
||
if cpt_trains_embeddings:
|
||
if embedding_lr_value is None:
|
||
# Default embedding_learning_rate = lr/10 per Unsloth's CPT notebook.
|
||
embedding_lr_value = lr_value / 10.0
|
||
logger.info(
|
||
f"CPT: using default embedding_learning_rate={embedding_lr_value:.1e} "
|
||
f"(lr/10). Set explicitly to override.\n"
|
||
)
|
||
elif embedding_lr_value is not None:
|
||
logger.warning(
|
||
"CPT: embedding_learning_rate was provided but embed_tokens is "
|
||
"not being trained; ignoring the override.\n"
|
||
)
|
||
embedding_lr_value = None
|
||
|
||
# Generate output dir
|
||
resume_from_checkpoint = config.get("resume_from_checkpoint")
|
||
output_dir = config.get("output_dir") or _output_dir_from_resume_checkpoint(
|
||
resume_from_checkpoint
|
||
)
|
||
if not output_dir:
|
||
output_dir = f"{model_name.replace('/', '_')}_{int(time.time())}"
|
||
output_dir = str(resolve_output_dir(output_dir))
|
||
ensure_dir(Path(output_dir))
|
||
|
||
tensorboard_dir = config.get("tensorboard_dir")
|
||
if config.get("enable_tensorboard", False):
|
||
tensorboard_dir = str(resolve_tensorboard_dir(tensorboard_dir))
|
||
ensure_dir(Path(tensorboard_dir))
|
||
|
||
# Start training (directly — no inner thread, we ARE the subprocess)
|
||
dataset_display = (
|
||
config.get("hf_dataset", "") or config.get("uploaded_file", "") or ""
|
||
)
|
||
_send_status(
|
||
event_queue,
|
||
f'Training "{model_name}"'
|
||
+ (f"\nDataset = {dataset_display}" if dataset_display else ""),
|
||
)
|
||
max_steps = config.get("max_steps", 0)
|
||
save_steps = config.get("save_steps", 0)
|
||
|
||
trainer._train_worker(
|
||
dataset,
|
||
output_dir = output_dir,
|
||
num_epochs = config.get("num_epochs", 3),
|
||
learning_rate = lr_value,
|
||
embedding_learning_rate = embedding_lr_value,
|
||
batch_size = config.get("batch_size", 2),
|
||
gradient_accumulation_steps = config.get("gradient_accumulation_steps", 4),
|
||
warmup_steps = config.get("warmup_steps"),
|
||
warmup_ratio = config.get("warmup_ratio"),
|
||
max_steps = max_steps if max_steps and max_steps > 0 else 0,
|
||
save_steps = save_steps if save_steps and save_steps > 0 else 0,
|
||
weight_decay = config.get("weight_decay", 0.001),
|
||
random_seed = config.get("random_seed", 3407),
|
||
packing = config.get("packing", False),
|
||
train_on_completions = False
|
||
if is_cpt
|
||
else config.get("train_on_completions", False),
|
||
enable_wandb = config.get("enable_wandb", False),
|
||
wandb_project = config.get("wandb_project", "unsloth-training"),
|
||
wandb_token = config.get("wandb_token"),
|
||
enable_tensorboard = config.get("enable_tensorboard", False),
|
||
tensorboard_dir = tensorboard_dir,
|
||
eval_dataset = eval_dataset,
|
||
eval_steps = eval_steps,
|
||
max_seq_length = config.get("max_seq_length", 2048),
|
||
vision_image_size = config.get("vision_image_size"),
|
||
optim = config.get("optim", "adamw_8bit"),
|
||
lr_scheduler_type = config.get("lr_scheduler_type", "linear"),
|
||
is_cpt = is_cpt,
|
||
resume_from_checkpoint = resume_from_checkpoint,
|
||
)
|
||
|
||
_tqdm_stop.set()
|
||
|
||
# Check final state
|
||
progress = trainer.get_training_progress()
|
||
if progress.error:
|
||
event_queue.put(
|
||
{
|
||
"type": "error",
|
||
"error": progress.error,
|
||
"stack": "",
|
||
"ts": time.time(),
|
||
}
|
||
)
|
||
else:
|
||
saved_output_dir = (
|
||
None if trainer.should_stop and not trainer.save_on_stop else output_dir
|
||
)
|
||
event_queue.put(
|
||
{
|
||
"type": "complete",
|
||
"output_dir": saved_output_dir,
|
||
"status_message": progress.status_message or "Training completed",
|
||
"ts": time.time(),
|
||
}
|
||
)
|
||
|
||
except Exception as exc:
|
||
_exc_str = str(exc).lower()
|
||
_is_oom = (
|
||
"out of memory" in _exc_str
|
||
or "hip out of memory" in _exc_str
|
||
or "cuda out of memory" in _exc_str
|
||
or type(exc).__name__ == "OutOfMemoryError"
|
||
)
|
||
if _is_oom:
|
||
_oom_msg = (
|
||
"GPU ran out of VRAM during training.\n"
|
||
"To fix: reduce max_seq_length (e.g. 2048–4096), enable "
|
||
"gradient_checkpointing=True, lower per_device_train_batch_size, "
|
||
"or use a smaller model / higher quantization."
|
||
)
|
||
logger.error("Training stopped: GPU OOM — %s", exc)
|
||
event_queue.put(
|
||
{
|
||
"type": "error",
|
||
"error": _oom_msg,
|
||
"stack": traceback.format_exc(limit = 20),
|
||
"ts": time.time(),
|
||
}
|
||
)
|
||
else:
|
||
event_queue.put(
|
||
{
|
||
"type": "error",
|
||
"error": str(exc),
|
||
"stack": traceback.format_exc(limit = 20),
|
||
"ts": time.time(),
|
||
}
|
||
)
|
||
|
||
|
||
def _send_status(event_queue: Any, message: str) -> None:
|
||
"""Send a status update to the parent process."""
|
||
event_queue.put(
|
||
{
|
||
"type": "status",
|
||
"message": message,
|
||
"ts": time.time(),
|
||
}
|
||
)
|
||
|
||
|
||
def _run_embedding_training(event_queue: Any, stop_queue: Any, config: dict) -> None:
|
||
"""Self-contained embedding model training pipeline.
|
||
|
||
Uses FastSentenceTransformer + SentenceTransformerTrainer +
|
||
MultipleNegativesRankingLoss — completely separate from the
|
||
LLM/VLM/audio paths in UnslothTrainer.
|
||
|
||
Mirrors the pattern from the reference embedding notebooks:
|
||
All_MiniLM_L6_v2.py, BGE_M3.py, EmbeddingGemma_300M.py,
|
||
ModernBert.py, Qwen3_Embedding_0_6B.py
|
||
"""
|
||
import math
|
||
import queue as _queue
|
||
import threading
|
||
|
||
model_name = config["model_name"]
|
||
training_start_time = time.time()
|
||
|
||
# ── 1. Import embedding-specific libraries ──
|
||
_send_status(event_queue, "Importing embedding libraries...")
|
||
try:
|
||
from unsloth import FastSentenceTransformer, is_bfloat16_supported
|
||
from sentence_transformers import (
|
||
SentenceTransformerTrainer,
|
||
SentenceTransformerTrainingArguments,
|
||
)
|
||
from sentence_transformers.losses import MultipleNegativesRankingLoss
|
||
from sentence_transformers.training_args import BatchSamplers
|
||
from datasets import load_dataset, Dataset
|
||
from transformers import TrainerCallback
|
||
from utils.paths import datasets_root, resolve_output_dir
|
||
except ImportError as e:
|
||
event_queue.put(
|
||
{
|
||
"type": "error",
|
||
"error": f"Failed to import embedding libraries: {e}. "
|
||
"Ensure 'sentence_transformers' and 'unsloth' are installed.",
|
||
"stack": traceback.format_exc(limit = 20),
|
||
"ts": time.time(),
|
||
}
|
||
)
|
||
return
|
||
|
||
# ── Stop signal handling ──
|
||
_should_stop = False
|
||
_save_on_stop = True
|
||
|
||
def _poll_stop():
|
||
nonlocal _should_stop, _save_on_stop
|
||
while True:
|
||
try:
|
||
msg = stop_queue.get(timeout = 1.0)
|
||
if msg and msg.get("type") == "stop":
|
||
_save_on_stop = msg.get("save", True)
|
||
_should_stop = True
|
||
logger.info(
|
||
"Embedding training: stop signal received (save=%s)",
|
||
_save_on_stop,
|
||
)
|
||
return
|
||
except _queue.Empty:
|
||
continue
|
||
except (EOFError, OSError):
|
||
return
|
||
|
||
stop_thread = threading.Thread(target = _poll_stop, daemon = True)
|
||
stop_thread.start()
|
||
|
||
# ── 2. Load model ──
|
||
_send_status(event_queue, "Loading embedding model...")
|
||
try:
|
||
hf_token = config.get("hf_token", "")
|
||
hf_token = hf_token if hf_token and hf_token.strip() else None
|
||
max_seq_length = config.get("max_seq_length", 512)
|
||
training_type = config.get("training_type", "LoRA/QLoRA")
|
||
use_lora = training_type == "LoRA/QLoRA"
|
||
|
||
model = FastSentenceTransformer.from_pretrained(
|
||
model_name = model_name,
|
||
max_seq_length = max_seq_length,
|
||
full_finetuning = not use_lora,
|
||
token = hf_token,
|
||
)
|
||
except Exception as e:
|
||
event_queue.put(
|
||
{
|
||
"type": "error",
|
||
"error": f"Failed to load embedding model '{model_name}': {e}",
|
||
"stack": traceback.format_exc(limit = 20),
|
||
"ts": time.time(),
|
||
}
|
||
)
|
||
return
|
||
|
||
if _should_stop:
|
||
event_queue.put({"type": "complete", "output_dir": None, "ts": time.time()})
|
||
return
|
||
|
||
# ── 3. Apply LoRA ──
|
||
if use_lora:
|
||
_send_status(event_queue, "Configuring LoRA adapters (FEATURE_EXTRACTION)...")
|
||
try:
|
||
gradient_checkpointing = config.get("gradient_checkpointing", False)
|
||
# Normalize: "none" or empty → False
|
||
if gradient_checkpointing in ("none", "", None):
|
||
gradient_checkpointing = False
|
||
|
||
model = FastSentenceTransformer.get_peft_model(
|
||
model,
|
||
r = config.get("lora_r", 32),
|
||
target_modules = config.get("target_modules")
|
||
or ["q_proj", "k_proj", "v_proj", "o_proj"],
|
||
lora_alpha = config.get("lora_alpha", 64),
|
||
lora_dropout = config.get("lora_dropout", 0.0),
|
||
bias = "none",
|
||
use_gradient_checkpointing = gradient_checkpointing,
|
||
random_state = config.get("random_seed", 3407),
|
||
use_rslora = config.get("use_rslora", False),
|
||
loftq_config = {"loftq_bits": 4, "loftq_iter": 1}
|
||
if config.get("use_loftq")
|
||
else None,
|
||
task_type = "FEATURE_EXTRACTION",
|
||
)
|
||
except Exception as e:
|
||
event_queue.put(
|
||
{
|
||
"type": "error",
|
||
"error": f"Failed to configure LoRA for embedding model: {e}",
|
||
"stack": traceback.format_exc(limit = 20),
|
||
"ts": time.time(),
|
||
}
|
||
)
|
||
return
|
||
|
||
if _should_stop:
|
||
event_queue.put({"type": "complete", "output_dir": None, "ts": time.time()})
|
||
return
|
||
|
||
# ── 4. Load dataset ──
|
||
_send_status(event_queue, "Loading dataset...")
|
||
try:
|
||
hf_dataset = config.get("hf_dataset", "")
|
||
local_datasets = config.get("local_datasets") or []
|
||
subset = config.get("subset") or None
|
||
train_split = config.get("train_split", "train") or "train"
|
||
|
||
if hf_dataset and hf_dataset.strip():
|
||
hf_token = config.get("hf_token", "")
|
||
hf_token = hf_token if hf_token and hf_token.strip() else None
|
||
dataset = load_dataset(
|
||
hf_dataset.strip(),
|
||
subset,
|
||
split = train_split,
|
||
token = hf_token,
|
||
)
|
||
elif local_datasets:
|
||
# Load from local file(s) — mirrors the non-embedding pipeline's
|
||
# directory handling so recipe outputs (parquet-files/) work.
|
||
all_files: list[str] = []
|
||
for dataset_file in local_datasets:
|
||
file_path = (
|
||
dataset_file
|
||
if os.path.isabs(dataset_file)
|
||
else os.path.join(
|
||
str(datasets_root()),
|
||
dataset_file,
|
||
)
|
||
)
|
||
if os.path.isdir(file_path):
|
||
file_path_obj = Path(file_path)
|
||
parquet_dir = (
|
||
file_path_obj / "parquet-files"
|
||
if (file_path_obj / "parquet-files").exists()
|
||
else file_path_obj
|
||
)
|
||
parquet_files = sorted(parquet_dir.glob("*.parquet"))
|
||
if parquet_files:
|
||
all_files.extend(str(p) for p in parquet_files)
|
||
continue
|
||
candidates: list[Path] = []
|
||
for ext in (".json", ".jsonl", ".csv", ".parquet"):
|
||
candidates.extend(sorted(file_path_obj.glob(f"*{ext}")))
|
||
if candidates:
|
||
all_files.extend(str(c) for c in candidates)
|
||
continue
|
||
raise ValueError(
|
||
f"No supported data files in directory: {file_path_obj}"
|
||
)
|
||
else:
|
||
all_files.append(file_path)
|
||
|
||
if all_files:
|
||
first_ext = Path(all_files[0]).suffix.lower()
|
||
if first_ext in (".json", ".jsonl"):
|
||
loader = "json"
|
||
elif first_ext == ".csv":
|
||
loader = "csv"
|
||
elif first_ext == ".parquet":
|
||
loader = "parquet"
|
||
else:
|
||
raise ValueError(
|
||
f"Unsupported local dataset format: {all_files[0]}"
|
||
)
|
||
dataset = load_dataset(loader, data_files = all_files, split = "train")
|
||
else:
|
||
event_queue.put(
|
||
{
|
||
"type": "error",
|
||
"error": "No dataset specified for embedding training.",
|
||
"stack": "",
|
||
"ts": time.time(),
|
||
}
|
||
)
|
||
return
|
||
|
||
# Apply dataset slicing if specified
|
||
slice_start = config.get("dataset_slice_start")
|
||
slice_end = config.get("dataset_slice_end")
|
||
if slice_start is not None or slice_end is not None:
|
||
start = slice_start if slice_start is not None else 0
|
||
end = slice_end if slice_end is not None else len(dataset)
|
||
dataset = dataset.select(range(start, min(end + 1, len(dataset))))
|
||
|
||
logger.info(f"Embedding dataset loaded: {len(dataset)} samples")
|
||
except Exception as e:
|
||
event_queue.put(
|
||
{
|
||
"type": "error",
|
||
"error": f"Failed to load dataset: {e}",
|
||
"stack": traceback.format_exc(limit = 20),
|
||
"ts": time.time(),
|
||
}
|
||
)
|
||
return
|
||
|
||
if _should_stop:
|
||
event_queue.put({"type": "complete", "output_dir": None, "ts": time.time()})
|
||
return
|
||
|
||
# ── 5. Create loss function ──
|
||
loss = MultipleNegativesRankingLoss(model)
|
||
|
||
# ── 6. Build training arguments ──
|
||
_send_status(event_queue, "Configuring training...")
|
||
try:
|
||
lr_value = float(config.get("learning_rate", "2e-4"))
|
||
except ValueError:
|
||
event_queue.put(
|
||
{
|
||
"type": "error",
|
||
"error": f"Invalid learning rate: {config.get('learning_rate')}",
|
||
"stack": "",
|
||
"ts": time.time(),
|
||
}
|
||
)
|
||
return
|
||
|
||
resume_from_checkpoint = config.get("resume_from_checkpoint")
|
||
output_dir = config.get("output_dir") or _output_dir_from_resume_checkpoint(
|
||
resume_from_checkpoint
|
||
)
|
||
if not output_dir:
|
||
output_dir = str(
|
||
resolve_output_dir(f"{model_name.replace('/', '_')}_{int(time.time())}")
|
||
)
|
||
output_dir = str(resolve_output_dir(output_dir))
|
||
|
||
num_epochs = config.get("num_epochs", 2)
|
||
batch_size = config.get("batch_size", 256)
|
||
gradient_accumulation_steps = config.get("gradient_accumulation_steps", 1)
|
||
max_steps_val = config.get("max_steps", 0)
|
||
save_steps_val = config.get("save_steps", 0)
|
||
warmup_ratio = config.get("warmup_ratio", 0.03)
|
||
warmup_steps_val = config.get("warmup_steps")
|
||
log_frequency = config.get("log_frequency", 50)
|
||
|
||
# Build args dict
|
||
training_args_kwargs = {
|
||
"output_dir": output_dir,
|
||
"per_device_train_batch_size": batch_size,
|
||
"gradient_accumulation_steps": gradient_accumulation_steps,
|
||
"learning_rate": lr_value,
|
||
"fp16": not is_bfloat16_supported(),
|
||
"bf16": is_bfloat16_supported(),
|
||
"logging_steps": 1,
|
||
"report_to": ["wandb"] if config.get("enable_wandb") else "none",
|
||
"lr_scheduler_type": config.get("lr_scheduler_type", "linear"),
|
||
"batch_sampler": BatchSamplers.NO_DUPLICATES,
|
||
"optim": config.get("optim", "adamw_8bit"),
|
||
"weight_decay": config.get("weight_decay", 0.001),
|
||
"seed": config.get("random_seed", 3407),
|
||
}
|
||
|
||
# max_steps vs epochs
|
||
if max_steps_val and max_steps_val > 0:
|
||
training_args_kwargs["max_steps"] = max_steps_val
|
||
else:
|
||
training_args_kwargs["num_train_epochs"] = num_epochs if num_epochs > 0 else 2
|
||
|
||
# warmup: prefer warmup_ratio (standard for embedding scripts), fallback to steps
|
||
if warmup_ratio is not None and warmup_ratio > 0:
|
||
training_args_kwargs["warmup_ratio"] = warmup_ratio
|
||
elif warmup_steps_val is not None and warmup_steps_val > 0:
|
||
training_args_kwargs["warmup_steps"] = warmup_steps_val
|
||
|
||
# save_steps
|
||
if save_steps_val and save_steps_val > 0:
|
||
training_args_kwargs["save_steps"] = save_steps_val
|
||
training_args_kwargs["save_strategy"] = "steps"
|
||
|
||
args = SentenceTransformerTrainingArguments(**training_args_kwargs)
|
||
|
||
# ── 7. Calculate total steps for progress tracking ──
|
||
if max_steps_val and max_steps_val > 0:
|
||
total_steps = max_steps_val
|
||
else:
|
||
effective_epochs = num_epochs if num_epochs > 0 else 2
|
||
len_dataloader = math.ceil(len(dataset) / batch_size)
|
||
steps_per_epoch = max(len_dataloader // gradient_accumulation_steps, 1)
|
||
total_steps = steps_per_epoch * effective_epochs
|
||
|
||
# ── 8. Create progress callback ──
|
||
class _EmbeddingProgressCallback(TrainerCallback):
|
||
"""Sends training progress events to the parent process via event_queue."""
|
||
|
||
def on_log(self, args, state, control, logs = None, **kwargs):
|
||
if not logs:
|
||
return
|
||
loss_value = logs.get("loss", logs.get("train_loss", None))
|
||
current_step = state.global_step
|
||
|
||
elapsed = time.time() - training_start_time
|
||
eta = None
|
||
if current_step > 0 and total_steps > 0:
|
||
remaining = total_steps - current_step
|
||
if remaining > 0:
|
||
eta = (elapsed / current_step) * remaining
|
||
|
||
event_queue.put(
|
||
{
|
||
"type": "progress",
|
||
"step": current_step,
|
||
"epoch": round(state.epoch, 2) if state.epoch else 0,
|
||
"loss": loss_value,
|
||
"learning_rate": logs.get("learning_rate", None),
|
||
"total_steps": total_steps,
|
||
"elapsed_seconds": elapsed,
|
||
"eta_seconds": eta,
|
||
"grad_norm": logs.get("grad_norm"),
|
||
"num_tokens": getattr(state, "num_input_tokens_seen", None),
|
||
"eval_loss": logs.get("eval_loss"),
|
||
"status_message": "",
|
||
"ts": time.time(),
|
||
}
|
||
)
|
||
|
||
def on_step_end(self, args, state, control, **kwargs):
|
||
if _should_stop:
|
||
logger.info("Embedding training: stop at step %d", state.global_step)
|
||
control.should_training_stop = True
|
||
return control
|
||
|
||
# ── 9. Create trainer and train ──
|
||
_send_status(event_queue, "Starting embedding training...")
|
||
try:
|
||
trainer = SentenceTransformerTrainer(
|
||
model = model,
|
||
train_dataset = dataset,
|
||
loss = loss,
|
||
args = args,
|
||
callbacks = [_EmbeddingProgressCallback()],
|
||
)
|
||
|
||
trainer.train(resume_from_checkpoint = resume_from_checkpoint)
|
||
except Exception as e:
|
||
event_queue.put(
|
||
{
|
||
"type": "error",
|
||
"error": f"Embedding training failed: {e}",
|
||
"stack": traceback.format_exc(limit = 20),
|
||
"ts": time.time(),
|
||
}
|
||
)
|
||
return
|
||
|
||
# ── 10. Save model ──
|
||
if _should_stop and not _save_on_stop:
|
||
event_queue.put(
|
||
{
|
||
"type": "complete",
|
||
"output_dir": None,
|
||
"status_message": "Training cancelled",
|
||
"ts": time.time(),
|
||
}
|
||
)
|
||
return
|
||
|
||
_send_status(event_queue, "Saving model...")
|
||
try:
|
||
if _should_stop and _save_on_stop:
|
||
trainer._save_checkpoint(trainer.model, trial = None)
|
||
model.save_pretrained(output_dir)
|
||
model.tokenizer.save_pretrained(output_dir)
|
||
logger.info("Embedding model saved to %s", output_dir)
|
||
except Exception as e:
|
||
logger.error("Failed to save embedding model: %s", e)
|
||
event_queue.put(
|
||
{
|
||
"type": "error",
|
||
"error": f"Training completed but failed to save: {e}",
|
||
"stack": traceback.format_exc(limit = 20),
|
||
"ts": time.time(),
|
||
}
|
||
)
|
||
return
|
||
|
||
# ── 11. Done ──
|
||
event_queue.put(
|
||
{
|
||
"type": "complete",
|
||
"output_dir": output_dir,
|
||
"status_message": "Embedding training completed",
|
||
"ts": time.time(),
|
||
}
|
||
)
|