Commit graph

4,536 commits

Author SHA1 Message Date
Roland Tannous
678d560042 Merge remote-tracking branch 'something/feature/merge-build-main' into test-branch-some-work 2026-03-12 20:03:50 +00:00
Roland Tannous
4332c2d986 Revert "Studio (#4237)"
This reverts commit 3e1469a55a.
2026-03-12 20:01:49 +00:00
Roland Tannous
985d2e43ee Final cleanup 2026-03-12 18:28:04 +00:00
Roland Tannous
3dfa503da6
Delete studio/frontend/README.md 2026-03-12 22:20:34 +04:00
Roland Tannous
82c5a572bf
Delete studio/frontend/AGENTS.md 2026-03-12 22:20:23 +04:00
Roland Tannous
7e336049d8 Update license headers 2026-03-12 17:23:10 +00:00
Roland Tannous
810820362d
Update llm_assist.py 2026-03-12 21:06:04 +04:00
Roland Tannous
bdadc87857
Update llm_assist.py 2026-03-12 20:32:04 +04:00
Roland Tannous
c2ca1ab054
Update run.py 2026-03-12 19:28:48 +04:00
Roland Tannous
d12f88bb3b
Update run.py 2026-03-12 18:53:19 +04:00
Roland Tannous
37a072bc35
Update run.py 2026-03-12 18:30:00 +04:00
Roland Tannous
b051900282
Update studio.py 2026-03-12 18:13:56 +04:00
Roland Tannous
a28ce64289
Update install_python_stack.py 2026-03-12 18:06:37 +04:00
Roland Tannous
83ef9816a1
Update run.py 2026-03-12 18:01:14 +04:00
Roland Tannous
17029818f1
Update studio.py 2026-03-12 17:30:10 +04:00
Roland Tannous
1c86db7d15
Update studio.py 2026-03-12 17:28:08 +04:00
Roland Tannous
90e7c15748
Update setup.ps1 2026-03-12 17:11:20 +04:00
Roland Tannous
e8f8cb16cd Remove AGENTS.md from frontend folder 2026-03-12 12:00:42 +00:00
Roland Tannous
b3b3f06aa6 Remove README.md from frontend folder 2026-03-12 11:59:56 +00:00
Daniel Han
12f8525bc6
Cache packed sequence metadata to reduce D2H syncs across layers (#4243)
* packing optimziation with cache to reduce D2H copy

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* cache per device to avoid race condition for multi-gpu

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* add cache freeing up func

---------

Co-authored-by: ruixiangw <ruixiangw@nvidia.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: ruixiang <wangruixiang07@outlook.com>
2026-03-12 03:37:49 -07:00
Daniel Han
3e1469a55a
Studio (#4237)
* Rebuild Studio branch on top of main

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Fix security and code quality issues for Studio PR #4237

- Validate models_dir query param against allowed directory roots
  to prevent path traversal in /api/models/local endpoint
- Replace string startswith() with Path.is_relative_to() for
  frontend path traversal check in serve_frontend
- Sanitize SSE error messages to not leak exception details to
  clients (4 locations in inference.py)
- Bind port-discovery socket to 127.0.0.1 instead of all interfaces
  in llama_cpp backend
- Import datasets_root and resolve_output_dir in embedding training
  function to fix NameError and use managed output directory
- Remove stale .gitignore entries for package-lock.json and test
  directories so tests can be tracked in version control
- Add venv-reexecution logic to ui CLI command matching the studio
  command behavior

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Move models_dir path validation before try/except block

The HTTPException(403) was inside the try/except Exception handler,
so it would be caught and re-raised as a 500. Moving the validation
before the try block ensures the 403 is returned directly and also
makes the control flow clearer for static analysis (path is validated
before any filesystem operations).

* Use os.path.realpath + startswith for models_dir validation

CodeQL py/path-injection does not recognize Path.is_relative_to() as
a sanitizer. Switched to os.path.realpath + str.startswith which is
a recognized sanitizer pattern in CodeQL's taint analysis. The
startswith check uses root_str + os.sep to prevent prefix collisions
(e.g. /app/models_evil matching /app/models).

* Never pass user input to Path constructor in models_dir validation

CodeQL traces taint through Path(resolved) even after a startswith
barrier guard. Fix: the user-supplied models_dir is only used as a
string for comparison against allowed roots. The Path object passed
to _scan_models_dir comes from the trusted allowed_roots list, not
from user input. This fully breaks the taint chain.

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2026-03-12 03:36:19 -07:00
Roland Tannous
ba14ed3a10 Update setup.ps1 2026-03-12 02:44:25 +04:00
Roland Tannous
514c88c337 Update setup.sh 2026-03-12 02:42:43 +04:00
Roland Tannous
388187024c resolved conflicts 2026-03-11 20:58:25 +00:00
Roland Tannous
50dd169367 Merge branch 'fix/pre-merge-cleanup' into feature/merge-build-final 2026-03-11 20:56:49 +00:00
Roland Tannous
ca1f260511 refactor: remove project_root passing, use self-resolved paths and ~/.unsloth/studio
- Workers now compute backend_path and venv_t5 locally via Path(__file__)
- Moved .venv_t5 to ~/.unsloth/studio/.venv_t5
- Added ensure_studio_directories() call on server startup
- Expanded CLI studio command into sub-app with setup subcommand
2026-03-11 20:32:18 +00:00
Manan17
6fb209c045 shifting setup & co inside studio 2026-03-11 20:19:52 +00:00
Shine1i
ad538c3f83 feat(studio): add auth-specific paths and integrate auth database location 2026-03-11 20:19:52 +00:00
Shine1i
2786fd2ec1 fix(studio): update temporary directory path to use system temp dir 2026-03-11 20:19:52 +00:00
Shine1i
f002ac59fd feat(studio): studio storage roots path utilities 2026-03-11 20:19:52 +00:00
Roland Tannous
aa6521859e resolved format_conversion conflict 2026-03-11 19:53:53 +00:00
Roland Tannous
1c87a4400c fix: prefer tabular files over archives in Tier 1 dataset preview
Tier 1 check-format was picking images.zip over testmini.parquet,
causing wrong columns (image/label) and broken VLM mapping.
Also log first VLM conversion failure instead of swallowing silently.
2026-03-11 19:13:11 +00:00
Roland Tannous
15a057b577 updated on completion response markers for qwen3.5 2026-03-11 19:00:29 +00:00
Roland Tannous
b5ed4fd316 add fmpeg system support for linux and windows 2026-03-11 18:50:11 +00:00
Roland Tannous
b64613990a Remove test_llama_cpp.ps1 2026-03-11 18:18:19 +00:00
Roland Tannous
d511e7a0cd Remove test_llama_cpp.ps1 from tracking 2026-03-11 18:10:25 +00:00
Roland Tannous
0d3cf1a82e Merge pull request #375 from unslothai/feature/llm-assist-detection
Feature/llm assist detection
2026-03-11 22:02:33 +04:00
Roland Tannous
ed31a4a107 chore: merge nightly & update dataset preview dialog mapping text 2026-03-11 17:00:14 +00:00
Roland Tannous
6ab9e0025c feat: target AI Assist mapping prompts for audio & embedding models 2026-03-11 16:55:43 +00:00
Roland Tannous
4d120dc8b1 Merge remote-tracking branch 'origin/nightly' into feature/llm-assist-detection 2026-03-11 16:23:09 +00:00
Roland Tannous
949ab44103 Merge pull request #374 from unslothai/fix/model-caching-issues
Fix: Normalize HuggingFace model identifiers to lowercase
2026-03-11 18:40:26 +04:00
Roland Tannous
3b3ee40475 fix: lowercase remote Hugging Face model IDs in ModelConfig and routes to prevent caching mismatches with Unsloth 2026-03-11 14:20:25 +00:00
Roland Tannous
e0b170a8d2 Merge pull request #372 from unslothai/fix/input-focus-clipping
Input focus outline clipped by container
2026-03-11 18:12:04 +04:00
Roland Tannous
6bef024806 Merge pull request #373 from unslothai/feature/structlog-logging-system
feat: integrate structlog, configure workers for prod logging, and mi…
2026-03-11 16:52:49 +04:00
Roland Tannous
5b325ebc6e feat: integrate structlog, configure workers for prod logging, and migrate print statements 2026-03-11 12:33:16 +00:00
imagineer99
d37cea9ffd fix: scope overflow-visible to studio collapsibles 2026-03-11 11:26:43 +00:00
imagineer99
4d0a652977 fix: input focus outline clipping 2026-03-11 11:11:57 +00:00
Roland Tannous
cbef97b9f2 Merge pull request #367 from unslothai/fix/yaml-syntax
Modified to fix the yaml syntax for unsloth_Qwen3-14B-Base-unsloth-bnb-4bit
2026-03-11 13:39:48 +04:00
Roland Tannous
763ff9cac5 Merge pull request #369 from unslothai/fix/model-mappping-syntax
fixed string concatenation in model mapping
2026-03-11 12:39:13 +04:00
Samit
69c88d4971 fixed string concatenation in model mapping 2026-03-11 00:07:26 -07:00