ceos/unsloth
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Revert "Setting default for the train on responses only"

Browse source 
This reverts commit 982a855df7.
This commit is contained in:
Roland Tannous 2026-02-19 09:55:21 +04:00
commit 9f1caa1ceb
1 changed files with 6 additions and 35 deletions
Download patch file Download diff file Expand all files Collapse all files

41
studio/frontend/src/features/training/stores/training-config-store.ts
View file

@ -102,21 +102,8 @@ export const useTrainingConfigStore = create<TrainingConfigStore>()(
if (controller.signal.aborted) return;
if (get().selectedModel !== modelName) return;
const patch = mapBackendModelConfigToTrainingPatch(modelDetails.config);
// train_on_responses_only: true for LLMs, true for VLM+text dataset, false for VLM+vision dataset
if (!modelDetails.is_vision) {
patch.trainOnCompletions = true;
} else {
const datasetMultimodal = get().isDatasetMultimodal;
if (datasetMultimodal !== null) {
patch.trainOnCompletions = !datasetMultimodal;
}
// if dataset not yet checked, leave YAML default
}
set({
...patch,
...mapBackendModelConfigToTrainingPatch(modelDetails.config),
isVisionModel: modelDetails.is_vision,
isLoadingModelDefaults: false,
isCheckingVision: false,
@ -140,20 +127,10 @@ export const useTrainingConfigStore = create<TrainingConfigStore>()(
void checkVisionModel(modelName)
.then((isVision) => {
if (get().selectedModel !== modelName) return;
const updates: Record<string, unknown> = {
set({
isVisionModel: isVision,
isCheckingVision: false,
};
// train_on_responses_only default
if (!isVision) {
updates.trainOnCompletions = true;
} else {
const datasetMultimodal = get().isDatasetMultimodal;
if (datasetMultimodal !== null) {
updates.trainOnCompletions = !datasetMultimodal;
}
}
set(updates as Partial<TrainingConfigState>);
});
})
.catch(() => {
if (get().selectedModel !== modelName) return;
@ -268,16 +245,10 @@ export const useTrainingConfigStore = create<TrainingConfigStore>()(
})
.then((res) => {
if (controller.signal.aborted) return;
const isMultimodal = !!res.is_multimodal;
const updates: Record<string, unknown> = {
isDatasetMultimodal: isMultimodal,
set({
isDatasetMultimodal: !!res.is_multimodal,
isCheckingDataset: false,
};
// train_on_responses_only: for VLMs, true if text dataset, false if vision dataset
if (get().isVisionModel) {
updates.trainOnCompletions = !isMultimodal;
}
set(updates as Partial<TrainingConfigState>);
});
})
.catch(() => {
if (controller.signal.aborted) return;