From 9f1caa1ceb03765e29888a04dd8e48cc1df80411 Mon Sep 17 00:00:00 2001 From: Roland Tannous <115670425+rolandtannous@users.noreply.github.com> Date: Thu, 19 Feb 2026 09:55:21 +0400 Subject: [PATCH] Revert "Setting default for the train on responses only" This reverts commit 982a855df77d41e5f4bdc2227be4330ccaf90baa. --- .../training/stores/training-config-store.ts | 41 +++---------------- 1 file changed, 6 insertions(+), 35 deletions(-) diff --git a/studio/frontend/src/features/training/stores/training-config-store.ts b/studio/frontend/src/features/training/stores/training-config-store.ts index 260625db0d..b98d2a3c7f 100644 --- a/studio/frontend/src/features/training/stores/training-config-store.ts +++ b/studio/frontend/src/features/training/stores/training-config-store.ts @@ -102,21 +102,8 @@ export const useTrainingConfigStore = create()( if (controller.signal.aborted) return; if (get().selectedModel !== modelName) return; - const patch = mapBackendModelConfigToTrainingPatch(modelDetails.config); - - // train_on_responses_only: true for LLMs, true for VLM+text dataset, false for VLM+vision dataset - if (!modelDetails.is_vision) { - patch.trainOnCompletions = true; - } else { - const datasetMultimodal = get().isDatasetMultimodal; - if (datasetMultimodal !== null) { - patch.trainOnCompletions = !datasetMultimodal; - } - // if dataset not yet checked, leave YAML default - } - set({ - ...patch, + ...mapBackendModelConfigToTrainingPatch(modelDetails.config), isVisionModel: modelDetails.is_vision, isLoadingModelDefaults: false, isCheckingVision: false, @@ -140,20 +127,10 @@ export const useTrainingConfigStore = create()( void checkVisionModel(modelName) .then((isVision) => { if (get().selectedModel !== modelName) return; - const updates: Record = { + set({ isVisionModel: isVision, isCheckingVision: false, - }; - // train_on_responses_only default - if (!isVision) { - updates.trainOnCompletions = true; - } else { - const datasetMultimodal = get().isDatasetMultimodal; - if (datasetMultimodal !== null) { - updates.trainOnCompletions = !datasetMultimodal; - } - } - set(updates as Partial); + }); }) .catch(() => { if (get().selectedModel !== modelName) return; @@ -268,16 +245,10 @@ export const useTrainingConfigStore = create()( }) .then((res) => { if (controller.signal.aborted) return; - const isMultimodal = !!res.is_multimodal; - const updates: Record = { - isDatasetMultimodal: isMultimodal, + set({ + isDatasetMultimodal: !!res.is_multimodal, isCheckingDataset: false, - }; - // train_on_responses_only: for VLMs, true if text dataset, false if vision dataset - if (get().isVisionModel) { - updates.trainOnCompletions = !isMultimodal; - } - set(updates as Partial); + }); }) .catch(() => { if (controller.signal.aborted) return;