agama/doc/ui/guidelines/url-state.md
David Díaz González 71754dd395
doc(web): warn that a search param update is a navigation
Everything watching navigations sees it, blockers included, and React
Router consults them on every navigation with no exemption for an
unchanged path. A blocker written as "stop the user while this form is
dirty" would fire while the user sorts a table or types in a filter, and
would cancel the update along the way.

Pages keep their view in the address now, so this is worth stating before
the first blocker is written rather than after.
2026-08-03 15:09:56 +01:00

9.2 KiB

URL as UI state

How a page is being looked at belongs in the address bar: which sections are expanded, which tab is open, how a table is filtered or sorted.

The hooks that implement this live in web/src/hooks/use-search-param-state.ts, plus web/src/hooks/use-filter-params.ts for the filters of a table. This page is about when to reach for them, and how to keep the resulting URLs sane.

Core principle

A page has a state that describes its view. That state is not a private detail of a component; it is part of what the user is looking at. Keeping it in the URL gives three things for free:

  • Reloading lands on the same view.
  • Going back returns to it.
  • The link someone copies shows what they were looking at.

None of those work when the same state sits in a component, a context or a module store, however carefully written.

What belongs there, and what does not

Ask what the value describes.

The value describes Where it lives Why
How the page is being viewed: expanded sections, active tab, filters, sort order URL search params Shareable, survives reload, restores on back
A transient interaction: an open menu, a hovered row, a half-typed search Component state, until it settles Nobody wants a link to a half-open dropdown, and every keystroke would be an update
Something the server knows: the proposal, the list of devices, whether the user is logged in TanStack Query It has to be fetched, cached and invalidated
One app-wide setting outside React: color scheme, terminal visibility A module store It belongs to no page, and applies before rendering
Which entity a page is about: a device index, a mount path Path params (useParams) It identifies the page, not the view of it

The second row is about when, not whether. A search still being typed is an unfinished action, so it stays local while the keys keep coming, and describes the view as soon as it settles. ?name=eth is a link worth having; ?name=e rewritten three times a second is not. useFilterParams draws that line for filters, so a table gets both halves without deciding anything.

The last row is the distinction worth being careful about. Both live in the URL, but /storage/drives/0 says which page and ?expanded=d0 says how it looks. Only the second belongs to the hooks described here.

Choosing a hook

// One value: a tab, a sort column, a single answer of any kind.
const [tab, setTab] = useSearchParamState(SETTINGS_TAB, "0");

// A set of on/off values packed into one param: expanded sections.
const { hasSearchParamToken, toggleSearchParamToken } = useSearchParamTokens(EXPANDED);

// Dropping several params at once, for a reset action.
const clearSearchParams = useClearSearchParams();

// Every filter of a table at once, which is what a table wants.
const { filters, setFilter, resetFilters, hasActiveFilters } = useFilterParams({
  name: textFilter(),
  status: choiceFilter(["active", "offline"]),
});

Prefer useSearchParamTokens over one param per item. Fifteen expandable sections should produce ?expanded=d0,d2, not fifteen params with most of them absent.

Reach for useFilterParams for anything a table filters by, rather than one useSearchParamState per filter. It handles what a table would otherwise have to remember on its own: typed text waits for a pause, resetting drops every param in one update along with any keystroke still waiting, a value the filter does not offer reads as the default, and a filter at its default writes no param at all.

Rules

Each page owns its vocabulary

The hooks know nothing about any page. Param names and token derivations belong to the area that uses them, gathered in one module so they are easy to find and hard to mistype. The storage pages keep theirs in web/src/components/storage/ui-state-params.ts.

Never spell a param name inline at a call site. Two components sharing a section need the same string, and a typo produces a silently separate piece of state.

Name a param after what it holds

?status=offline&minChannel=0.0.0150 says what it does. Someone can read it in a bug report, guess what to change, and change it. Since an unrecognized value falls back to the default rather than breaking the page, that guessing is safe, which is what makes the readable name worth its characters.

Filters get this for free: useFilterParams uses the name of the filter as the name of the param, so there is nothing to declare and no way for two filters to collide.

The exception is a param holding a composed value nobody is meant to write by hand, such as the sorting (?sortBy=channel:desc) or a set of tokens (?expanded=d0,d2). Keep those short-ish and let the constant next to the call carry the meaning.

Never clear several params one by one

Each setter starts from the params of the render that created it, so two calls in the same handler fight and the second undoes the first. Use useClearSearchParams, which performs a single update.

// Wrong: only the last one survives.
setExpanded(undefined);
setTab(undefined);

// Right.
clearSearchParams(EXPANDED, SETTINGS_TAB);

Let a default mean nothing at all

Writing ?status=all adds noise and no information, so setting a value equal to the default removes the param instead. A view then has one address rather than two. Reading is untouched: an address that spells a default out is left as it was found, since nothing rewrites the URL until a control moves.

Debounce free text

Every write is a router update. Fine for a click on a section, wrong for a text filter, where it would run on each keystroke and turn the back button into an undo for letters. useFilterParams already does this; anywhere else, keep the input on local state and push the param when the user pauses.

A value being typed has to stay local until the address actually holds it. Router updates apply asynchronously, so releasing it when the write is requested leaves a render showing neither the typed value nor the stored one.

Treat a param update as the navigation it is

setSearchParams is navigate("?" + params) underneath, so writing a param goes through the router like any other navigation. Everything watching navigations sees it, whether or not the page changed.

This matters most for navigation blockers. React Router consults the blocker on every navigation, with no exemption for an unchanged path or a search-only change, so a blocker written as "stop the user while this form is dirty" fires when they sort a table or expand a section, and cancels the update as well, which means the view silently fails to reach the address.

A blocker guards leaving, and leaving means the path changes:

// Wrong: fires while the user filters a table on the page they are already on.
useBlocker(() => isDirty);

// Right.
useBlocker(
  ({ currentLocation, nextLocation }) =>
    isDirty && currentLocation.pathname !== nextLocation.pathname,
);

Anything else reacting to navigations (analytics, scroll handling, guards of any kind) needs the same question asked of it: does it mean the page changed, or something navigated?

Nothing sensitive, nothing large

The address is visible on screen, and it might end up shared or attached to a bug report. It holds short identifiers of view state, not credentials and not serialized objects.

Why the function names are long

hasSearchParamToken("d0") rather than has("d0"), because a call site read on its own should say where the state lives. It also removes a real ambiguity: a shorter hasSearchParam("d0") reads as a question about a param named d0, which is not what it answers.

"Search param" is the term used by the platform (URLSearchParams) and by React Router (useSearchParams). It also keeps these apart from path params, which this codebase reads with useParams.

Writes never disturb the page

Every update replaces the current history entry and keeps the scroll position. So back and forward step between pages rather than between individual clicks, and expanding a section halfway down a long page leaves the reader where they were.

This is deliberate and load-bearing: an earlier attempt at URL-backed UI state was abandoned because each update sent the content back to the top.

Testing

Both hooks need router context, which installerRender already provides. mockRoutes sets the starting URL, so a test can render a component as if someone had arrived through a link:

mockRoutes("/storage?expanded=d0");
installerRender(<PartitionsSection collection="drives" index={0} />);

This is the useful part for coverage: state in the URL makes deep links possible, and deep links make that state reachable in a test without clicking through the interface first. Prefer asserting what the user sees over asserting the URL, except where the URL is the subject.

Reach for createMemoryRouter only if a test genuinely needs a data router, for route loader or shouldRevalidate behavior. It cannot share a file with test-utils, whose module-wide react-router mock replaces Outlet and friends, so such a test has to import the router itself.

Known limits

These updates leave the scroll position alone, but nothing restores it when returning to a page from somewhere else. That needs a separate mechanism, which does not exist yet.