mirror of
https://github.com/pewdiepie-archdaemon/odysseus.git
synced 2026-08-27 11:20:42 +02:00
b2789d04fb* fix: stop polling GET /api/tasks/runs/recent from cancelling running tasks Two paths caused the scheduler to interrupt a running background task when the frontend Activity view polled for status: 1. GET /api/tasks/runs/recent was not in _PASSIVE_EXACT_PATHS, so _InteractiveActivityMiddleware treated it as a foreground request and called stop_background_tasks_for_foreground, cancelling any in-flight scheduled task. Add it to _PASSIVE_EXACT_PATHS alongside the other read-only polling endpoints. 2. The /api/activity/heartbeat handler called stop_background_tasks_for_foreground unconditionally, ignoring BACKGROUND_TASK_FOREGROUND_GATE=false. Wrap the call in a _gate_enabled() guard so the env var fully disables heartbeat- triggered cancellations. Fixes #5782 Signed-off-by: Christian Sidak <christian@sentineltech.eu> Signed-off-by: Christian-Sidak <61099993+Christian-Sidak@users.noreply.github.com> * fix(scheduler): respect foreground gate for heartbeat --------- Signed-off-by: Christian Sidak <christian@sentineltech.eu> Signed-off-by: Christian-Sidak <61099993+Christian-Sidak@users.noreply.github.com> Co-authored-by: Alexandre Teixeira <alexandremagteixeira@gmail.com>
66 lines
1.6 KiB
Python
66 lines
1.6 KiB
Python
"""Regression tests for polling endpoints and foreground task interruption."""
|
|
|
|
import asyncio
|
|
import importlib
|
|
|
|
|
|
def _reload_gate():
|
|
import src.interactive_gate as ig
|
|
|
|
importlib.reload(ig)
|
|
return ig
|
|
|
|
|
|
def test_tasks_runs_recent_is_passive():
|
|
ig = _reload_gate()
|
|
|
|
assert not ig.should_track_interactive_request(
|
|
"/api/tasks/runs/recent", "GET"
|
|
)
|
|
|
|
|
|
def test_tasks_runs_recent_does_not_affect_other_task_paths():
|
|
ig = _reload_gate()
|
|
|
|
# A neighboring mutating path must remain interactive.
|
|
assert ig.should_track_interactive_request(
|
|
"/api/tasks/runs/recent/something", "POST"
|
|
)
|
|
|
|
|
|
def test_heartbeat_does_not_stop_background_tasks_when_gate_disabled(monkeypatch):
|
|
ig = _reload_gate()
|
|
monkeypatch.setenv("BACKGROUND_TASK_FOREGROUND_GATE", "false")
|
|
|
|
stop_calls = []
|
|
|
|
async def fake_stop_background_tasks_for_foreground(*, reason):
|
|
stop_calls.append(reason)
|
|
|
|
result = asyncio.run(
|
|
ig.maybe_stop_background_tasks_for_heartbeat(
|
|
fake_stop_background_tasks_for_foreground
|
|
)
|
|
)
|
|
|
|
assert result is False
|
|
assert stop_calls == []
|
|
|
|
|
|
def test_heartbeat_stops_background_tasks_when_gate_enabled(monkeypatch):
|
|
ig = _reload_gate()
|
|
monkeypatch.delenv("BACKGROUND_TASK_FOREGROUND_GATE", raising=False)
|
|
|
|
stop_calls = []
|
|
|
|
async def fake_stop_background_tasks_for_foreground(*, reason):
|
|
stop_calls.append(reason)
|
|
|
|
result = asyncio.run(
|
|
ig.maybe_stop_background_tasks_for_heartbeat(
|
|
fake_stop_background_tasks_for_foreground
|
|
)
|
|
)
|
|
|
|
assert result is True
|
|
assert stop_calls == ["browser heartbeat"]
|