61a9719d7a
permissions:
- All five PR-time workflows (backend, frontend, inference smoke, tauri,
wheel) now declare permissions: contents: read at the workflow level,
matching CodeQL's default-permissions guidance and the existing pattern
in release-desktop.yml. None of these workflows write to the repo.
skipped tests:
- Repo tests (CPU) job now installs node 22 and uv, which unblocks
~60 tests that were silently skipping on CI:
- 9 tests in tests/studio/test_chat_preset_builtin_invariants.py
skipped on "node not available". Fixed in this commit; an obsolete
"unsloth_repo/" prefix in WORKDIR was also pointing the source-file
existence check at a path that no longer exists.
- tests/python/test_e2e_no_torch_sandbox.py (47), test_studio_import_no_torch.py
(29), test_tokenizers_and_torch_constraint.py (most of 42) all spawn
fresh uv venvs and self-skip when uv is missing.
- Three test_tokenizers_and_torch_constraint.py cases are deselected
because they expose a real bug in studio/backend/requirements/no-torch-runtime.txt:
the unpinned tokenizers line resolves to 0.23.1, which transformers
rejects with "tokenizers>=0.22.0,<=0.23.0 is required". Tracked
separately as a no-torch install regression.
Locally: 760 passed, 1 skipped, 23 deselected (was 694 / 67 / 23).
111 lines
4 KiB
YAML
111 lines
4 KiB
YAML
# SPDX-License-Identifier: AGPL-3.0-only
|
|
# Copyright 2026-present the Unsloth AI Inc. team. All rights reserved.
|
|
|
|
# Frontend PR gate: lockfile freshness, typecheck, build, and a bundle grep
|
|
# that catches the 2026.5.1 chat-history regression at the JS level.
|
|
#
|
|
# biome runs as non-blocking for now: the codebase currently has accumulated
|
|
# ~470 errors and ~1650 warnings against the existing biome config. Surfacing
|
|
# the count in CI lets us drive it down without forcing a fleet-wide cleanup
|
|
# in the same PR. Drop `continue-on-error` once that number is zero.
|
|
|
|
name: Frontend CI
|
|
|
|
on:
|
|
pull_request:
|
|
paths:
|
|
- 'studio/frontend/**'
|
|
- '.github/workflows/studio-frontend-ci.yml'
|
|
push:
|
|
branches: [main, pip]
|
|
|
|
concurrency:
|
|
group: ${{ github.workflow }}-${{ github.ref }}
|
|
cancel-in-progress: true
|
|
|
|
permissions:
|
|
contents: read
|
|
|
|
jobs:
|
|
build:
|
|
name: Frontend build + bundle sanity
|
|
runs-on: ubuntu-latest
|
|
timeout-minutes: 10
|
|
defaults:
|
|
run:
|
|
working-directory: studio/frontend
|
|
steps:
|
|
- uses: actions/checkout@v4
|
|
|
|
# FIXME: drop this step once @assistant-ui/* and assistant-stream
|
|
# leave 0.x -- on 1.x, caret ranges are conventional. Until then,
|
|
# every 0.minor on this surface is a SemVer-major (this is exactly
|
|
# how 2026.5.1 shipped a broken chat runtime: ^0.12.19 quietly
|
|
# resolved to 0.12.28).
|
|
- name: '@assistant-ui must be pinned exactly (no caret/tilde)'
|
|
working-directory: ${{ github.workspace }}
|
|
run: |
|
|
set -e
|
|
if grep -nE '"(@assistant-ui/[a-z-]+|assistant-stream)":[[:space:]]*"[\^~]' studio/frontend/package.json; then
|
|
echo "::error file=studio/frontend/package.json::These packages must be pinned to exact versions until they leave 0.x. Drop the leading ^ or ~."
|
|
exit 1
|
|
fi
|
|
echo "All assistant-ui packages are pinned exactly."
|
|
|
|
- uses: actions/setup-node@v4
|
|
with:
|
|
node-version: '22'
|
|
cache: 'npm'
|
|
cache-dependency-path: studio/frontend/package-lock.json
|
|
|
|
- name: Lockfile must agree with package.json (npm ci is strict)
|
|
run: npm ci --no-fund --no-audit
|
|
|
|
- name: npm ci must not have modified the working tree
|
|
working-directory: ${{ github.workspace }}
|
|
run: |
|
|
if ! git diff --quiet -- studio/frontend; then
|
|
echo "::error::npm ci modified files; commit the updated lockfile"
|
|
git status -- studio/frontend
|
|
exit 1
|
|
fi
|
|
|
|
- name: Typecheck
|
|
run: npm run typecheck
|
|
|
|
- name: Build
|
|
run: npm run build
|
|
|
|
- name: Built bundle must not contain Studio's unstable_Provider call site
|
|
run: |
|
|
set -e
|
|
JS=$(ls dist/assets/index-*.js | head -1)
|
|
HITS=$(grep -c 'unstable_Provider:' "$JS" || echo 0)
|
|
echo "main bundle: $JS"
|
|
echo "unstable_Provider: hits=$HITS (assistant-ui internals contribute up to 3)"
|
|
if [ "$HITS" -gt 3 ]; then
|
|
echo "::error file=studio/frontend/src/features/chat/runtime-provider.tsx::Studio bundle still passes unstable_Provider through useRemoteThreadListRuntime; this is the 2026.5.1 chat-history regression. Pass adapters directly into useLocalRuntime instead."
|
|
exit 1
|
|
fi
|
|
|
|
- name: Bundle size budget (75 MB)
|
|
run: |
|
|
SIZE=$(du -sb dist | cut -f1)
|
|
BUDGET=$((75 * 1024 * 1024))
|
|
echo "dist size: $SIZE bytes ($((SIZE/1024/1024)) MB), budget: $BUDGET bytes (75 MB)"
|
|
if [ "$SIZE" -gt "$BUDGET" ]; then
|
|
echo "::error::studio/frontend/dist/ exceeded the 75 MB budget. Drop dead deps (e.g. the unused next dep) or split chunks."
|
|
exit 1
|
|
fi
|
|
|
|
- name: Biome (non-blocking until accumulated drift is cleared)
|
|
continue-on-error: true
|
|
run: npm run biome:check
|
|
|
|
- name: Upload built dist on failure
|
|
if: failure()
|
|
uses: actions/upload-artifact@v4
|
|
with:
|
|
name: studio-frontend-dist
|
|
path: studio/frontend/dist
|
|
retention-days: 3
|