unsloth/studio/src-tauri
Daniel Han 4f0cbf0d81
Desktop: ask before quitting on top of a running install (#7550)
* Desktop: ask before quitting on top of a running install

This is the trigger neither #7492 nor #7490 addresses -- both start from a venv
that is already broken. Confirmed: neither PR touches cleanup_child_processes.

Quitting runs cleanup_child_processes -> install::stop_install, which SIGTERMs the
installer's process group. In the reported session that landed at "5/10 studio
deps", so the venv kept the CLI's dependencies and lost the server stack, and the
next launch died on `import structlog`. Three minutes of installing, destroyed
with no warning and no way back.

So ask. Only from the tray Quit item -- a deliberate action with a UI present. The
RunEvent::Exit path (OS shutdown, SIGTERM) is left alone: it must never block on a
dialog nobody can answer. The call already runs off the menu callback thread,
which is also what blocking_show requires.

Closing the window was already safe (it hides to tray); this closes the remaining
way to lose an install by accident.

* Tighten comments in desktop quit-during-install guard

* Condense comments in quit-during-install guard

---------

Co-authored-by: danielhanchen <unslothai@gmail.com>
2026-07-28 18:52:00 -07:00
..
capabilities Add Unsloth desktop deep links (#7560) 2026-07-28 16:52:53 +02:00
icons Polish Studio desktop chrome (#6332) 2026-06-24 17:56:25 -07:00
linux Add Unsloth desktop deep links (#7560) 2026-07-28 16:52:53 +02:00
src Desktop: ask before quitting on top of a running install (#7550) 2026-07-28 18:52:00 -07:00
windows Windows installer: fix DiskPart UAC mid-install, drive-root cache, and spurious unsloth.exe rename warning (#6296) 2026-06-22 03:09:08 -07:00
build.rs Add tauri (#5144) 2026-04-23 04:50:10 -07:00
Cargo.lock Add Unsloth desktop deep links (#7560) 2026-07-28 16:52:53 +02:00
Cargo.toml Add Unsloth desktop deep links (#7560) 2026-07-28 16:52:53 +02:00
Entitlements.plist Fix Studio desktop reliability (#7255) 2026-07-21 09:51:18 +02:00
Info.plist Fix Studio desktop reliability (#7255) 2026-07-21 09:51:18 +02:00
tauri.conf.json Add Unsloth desktop deep links (#7560) 2026-07-28 16:52:53 +02:00
tauri.macos.conf.json Fix Studio desktop reliability (#7255) 2026-07-21 09:51:18 +02:00
tauri.windows.conf.json Fix Windows workflow issues(#5694) 2026-05-22 05:32:30 -07:00