4f0cbf0d81* Desktop: ask before quitting on top of a running install This is the trigger neither #7492 nor #7490 addresses -- both start from a venv that is already broken. Confirmed: neither PR touches cleanup_child_processes. Quitting runs cleanup_child_processes -> install::stop_install, which SIGTERMs the installer's process group. In the reported session that landed at "5/10 studio deps", so the venv kept the CLI's dependencies and lost the server stack, and the next launch died on `import structlog`. Three minutes of installing, destroyed with no warning and no way back. So ask. Only from the tray Quit item -- a deliberate action with a UI present. The RunEvent::Exit path (OS shutdown, SIGTERM) is left alone: it must never block on a dialog nobody can answer. The call already runs off the menu callback thread, which is also what blocking_show requires. Closing the window was already safe (it hides to tray); this closes the remaining way to lose an install by accident. * Tighten comments in desktop quit-during-install guard * Condense comments in quit-during-install guard --------- Co-authored-by: danielhanchen <unslothai@gmail.com> |
||
|---|---|---|
| .. | ||
| diagnostics | ||
| preflight | ||
| app_layout.rs | ||
| commands.rs | ||
| desktop_auth.rs | ||
| desktop_backend_owner.rs | ||
| desktop_update_policy.rs | ||
| install.rs | ||
| main.rs | ||
| native_backend_lease.rs | ||
| native_clipboard.rs | ||
| native_file_dialogs.rs | ||
| native_intents.rs | ||
| native_path_policy.rs | ||
| preflight.rs | ||
| process.rs | ||
| update.rs | ||
| windows_job.rs | ||