Two review fixes on the multi-GPU export path: 1. The LoRA-merge save path budgeted every merged tensor against GPU0 (get_device_properties(0) + unqualified memory_allocated()). A merged tensor lives on the GPU of its source layer, so for a model sharded across GPUs (the device_map="balanced" this PR enables) GPU1+ could OOM as their weights accumulated while only GPU0's headroom was checked. Budget against W's own device via a per-device cache; single-GPU behavior is unchanged (W on GPU0). 2. _offload_model_for_quantize_subprocess removed the accelerate hooks and then moved a dispatched model to CPU; if that move raised (host RAM too small for the sharded checkpoint) the model was left hookless and half-moved, breaking later exports in the same worker. It now re-dispatches (or, for the single-device path, moves back) on a failed move before aborting the offload.
215 lines
7.8 KiB
Python
215 lines
7.8 KiB
Python
# SPDX-License-Identifier: AGPL-3.0-only
|
|
# Copyright 2026-present the Unsloth AI Inc. team. All rights reserved.
|
|
|
|
"""The compressed (FP8/NVFP4) export must free GPU weights before its
|
|
llm-compressor subprocess loads a second copy from disk -- including for
|
|
accelerate-dispatched multi-GPU shards (e.g. Studio's multi-GPU export load),
|
|
which the old single-device-only ``.to("cpu")`` skipped, leaving every GPU
|
|
holding a full copy alongside the subprocess's.
|
|
|
|
Loads only the two release/restore helpers from unsloth/save.py via AST (the
|
|
module itself needs torch/transformers), and exercises them with fakes.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import ast
|
|
import sys
|
|
import types
|
|
from pathlib import Path
|
|
|
|
import pytest
|
|
|
|
_SAVE_PY = Path(__file__).resolve().parent.parent / "unsloth" / "save.py"
|
|
_WANTED = {
|
|
"_offload_model_for_quantize_subprocess",
|
|
"_restore_model_after_quantize_subprocess",
|
|
}
|
|
|
|
|
|
class _FakeLogger:
|
|
def __init__(self):
|
|
self.warnings = []
|
|
|
|
def warning_once(self, msg):
|
|
self.warnings.append(msg)
|
|
|
|
|
|
def _load_helpers(fake_torch, fake_logger):
|
|
tree = ast.parse(_SAVE_PY.read_text(encoding = "utf-8"))
|
|
keep = [
|
|
node for node in tree.body if isinstance(node, ast.FunctionDef) and node.name in _WANTED
|
|
]
|
|
assert len(keep) == len(_WANTED), "release helpers missing from save.py"
|
|
namespace = {"torch": fake_torch, "logger": fake_logger}
|
|
exec( # noqa: S102 - loading trusted repo source
|
|
compile(ast.Module(body = keep, type_ignores = []), str(_SAVE_PY), "exec"),
|
|
namespace,
|
|
)
|
|
return namespace
|
|
|
|
|
|
def _fake_torch(cuda_available = True):
|
|
t = types.ModuleType("torch")
|
|
t.cuda = types.SimpleNamespace(is_available = lambda: cuda_available)
|
|
return t
|
|
|
|
|
|
class _FakeModel:
|
|
def __init__(
|
|
self,
|
|
device_map = None,
|
|
devices = ("cuda:0",),
|
|
quantized = False,
|
|
):
|
|
if device_map is not None:
|
|
self.hf_device_map = device_map
|
|
self._devices = [types.SimpleNamespace(device = d) for d in devices]
|
|
self.moved_to = []
|
|
self.is_loaded_in_4bit = quantized
|
|
|
|
def parameters(self):
|
|
return iter(self._devices)
|
|
|
|
def to(self, target):
|
|
self.moved_to.append(str(target))
|
|
return self
|
|
|
|
|
|
@pytest.fixture
|
|
def _fake_accelerate(monkeypatch):
|
|
calls = {"removed": [], "dispatched": []}
|
|
accel = types.ModuleType("accelerate")
|
|
accel.dispatch_model = lambda model, device_map: calls["dispatched"].append(
|
|
(model, dict(device_map))
|
|
)
|
|
hooks = types.ModuleType("accelerate.hooks")
|
|
hooks.remove_hook_from_submodules = lambda model: calls["removed"].append(model)
|
|
accel.hooks = hooks
|
|
monkeypatch.setitem(sys.modules, "accelerate", accel)
|
|
monkeypatch.setitem(sys.modules, "accelerate.hooks", hooks)
|
|
return calls
|
|
|
|
|
|
def test_dispatched_multi_gpu_model_is_released_and_redispatched(_fake_accelerate):
|
|
ns = _load_helpers(_fake_torch(), _FakeLogger())
|
|
device_map = {"model.embed": 0, "model.layers.0": 0, "model.layers.1": 1}
|
|
model = _FakeModel(device_map = device_map, devices = ("cuda:0", "cuda:1"))
|
|
|
|
token = ns["_offload_model_for_quantize_subprocess"](model)
|
|
|
|
assert _fake_accelerate["removed"] == [model] # hooks removed before the move
|
|
assert model.moved_to == ["cpu"]
|
|
assert token == ("dispatch", device_map)
|
|
|
|
ns["_restore_model_after_quantize_subprocess"](model, token)
|
|
assert _fake_accelerate["dispatched"] == [(model, device_map)]
|
|
|
|
|
|
def test_dispatched_move_failure_redispatches_and_returns_none(_fake_accelerate):
|
|
# If .to("cpu") raises AFTER the accelerate hooks are removed, the model
|
|
# must be re-dispatched (not left hookless/half-moved) and offload aborts.
|
|
ns = _load_helpers(_fake_torch(), _FakeLogger())
|
|
device_map = {"model.embed": 0, "model.layers.1": 1}
|
|
|
|
class _MoveFails(_FakeModel):
|
|
def to(self, target):
|
|
raise RuntimeError("host RAM cannot hold the sharded model")
|
|
|
|
model = _MoveFails(device_map = device_map, devices = ("cuda:0", "cuda:1"))
|
|
token = ns["_offload_model_for_quantize_subprocess"](model)
|
|
assert token is None # offload aborted
|
|
assert _fake_accelerate["removed"] == [model] # hooks were removed...
|
|
assert _fake_accelerate["dispatched"] == [(model, device_map)] # ...then restored
|
|
|
|
|
|
def test_single_device_move_failure_restores_and_returns_none():
|
|
ns = _load_helpers(_fake_torch(), _FakeLogger())
|
|
|
|
class _MoveFails(_FakeModel):
|
|
def __init__(self):
|
|
super().__init__(devices = ("cuda:0",))
|
|
|
|
def to(self, target):
|
|
self.moved_to.append(str(target))
|
|
if target == "cpu":
|
|
raise RuntimeError("move failed")
|
|
return self
|
|
|
|
model = _MoveFails()
|
|
token = ns["_offload_model_for_quantize_subprocess"](model)
|
|
assert token is None
|
|
# attempted the cpu move, then restored back to the original device
|
|
assert model.moved_to == ["cpu", "cuda:0"]
|
|
|
|
|
|
def test_cpu_or_disk_offloaded_map_is_left_alone(_fake_accelerate):
|
|
# accelerate is already offloading part of the model; removing hooks and
|
|
# re-dispatching could thrash, so leave it untouched.
|
|
ns = _load_helpers(_fake_torch(), _FakeLogger())
|
|
model = _FakeModel(device_map = {"model.embed": 0, "model.layers.9": "cpu"})
|
|
assert ns["_offload_model_for_quantize_subprocess"](model) is None
|
|
assert model.moved_to == []
|
|
assert _fake_accelerate["removed"] == []
|
|
|
|
|
|
def test_single_device_model_keeps_plain_move():
|
|
ns = _load_helpers(_fake_torch(), _FakeLogger())
|
|
model = _FakeModel(devices = ("cuda:0",))
|
|
token = ns["_offload_model_for_quantize_subprocess"](model)
|
|
assert model.moved_to == ["cpu"]
|
|
assert token is not None and token[0] == "device"
|
|
|
|
ns["_restore_model_after_quantize_subprocess"](model, token)
|
|
assert model.moved_to[-1] == "cuda:0"
|
|
|
|
|
|
def test_quantized_model_is_never_moved():
|
|
ns = _load_helpers(_fake_torch(), _FakeLogger())
|
|
model = _FakeModel(devices = ("cuda:0",), quantized = True)
|
|
assert ns["_offload_model_for_quantize_subprocess"](model) is None
|
|
assert model.moved_to == []
|
|
|
|
|
|
def test_no_cuda_is_noop_and_restore_none_is_noop():
|
|
ns = _load_helpers(_fake_torch(cuda_available = False), _FakeLogger())
|
|
model = _FakeModel()
|
|
assert ns["_offload_model_for_quantize_subprocess"](model) is None
|
|
ns["_restore_model_after_quantize_subprocess"](model, None) # must not raise
|
|
assert model.moved_to == []
|
|
|
|
|
|
def test_restore_failure_warns_instead_of_raising(_fake_accelerate):
|
|
fake_logger = _FakeLogger()
|
|
ns = _load_helpers(_fake_torch(), fake_logger)
|
|
|
|
class _ExplodingModel(_FakeModel):
|
|
def to(self, target):
|
|
raise RuntimeError("device gone")
|
|
|
|
model = _ExplodingModel(devices = ("cuda:0",))
|
|
ns["_restore_model_after_quantize_subprocess"](model, ("device", "cuda:0"))
|
|
assert fake_logger.warnings # warned, did not raise
|
|
|
|
|
|
def test_lora_merge_budgets_per_device():
|
|
# A merged tensor W lives on the GPU of its source layer, so a model sharded
|
|
# across GPUs (device_map="balanced") must be budgeted against W's own
|
|
# device, not GPU0 -- otherwise GPU1+ can OOM while only GPU0 is checked
|
|
# (#7053). Pin the device-aware budget in the LoRA-merge save path.
|
|
src = _SAVE_PY.read_text(encoding = "utf-8")
|
|
tree = ast.parse(src)
|
|
fn = next(
|
|
(
|
|
n
|
|
for n in ast.walk(tree)
|
|
if isinstance(n, ast.FunctionDef) and n.name == "unsloth_save_model"
|
|
),
|
|
None,
|
|
)
|
|
assert fn is not None, "unsloth_save_model not found"
|
|
body = ast.get_source_segment(src, fn)
|
|
# Budget keyed on W's device, not a hardcoded device 0 / unqualified alloc.
|
|
assert "torch.cuda.memory_allocated(W.device)" in body
|
|
assert "_device_vram_budget(W.device)" in body
|
|
assert "get_device_properties(0).total_memory * maximum_memory_usage" not in body
|