unsloth/studio/frontend/src/shared
Michael Han 84d9d56062
studio/frontend: make toast and inline error text selectable and copyable (#5506)
* studio/frontend: make toast and inline error text selectable and copyable

Sonner toasts and the inline model-load error in the chat header were
showing copyable content (backend tracebacks, model-load failures, log
lines) that users could not actually select with the mouse.

Two underlying issues:

1. Sonner's swipe-to-dismiss handler calls `setPointerCapture` in
   `onPointerDown`, which preempts the browser's text-selection
   gesture. The capture only happens when `dismissible` is true. CSS
   alone cannot work around this.
2. The inline model-load error truncated with `text-overflow: ellipsis`
   and parked the full string in a native `title=` tooltip, which
   browsers render as an OS tooltip that cannot be selected.

Fixes:

- New `@/lib/toast` wrapper that defaults `dismissible: false` on every
  toast (callable plus `.success` / `.error` / `.info` / `.warning` /
  `.loading` / `.message` / `.custom`). API is identical to sonner's
  `toast`, so the 18 call sites just swap their import path. Callers
  can opt back into swipe-to-dismiss with `dismissible: true`.
- `<Toaster>` sets `swipeDirections={[]}` to make the intent explicit.
- `index.css` forces `user-select: text` on toast text content and
  keeps `user-select: none` on toast buttons.
- New `<CopyableErrorChip>` component replaces the truncated inline
  error in the chat header. The chip shows the truncated message
  inline and opens a popover with the full, wrap-friendly, selectable
  message and a one-click Copy button.

Toasts still auto-dismiss after their `duration`, close buttons and
action buttons still work.

* studio/frontend: tighten code comments in selectable-toast change

* studio/frontend: address PR review on selectable-toast change

Three review-driven fixes:

1. CopyableErrorChip clears the copied->reset setTimeout on unmount via
   a useRef + useEffect cleanup so setState cannot fire on an unmounted
   component.

2. index.css restricts `cursor: text` to text-bearing toast nodes
   (`[data-title]`, `[data-description]`, `p`, `span`). The toast
   container keeps its default cursor and no longer pretends to be an
   editable surface. `user-select: text` still applies to the full toast
   tree so a drag-select starting on padding still works.

3. Toast wrapper now also injects `dismissible: false` into the second
   argument of `toast.promise(p, data?)`, covering the loading /
   success / error toasts created from a single promise call. Explicit
   `dismissible: true` in the data continues to win.

A fourth review point asked us to drop the wrapper and instead pass
`toastOptions={{ dismissible: false }}` to <Toaster>. Sonner v2.0.7's
Toaster only forwards `duration`, `className`, `descriptionClassName`,
`closeButton`, `style`, `unstyled`, `classNames`, `cancelButtonStyle`,
`actionButtonStyle`, and `closeButtonAriaLabel` from `toastOptions`
(see index.mjs lines 1144-1164). `dismissible` is not forwarded, so the
global-option approach is a runtime no-op (verified empirically across
Chromium / Firefox / WebKit). Wrapper is required.

* studio/frontend: drop chip aria-label override so message reads via SR

The CopyableErrorChip trigger set a fixed `aria-label`, which overrides
the visible message in the accessibility tree. Inside the chat header's
`role="status"` region this caused screen readers to announce the
generic label instead of the actual model-load error, a regression
versus the old plain-text status div.

Removed the `ariaLabel` prop and the default override. The button's
visible message text is now its accessible name, so the full
(untruncated) error is announced. Truncation stays purely visual via
CSS. Caller in chat-page.tsx dropped the prop too.

Added a Playwright assertion that the trigger's accessible name
contains the error message across Chromium, Firefox, and WebKit.

---------

Co-authored-by: Unsloth <michaelhan@Michaels-MacBook-Pro.local>
2026-05-18 03:47:21 -07:00
..
toast.ts studio/frontend: make toast and inline error text selectable and copyable (#5506) 2026-05-18 03:47:21 -07:00