f08aef1804
* Rebuild Studio branch on top of main * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Fix security and code quality issues for Studio PR #4237 - Validate models_dir query param against allowed directory roots to prevent path traversal in /api/models/local endpoint - Replace string startswith() with Path.is_relative_to() for frontend path traversal check in serve_frontend - Sanitize SSE error messages to not leak exception details to clients (4 locations in inference.py) - Bind port-discovery socket to 127.0.0.1 instead of all interfaces in llama_cpp backend - Import datasets_root and resolve_output_dir in embedding training function to fix NameError and use managed output directory - Remove stale .gitignore entries for package-lock.json and test directories so tests can be tracked in version control - Add venv-reexecution logic to ui CLI command matching the studio command behavior * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Move models_dir path validation before try/except block The HTTPException(403) was inside the try/except Exception handler, so it would be caught and re-raised as a 500. Moving the validation before the try block ensures the 403 is returned directly and also makes the control flow clearer for static analysis (path is validated before any filesystem operations). * Use os.path.realpath + startswith for models_dir validation CodeQL py/path-injection does not recognize Path.is_relative_to() as a sanitizer. Switched to os.path.realpath + str.startswith which is a recognized sanitizer pattern in CodeQL's taint analysis. The startswith check uses root_str + os.sep to prevent prefix collisions (e.g. /app/models_evil matching /app/models). * Never pass user input to Path constructor in models_dir validation CodeQL traces taint through Path(resolved) even after a startswith barrier guard. Fix: the user-supplied models_dir is only used as a string for comparison against allowed roots. The Path object passed to _scan_models_dir comes from the trusted allowed_roots list, not from user input. This fully breaks the taint chain. --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
150 lines
3.2 KiB
JSON
150 lines
3.2 KiB
JSON
{
|
|
"$schema": "https://biomejs.dev/schemas/1.9.4/schema.json",
|
|
"files": {
|
|
"ignore": [
|
|
"dist",
|
|
"node_modules",
|
|
"test",
|
|
"test/**",
|
|
"**/._*",
|
|
"._*",
|
|
"**/.DS_Store",
|
|
"tsconfig*.json"
|
|
]
|
|
},
|
|
"formatter": {
|
|
"enabled": true,
|
|
"indentStyle": "space",
|
|
"indentWidth": 2
|
|
},
|
|
"organizeImports": {
|
|
"enabled": true
|
|
},
|
|
"linter": {
|
|
"enabled": true,
|
|
"rules": {
|
|
"recommended": true,
|
|
"a11y": { "all": true },
|
|
"complexity": { "all": true },
|
|
"correctness": { "all": true, "useImportExtensions": "off" },
|
|
"performance": { "all": true },
|
|
"security": { "all": true },
|
|
"style": {
|
|
"all": true,
|
|
"useNamingConvention": { "options": { "strictCase": false } }
|
|
},
|
|
"suspicious": { "all": true, "noReactSpecificProps": "off" }
|
|
}
|
|
},
|
|
"overrides": [
|
|
{
|
|
"include": ["vite.config.ts", "eslint.config.js"],
|
|
"linter": {
|
|
"rules": {
|
|
"correctness": { "noNodejsModules": "off" },
|
|
"style": { "noDefaultExport": "off" }
|
|
}
|
|
}
|
|
},
|
|
{
|
|
"include": ["src/components/assistant-ui/reasoning.tsx"],
|
|
"linter": {
|
|
"rules": {
|
|
"style": { "useNamingConvention": "off" }
|
|
}
|
|
}
|
|
},
|
|
{
|
|
"include": ["src/components/assistant-ui/attachment.tsx"],
|
|
"linter": {
|
|
"rules": {
|
|
"style": { "useNamingConvention": "off" }
|
|
}
|
|
}
|
|
},
|
|
{
|
|
"include": ["src/components/assistant-ui/tool-fallback.tsx"],
|
|
"linter": {
|
|
"rules": {
|
|
"style": { "useNamingConvention": "off" }
|
|
}
|
|
}
|
|
},
|
|
{
|
|
"include": ["src/components/component-example.tsx"],
|
|
"linter": {
|
|
"rules": {
|
|
"style": { "noNamespaceImport": "off" }
|
|
}
|
|
}
|
|
},
|
|
{
|
|
"include": ["src/config/env.ts"],
|
|
"linter": {
|
|
"rules": {
|
|
"style": { "useNamingConvention": "off" }
|
|
}
|
|
}
|
|
},
|
|
{
|
|
"include": ["src/components/layout/index.ts"],
|
|
"linter": {
|
|
"rules": {
|
|
"performance": { "noBarrelFile": "off" }
|
|
}
|
|
}
|
|
},
|
|
{
|
|
"include": ["src/features/**/index.ts"],
|
|
"linter": {
|
|
"rules": {
|
|
"performance": { "noBarrelFile": "off" }
|
|
}
|
|
}
|
|
},
|
|
{
|
|
"include": ["src/features/chat/thread-sidebar.tsx"],
|
|
"linter": {
|
|
"rules": {
|
|
"a11y": { "useSemanticElements": "off" }
|
|
}
|
|
}
|
|
},
|
|
{
|
|
"include": ["src/features/chat/runtime-provider.tsx"],
|
|
"linter": {
|
|
"rules": {
|
|
"style": { "useNamingConvention": "off" }
|
|
}
|
|
}
|
|
},
|
|
{
|
|
"include": ["src/components/assistant-ui/thread.tsx"],
|
|
"linter": {
|
|
"rules": {
|
|
"style": { "useNamingConvention": "off" }
|
|
}
|
|
}
|
|
},
|
|
{
|
|
"include": ["src/features/onboarding/components/steps/summary-step.tsx"],
|
|
"linter": {
|
|
"rules": {
|
|
"style": { "useExplicitLengthCheck": "off" }
|
|
}
|
|
}
|
|
},
|
|
{
|
|
"include": ["src/components/ui/**"],
|
|
"linter": {
|
|
"enabled": false
|
|
},
|
|
"formatter": {
|
|
"enabled": false
|
|
},
|
|
"organizeImports": {
|
|
"enabled": false
|
|
}
|
|
}
|
|
]
|
|
}
|