* Rebuild Studio branch on top of main * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Fix security and code quality issues for Studio PR #4237 - Validate models_dir query param against allowed directory roots to prevent path traversal in /api/models/local endpoint - Replace string startswith() with Path.is_relative_to() for frontend path traversal check in serve_frontend - Sanitize SSE error messages to not leak exception details to clients (4 locations in inference.py) - Bind port-discovery socket to 127.0.0.1 instead of all interfaces in llama_cpp backend - Import datasets_root and resolve_output_dir in embedding training function to fix NameError and use managed output directory - Remove stale .gitignore entries for package-lock.json and test directories so tests can be tracked in version control - Add venv-reexecution logic to ui CLI command matching the studio command behavior * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Move models_dir path validation before try/except block The HTTPException(403) was inside the try/except Exception handler, so it would be caught and re-raised as a 500. Moving the validation before the try block ensures the 403 is returned directly and also makes the control flow clearer for static analysis (path is validated before any filesystem operations). * Use os.path.realpath + startswith for models_dir validation CodeQL py/path-injection does not recognize Path.is_relative_to() as a sanitizer. Switched to os.path.realpath + str.startswith which is a recognized sanitizer pattern in CodeQL's taint analysis. The startswith check uses root_str + os.sep to prevent prefix collisions (e.g. /app/models_evil matching /app/models). * Never pass user input to Path constructor in models_dir validation CodeQL traces taint through Path(resolved) even after a startswith barrier guard. Fix: the user-supplied models_dir is only used as a string for comparison against allowed roots. The Path object passed to _scan_models_dir comes from the trusted allowed_roots list, not from user input. This fully breaks the taint chain. --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
132 lines
4.4 KiB
Python
132 lines
4.4 KiB
Python
# SPDX-License-Identifier: AGPL-3.0-only
|
|
# Copyright 2026-present the Unsloth AI Inc. team. All rights reserved. See /studio/LICENSE.AGPL-3.0
|
|
|
|
from pathlib import Path
|
|
from typing import Optional
|
|
|
|
import typer
|
|
|
|
|
|
EXPORT_FORMATS = ["merged-16bit", "merged-4bit", "gguf", "lora"]
|
|
GGUF_QUANTS = ["q4_k_m", "q5_k_m", "q8_0", "f16"]
|
|
|
|
|
|
def list_checkpoints(
|
|
outputs_dir: Path = typer.Option(
|
|
Path("./outputs"), "--outputs-dir", help = "Directory that holds training runs."
|
|
),
|
|
):
|
|
"""List checkpoints detected in the outputs directory."""
|
|
from studio.backend.core.export import ExportBackend
|
|
|
|
backend = ExportBackend()
|
|
checkpoints = backend.scan_checkpoints(outputs_dir = str(outputs_dir))
|
|
if not checkpoints:
|
|
typer.echo("No checkpoints found.")
|
|
raise typer.Exit()
|
|
|
|
for model_name, ckpt_list, metadata in checkpoints:
|
|
typer.echo(f"\n{model_name}:")
|
|
for display, path, loss in ckpt_list:
|
|
loss_str = f" (loss: {loss:.4f})" if loss is not None else ""
|
|
typer.echo(f" {display}{loss_str}: {path}")
|
|
|
|
|
|
def export(
|
|
checkpoint: Path = typer.Argument(..., help = "Path to checkpoint directory."),
|
|
output_dir: Path = typer.Argument(..., help = "Directory to save exported model."),
|
|
format: str = typer.Option(
|
|
"merged-16bit",
|
|
"--format",
|
|
"-f",
|
|
help = f"Export format: {', '.join(EXPORT_FORMATS)}",
|
|
),
|
|
quantization: str = typer.Option(
|
|
"q4_k_m",
|
|
"--quantization",
|
|
"-q",
|
|
help = f"GGUF quantization method: {', '.join(GGUF_QUANTS)}",
|
|
),
|
|
push_to_hub: bool = typer.Option(
|
|
False, "--push-to-hub", help = "Push exported model to HuggingFace Hub."
|
|
),
|
|
repo_id: Optional[str] = typer.Option(
|
|
None, "--repo-id", help = "HuggingFace repo ID (username/model-name)."
|
|
),
|
|
hf_token: Optional[str] = typer.Option(
|
|
None, "--hf-token", envvar = "HF_TOKEN", help = "HuggingFace token."
|
|
),
|
|
private: bool = typer.Option(
|
|
False, "--private", help = "Make the HuggingFace repo private."
|
|
),
|
|
max_seq_length: int = typer.Option(2048, "--max-seq-length"),
|
|
load_in_4bit: bool = typer.Option(True, "--load-in-4bit/--no-load-in-4bit"),
|
|
):
|
|
"""Export a checkpoint to various formats (merged, GGUF, LoRA adapter)."""
|
|
if format not in EXPORT_FORMATS:
|
|
typer.echo(
|
|
f"Error: Invalid format '{format}'. Choose from: {', '.join(EXPORT_FORMATS)}",
|
|
err = True,
|
|
)
|
|
raise typer.Exit(code = 2)
|
|
|
|
if push_to_hub and not repo_id:
|
|
typer.echo("Error: --repo-id required when using --push-to-hub", err = True)
|
|
raise typer.Exit(code = 2)
|
|
|
|
from studio.backend.core.export import ExportBackend
|
|
|
|
backend = ExportBackend()
|
|
|
|
typer.echo(f"Loading checkpoint: {checkpoint}")
|
|
success, message = backend.load_checkpoint(
|
|
checkpoint_path = str(checkpoint),
|
|
max_seq_length = max_seq_length,
|
|
load_in_4bit = load_in_4bit,
|
|
)
|
|
if not success:
|
|
typer.echo(f"Error: {message}", err = True)
|
|
raise typer.Exit(code = 1)
|
|
typer.echo(message)
|
|
|
|
typer.echo(f"Exporting as {format}...")
|
|
if format == "merged-16bit":
|
|
success, message = backend.export_merged_model(
|
|
save_directory = str(output_dir),
|
|
format_type = "16-bit (FP16)",
|
|
push_to_hub = push_to_hub,
|
|
repo_id = repo_id,
|
|
hf_token = hf_token,
|
|
private = private,
|
|
)
|
|
elif format == "merged-4bit":
|
|
success, message = backend.export_merged_model(
|
|
save_directory = str(output_dir),
|
|
format_type = "4-bit (FP4)",
|
|
push_to_hub = push_to_hub,
|
|
repo_id = repo_id,
|
|
hf_token = hf_token,
|
|
private = private,
|
|
)
|
|
elif format == "gguf":
|
|
success, message = backend.export_gguf(
|
|
save_directory = str(output_dir),
|
|
quantization_method = quantization.upper(),
|
|
push_to_hub = push_to_hub,
|
|
repo_id = repo_id,
|
|
hf_token = hf_token,
|
|
)
|
|
elif format == "lora":
|
|
success, message = backend.export_lora_adapter(
|
|
save_directory = str(output_dir),
|
|
push_to_hub = push_to_hub,
|
|
repo_id = repo_id,
|
|
hf_token = hf_token,
|
|
private = private,
|
|
)
|
|
|
|
if not success:
|
|
typer.echo(f"Error: {message}", err = True)
|
|
raise typer.Exit(code = 1)
|
|
|
|
typer.echo(message)
|