unsloth/.github
Daniel Han 4e1f1e959a ci(windows): do not pre-create dist/node_modules before Defender exclusion
Run 25546676715 / job 74984469728 (Windows Studio UI CI / Chat UI Tests)
broke on the previous commit (2843e2a9). Symptom:

  install.log:  "frontend  up to date"
  studio.log:   FileNotFoundError:
                D:\\a\\unsloth\\unsloth\\studio\\frontend\\dist\\index.html
  Playwright:   TimeoutError waiting for "#new-password" (60s)

Root cause: the Pre-install Windows tweaks step's loop did

  if (-not (Test-Path $p)) { New-Item -ItemType Directory -Force -Path $p }
  Add-MpPreference -ExclusionPath $p

before install.ps1 ran. That created an empty studio/frontend/dist
directory whose mtime was newer than every source file. setup.ps1's
mtime-based "is the frontend stale?" check at studio/setup.ps1
line 1281-1296 then concluded "frontend up to date, skip rebuild",
so vite never wrote anything into dist. Studio booted with an empty
dist directory and crashed on GET /change-password (the static-file
handler at studio/backend/main.py:489 read_bytes()'d a non-existent
index.html).

The same trap broke the frontend-dist actions/cache attempt earlier
in this branch (commit d65f8b19 -> reverted in e1345d5f). Same root
cause: any process that puts a fresh-mtime directory at
studio/frontend/dist before the build silences the Vite rebuild.

Fix: drop the New-Item call. Add-MpPreference accepts paths that do
not yet exist; the exclusion is registered and applies when the path
materialises. The failure is bisected to this single line, and reverting
just that line restores green.

Applied identically to all 4 Windows workflows so api/ui/update/inference
jobs all stay green.
2026-05-08 09:08:46 +00:00
..
ISSUE_TEMPLATE Update issue template 2026-03-23 10:10:15 +05:30
workflows ci(windows): do not pre-create dist/node_modules before Defender exclusion 2026-05-08 09:08:46 +00:00
CODEOWNERS Update CODEOWNERS 2026-03-13 13:38:19 -07:00
dependabot.yml CI(security): defense-in-depth additions across 7 axes 2026-05-07 00:09:40 +00:00
FUNDING.yml Update FUNDING.yml (#3792) 2025-12-28 19:57:43 -08:00