unsloth/docker
Daniel Han 5906a9feb6 docker: close four holes the review found
docker-publish.yml: the llama.cpp tag resolver was the one step in the prepare
job still using `curl | sed` without pipefail. The runner's default `bash -e`
shell takes sed's exit status, so an unreachable github.com left TAG empty and
the step published the mutable `latest`. Both arch legs re-resolve that through
fetch_llama_prebuilt.py and Dockerfile.studio resolves it a third time, so a
release cut mid-run can put different llama.cpp bundles under one manifest.
Capture the redirect first and fail the job when it is missing or does not land
on a release tag, matching the three ref resolvers below it.

unsloth_nb_strip_colab.py: strip_notebook read, parsed and then unconditionally
os.replace'd. The refresh child re-arms finalize after the entrypoint has execed
the container command, so JupyterLab is already serving the tree and a save
landing in that window was destroyed, after which migrate recorded the cleaned
hash and marked the notebook pristine forever. Re-read the hash once the staged
copy is complete and drop it when the file moved, the same rule the refresh
publish in unsloth_sync_notebooks.sh already follows.

unsloth_nb_view.py: ownership for the view teardown accepted any symlink target
under DEST, but every link the tool creates points at DEST/nb. A shortcut the
user made in the landing dir to their own file elsewhere in the checkout was
therefore classified as ours and deleted on the next boot. Key ownership on
DEST/nb instead.

cellNav.ts: the edit-mode boundary test compared the cursor line against
editor.lineCount, both logical, while JupyterLab wraps markdown and raw editors
by default (StaticNotebook.defaultEditorConfig). A one-line markdown header
renders as several visual rows, so every arrow left the cell and the wrapped
rows could not be reached. Ask CodeMirror whether it can still move one visual
line (EditorView.moveVertically, compared by coordsAtPos top) and keep the
logical test as the fallback for a non-CodeMirror editor.

New tests: 12 passed / 8 failed before, 20 passed / 0 failed after.
2026-07-27 16:06:56 +00:00
..
jupyter docker: close four holes the review found 2026-07-27 16:06:56 +00:00
.dockerignore docker: Colab-grade JupyterLab and Studio UX for the Unsloth image (#6681) 2026-07-06 08:27:00 -07:00
build.sh docker: fix build.sh's arch-list read for relative invocations 2026-07-26 17:30:21 +00:00
Dockerfile docker: keep transformers sidecar selection inside what the baked vLLM can import 2026-07-26 17:28:08 +00:00
Dockerfile.studio docker: trim redundant comments in the image build files 2026-07-26 15:45:58 +00:00
entrypoint.sh docker: trim redundant comments in the image build files 2026-07-26 15:45:58 +00:00
fetch_llama_prebuilt.py docker: tighten comments 2026-07-19 15:32:20 +00:00
NOTICE docker: Colab-grade JupyterLab and Studio UX for the Unsloth image (#6681) 2026-07-06 08:27:00 -07:00
run.sh docker: tighten comments 2026-07-19 15:32:20 +00:00
smoke_test.py docker: trim redundant comments in the image build files 2026-07-26 15:45:58 +00:00
studio_launch.sh docker: trim redundant comments in the image build files 2026-07-26 15:45:58 +00:00
supervisord.conf docker: tighten comments 2026-07-19 15:32:20 +00:00
unsloth_colab_compat.py docker: tighten comments 2026-07-19 15:32:20 +00:00
unsloth_ipython_startup.py docker: tighten comments 2026-07-19 15:32:20 +00:00
unsloth_jupyter_tunnel.sh docker: optional Cloudflare tunnel for JupyterLab (UNSLOTH_JUPYTER_CLOUDFLARE) 2026-06-24 09:55:11 +00:00
unsloth_llama_update.sh docker: close five failure paths the review found 2026-07-27 14:02:16 +00:00
unsloth_nb_compat.py docker: keep transformers sidecar selection inside what the baked vLLM can import 2026-07-26 17:28:08 +00:00
unsloth_nb_content_sig.py docker: tighten comments 2026-07-19 15:32:20 +00:00
unsloth_nb_pip_magic.py docker: trim redundant comments in the image build files 2026-07-26 15:45:58 +00:00
unsloth_nb_strip_colab.py docker: close four holes the review found 2026-07-27 16:06:56 +00:00
unsloth_nb_view.py docker: close four holes the review found 2026-07-27 16:06:56 +00:00
unsloth_pip_shim.py docker: protect the tested training stack from notebook install cells 2026-07-26 17:28:15 +00:00
unsloth_run.py docker: tighten comments 2026-07-19 15:32:20 +00:00
unsloth_studio_update.sh docker: close five failure paths the review found 2026-07-27 14:02:16 +00:00
unsloth_sync_notebooks.sh docker: close five failure paths the review found 2026-07-27 14:02:16 +00:00