2bea7862efunsloth_cli/commands/start.py imports click at module scope, and unsloth_cli/__init__.py imports that module, so every unsloth command needs it. typer carried click through 0.19 and dropped it in 0.27, and the declared floor is typer>=0.12.0, so a fresh resolve gets none. The wheel still works today only because huggingface_hub requires click<9,>=8.4.2, which is luck rather than a declaration. Verified on a wheel built from a dependency list without that transitive provider: every command, including `unsloth --help`, died with ModuleNotFoundError for click. Same class as the structlog gap in #7493, so the drift test covers both now.
85 lines
3.1 KiB
Python
85 lines
3.1 KiB
Python
# SPDX-License-Identifier: AGPL-3.0-only
|
|
# Copyright 2026-present the Unsloth AI Inc. team. All rights reserved. See /studio/LICENSE.AGPL-3.0
|
|
|
|
"""The studio extra must mirror studio/backend/requirements/studio.txt.
|
|
|
|
Nothing else keeps them in sync, and drift reintroduces #4701 / #5260 / #7147.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import pathlib
|
|
import sys
|
|
|
|
import pytest
|
|
|
|
REPO_ROOT = pathlib.Path(__file__).resolve().parents[3]
|
|
PYPROJECT = REPO_ROOT / "pyproject.toml"
|
|
STUDIO_TXT = REPO_ROOT / "studio" / "backend" / "requirements" / "studio.txt"
|
|
|
|
# Imported at module scope by the chain every CLI command walks: structlog via
|
|
# studio.backend, click via unsloth_cli/commands/start.py.
|
|
CORE_RUNTIME_PACKAGES = ("structlog", "click")
|
|
|
|
|
|
def _load_pyproject() -> dict:
|
|
if sys.version_info >= (3, 11):
|
|
import tomllib
|
|
else:
|
|
tomllib = pytest.importorskip("tomli")
|
|
return tomllib.loads(PYPROJECT.read_text(encoding = "utf-8"))
|
|
|
|
|
|
def _requirement_lines(path: pathlib.Path) -> list[str]:
|
|
out = []
|
|
for line in path.read_text(encoding = "utf-8").splitlines():
|
|
text = line.split("#", 1)[0].strip()
|
|
if text and not text.startswith("-"):
|
|
out.append(text)
|
|
return out
|
|
|
|
|
|
def _normalise(name: str) -> str:
|
|
"""PEP 503 normalisation, so PyJWT/pyjwt and nest_asyncio/nest-asyncio match."""
|
|
head = name
|
|
for sep in ("===", "==", ">=", "<=", "~=", "!=", ">", "<", "[", ";", " "):
|
|
idx = head.find(sep)
|
|
if idx > 0:
|
|
head = head[:idx]
|
|
return head.strip().lower().replace("_", "-").replace(".", "-")
|
|
|
|
|
|
def test_studio_extra_exists():
|
|
extras = _load_pyproject()["project"]["optional-dependencies"]
|
|
assert "studio" in extras, (
|
|
"pyproject.toml has no `studio` extra. The wheel ships studio/ and "
|
|
"studio.backend*, so their dependencies need a pip-installable home."
|
|
)
|
|
|
|
|
|
def test_studio_extra_matches_requirements_file():
|
|
extras = _load_pyproject()["project"]["optional-dependencies"]
|
|
extra = sorted(_normalise(entry) for entry in extras["studio"])
|
|
required = sorted(_normalise(entry) for entry in _requirement_lines(STUDIO_TXT))
|
|
|
|
missing = sorted(set(required) - set(extra))
|
|
surplus = sorted(set(extra) - set(required))
|
|
assert not missing, (
|
|
f"studio.txt lists {missing} but the `studio` extra does not. "
|
|
'`pip install "unsloth[studio]"` would build a venv the Studio server '
|
|
"cannot boot in. Add them to [project.optional-dependencies] studio."
|
|
)
|
|
assert not surplus, (
|
|
f"The `studio` extra lists {surplus} but studio.txt does not. "
|
|
"Remove them, or add them to studio.txt if install.sh needs them too."
|
|
)
|
|
|
|
|
|
@pytest.mark.parametrize("package", CORE_RUNTIME_PACKAGES)
|
|
def test_cli_runtime_packages_are_core_dependencies(package):
|
|
core = [_normalise(entry) for entry in _load_pyproject()["project"]["dependencies"]]
|
|
assert _normalise(package) in core, (
|
|
f"{package} is imported at module scope by the studio.backend chain "
|
|
f"`unsloth train` / `unsloth export` walk, so a plain `pip install "
|
|
f"unsloth` must provide it or they die with ModuleNotFoundError."
|
|
)
|