unsloth/studio/backend/core/rag/embeddings.py
Daniel Han 414503745e
Run the malware gate on the RAG embedding model before it loads (#6887)
* Run the malware gate on the RAG embedding model before it loads

Setting the RAG embedding model through PUT /api/settings/embedding-model
persisted an arbitrary repo and later handed it straight to
SentenceTransformer, which deserializes pickle weights. Unlike the normal
model-load paths, this route never ran evaluate_file_security, and force
skipped verification entirely, so a repo Hugging Face flags as unsafe (or
any repo under force) could be downloaded and loaded in the backend
process without a scan.

Run the malware/pickle scan at both ends: the settings endpoint now scans
before persisting and returns 409 on a flagged repo even under force
(force still only skips the is-embedding-model type check for offline or
local repos), and the embedder scans again at the load sink so a name that
arrives via env or default is covered too. Local paths and unreachable
scans fail open inside evaluate_file_security, and the sink never bricks
the embedder on a gate error.

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Thread the load token into the embedding scan and hard-fail on a block

The load-sink scan ran without a token, so evaluate_file_security (which
passes token=False when none is given) could not reach a gated or private
repo and failed open for exactly the model SentenceTransformer would still
load. Resolve the loader's own token (HF_TOKEN env or the cached login)
and pass it to the sink scan, and fall back to it in the settings endpoint
when the request omits one.

The sink previously raised a plain RuntimeError, which the llama-server
fallback in encode() and _build_st_backend_or_fallback() swallowed as a
routine ST failure, silently switching backends instead of blocking. Raise
a distinct UnsafeEmbeddingModelError that both fallback paths re-raise, so
a flagged model hard-fails.

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Scan sentence-transformers module dirs and scope the embedding pickle gate to the ST backend

Extend the RAG embedding malware gate so a poisoned pickle under a SentenceTransformer
module dir (for example 0_Transformer/pytorch_model.bin) blocks. Those dirs are read
from the repo's modules.json and passed as load roots to evaluate_file_security at both
the settings endpoint and the load sink, so such a pickle is treated as root-level there
instead of an unreferenced nested shard that was previously allowed.

Scope the ST pickle scan to the sentence-transformers backend. On the llama-server
backend the embedder loads GGUF files (inert) from the -GGUF companion repo, never the
ST repo's pickle, so a custom ST repo with a flagged pickle and a clean GGUF companion
is no longer rejected. The existing GGUF availability checks already cover that path.

Return 403 for the hard security block instead of 409. The settings UI routes every 409
into the forceable save-anyway flow, but this block cannot be bypassed by force, so it
now uses a distinct status the client treats as non-forceable.

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Base the embedding pickle scan on the actual backend, not just the resolver

_llama_backend_active only consulted the auto resolver, so on a GPU box
where auto resolves to sentence-transformers but the process already fell
back to the llama-server backend at runtime (a torch or CUDA load/encode
failure), it returned False and the settings endpoint hard-blocked a save
whose ST pickle is flagged even though the process loads only inert GGUF.

Add active_backend_is_llama, which reflects the actual built backend (True
when the cached backend is a LlamaServerBackend, including a runtime
fallback) and otherwise defers to the resolver as a fresh process would,
and delegate _llama_backend_active to it.

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Report the cached embedding backend verbatim, not the resolver

active_backend_is_llama() fell through to the config resolver whenever a
backend was already built but was not llama-server, so a live
sentence-transformers backend could report llama=True once the resolver
picked llama (GPU heuristic or a runtime config change) and wrongly skip
its pickle scan. Once a backend exists, return isinstance(backend,
LlamaServerBackend) directly; only defer to the resolver before any
backend is built.

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2026-07-07 04:30:21 -07:00

432 lines
16 KiB
Python

# SPDX-License-Identifier: AGPL-3.0-only
# Copyright 2026-present the Unsloth AI Inc. team. All rights reserved. See /studio/LICENSE.AGPL-3.0
"""Dense embedder facade dispatching to a process-wide backend from
``config.EMBED_BACKEND`` (``auto`` picks by hardware): ``sentence-transformers``
(torch) or ``llama-server`` (GGUF, no torch).
Backends produce different vectors, so switching requires rebuilding the index. We
degrade to llama.cpp rather than crash when ST breaks on a machine: an init-time
probe falls back before any vector is produced (so spaces can't mix), and a
runtime ``encode`` failure swaps the process to llama-server for the rest of its
life (KBs already embedded with ST should then be reindexed).
"""
from __future__ import annotations
import logging
import os
import threading
from functools import lru_cache
from typing import Callable
from utils.hardware.hardware import DeviceType, get_device
from . import config
logger = logging.getLogger(__name__)
# "false" silences the fast tokenizer's fork warning; encode() flips it to "true"
# only during a batch tokenize (rayon speedup), then restores it.
os.environ.setdefault("TOKENIZERS_PARALLELISM", "false")
_lock = threading.Lock()
# Serializes encode/tokenize (HF fast tokenizer isn't thread-safe). Separate from
# _lock so a long encode never blocks a reload.
_compute_lock = threading.Lock()
_model = None
_name: str | None = None
# Studio device -> torch device string. Apple has no torch device -> CPU.
_TORCH_DEVICE = {DeviceType.CUDA: "cuda", DeviceType.XPU: "xpu"}
def _device() -> str:
return _TORCH_DEVICE.get(get_device(), "cpu")
_torchao_stub_done = False
def _install_torchao_stub_once() -> None:
"""Neutralize torchao before importing sentence-transformers. On Windows ROCm,
torchao (pulled in by transformers.quantizers) imports an absent c10d backend
and aborts, dropping the embedder to llama-server. Workers stub it too; the
embedder runs in the main process. No-op elsewhere; runs once under ``_lock``."""
global _torchao_stub_done
if _torchao_stub_done:
return
_torchao_stub_done = True
from core._torchao_stub import install_torchao_windows_rocm_stub
install_torchao_windows_rocm_stub()
class UnsafeEmbeddingModelError(RuntimeError):
"""Raised when the embedding model repo is flagged unsafe. A distinct type so the
llama-server fallback paths re-raise it instead of masking a security block as a
routine ST failure."""
def _ambient_hf_token() -> str | None:
"""The HF token the loader itself would use (HF_TOKEN env or the cached login), so
the scan can reach a gated/private repo instead of failing open. None if unavailable."""
try:
from huggingface_hub import get_token
return get_token()
except Exception:
return None
def _st_module_subdirs(name: str, token: str | None) -> tuple[str, ...]:
"""The module directories a SentenceTransformer load reads weights from, taken from
the repo's ``modules.json`` (each module's non-empty ``path``, e.g. ``0_Transformer``).
ST deserializes ``pytorch_model.bin`` from these dirs, so they are load roots for the
security scan: a flagged pickle directly under one must block. Returns () on any
failure (no modules.json, offline, malformed) so the guard never bricks the embedder.
"""
try:
import json
from utils.paths import is_local_path
if is_local_path(name):
from pathlib import Path
from utils.paths import normalize_path
path = Path(normalize_path(name)).expanduser() / "modules.json"
if not path.is_file():
return ()
data = json.loads(path.read_text())
else:
from huggingface_hub import hf_hub_download
from huggingface_hub.utils import EntryNotFoundError
try:
local = hf_hub_download(name, "modules.json", token = token or None)
except EntryNotFoundError:
return ()
data = json.loads(open(local).read())
subdirs = []
for module in data or ():
sub = str((module or {}).get("path", "")).strip().strip("/")
if sub:
subdirs.append(sub)
return tuple(dict.fromkeys(subdirs))
except Exception:
return ()
def _guard_model_security(name: str) -> None:
"""Refuse to load a repo HF flagged as unsafe: a poisoned pickle deserializes inside
SentenceTransformer regardless of trust_remote_code. Defense in depth behind the
/settings gate (a name can also arrive via env/default); local paths and unreachable
scans fail open inside evaluate_file_security. Never bricks the embedder on a gate error.
"""
try:
from utils.security import evaluate_file_security, security_load_subdirs
token = _ambient_hf_token()
# Union the audio-model load roots with the ST module dirs so a flagged pickle
# directly under a Transformer module dir (0_Transformer/) blocks instead of
# passing as an unreferenced nested shard.
load_subdirs = tuple(
dict.fromkeys((*security_load_subdirs(name, token), *_st_module_subdirs(name, token)))
)
blocked = evaluate_file_security(name, hf_token = token, load_subdirs = load_subdirs).blocked
except Exception:
return
if blocked:
raise UnsafeEmbeddingModelError(
f"Embedding model {name!r} is flagged as unsafe by Hugging Face's security "
"scan; refusing to load. Set a different RAG embedding model."
)
def _get(model_name: str | None = None):
"""Cached SentenceTransformer, (re)loading on a name change. Loaded in fp16
for a ~1.5x speedup at negligible accuracy loss."""
global _model, _name
name = model_name or config.effective_embedding_model()
with _lock:
if _model is None or _name != name:
_install_torchao_stub_once()
from sentence_transformers import SentenceTransformer
device = _device()
logger.info("loading embedding model %s on %s", name, device)
_guard_model_security(name)
_model = SentenceTransformer(
name, device = device, model_kwargs = {"torch_dtype": "float16"}
)
_name = name
return _model
@lru_cache(maxsize = 1)
def _inference_ctx_factory():
"""``torch.inference_mode`` if torch imports, else ``nullcontext``. Returns the
factory so each call gets a fresh single-use guard."""
try:
import torch
return torch.inference_mode
except Exception: # noqa: BLE001 - torch may be missing or broken
from contextlib import nullcontext
return nullcontext
def _inference_ctx():
return _inference_ctx_factory()()
def _st_encode(
texts: list[str],
*,
model_name: str | None = None,
normalize: bool = True,
):
"""ST encode -> (N, dim) float32. Serialized (fast-tokenizer borrow check),
under inference_mode when torch is present, with rayon enabled for the call."""
model = _get(model_name)
with _compute_lock:
os.environ["TOKENIZERS_PARALLELISM"] = "true"
try:
with _inference_ctx():
out = model.encode(
texts,
normalize_embeddings = normalize,
convert_to_numpy = True,
show_progress_bar = False,
)
finally:
os.environ["TOKENIZERS_PARALLELISM"] = "false"
# fp16 weights yield fp16 output; store float32 for sqlite-vec + stable cosine.
if hasattr(out, "astype"):
out = out.astype("float32", copy = False)
return out
def _st_dim(model_name: str | None = None) -> int:
return _get(model_name).get_sentence_embedding_dimension()
def _st_token_counter(model_name: str | None = None) -> Callable[[str], int]:
"""Token counter using the model's tokenizer, under the compute lock (the same
fast tokenizer backs encode and isn't thread-safe), with rayon enabled for the
call. Mirrors ``_st_encode``."""
tok = _get(model_name).tokenizer
def _count(t: str) -> int:
with _compute_lock:
os.environ["TOKENIZERS_PARALLELISM"] = "true"
try:
return len(tok.encode(t, add_special_tokens = False))
finally:
os.environ["TOKENIZERS_PARALLELISM"] = "false"
return _count
class _SentenceTransformersBackend:
"""Default backend; delegates to the module-level ST helpers so the ``_get``
monkeypatch in tests keeps working."""
def encode(
self,
texts,
*,
model_name = None,
normalize = True,
):
try:
return _st_encode(texts, model_name = model_name, normalize = normalize)
except UnsafeEmbeddingModelError:
raise # a security block must hard-fail, not fall back to llama-server
except Exception as st_err: # noqa: BLE001 - runtime ST/CUDA encode failure
# ST loaded but this encode blew up; swap the process to the llama-server
# embedder (so later encodes stay in one space) and retry.
fallback = _switch_to_llama_fallback(st_err)
if fallback is None:
raise
return fallback.encode(texts, model_name = model_name, normalize = normalize)
def token_counter(self, *, model_name = None):
return _st_token_counter(model_name)
def dim(self, *, model_name = None):
return _st_dim(model_name)
def warm(self, *, model_name = None):
_get(model_name)
_backend_lock = threading.Lock()
_backend = None
_backend_key: str | None = None
_ST_ALIASES = frozenset({"sentence-transformers", "sentence_transformers", "st"})
_LLAMA_ALIASES = frozenset(
{"llama-server", "llama_server", "llama", "llama.cpp", "llamacpp", "gguf"}
)
_AUTO_ALIASES = frozenset({"auto", ""})
def _resolve_auto() -> str:
"""Pick a backend for ``auto``: sentence-transformers when a CUDA/ROCm GPU is
present (torch fp16 wins bulk indexing), else the torch-free GGUF llama-server
-- or ST if its binary is missing. GPU check is torch-free (nvidia-smi)."""
from core.inference.llama_cpp import LlamaCppBackend
if LlamaCppBackend._get_gpu_free_memory():
return "sentence-transformers"
if LlamaCppBackend._find_llama_server_binary():
return "llama-server"
return "sentence-transformers"
def _try_make_llama_backend():
"""A llama-server GGUF embedding backend if its binary is present, else None.
Construction is lazy -- no server starts until warm."""
from core.inference.llama_cpp import LlamaCppBackend
if not LlamaCppBackend._find_llama_server_binary():
return None
from .embed_llama_server import LlamaServerBackend
return LlamaServerBackend()
def _build_st_backend_or_fallback():
"""Build the ST backend, probing it by loading the model now. If the probe
raises (no torch, CUDA mismatch, bad wheel) and the GGUF llama-server embedder
is available, fall back to it. The probe runs before any vector is produced, so
this never mixes spaces. Re-raises if no embedder can start."""
backend = _SentenceTransformersBackend()
try:
backend.warm(model_name = None)
return backend
except UnsafeEmbeddingModelError:
raise # a security block must hard-fail, not fall back to llama-server
except Exception as st_err: # noqa: BLE001 - any ST/torch import or load failure
fallback = _try_make_llama_backend()
if fallback is None:
raise
logger.warning(
"sentence-transformers embedder unavailable (%s); falling back to the "
"llama-server GGUF embedder",
st_err,
)
return fallback
def _switch_to_llama_fallback(err):
"""An ST encode failed at runtime even though the model had loaded. Swap the
process embedder to llama-server so every later encode stays in one space, and
return it (None if no binary). Vectors written before the swap were ST, so any
KB already embedded with ST should be reindexed."""
global _backend, _backend_key
with _backend_lock:
if not isinstance(_backend, _SentenceTransformersBackend):
return _backend # another thread already swapped (or was never ST)
fallback = _try_make_llama_backend()
if fallback is None:
return None
logger.warning(
"sentence-transformers encode failed (%s); switching to the llama-server "
"embedder for the rest of this process. Reindex any knowledge base that "
"was already embedded with sentence-transformers.",
err,
)
_backend = fallback
_backend_key = (config.EMBED_BACKEND or "auto").strip().lower()
return fallback
def _get_backend():
"""The process-wide embedding backend for ``config.EMBED_BACKEND``, built once.
Cached by the raw config value, so ``auto`` detection runs only on a miss and a
config change rebuilds it."""
global _backend, _backend_key
raw = (config.EMBED_BACKEND or "auto").strip().lower()
with _backend_lock:
if _backend is not None and _backend_key == raw:
return _backend
key = _resolve_auto() if raw in _AUTO_ALIASES else raw
if key in _ST_ALIASES:
_backend = _build_st_backend_or_fallback()
elif key in _LLAMA_ALIASES:
# Imported lazily so the ST path never imports llama plumbing.
from .embed_llama_server import LlamaServerBackend
_backend = LlamaServerBackend()
else:
raise ValueError(
f"Unknown RAG_EMBED_BACKEND={config.EMBED_BACKEND!r}; expected "
"'auto', 'sentence-transformers' or 'llama-server'"
)
_backend_key = raw
return _backend
def _reset_backend() -> None:
"""Drop the cached backend (test teardown / re-init)."""
global _backend, _backend_key
with _backend_lock:
_backend = None
_backend_key = None
def active_backend_is_llama() -> bool:
"""True when this process actually embeds via the llama-server (GGUF) backend.
Reflects the ACTUAL built backend once one exists: an ``auto`` install that
resolves to sentence-transformers but then falls back to llama-server at
runtime (``_build_st_backend_or_fallback`` on a torch/CUDA load failure, or
``_switch_to_llama_fallback`` on an encode failure) loads only inert GGUF, so
callers gating on the ST pickle must see llama here. Before any backend is
built, defers to the resolver (``auto`` -> ``_resolve_auto()``, else the raw
key) exactly as a fresh process would. Never raises: a backend probe must not
block saving a model."""
try:
with _backend_lock:
backend = _backend
if backend is not None:
# A backend exists: report what it ACTUALLY is. A concrete
# sentence-transformers backend must return False even if the
# resolver would now pick llama, so its pickle stays gated. If the
# llama import fails we cannot be llama, so fall to the safe False.
try:
from .embed_llama_server import LlamaServerBackend
except Exception: # noqa: BLE001 - llama plumbing import must never block
return False
return isinstance(backend, LlamaServerBackend)
raw = (config.EMBED_BACKEND or "auto").strip().lower()
key = _resolve_auto() if raw in _AUTO_ALIASES else raw
return key in _LLAMA_ALIASES
except Exception: # noqa: BLE001 - a backend probe must never block saving
return False
def warm(model_name: str | None = None) -> None:
"""Eagerly load the embedder so the first real request isn't slow."""
_get_backend().warm(model_name = model_name)
def encode(
texts: list[str],
*,
model_name: str | None = None,
normalize: bool = True,
):
"""Embed texts into an (N, dim) float32 numpy array."""
return _get_backend().encode(texts, model_name = model_name, normalize = normalize)
def dim(model_name: str | None = None) -> int:
"""Embedding dimension for the (loaded) model."""
return _get_backend().dim(model_name = model_name)
def token_counter(model_name: str | None = None) -> Callable[[str], int]:
"""Callable counting tokens with the embedder's own tokenizer."""
return _get_backend().token_counter(model_name = model_name)