Four actionable findings from round 30. Skipped P1 #1 / #2 / #3 (huggingface-hub bump in studio.txt / single-env / colab-new) because the live B200 Studio that successfully generated FLUX.2 klein images runs the exact combo the reviewer flags as broken: huggingface_hub 0.36.2 + transformers 4.57.6 + diffusers 0.37.1 Flux2KleinPipeline: True (imports cleanly) The is_offline_mode ImportError only fires with transformers 5.x, and the standard install path pins transformers==4.57.6 via constraints. The round 26 fix bumped no-torch-runtime.txt + pyproject huggingfacenotorch where the --no-deps install path can land on transformers 5.x; that remains the correct surface. 1. core/inference/diffusion.py: preflight transformers + accelerate via importlib.util.find_spec BEFORE any destructive GPU-owner unload. Diffusers can expose stub pipeline classes when transformers / accelerate are missing, so the load used to drop chat first and fail later inside from_pretrained. find_spec keeps existing tests that stub these modules passing because no real module is executed (round 30 P1 #11). 2. models/export.py ExportGGUFRequest.quantization_method: extend the embedded HF token validator to this field too. Round 23 added the control-char guard but not the token guard; the value is forwarded into worker command lines and reflected in error / success text (round 30 P1 #5). 3. models/data_recipe.py SeedInspectUploadRequest: add _no_control_chars + _reject_embedded_hf_token field_validators to filename and to each entry of file_names. Mirrors the sibling SeedInspectRequest.dataset_name hardening (round 30 P1 #6). 4. frontend/src/features/images/images-page.tsx: defer the initial refreshStatus() call via queueMicrotask so the synchronous setRefreshingStatus(true) inside it does not trip the react-hooks/set-state-in-effect lint on mount (round 30 P2 #12). Deferred (need larger surgery / out of scope for this round): P1 #4 native_path_lease for diffusion local-path loads P1 #7-#10 helper/advisor + public-start window mutual lock symmetry Tests: 98 targeted (diffusion + cached_gguf + inference_validation) pass locally; frontend npm run typecheck passes.
207 lines
6.9 KiB
Python
207 lines
6.9 KiB
Python
# SPDX-License-Identifier: AGPL-3.0-only
|
|
# Copyright 2026-present the Unsloth AI Inc. team. All rights reserved. See /studio/LICENSE.AGPL-3.0
|
|
|
|
"""
|
|
Pydantic schemas for Data Recipe (DataDesigner) API.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
from typing import Any
|
|
|
|
from pydantic import BaseModel, Field, field_validator, model_validator
|
|
|
|
# Round 23 P1 #5: identifier hardening reused from the chat models
|
|
# so /api/data_recipe/publish rejects control characters and
|
|
# URL-form ``hf_xxxxx`` tokens in ``repo_id`` before they reach
|
|
# log lines or the HF API.
|
|
from models.inference import _no_control_chars, _reject_embedded_hf_token
|
|
|
|
|
|
class RecipePayload(BaseModel):
|
|
recipe: dict[str, Any] = Field(default_factory = dict)
|
|
run: dict[str, Any] | None = None
|
|
ui: dict[str, Any] | None = None
|
|
|
|
|
|
class PreviewResponse(BaseModel):
|
|
dataset: list[dict[str, Any]] = Field(default_factory = list)
|
|
processor_artifacts: dict[str, Any] | None = None
|
|
analysis: dict[str, Any] | None = None
|
|
|
|
|
|
class ValidateError(BaseModel):
|
|
message: str
|
|
path: str | None = None
|
|
code: str | None = None
|
|
|
|
|
|
class ValidateResponse(BaseModel):
|
|
valid: bool
|
|
errors: list[ValidateError] = Field(default_factory = list)
|
|
raw_detail: str | None = None
|
|
|
|
|
|
class JobCreateResponse(BaseModel):
|
|
job_id: str
|
|
|
|
|
|
class PublishDatasetRequest(BaseModel):
|
|
repo_id: str = Field(min_length = 3, description = "Hugging Face dataset repo ID")
|
|
description: str = Field(
|
|
min_length = 1,
|
|
max_length = 4000,
|
|
description = "Short dataset description for the dataset card",
|
|
)
|
|
hf_token: str | None = Field(
|
|
default = None,
|
|
description = "Optional Hugging Face token for private or write-protected repos",
|
|
)
|
|
private: bool = Field(
|
|
default = False,
|
|
description = "Create or update the dataset repo as private",
|
|
)
|
|
artifact_path: str | None = Field(
|
|
default = None,
|
|
description = "Execution artifact path captured by the UI for completed runs",
|
|
)
|
|
|
|
@field_validator("repo_id")
|
|
@classmethod
|
|
def _no_repo_id_control_chars(cls, v, info):
|
|
return _no_control_chars(v, info.field_name)
|
|
|
|
@field_validator("repo_id")
|
|
@classmethod
|
|
def _no_repo_id_embedded_hf_tokens(cls, v, info):
|
|
return _reject_embedded_hf_token(v, info.field_name)
|
|
|
|
|
|
class PublishDatasetResponse(BaseModel):
|
|
success: bool = True
|
|
url: str
|
|
message: str
|
|
|
|
|
|
class SeedInspectRequest(BaseModel):
|
|
dataset_name: str = Field(min_length = 1)
|
|
hf_token: str | None = None
|
|
subset: str | None = None
|
|
split: str | None = "train"
|
|
preview_size: int = Field(default = 10, ge = 1, le = 50)
|
|
|
|
# Round 26 P1 #11: dataset_name reaches HF + log/echo paths, so
|
|
# mirror the hardening other dataset request models already do.
|
|
# Round 27 P1 #7: split and subset also flow into HF dataset
|
|
# APIs / errors and must be guarded the same way.
|
|
@field_validator("dataset_name", "subset", "split")
|
|
@classmethod
|
|
def _no_dataset_name_control_chars(cls, v, info):
|
|
return _no_control_chars(v, info.field_name)
|
|
|
|
@field_validator("dataset_name", "subset", "split")
|
|
@classmethod
|
|
def _no_dataset_name_embedded_hf_tokens(cls, v, info):
|
|
return _reject_embedded_hf_token(v, info.field_name)
|
|
|
|
|
|
class SeedInspectUploadRequest(BaseModel):
|
|
# Legacy single-file flow (mutually exclusive with file_ids)
|
|
filename: str | None = None
|
|
content_base64: str | None = None
|
|
# Multi-file flow (mutually exclusive with content_base64)
|
|
block_id: str | None = None
|
|
file_ids: list[str] | None = None
|
|
file_names: list[str] | None = None
|
|
# Shared fields
|
|
preview_size: int = Field(default = 10, ge = 1, le = 50)
|
|
seed_source_type: str | None = None
|
|
unstructured_chunk_size: int | None = Field(default = None, ge = 1, le = 20000)
|
|
unstructured_chunk_overlap: int | None = Field(default = None, ge = 0, le = 20000)
|
|
|
|
# Round 30 P1 #6: filename / file_names are reflected as dataset
|
|
# names + error/log messages; harden them the same way the sibling
|
|
# SeedInspectRequest hardens dataset_name.
|
|
@field_validator("filename")
|
|
@classmethod
|
|
def _no_filename_control_chars(cls, v, info):
|
|
return _no_control_chars(v, info.field_name)
|
|
|
|
@field_validator("filename")
|
|
@classmethod
|
|
def _no_filename_embedded_hf_tokens(cls, v, info):
|
|
return _reject_embedded_hf_token(v, info.field_name)
|
|
|
|
@field_validator("file_names")
|
|
@classmethod
|
|
def _no_file_names_control_chars(cls, v):
|
|
if v is None:
|
|
return v
|
|
for i, entry in enumerate(v):
|
|
_no_control_chars(entry, f"file_names[{i}]")
|
|
return v
|
|
|
|
@field_validator("file_names")
|
|
@classmethod
|
|
def _no_file_names_embedded_hf_tokens(cls, v):
|
|
if v is None:
|
|
return v
|
|
for i, entry in enumerate(v):
|
|
_reject_embedded_hf_token(entry, f"file_names[{i}]")
|
|
return v
|
|
|
|
@model_validator(mode = "after")
|
|
def _check_mutual_exclusivity(self) -> "SeedInspectUploadRequest":
|
|
has_legacy = self.content_base64 is not None
|
|
has_multi = self.file_ids is not None
|
|
if has_legacy and has_multi:
|
|
raise ValueError("Provide either content_base64 or file_ids, not both")
|
|
if not has_legacy and not has_multi:
|
|
raise ValueError("Provide either content_base64 or file_ids")
|
|
if has_multi:
|
|
if len(self.file_ids) == 0:
|
|
raise ValueError("file_ids must not be empty")
|
|
if not self.block_id:
|
|
raise ValueError("block_id is required when using file_ids")
|
|
if self.file_names is None or len(self.file_ids) != len(self.file_names):
|
|
raise ValueError(
|
|
"file_names must be provided and same length as file_ids"
|
|
)
|
|
if has_legacy:
|
|
if not self.filename:
|
|
raise ValueError("filename is required when using content_base64")
|
|
return self
|
|
|
|
|
|
class SeedInspectResponse(BaseModel):
|
|
dataset_name: str
|
|
resolved_path: str
|
|
columns: list[str] = Field(default_factory = list)
|
|
preview_rows: list[dict[str, Any]] = Field(default_factory = list)
|
|
split: str | None = None
|
|
subset: str | None = None
|
|
resolved_paths: list[str] | None = None
|
|
|
|
|
|
class UnstructuredFileUploadResponse(BaseModel):
|
|
file_id: str
|
|
filename: str
|
|
size_bytes: int
|
|
status: str # "ok" or "error"
|
|
error: str | None = None
|
|
|
|
|
|
class McpToolsListRequest(BaseModel):
|
|
mcp_providers: list[dict[str, Any]] = Field(default_factory = list)
|
|
timeout_sec: float | None = Field(default = None, gt = 0)
|
|
|
|
|
|
class McpToolsProviderResult(BaseModel):
|
|
name: str
|
|
tools: list[str] = Field(default_factory = list)
|
|
error: str | None = None
|
|
|
|
|
|
class McpToolsListResponse(BaseModel):
|
|
providers: list[McpToolsProviderResult] = Field(default_factory = list)
|
|
duplicate_tools: dict[str, list[str]] = Field(default_factory = dict)
|