4176448fb8* Studio: enable stdio MCP servers on a loopback bind * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Studio: address codex review on stdio MCP loopback gate * Studio: fix banner URL and preserve stdio MCP env opt-in on network binds * Studio: scope loopback to exact aliases and honor force-disable on run_server reuse * Studio: cover force-disable across a public re-bind and fix a stale test comment * Studio: keep stdio MCP off on Colab loopback launches * Studio: set tool policy before server startup --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Lee Jackson <130007945+Imagineer99@users.noreply.github.com> Co-authored-by: imagineer99 <samleejackson0@gmail.com>
78 lines
3.4 KiB
Python
78 lines
3.4 KiB
Python
# SPDX-License-Identifier: AGPL-3.0-only
|
|
# Copyright 2026-present the Unsloth AI Inc. team. All rights reserved. See /studio/LICENSE.AGPL-3.0
|
|
|
|
"""Bind-host trust policy for the Studio backend.
|
|
|
|
Stdlib only -- safe to import without the rest of the backend.
|
|
|
|
`is_external_host` mirrors the CLI's `unsloth_cli/_tool_policy.py`: a loopback
|
|
bind is the user's own machine, any other address is network-reachable. The
|
|
logic is duplicated rather than shared because the backend is self-contained
|
|
(see run.py: "can be moved to any directory") and runs from a venv that may not
|
|
have `unsloth_cli` on sys.path. Keep the two in sync.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import os
|
|
|
|
# Loopback aliases; any other bind address is treated as network-reachable. Only
|
|
# the exact aliases the rest of the stack assumes for loopback (health checks,
|
|
# banner URLs, run.py all hard-code 127.0.0.1), so other 127.0.0.0/8 addresses
|
|
# are deliberately left out -- they are not supported launch hosts.
|
|
_LOOPBACK_HOSTS = frozenset({"127.0.0.1", "localhost", "::1"})
|
|
|
|
# Whether a loopback launch in THIS process auto-enabled the gate. run_server
|
|
# normally runs once per process, but if it is reused with a different host
|
|
# (embedders, tests) a stale loopback default must not carry into a later
|
|
# public bind, so we only ever take back a value we set ourselves.
|
|
_auto_enabled = False
|
|
|
|
|
|
def is_external_host(host: str) -> bool:
|
|
"""True when `host` is reachable from beyond loopback."""
|
|
return host.lower() not in _LOOPBACK_HOSTS
|
|
|
|
|
|
def apply_stdio_mcp_loopback_default(host: str, *, is_colab: bool = False) -> None:
|
|
"""Default stdio MCP servers on when bound to loopback.
|
|
|
|
A loopback bind is the user's own machine -- the same trust boundary the
|
|
Tauri desktop app relies on (see main.py, which also binds 127.0.0.1 and
|
|
setdefaults this var). Colab is excluded: even its loopback is a hosted VM
|
|
reachable through Colab's proxy, so it stays off unless opted in. An explicit
|
|
operator value wins: a pre-set `UNSLOTH_STUDIO_ALLOW_STDIO_MCP=0`
|
|
force-disables and `=1` opts in, including on a network bind. We only ever
|
|
set or clear a default we applied ourselves, so reusing run_server with a
|
|
public host after a loopback one does not leave the gate on.
|
|
"""
|
|
global _auto_enabled
|
|
current = os.environ.get("UNSLOTH_STUDIO_ALLOW_STDIO_MCP")
|
|
# If our prior auto-default was changed out from under us (in-process reuse),
|
|
# relinquish ownership: an explicit =0 is then honored below as a sticky
|
|
# force-disable, while a cleared var falls back to the host default like a
|
|
# fresh process.
|
|
if _auto_enabled and current != "1":
|
|
_auto_enabled = False
|
|
# An explicit operator value is one we did not set; never touch it.
|
|
if current is not None and not _auto_enabled:
|
|
return
|
|
if is_colab or is_external_host(host):
|
|
if _auto_enabled:
|
|
os.environ.pop("UNSLOTH_STUDIO_ALLOW_STDIO_MCP", None)
|
|
_auto_enabled = False
|
|
else:
|
|
os.environ["UNSLOTH_STUDIO_ALLOW_STDIO_MCP"] = "1"
|
|
_auto_enabled = True
|
|
|
|
|
|
def loopback_default_active() -> bool:
|
|
"""True when stdio MCP is on only because a loopback bind auto-enabled it,
|
|
rather than an explicit operator opt-in. Lets the gate tell the two apart."""
|
|
return _auto_enabled
|
|
|
|
|
|
def _reset_loopback_default_state() -> None:
|
|
"""Test hook: forget any auto-enable applied earlier in this process."""
|
|
global _auto_enabled
|
|
_auto_enabled = False
|