06829c2627Comment-only follow-up to #7454. That change carried 523 comment lines, many of them three and four line preambles where one line says the same thing. This collapses them and drops the ones restating what the code already says, for a net 77 lines. Scope is limited to comments #7454 itself introduced. The files it touched hold about 3,761 comments in total; the rest predate it and are untouched, verified by checking that every removed line is one that commit added. Nothing that records why a non-obvious decision was made was dropped, only compressed. Still stated: the normcase-before-versus-after Windows separator trap, the innermost-indexed-model rule for nested directories, an HTTPException being a decision rather than a failure to decide, that only an explicit False is anonymous to huggingface_hub while None borrows the server owner's login, the fail-closed tri-state custom-code gate, and the regressions each test was written for. Code is provably unchanged: comment_tools.py check reports 17/17 files comments-only. Backend CI command 10337 passed, 0 failed. tsc -b clean.
1661 lines
64 KiB
Python
1661 lines
64 KiB
Python
# SPDX-License-Identifier: AGPL-3.0-only
|
|
# Copyright 2026-present the Unsloth AI Inc. team. All rights reserved. See /studio/LICENSE.AGPL-3.0
|
|
|
|
from __future__ import annotations
|
|
|
|
import builtins
|
|
import subprocess
|
|
import sys
|
|
from typing import Any
|
|
from unittest import mock
|
|
|
|
from core.training import worker
|
|
|
|
|
|
def _missing_flash_attn_import():
|
|
real_import = builtins.__import__
|
|
|
|
def fake_import(
|
|
name,
|
|
globals = None,
|
|
locals = None,
|
|
fromlist = (),
|
|
level = 0,
|
|
):
|
|
if name == "flash_attn":
|
|
raise ImportError
|
|
return real_import(name, globals, locals, fromlist, level)
|
|
|
|
return fake_import
|
|
|
|
|
|
def _missing_module_import(missing: str):
|
|
real_import = builtins.__import__
|
|
|
|
def fake_import(
|
|
name,
|
|
globals = None,
|
|
locals = None,
|
|
fromlist = (),
|
|
level = 0,
|
|
):
|
|
if name == missing:
|
|
raise ImportError
|
|
return real_import(name, globals, locals, fromlist, level)
|
|
|
|
return fake_import
|
|
|
|
|
|
def test_should_try_runtime_flash_attn_install_threshold_and_skip(monkeypatch):
|
|
monkeypatch.delenv(worker._FLASH_ATTN_SKIP_ENV, raising = False)
|
|
assert worker._should_try_runtime_flash_attn_install(32767) is False
|
|
assert worker._should_try_runtime_flash_attn_install(32768) is sys.platform.startswith("linux")
|
|
|
|
monkeypatch.setenv(worker._FLASH_ATTN_SKIP_ENV, "1")
|
|
assert worker._should_try_runtime_flash_attn_install(32768) is False
|
|
|
|
|
|
def test_runtime_flash_attn_prefers_prebuilt_wheel(monkeypatch):
|
|
statuses: list[str] = []
|
|
|
|
monkeypatch.delenv(worker._FLASH_ATTN_SKIP_ENV, raising = False)
|
|
monkeypatch.setattr(builtins, "__import__", _missing_flash_attn_import())
|
|
monkeypatch.setattr(
|
|
worker,
|
|
"flash_attn_wheel_url",
|
|
lambda env: "https://example.com/fa.whl",
|
|
)
|
|
monkeypatch.setattr(worker, "url_exists", lambda url: True)
|
|
monkeypatch.setattr(
|
|
worker,
|
|
"_send_status",
|
|
lambda queue, message: statuses.append(message),
|
|
)
|
|
monkeypatch.setattr(
|
|
worker,
|
|
"install_wheel",
|
|
lambda *args, **kwargs: [("pip", subprocess.CompletedProcess(["pip"], 0, ""))],
|
|
)
|
|
|
|
worker._ensure_flash_attn_for_long_context(event_queue = [], max_seq_length = 32768)
|
|
|
|
assert statuses == ["Installing flash-attn for faster training..."]
|
|
|
|
|
|
def test_runtime_flash_attn_falls_back_to_pypi(monkeypatch):
|
|
calls: list[list[str]] = []
|
|
statuses: list[str] = []
|
|
|
|
monkeypatch.delenv(worker._FLASH_ATTN_SKIP_ENV, raising = False)
|
|
monkeypatch.setattr(builtins, "__import__", _missing_flash_attn_import())
|
|
monkeypatch.setattr(
|
|
worker,
|
|
"probe_torch_wheel_env",
|
|
lambda timeout = 30: {
|
|
"python_tag": "cp313",
|
|
"torch_mm": "2.10",
|
|
"cuda_major": "13",
|
|
"cxx11abi": "TRUE",
|
|
"platform_tag": "linux_x86_64",
|
|
},
|
|
)
|
|
monkeypatch.setattr(
|
|
worker,
|
|
"flash_attn_wheel_url",
|
|
lambda env: "https://example.com/fa.whl",
|
|
)
|
|
monkeypatch.setattr(worker, "url_exists", lambda url: False)
|
|
monkeypatch.setattr(worker.shutil, "which", lambda name: None)
|
|
monkeypatch.setattr(
|
|
worker,
|
|
"_send_status",
|
|
lambda queue, message: statuses.append(message),
|
|
)
|
|
monkeypatch.setattr(worker, "install_wheel", mock.Mock())
|
|
|
|
def fake_run(
|
|
cmd,
|
|
stdout = None,
|
|
stderr = None,
|
|
text = None,
|
|
):
|
|
calls.append(list(cmd))
|
|
return subprocess.CompletedProcess(cmd, 0, "")
|
|
|
|
monkeypatch.setattr(worker._sp, "run", fake_run)
|
|
|
|
worker._ensure_flash_attn_for_long_context(event_queue = [], max_seq_length = 32768)
|
|
|
|
assert statuses == ["Installing flash-attn from PyPI for long-context training..."]
|
|
assert calls == [[sys.executable, "-m", "pip", "install", "flash-attn"]]
|
|
|
|
|
|
def test_runtime_flash_attn_skip_env_avoids_all_install_work(monkeypatch):
|
|
monkeypatch.setenv(worker._FLASH_ATTN_SKIP_ENV, "1")
|
|
monkeypatch.setattr(worker._sp, "run", mock.Mock())
|
|
|
|
worker._ensure_flash_attn_for_long_context(event_queue = [], max_seq_length = 32768)
|
|
|
|
worker._sp.run.assert_not_called()
|
|
|
|
|
|
def test_causal_conv1d_fast_path_preserves_wheel_first_install_args(monkeypatch):
|
|
install_mock = mock.Mock(return_value = True)
|
|
monkeypatch.setattr(worker, "_install_package_wheel_first", install_mock)
|
|
|
|
worker._ensure_causal_conv1d_fast_path(
|
|
event_queue = [],
|
|
model_name = "tiiuae/Falcon-H1-0.5B-Instruct",
|
|
)
|
|
|
|
install_mock.assert_called_once_with(
|
|
event_queue = [],
|
|
import_name = "causal_conv1d",
|
|
display_name = "causal-conv1d",
|
|
pypi_name = "causal-conv1d",
|
|
pypi_version = worker._CAUSAL_CONV1D_PACKAGE_VERSION,
|
|
filename_prefix = "causal_conv1d",
|
|
release_tag = worker._CAUSAL_CONV1D_RELEASE_TAG,
|
|
release_base_url = "https://github.com/Dao-AILab/causal-conv1d/releases/download",
|
|
)
|
|
|
|
|
|
def test_causal_conv1d_fast_path_includes_qwen3_6_variants(monkeypatch):
|
|
install_mock = mock.Mock(return_value = True)
|
|
monkeypatch.setattr(worker, "_install_package_wheel_first", install_mock)
|
|
|
|
worker._ensure_causal_conv1d_fast_path(
|
|
event_queue = [],
|
|
model_name = "unsloth/Qwen3.6-4B",
|
|
)
|
|
worker._ensure_causal_conv1d_fast_path(
|
|
event_queue = [],
|
|
model_name = "unsloth/Qwen3_6-4B",
|
|
)
|
|
|
|
assert install_mock.call_count == 2
|
|
|
|
|
|
def test_mamba_ssm_path_preserves_wheel_first_install_args(monkeypatch):
|
|
install_mock = mock.Mock(return_value = True)
|
|
monkeypatch.setattr(worker, "_install_package_wheel_first", install_mock)
|
|
|
|
worker._ensure_mamba_ssm(
|
|
event_queue = [],
|
|
model_name = "tiiuae/Falcon-H1-0.5B-Instruct",
|
|
)
|
|
|
|
install_mock.assert_called_once_with(
|
|
event_queue = [],
|
|
import_name = "mamba_ssm",
|
|
display_name = "mamba-ssm",
|
|
pypi_name = "mamba-ssm",
|
|
pypi_version = worker._MAMBA_SSM_PACKAGE_VERSION,
|
|
filename_prefix = "mamba_ssm",
|
|
release_tag = worker._MAMBA_SSM_RELEASE_TAG,
|
|
release_base_url = "https://github.com/state-spaces/mamba/releases/download",
|
|
)
|
|
|
|
|
|
def _force_missing_fla_imports(monkeypatch):
|
|
"""Force fla.modules / fla.ops imports to raise ImportError."""
|
|
real_import = builtins.__import__
|
|
|
|
def fake_import(name, *a, **kw):
|
|
if name.startswith("fla.modules") or name.startswith("fla.ops"):
|
|
raise ImportError
|
|
return real_import(name, *a, **kw)
|
|
|
|
monkeypatch.setattr(builtins, "__import__", fake_import)
|
|
|
|
|
|
def _pin_fla_model_types(monkeypatch):
|
|
"""Pin the auto-discovered FLA allowlist to the Qwen GDN families.
|
|
|
|
`_discover_fla_model_types` scans the *installed* transformers, and
|
|
`models/qwen3_5/` only exists from 5.x. The backend supports
|
|
`transformers>=4.51`, so on a 4.x install the gate returns False and every
|
|
Qwen3.5 assertion below silently no-ops. Pinning keeps these tests hermetic
|
|
across the supported range.
|
|
"""
|
|
monkeypatch.setattr(
|
|
worker,
|
|
"_discover_fla_model_types",
|
|
lambda: frozenset({"qwen3_5", "qwen3_5_moe", "qwen3_6", "qwen3_next"}),
|
|
)
|
|
|
|
|
|
def test_flash_linear_attention_installs_pinned_pair_for_qwen3_5(monkeypatch):
|
|
_pin_fla_model_types(monkeypatch)
|
|
monkeypatch.setattr(worker.shutil, "which", lambda name: "/usr/bin/uv")
|
|
run_mock = mock.Mock(return_value = mock.Mock(returncode = 0, stdout = ""))
|
|
monkeypatch.setattr(worker._sp, "run", run_mock)
|
|
_force_missing_fla_imports(monkeypatch)
|
|
statuses: list[str] = []
|
|
monkeypatch.setattr(worker, "_send_status", lambda queue, msg: statuses.append(msg))
|
|
|
|
worker._ensure_flash_linear_attention(
|
|
event_queue = [],
|
|
model_name = "unsloth/Qwen3.5-2B",
|
|
)
|
|
|
|
run_mock.assert_called_once()
|
|
args = run_mock.call_args[0][0]
|
|
assert f"flash-linear-attention=={worker._FLA_PACKAGE_VERSION}" in args
|
|
assert f"fla-core=={worker._FLA_CORE_PACKAGE_VERSION}" in args
|
|
assert "--no-deps" in args
|
|
assert run_mock.call_args.kwargs["timeout"] == worker._TILELANG_INSTALL_TIMEOUT_S
|
|
assert any("flash-linear-attention" in s for s in statuses)
|
|
|
|
|
|
def test_flash_linear_attention_skips_for_unrelated_models(monkeypatch):
|
|
run_mock = mock.Mock(return_value = mock.Mock(returncode = 0, stdout = ""))
|
|
monkeypatch.setattr(worker._sp, "run", run_mock)
|
|
|
|
worker._ensure_flash_linear_attention(
|
|
event_queue = [],
|
|
model_name = "meta-llama/Llama-3.2-1B-Instruct",
|
|
)
|
|
|
|
run_mock.assert_not_called()
|
|
|
|
|
|
def test_flash_linear_attention_skips_for_ssm_only_models(monkeypatch):
|
|
# Nemotron-H / Falcon-H1 / Granite-H / LFM2 take the mamba_ssm path,
|
|
# never FLA's gated_delta_rule kernels.
|
|
run_mock = mock.Mock(return_value = mock.Mock(returncode = 0, stdout = ""))
|
|
monkeypatch.setattr(worker._sp, "run", run_mock)
|
|
|
|
for name in (
|
|
"tiiuae/Falcon-H1-0.5B-Instruct",
|
|
"nvidia/Nemotron-H-8B-Base",
|
|
"ibm-granite/granite-4.0-h-tiny",
|
|
"LiquidAI/LFM2-1.2B-Instruct",
|
|
):
|
|
worker._ensure_flash_linear_attention(event_queue = [], model_name = name)
|
|
|
|
run_mock.assert_not_called()
|
|
|
|
|
|
def test_flash_linear_attention_matches_full_qwen3_family(monkeypatch):
|
|
monkeypatch.setattr(worker.shutil, "which", lambda name: "/usr/bin/uv")
|
|
run_mock = mock.Mock(return_value = mock.Mock(returncode = 0, stdout = ""))
|
|
monkeypatch.setattr(worker._sp, "run", run_mock)
|
|
_force_missing_fla_imports(monkeypatch)
|
|
monkeypatch.setattr(worker, "_send_status", lambda *a, **k: None)
|
|
# Hermetic discovery: pretend transformers ships all Qwen GDN families.
|
|
monkeypatch.setattr(
|
|
worker,
|
|
"_discover_fla_model_types",
|
|
lambda: frozenset({"qwen3_5", "qwen3_5_moe", "qwen3_6", "qwen3_next"}),
|
|
)
|
|
|
|
for name in (
|
|
"unsloth/Qwen3.5-2B",
|
|
"unsloth/Qwen3_5-MoE-A22B",
|
|
"unsloth/Qwen3.6-4B",
|
|
"unsloth/Qwen3_6-4B",
|
|
"unsloth/Qwen3-Next-80B-A3B",
|
|
"unsloth/Qwen3_Next-80B-A3B",
|
|
):
|
|
worker._ensure_flash_linear_attention(event_queue = [], model_name = name)
|
|
|
|
assert run_mock.call_count == 6
|
|
|
|
|
|
def test_flash_linear_attention_skipped_below_python_3_10(monkeypatch):
|
|
# sys.version_info is a structseq, not constructible; substitute a
|
|
# plain tuple so the `< _FLA_MIN_PYTHON` comparison still works.
|
|
monkeypatch.setattr(worker.sys, "version_info", (3, 9, 0, "final", 0))
|
|
run_mock = mock.Mock(return_value = mock.Mock(returncode = 0, stdout = ""))
|
|
monkeypatch.setattr(worker._sp, "run", run_mock)
|
|
|
|
worker._ensure_flash_linear_attention(
|
|
event_queue = [],
|
|
model_name = "unsloth/Qwen3.5-2B",
|
|
)
|
|
|
|
run_mock.assert_not_called()
|
|
|
|
|
|
def test_flash_linear_attention_skipped_via_env(monkeypatch):
|
|
monkeypatch.setenv(worker._FLA_SKIP_ENV, "1")
|
|
run_mock = mock.Mock(return_value = mock.Mock(returncode = 0, stdout = ""))
|
|
monkeypatch.setattr(worker._sp, "run", run_mock)
|
|
|
|
worker._ensure_flash_linear_attention(
|
|
event_queue = [],
|
|
model_name = "unsloth/Qwen3.5-2B",
|
|
)
|
|
|
|
run_mock.assert_not_called()
|
|
|
|
|
|
def test_flash_linear_attention_skipped_below_torch_2_7(monkeypatch):
|
|
_pin_fla_model_types(monkeypatch)
|
|
monkeypatch.delenv(worker._FLA_SKIP_ENV, raising = False)
|
|
monkeypatch.setattr(worker, "_installed_torch_version_tuple", lambda: (2, 5))
|
|
run_mock = mock.Mock(return_value = mock.Mock(returncode = 0, stdout = ""))
|
|
monkeypatch.setattr(worker._sp, "run", run_mock)
|
|
statuses: list[str] = []
|
|
monkeypatch.setattr(worker, "_send_status", lambda queue, msg: statuses.append(msg))
|
|
|
|
worker._ensure_flash_linear_attention(
|
|
event_queue = [],
|
|
model_name = "unsloth/Qwen3.5-2B",
|
|
)
|
|
|
|
run_mock.assert_not_called()
|
|
assert any("torch>=" in s for s in statuses)
|
|
|
|
|
|
def test_flash_linear_attention_install_includes_einops(monkeypatch):
|
|
_pin_fla_model_types(monkeypatch)
|
|
monkeypatch.delenv(worker._FLA_SKIP_ENV, raising = False)
|
|
monkeypatch.setattr(worker.shutil, "which", lambda name: "/usr/bin/uv")
|
|
monkeypatch.setattr(worker, "_installed_torch_version_tuple", lambda: (2, 9))
|
|
monkeypatch.setattr(worker, "_flash_linear_attention_importable", lambda: False)
|
|
run_mock = mock.Mock(return_value = mock.Mock(returncode = 0, stdout = ""))
|
|
monkeypatch.setattr(worker._sp, "run", run_mock)
|
|
monkeypatch.setattr(worker, "_send_status", lambda *a, **k: None)
|
|
|
|
worker._ensure_flash_linear_attention(
|
|
event_queue = [],
|
|
model_name = "unsloth/Qwen3.5-2B",
|
|
)
|
|
|
|
args = run_mock.call_args[0][0]
|
|
assert "--no-deps" in args
|
|
# packaging and triton are added because fla/utils.py imports them at load
|
|
# but neither is in fla-core's METADATA (an upstream FLA gap).
|
|
assert "einops" in args
|
|
assert "packaging" in args
|
|
assert "triton" in args
|
|
assert f"flash-linear-attention=={worker._FLA_PACKAGE_VERSION}" in args
|
|
assert f"fla-core=={worker._FLA_CORE_PACKAGE_VERSION}" in args
|
|
|
|
|
|
def test_flash_linear_attention_logs_post_install_import_failure(monkeypatch):
|
|
"""pip exits 0 but `import fla.modules` still fails (missing transitive)."""
|
|
_pin_fla_model_types(monkeypatch)
|
|
monkeypatch.delenv(worker._FLA_SKIP_ENV, raising = False)
|
|
monkeypatch.setattr(worker.shutil, "which", lambda name: "/usr/bin/uv")
|
|
monkeypatch.setattr(worker, "_installed_torch_version_tuple", lambda: (2, 9))
|
|
import_calls = {"count": 0}
|
|
|
|
def fake_importable():
|
|
import_calls["count"] += 1
|
|
# Pre-install probe -> False (attempt install); post-install
|
|
# verify -> still False.
|
|
return False
|
|
|
|
monkeypatch.setattr(worker, "_flash_linear_attention_importable", fake_importable)
|
|
run_mock = mock.Mock(return_value = mock.Mock(returncode = 0, stdout = ""))
|
|
monkeypatch.setattr(worker._sp, "run", run_mock)
|
|
statuses: list[str] = []
|
|
monkeypatch.setattr(worker, "_send_status", lambda queue, msg: statuses.append(msg))
|
|
|
|
worker._ensure_flash_linear_attention(
|
|
event_queue = [],
|
|
model_name = "unsloth/Qwen3.5-2B",
|
|
)
|
|
|
|
assert import_calls["count"] == 2
|
|
assert any("not importable" in s for s in statuses)
|
|
|
|
|
|
def test_tilelang_backend_skipped_on_unsupported_linux_arch(monkeypatch):
|
|
monkeypatch.delenv(worker._TILELANG_SKIP_ENV, raising = False)
|
|
monkeypatch.setattr(worker.sys, "platform", "linux")
|
|
import platform as _platform
|
|
|
|
monkeypatch.setattr(_platform, "machine", lambda: "ppc64le")
|
|
run_mock = mock.Mock(return_value = mock.Mock(returncode = 0, stdout = ""))
|
|
monkeypatch.setattr(worker._sp, "run", run_mock)
|
|
|
|
worker._ensure_tilelang_backend(
|
|
event_queue = [],
|
|
model_name = "unsloth/Qwen3.5-2B",
|
|
)
|
|
|
|
run_mock.assert_not_called()
|
|
|
|
|
|
def test_tilelang_backend_pins_only_binary(monkeypatch):
|
|
_pin_fla_model_types(monkeypatch)
|
|
monkeypatch.delenv(worker._TILELANG_SKIP_ENV, raising = False)
|
|
monkeypatch.setattr(worker.shutil, "which", lambda name: "/usr/bin/uv")
|
|
monkeypatch.setattr(worker, "_installed_tvm_ffi_version", lambda: None)
|
|
monkeypatch.setattr(worker, "_tilelang_importable", lambda: False)
|
|
run_mock = mock.Mock(return_value = mock.Mock(returncode = 0, stdout = ""))
|
|
monkeypatch.setattr(worker._sp, "run", run_mock)
|
|
monkeypatch.setattr(worker, "_send_status", lambda *a, **k: None)
|
|
# Bypass the post-install probe too.
|
|
probe_calls = {"count": 0}
|
|
|
|
def fake_probe():
|
|
probe_calls["count"] += 1
|
|
# Pre-install probe: False (install runs); post-install: True
|
|
# (success branch taken).
|
|
return probe_calls["count"] > 1
|
|
|
|
monkeypatch.setattr(worker, "_tilelang_importable", fake_probe)
|
|
|
|
worker._ensure_tilelang_backend(
|
|
event_queue = [],
|
|
model_name = "unsloth/Qwen3.5-2B",
|
|
)
|
|
|
|
args = run_mock.call_args[0][0]
|
|
assert "--only-binary=:all:" in args
|
|
assert "--no-deps" not in args
|
|
|
|
|
|
def _force_missing_tilelang_imports(monkeypatch):
|
|
real_import = builtins.__import__
|
|
|
|
def fake_import(name, *a, **kw):
|
|
if name in ("tilelang", "tvm_ffi"):
|
|
raise ImportError
|
|
return real_import(name, *a, **kw)
|
|
|
|
monkeypatch.setattr(builtins, "__import__", fake_import)
|
|
|
|
|
|
def test_tilelang_backend_installs_pinned_pair_for_qwen3_5(monkeypatch):
|
|
_pin_fla_model_types(monkeypatch)
|
|
monkeypatch.delenv(worker._TILELANG_SKIP_ENV, raising = False)
|
|
monkeypatch.setattr(worker.shutil, "which", lambda name: "/usr/bin/uv")
|
|
monkeypatch.setattr(worker, "_installed_tvm_ffi_version", lambda: None)
|
|
run_mock = mock.Mock(return_value = mock.Mock(returncode = 0, stdout = ""))
|
|
monkeypatch.setattr(worker._sp, "run", run_mock)
|
|
_force_missing_tilelang_imports(monkeypatch)
|
|
statuses: list[str] = []
|
|
monkeypatch.setattr(worker, "_send_status", lambda queue, msg: statuses.append(msg))
|
|
|
|
worker._ensure_tilelang_backend(
|
|
event_queue = [],
|
|
model_name = "unsloth/Qwen3.5-2B",
|
|
)
|
|
|
|
run_mock.assert_called_once()
|
|
args = run_mock.call_args[0][0]
|
|
assert f"apache-tvm-ffi=={worker._APACHE_TVM_FFI_PACKAGE_VERSION}" in args
|
|
assert f"tilelang=={worker._TILELANG_PACKAGE_VERSION}" in args
|
|
assert run_mock.call_args.kwargs["timeout"] == worker._TILELANG_INSTALL_TIMEOUT_S
|
|
assert any("Installing TileLang" in s for s in statuses)
|
|
|
|
|
|
def test_tilelang_backend_reinstalls_when_tvm_ffi_is_broken(monkeypatch):
|
|
"""Repair path issues TWO pip calls:
|
|
|
|
1 (repair): --force-reinstall --no-deps apache-tvm-ffi -- downgrades only
|
|
the broken package; --no-deps stops the cascade through its deps to torch.
|
|
2 (install): plain apache-tvm-ffi + tilelang -- resolves missing transitive
|
|
deps without --force-reinstall, so it never replaces correct packages.
|
|
"""
|
|
_pin_fla_model_types(monkeypatch)
|
|
monkeypatch.delenv(worker._TILELANG_SKIP_ENV, raising = False)
|
|
monkeypatch.setattr(worker.shutil, "which", lambda name: "/usr/bin/uv")
|
|
monkeypatch.setattr(worker, "_installed_tvm_ffi_version", lambda: "0.1.11")
|
|
run_mock = mock.Mock(return_value = mock.Mock(returncode = 0, stdout = ""))
|
|
monkeypatch.setattr(worker._sp, "run", run_mock)
|
|
monkeypatch.setattr(worker, "_send_status", lambda *a, **k: None)
|
|
|
|
worker._ensure_tilelang_backend(
|
|
event_queue = [],
|
|
model_name = "unsloth/Qwen3.5-2B",
|
|
)
|
|
|
|
assert run_mock.call_count == 2
|
|
repair_args, install_args = (call[0][0] for call in run_mock.call_args_list)
|
|
|
|
# Repair: --force-reinstall --no-deps, apache-tvm-ffi ONLY.
|
|
assert "--force-reinstall" in repair_args
|
|
assert "--no-deps" in repair_args, "Repair MUST use --no-deps to avoid replacing torch / CUDA"
|
|
assert "--only-binary=:all:" in repair_args
|
|
assert f"apache-tvm-ffi=={worker._APACHE_TVM_FFI_PACKAGE_VERSION}" in repair_args
|
|
assert all("tilelang" not in a for a in repair_args), "Repair MUST only touch apache-tvm-ffi"
|
|
|
|
# Install: regular dep-resolving install, no --force-reinstall.
|
|
assert "--force-reinstall" not in install_args
|
|
assert "--no-deps" not in install_args
|
|
assert "--only-binary=:all:" in install_args
|
|
assert f"apache-tvm-ffi=={worker._APACHE_TVM_FFI_PACKAGE_VERSION}" in install_args
|
|
assert f"tilelang=={worker._TILELANG_PACKAGE_VERSION}" in install_args
|
|
|
|
|
|
def test_tilelang_backend_skipped_below_python_3_10(monkeypatch):
|
|
monkeypatch.delenv(worker._TILELANG_SKIP_ENV, raising = False)
|
|
# sys.version_info is a structseq, not constructible; substitute a
|
|
# plain tuple so the `< _FLA_MIN_PYTHON` comparison still works.
|
|
monkeypatch.setattr(worker.sys, "version_info", (3, 9, 0, "final", 0))
|
|
run_mock = mock.Mock(return_value = mock.Mock(returncode = 0, stdout = ""))
|
|
monkeypatch.setattr(worker._sp, "run", run_mock)
|
|
|
|
worker._ensure_tilelang_backend(
|
|
event_queue = [],
|
|
model_name = "unsloth/Qwen3.5-2B",
|
|
)
|
|
|
|
run_mock.assert_not_called()
|
|
|
|
|
|
def test_tilelang_backend_skipped_on_windows(monkeypatch):
|
|
monkeypatch.delenv(worker._TILELANG_SKIP_ENV, raising = False)
|
|
monkeypatch.setattr(worker.sys, "platform", "win32")
|
|
run_mock = mock.Mock(return_value = mock.Mock(returncode = 0, stdout = ""))
|
|
monkeypatch.setattr(worker._sp, "run", run_mock)
|
|
|
|
worker._ensure_tilelang_backend(
|
|
event_queue = [],
|
|
model_name = "unsloth/Qwen3.5-2B",
|
|
)
|
|
|
|
run_mock.assert_not_called()
|
|
|
|
|
|
def test_tilelang_backend_swallows_install_timeout(monkeypatch):
|
|
_pin_fla_model_types(monkeypatch)
|
|
monkeypatch.delenv(worker._TILELANG_SKIP_ENV, raising = False)
|
|
monkeypatch.setattr(worker.shutil, "which", lambda name: "/usr/bin/uv")
|
|
monkeypatch.setattr(worker, "_installed_tvm_ffi_version", lambda: None)
|
|
_force_missing_tilelang_imports(monkeypatch)
|
|
|
|
def raise_timeout(*a, **kw):
|
|
raise subprocess.TimeoutExpired(cmd = "pip", timeout = 1)
|
|
|
|
monkeypatch.setattr(worker._sp, "run", raise_timeout)
|
|
statuses: list[str] = []
|
|
monkeypatch.setattr(worker, "_send_status", lambda queue, msg: statuses.append(msg))
|
|
|
|
# Must not raise.
|
|
worker._ensure_tilelang_backend(
|
|
event_queue = [],
|
|
model_name = "unsloth/Qwen3.5-2B",
|
|
)
|
|
|
|
assert any("timed out" in s.lower() for s in statuses)
|
|
|
|
|
|
def test_tilelang_backend_skipped_for_ssm_models(monkeypatch):
|
|
monkeypatch.delenv(worker._TILELANG_SKIP_ENV, raising = False)
|
|
run_mock = mock.Mock(return_value = mock.Mock(returncode = 0, stdout = ""))
|
|
monkeypatch.setattr(worker._sp, "run", run_mock)
|
|
|
|
# Nemotron-H / Falcon-H1 / Granite-H take the mamba_ssm path, not FLA's
|
|
# gated_delta_rule -> tilelang doesn't affect them.
|
|
for name in (
|
|
"tiiuae/Falcon-H1-0.5B-Instruct",
|
|
"nvidia/Nemotron-H-8B-Base",
|
|
"ibm-granite/granite-4.0-h-tiny",
|
|
"meta-llama/Llama-3.2-1B-Instruct",
|
|
):
|
|
worker._ensure_tilelang_backend(event_queue = [], model_name = name)
|
|
|
|
run_mock.assert_not_called()
|
|
|
|
|
|
def test_tilelang_backend_skipped_via_env(monkeypatch):
|
|
monkeypatch.setenv(worker._TILELANG_SKIP_ENV, "1")
|
|
run_mock = mock.Mock(return_value = mock.Mock(returncode = 0, stdout = ""))
|
|
monkeypatch.setattr(worker._sp, "run", run_mock)
|
|
|
|
worker._ensure_tilelang_backend(
|
|
event_queue = [],
|
|
model_name = "unsloth/Qwen3.5-2B",
|
|
)
|
|
|
|
run_mock.assert_not_called()
|
|
|
|
|
|
def test_tilelang_backend_swallows_install_failure(monkeypatch):
|
|
_pin_fla_model_types(monkeypatch)
|
|
monkeypatch.delenv(worker._TILELANG_SKIP_ENV, raising = False)
|
|
monkeypatch.setattr(worker.shutil, "which", lambda name: None)
|
|
monkeypatch.setattr(worker, "_installed_tvm_ffi_version", lambda: None)
|
|
run_mock = mock.Mock(return_value = mock.Mock(returncode = 1, stdout = "boom"))
|
|
monkeypatch.setattr(worker._sp, "run", run_mock)
|
|
_force_missing_tilelang_imports(monkeypatch)
|
|
statuses: list[str] = []
|
|
monkeypatch.setattr(worker, "_send_status", lambda queue, msg: statuses.append(msg))
|
|
|
|
# Should not raise even when pip exits non-zero.
|
|
worker._ensure_tilelang_backend(
|
|
event_queue = [],
|
|
model_name = "unsloth/Qwen3.5-2B",
|
|
)
|
|
|
|
run_mock.assert_called_once()
|
|
assert any("failed" in s.lower() for s in statuses)
|
|
|
|
|
|
# Runtime hook on is_flash_linear_attention_available /
|
|
# is_causal_conv1d_available -- the primary gate in normal operation. The
|
|
# substring tests above cover the SKIP_FAST_PATH_HOOKS=1 fallback.
|
|
|
|
|
|
class _FakeQueue(list):
|
|
"""List with `.put` so worker._send_status can send into it in tests."""
|
|
|
|
def put(self, item):
|
|
self.append(item)
|
|
|
|
|
|
def _make_fake_gate(initial_return: bool):
|
|
"""Callable mimicking transformers' lru_cache-decorated gates.
|
|
|
|
Tracks call count and exposes `cache_clear`. Flip `.next_return` to
|
|
mimic install-then-True behaviour.
|
|
"""
|
|
|
|
class Gate:
|
|
def __init__(self, initial: bool) -> None:
|
|
self.next_return = initial
|
|
self.call_count = 0
|
|
self.cache_clear_count = 0
|
|
|
|
def __call__(self) -> bool:
|
|
self.call_count += 1
|
|
return self.next_return
|
|
|
|
def cache_clear(self) -> None:
|
|
self.cache_clear_count += 1
|
|
|
|
return Gate(initial_return)
|
|
|
|
|
|
def _patch_iu_gates(monkeypatch, fla_gate, conv_gate):
|
|
"""Drop fake gates onto transformers.utils.import_utils for the test."""
|
|
from transformers.utils import import_utils as _iu
|
|
|
|
monkeypatch.setattr(_iu, "is_flash_linear_attention_available", fla_gate)
|
|
monkeypatch.setattr(_iu, "is_causal_conv1d_available", conv_gate)
|
|
|
|
|
|
def test_hook_installs_when_gate_returns_false(monkeypatch):
|
|
_pin_fla_model_types(monkeypatch)
|
|
fla_gate = _make_fake_gate(initial_return = False)
|
|
conv_gate = _make_fake_gate(initial_return = False)
|
|
_patch_iu_gates(monkeypatch, fla_gate, conv_gate)
|
|
|
|
def _fla_install_side_effect(eq):
|
|
fla_gate.next_return = True
|
|
return True
|
|
|
|
fla_install = mock.Mock(side_effect = _fla_install_side_effect)
|
|
tile_install = mock.Mock(side_effect = lambda eq: None)
|
|
|
|
def _conv_install_side_effect(**kw):
|
|
conv_gate.next_return = True
|
|
return True
|
|
|
|
conv_install = mock.Mock(side_effect = _conv_install_side_effect)
|
|
|
|
monkeypatch.setattr(worker, "_ensure_flash_linear_attention_unconditional", fla_install)
|
|
monkeypatch.setattr(worker, "_ensure_tilelang_backend_unconditional", tile_install)
|
|
monkeypatch.setattr(worker, "_install_package_wheel_first", conv_install)
|
|
monkeypatch.delenv(worker._FAST_PATH_HOOKS_SKIP_ENV, raising = False)
|
|
|
|
worker._install_fast_path_hooks(event_queue = _FakeQueue(), model_name = "unsloth/Qwen3.5-2B")
|
|
|
|
from transformers.utils import import_utils as _iu
|
|
|
|
# Both gates wrapped; calling them should drive the install.
|
|
assert _iu.is_flash_linear_attention_available() is True
|
|
fla_install.assert_called_once()
|
|
tile_install.assert_called_once()
|
|
assert _iu.is_causal_conv1d_available() is True
|
|
conv_install.assert_called_once()
|
|
|
|
|
|
def test_hook_skips_install_when_gate_already_true(monkeypatch):
|
|
"""Both gates already True AND tilelang healthy -> zero install work.
|
|
(Tilelang repair on the already-True path is covered by
|
|
test_hook_runs_tilelang_repair_when_fla_already_true.)
|
|
"""
|
|
fla_gate = _make_fake_gate(initial_return = True)
|
|
conv_gate = _make_fake_gate(initial_return = True)
|
|
_patch_iu_gates(monkeypatch, fla_gate, conv_gate)
|
|
|
|
fla_install = mock.Mock()
|
|
tile_install = mock.Mock()
|
|
conv_install = mock.Mock()
|
|
monkeypatch.setattr(worker, "_ensure_flash_linear_attention_unconditional", fla_install)
|
|
monkeypatch.setattr(worker, "_ensure_tilelang_backend_unconditional", tile_install)
|
|
monkeypatch.setattr(worker, "_install_package_wheel_first", conv_install)
|
|
# Tilelang healthy -> post_available path is a no-op (otherwise it
|
|
# would call tile_install, correct but out of scope here).
|
|
monkeypatch.setattr(worker, "_tilelang_importable", lambda: True)
|
|
monkeypatch.setattr(worker, "_installed_tvm_ffi_version", lambda: "0.1.9")
|
|
monkeypatch.delenv(worker._FAST_PATH_HOOKS_SKIP_ENV, raising = False)
|
|
|
|
worker._install_fast_path_hooks(event_queue = _FakeQueue(), model_name = "unsloth/Qwen3.5-2B")
|
|
|
|
from transformers.utils import import_utils as _iu
|
|
|
|
assert _iu.is_flash_linear_attention_available() is True
|
|
assert _iu.is_causal_conv1d_available() is True
|
|
fla_install.assert_not_called()
|
|
tile_install.assert_not_called()
|
|
conv_install.assert_not_called()
|
|
|
|
|
|
def test_hook_idempotent_on_repeat_call(monkeypatch):
|
|
_pin_fla_model_types(monkeypatch)
|
|
fla_gate = _make_fake_gate(initial_return = False)
|
|
conv_gate = _make_fake_gate(initial_return = False)
|
|
_patch_iu_gates(monkeypatch, fla_gate, conv_gate)
|
|
|
|
def _fla_install_side_effect(eq):
|
|
fla_gate.next_return = True
|
|
return True
|
|
|
|
fla_install = mock.Mock(side_effect = _fla_install_side_effect)
|
|
tile_install = mock.Mock()
|
|
|
|
def _conv_install_side_effect(**kw):
|
|
conv_gate.next_return = True
|
|
return True
|
|
|
|
conv_install = mock.Mock(side_effect = _conv_install_side_effect)
|
|
monkeypatch.setattr(worker, "_ensure_flash_linear_attention_unconditional", fla_install)
|
|
monkeypatch.setattr(worker, "_ensure_tilelang_backend_unconditional", tile_install)
|
|
monkeypatch.setattr(worker, "_install_package_wheel_first", conv_install)
|
|
monkeypatch.delenv(worker._FAST_PATH_HOOKS_SKIP_ENV, raising = False)
|
|
|
|
worker._install_fast_path_hooks(event_queue = _FakeQueue(), model_name = "unsloth/Qwen3.5-2B")
|
|
|
|
from transformers.utils import import_utils as _iu
|
|
|
|
# First call: hook fires.
|
|
_iu.is_flash_linear_attention_available()
|
|
# Later calls: must not re-trigger the installer.
|
|
_iu.is_flash_linear_attention_available()
|
|
_iu.is_flash_linear_attention_available()
|
|
assert fla_install.call_count == 1
|
|
assert tile_install.call_count == 1
|
|
|
|
|
|
def test_hook_handles_install_failure_gracefully(monkeypatch):
|
|
fla_gate = _make_fake_gate(initial_return = False)
|
|
conv_gate = _make_fake_gate(initial_return = True) # bypass to focus on FLA
|
|
_patch_iu_gates(monkeypatch, fla_gate, conv_gate)
|
|
|
|
def raising_install(eq):
|
|
raise RuntimeError("pip failed to fetch wheel")
|
|
|
|
monkeypatch.setattr(worker, "_ensure_flash_linear_attention_unconditional", raising_install)
|
|
monkeypatch.setattr(worker, "_ensure_tilelang_backend_unconditional", lambda eq: None)
|
|
monkeypatch.setattr(worker, "_install_package_wheel_first", lambda **kw: None)
|
|
monkeypatch.delenv(worker._FAST_PATH_HOOKS_SKIP_ENV, raising = False)
|
|
|
|
worker._install_fast_path_hooks(event_queue = _FakeQueue(), model_name = "unsloth/Qwen3.5-2B")
|
|
|
|
from transformers.utils import import_utils as _iu
|
|
|
|
# Must not raise; returns False so transformers uses the torch loop.
|
|
assert _iu.is_flash_linear_attention_available() is False
|
|
|
|
|
|
def test_hook_can_be_disabled_via_env(monkeypatch):
|
|
fla_gate = _make_fake_gate(initial_return = False)
|
|
conv_gate = _make_fake_gate(initial_return = False)
|
|
_patch_iu_gates(monkeypatch, fla_gate, conv_gate)
|
|
|
|
fla_install = mock.Mock()
|
|
monkeypatch.setattr(worker, "_ensure_flash_linear_attention_unconditional", fla_install)
|
|
monkeypatch.setenv(worker._FAST_PATH_HOOKS_SKIP_ENV, "1")
|
|
|
|
worker._install_fast_path_hooks(event_queue = _FakeQueue(), model_name = "unsloth/Qwen3.5-2B")
|
|
|
|
from transformers.utils import import_utils as _iu
|
|
|
|
# Hook not installed; gates remain the fakes.
|
|
assert _iu.is_flash_linear_attention_available is fla_gate
|
|
assert _iu.is_causal_conv1d_available is conv_gate
|
|
fla_install.assert_not_called()
|
|
|
|
|
|
def test_hook_clears_lru_cache_before_first_check(monkeypatch):
|
|
fla_gate = _make_fake_gate(initial_return = True)
|
|
conv_gate = _make_fake_gate(initial_return = True)
|
|
_patch_iu_gates(monkeypatch, fla_gate, conv_gate)
|
|
|
|
monkeypatch.setattr(worker, "_ensure_flash_linear_attention_unconditional", lambda eq: None)
|
|
monkeypatch.setattr(worker, "_ensure_tilelang_backend_unconditional", lambda eq: None)
|
|
monkeypatch.setattr(worker, "_install_package_wheel_first", lambda **kw: None)
|
|
monkeypatch.delenv(worker._FAST_PATH_HOOKS_SKIP_ENV, raising = False)
|
|
|
|
worker._install_fast_path_hooks(event_queue = _FakeQueue(), model_name = "unsloth/Qwen3.5-2B")
|
|
from transformers.utils import import_utils as _iu
|
|
|
|
_iu.is_flash_linear_attention_available()
|
|
# Wrapper called cache_clear at least once before delegating.
|
|
assert fla_gate.cache_clear_count >= 1
|
|
|
|
|
|
def test_hook_rewrites_previously_imported_module_bindings(monkeypatch):
|
|
"""Modeling files bind is_flash_linear_attention_available locally via
|
|
`from ... import is_X`. Reassigning the attribute on import_utils alone
|
|
misses those; the hook installer sweeps sys.modules and rebinds them.
|
|
"""
|
|
fla_gate = _make_fake_gate(initial_return = False)
|
|
conv_gate = _make_fake_gate(initial_return = True)
|
|
_patch_iu_gates(monkeypatch, fla_gate, conv_gate)
|
|
|
|
# Fake modeling module that did `from ... import is_flash_linear_attention_available`.
|
|
fake_mod = sys.modules.setdefault(
|
|
"_test_fake_modeling_qwen35", type(sys)("_test_fake_modeling_qwen35")
|
|
)
|
|
fake_mod.is_flash_linear_attention_available = fla_gate
|
|
|
|
def fake_install(eq):
|
|
fla_gate.next_return = True
|
|
return True
|
|
|
|
monkeypatch.setattr(worker, "_ensure_flash_linear_attention_unconditional", fake_install)
|
|
monkeypatch.setattr(worker, "_ensure_tilelang_backend_unconditional", lambda eq: True)
|
|
monkeypatch.setattr(worker, "_install_package_wheel_first", lambda **kw: True)
|
|
monkeypatch.delenv(worker._FAST_PATH_HOOKS_SKIP_ENV, raising = False)
|
|
|
|
worker._install_fast_path_hooks(event_queue = _FakeQueue(), model_name = "unsloth/Qwen3.5-2B")
|
|
|
|
# The fake module's local binding is rewritten to the wrapper.
|
|
assert fake_mod.is_flash_linear_attention_available is not fla_gate
|
|
# Calling through the fake module's reference triggers install.
|
|
assert fake_mod.is_flash_linear_attention_available() is True
|
|
|
|
del sys.modules["_test_fake_modeling_qwen35"]
|
|
|
|
|
|
def test_hook_skips_when_import_utils_unavailable(monkeypatch):
|
|
"""If transformers.utils.import_utils can't be imported, the hook
|
|
installer must log and return cleanly rather than crash the worker."""
|
|
real_import = builtins.__import__
|
|
|
|
def fake_import(name, *a, **kw):
|
|
if name == "transformers.utils" or name == "transformers.utils.import_utils":
|
|
raise ImportError("transformers missing in worker venv")
|
|
return real_import(name, *a, **kw)
|
|
|
|
monkeypatch.setattr(builtins, "__import__", fake_import)
|
|
monkeypatch.delenv(worker._FAST_PATH_HOOKS_SKIP_ENV, raising = False)
|
|
|
|
# Should not raise.
|
|
worker._install_fast_path_hooks(event_queue = _FakeQueue(), model_name = "unsloth/Qwen3.5-2B")
|
|
|
|
|
|
def test_substring_fallback_unchanged_when_hook_skipped(monkeypatch):
|
|
"""Hook disabled -> legacy gate falls back to auto-discovered types."""
|
|
install_mock = mock.Mock()
|
|
monkeypatch.setattr(worker, "_ensure_flash_linear_attention_unconditional", install_mock)
|
|
monkeypatch.setattr(worker, "_discover_fla_model_types", lambda: frozenset({"qwen3_5"}))
|
|
monkeypatch.setenv(worker._FAST_PATH_HOOKS_SKIP_ENV, "1")
|
|
|
|
worker._ensure_flash_linear_attention(event_queue = [], model_name = "unsloth/Qwen3.5-2B")
|
|
assert install_mock.call_count == 1
|
|
|
|
worker._ensure_flash_linear_attention(event_queue = [], model_name = "meta-llama/Llama-3.1-8B")
|
|
assert install_mock.call_count == 1
|
|
|
|
|
|
# Regression tests for the reviewer findings:
|
|
# 1. tilelang Qwen-guard on hook path (non-Qwen FLA models)
|
|
# 2. tilelang repair must not replace torch / CUDA stack
|
|
# 3. hook must trust installer's bool, not transformers metadata
|
|
# 4. causal-conv1d must stay eager for SSM models that bypass the gate
|
|
# 5. rebind sweep must not invoke lazy module __getattr__
|
|
# 6. tilelang skipped when FLA was skipped / failed
|
|
# 7. tilelang repair runs when FLA is already True
|
|
# 8. older FLA detected as stale and reinstalled
|
|
|
|
|
|
def test_hook_does_not_install_tilelang_for_model_outside_allowlist(monkeypatch):
|
|
"""A model not in the auto-discovered FLA allowlist calls
|
|
is_flash_linear_attention_available but must NOT get tilelang."""
|
|
fla_gate = _make_fake_gate(initial_return = False)
|
|
conv_gate = _make_fake_gate(initial_return = True)
|
|
_patch_iu_gates(monkeypatch, fla_gate, conv_gate)
|
|
|
|
def _fla_install(eq):
|
|
fla_gate.next_return = True
|
|
return True
|
|
|
|
fla_install = mock.Mock(side_effect = _fla_install)
|
|
tile_install = mock.Mock(return_value = True)
|
|
monkeypatch.setattr(worker, "_ensure_flash_linear_attention_unconditional", fla_install)
|
|
monkeypatch.setattr(worker, "_ensure_tilelang_backend_unconditional", tile_install)
|
|
monkeypatch.setattr(worker, "_install_package_wheel_first", mock.Mock(return_value = True))
|
|
monkeypatch.delenv(worker._FAST_PATH_HOOKS_SKIP_ENV, raising = False)
|
|
# Hermetize the auto-discovered set so the test stays valid as new
|
|
# transformers releases add FLA-using model_types (eg olmo_hybrid in
|
|
# 5.4.0). Test semantic: "outside-allowlist -> no tilelang".
|
|
monkeypatch.setattr(
|
|
worker,
|
|
"_discover_fla_model_types",
|
|
lambda: frozenset({"qwen3_5", "qwen3_5_moe", "qwen3_next"}),
|
|
)
|
|
|
|
worker._install_fast_path_hooks(
|
|
event_queue = _FakeQueue(),
|
|
model_name = "fake-org/Fictional-FLA-Only-Model-7B",
|
|
)
|
|
|
|
from transformers.utils import import_utils as _iu
|
|
|
|
assert _iu.is_flash_linear_attention_available() is True
|
|
fla_install.assert_called_once()
|
|
tile_install.assert_not_called()
|
|
|
|
|
|
def test_hook_does_install_tilelang_for_qwen35(monkeypatch):
|
|
"""Positive control for finding #1: Qwen3.5 still gets tilelang."""
|
|
_pin_fla_model_types(monkeypatch)
|
|
fla_gate = _make_fake_gate(initial_return = False)
|
|
conv_gate = _make_fake_gate(initial_return = True)
|
|
_patch_iu_gates(monkeypatch, fla_gate, conv_gate)
|
|
|
|
def _fla_install(eq):
|
|
fla_gate.next_return = True
|
|
return True
|
|
|
|
fla_install = mock.Mock(side_effect = _fla_install)
|
|
tile_install = mock.Mock(return_value = True)
|
|
monkeypatch.setattr(worker, "_ensure_flash_linear_attention_unconditional", fla_install)
|
|
monkeypatch.setattr(worker, "_ensure_tilelang_backend_unconditional", tile_install)
|
|
monkeypatch.setattr(worker, "_install_package_wheel_first", mock.Mock(return_value = True))
|
|
monkeypatch.delenv(worker._FAST_PATH_HOOKS_SKIP_ENV, raising = False)
|
|
|
|
worker._install_fast_path_hooks(event_queue = _FakeQueue(), model_name = "unsloth/Qwen3.5-2B")
|
|
|
|
from transformers.utils import import_utils as _iu
|
|
|
|
_iu.is_flash_linear_attention_available()
|
|
fla_install.assert_called_once()
|
|
tile_install.assert_called_once()
|
|
|
|
|
|
def test_tilelang_repair_does_not_touch_torch_cuda_stack(monkeypatch):
|
|
"""Finding #2: the broken-tvm-ffi repair must use --no-deps on the
|
|
forced step so --force-reinstall doesn't cascade through
|
|
apache-tvm-ffi's dep graph and pull a different torch wheel.
|
|
"""
|
|
_pin_fla_model_types(monkeypatch)
|
|
monkeypatch.delenv(worker._TILELANG_SKIP_ENV, raising = False)
|
|
monkeypatch.setattr(worker.shutil, "which", lambda name: "/usr/bin/uv")
|
|
monkeypatch.setattr(worker, "_installed_tvm_ffi_version", lambda: "0.1.10")
|
|
run_mock = mock.Mock(return_value = mock.Mock(returncode = 0, stdout = ""))
|
|
monkeypatch.setattr(worker._sp, "run", run_mock)
|
|
monkeypatch.setattr(worker, "_send_status", lambda *a, **k: None)
|
|
|
|
worker._ensure_tilelang_backend(event_queue = [], model_name = "unsloth/Qwen3.5-2B")
|
|
|
|
assert run_mock.call_count == 2
|
|
repair_args = run_mock.call_args_list[0][0][0]
|
|
# Forced step MUST be --no-deps so torch / CUDA stack is untouched.
|
|
assert "--force-reinstall" in repair_args and "--no-deps" in repair_args
|
|
# Touches ONLY apache-tvm-ffi, not tilelang / torch.
|
|
assert all("tilelang" not in a for a in repair_args)
|
|
assert all("torch" not in a for a in repair_args)
|
|
|
|
|
|
def test_hook_trusts_installer_bool_not_metadata(monkeypatch):
|
|
"""Finding #3: if pip exits 0 but deep imports fail, the installer returns
|
|
False; the hook must propagate that False even if the metadata-only gate
|
|
returns True after pip succeeds, so transformers takes the torch fallback.
|
|
"""
|
|
# Gate flips True after install (simulating "metadata sees fla").
|
|
fla_gate = _make_fake_gate(initial_return = False)
|
|
conv_gate = _make_fake_gate(initial_return = True)
|
|
_patch_iu_gates(monkeypatch, fla_gate, conv_gate)
|
|
|
|
# Installer "succeeds" at pip and flips the gate to True (metadata
|
|
# sees fla post-install), but returns False (deep import broken).
|
|
def _bad_install(eq):
|
|
fla_gate.next_return = True # metadata says yes after pip
|
|
return False # but deep import is broken
|
|
|
|
fake_fla_install = mock.Mock(side_effect = _bad_install)
|
|
monkeypatch.setattr(worker, "_ensure_flash_linear_attention_unconditional", fake_fla_install)
|
|
monkeypatch.setattr(
|
|
worker, "_ensure_tilelang_backend_unconditional", mock.Mock(return_value = True)
|
|
)
|
|
monkeypatch.setattr(worker, "_install_package_wheel_first", mock.Mock(return_value = True))
|
|
monkeypatch.delenv(worker._FAST_PATH_HOOKS_SKIP_ENV, raising = False)
|
|
|
|
worker._install_fast_path_hooks(event_queue = _FakeQueue(), model_name = "unsloth/Qwen3.5-2B")
|
|
|
|
from transformers.utils import import_utils as _iu
|
|
|
|
# Hook MUST return False (installer's verdict), not True (metadata lies).
|
|
assert _iu.is_flash_linear_attention_available() is False
|
|
fake_fla_install.assert_called_once()
|
|
|
|
|
|
def test_rebind_does_not_trigger_module_getattr(monkeypatch):
|
|
"""Finding #5: the rebind sweep must use __dict__, not getattr(), to
|
|
avoid invoking transformers' lazy module __getattr__ which spits out
|
|
hundreds of "Accessing X from .models..." warnings.
|
|
"""
|
|
original = object()
|
|
replacement = object()
|
|
|
|
class _GetattrTripwire(type(sys)):
|
|
getattr_called = False
|
|
|
|
def __getattr__(self, name):
|
|
type(self).getattr_called = True
|
|
raise AttributeError(name)
|
|
|
|
lazy = _GetattrTripwire("_lazy_test_module")
|
|
sys.modules["_lazy_test_module"] = lazy
|
|
try:
|
|
# No `is_flash_linear_attention_available` in __dict__, so the
|
|
# sweep must NOT trip the tripwire.
|
|
worker._rebind_in_already_imported_modules(
|
|
attr_name = "is_flash_linear_attention_available",
|
|
old_obj = original,
|
|
new_obj = replacement,
|
|
)
|
|
assert (
|
|
not _GetattrTripwire.getattr_called
|
|
), "Rebind sweep invoked __getattr__ — should use __dict__ probe"
|
|
finally:
|
|
sys.modules.pop("_lazy_test_module", None)
|
|
|
|
|
|
def test_hook_skips_tilelang_when_fla_install_is_skipped(monkeypatch):
|
|
"""Finding #6: env-skipped FLA returns False from
|
|
_ensure_flash_linear_attention_unconditional; tilelang must NOT
|
|
install then.
|
|
"""
|
|
fla_gate = _make_fake_gate(initial_return = False)
|
|
conv_gate = _make_fake_gate(initial_return = True)
|
|
_patch_iu_gates(monkeypatch, fla_gate, conv_gate)
|
|
|
|
monkeypatch.setenv(worker._FLA_SKIP_ENV, "1")
|
|
tile_install = mock.Mock(return_value = True)
|
|
monkeypatch.setattr(worker, "_ensure_tilelang_backend_unconditional", tile_install)
|
|
monkeypatch.setattr(worker, "_install_package_wheel_first", mock.Mock(return_value = True))
|
|
monkeypatch.delenv(worker._FAST_PATH_HOOKS_SKIP_ENV, raising = False)
|
|
|
|
worker._install_fast_path_hooks(event_queue = _FakeQueue(), model_name = "unsloth/Qwen3.5-2B")
|
|
|
|
from transformers.utils import import_utils as _iu
|
|
|
|
# FLA gate stays False (env-skipped, install never ran).
|
|
assert _iu.is_flash_linear_attention_available() is False
|
|
tile_install.assert_not_called()
|
|
|
|
|
|
def test_hook_runs_tilelang_repair_when_fla_already_true(monkeypatch):
|
|
"""Finding #7: when FLA is already importable (gate True at first
|
|
probe) but tilelang is missing or apache-tvm-ffi is on the broken
|
|
list, the post-available action must still run tilelang.
|
|
"""
|
|
_pin_fla_model_types(monkeypatch)
|
|
fla_gate = _make_fake_gate(initial_return = True)
|
|
conv_gate = _make_fake_gate(initial_return = True)
|
|
_patch_iu_gates(monkeypatch, fla_gate, conv_gate)
|
|
|
|
fla_install = mock.Mock(return_value = True)
|
|
tile_install = mock.Mock(return_value = True)
|
|
monkeypatch.setattr(worker, "_ensure_flash_linear_attention_unconditional", fla_install)
|
|
monkeypatch.setattr(worker, "_ensure_tilelang_backend_unconditional", tile_install)
|
|
monkeypatch.setattr(worker, "_install_package_wheel_first", mock.Mock(return_value = True))
|
|
# tilelang missing AND tvm-ffi on broken list — both trigger repair.
|
|
monkeypatch.setattr(worker, "_tilelang_importable", lambda: False)
|
|
monkeypatch.setattr(worker, "_installed_tvm_ffi_version", lambda: "0.1.11")
|
|
monkeypatch.delenv(worker._FAST_PATH_HOOKS_SKIP_ENV, raising = False)
|
|
|
|
worker._install_fast_path_hooks(event_queue = _FakeQueue(), model_name = "unsloth/Qwen3.5-2B")
|
|
|
|
from transformers.utils import import_utils as _iu
|
|
|
|
_iu.is_flash_linear_attention_available()
|
|
# FLA install NOT needed; tilelang repair still triggered.
|
|
fla_install.assert_not_called()
|
|
tile_install.assert_called_once()
|
|
|
|
|
|
def test_fla_installer_force_reinstalls_when_older_version_present(monkeypatch):
|
|
"""Finding #8: an older `flash-linear-attention` that is importable
|
|
but below the pin must force a reinstall (not no-op).
|
|
"""
|
|
monkeypatch.delenv(worker._FLA_SKIP_ENV, raising = False)
|
|
monkeypatch.setattr(worker.shutil, "which", lambda name: "/usr/bin/uv")
|
|
monkeypatch.setattr(worker, "_installed_torch_version_tuple", lambda: (2, 9))
|
|
# Importable but stale (current()=False though importable()=True).
|
|
monkeypatch.setattr(worker, "_flash_linear_attention_importable", lambda: True)
|
|
monkeypatch.setattr(worker, "_flash_linear_attention_current", lambda **kw: False)
|
|
run_mock = mock.Mock(return_value = mock.Mock(returncode = 0, stdout = ""))
|
|
monkeypatch.setattr(worker._sp, "run", run_mock)
|
|
monkeypatch.setattr(worker, "_send_status", lambda *a, **k: None)
|
|
|
|
worker._ensure_flash_linear_attention_unconditional(event_queue = [])
|
|
|
|
run_mock.assert_called_once()
|
|
args = run_mock.call_args[0][0]
|
|
assert (
|
|
"--force-reinstall" in args
|
|
), "Stale FLA must trigger --force-reinstall, otherwise pip is a no-op"
|
|
# --no-deps still applies so torch stays untouched.
|
|
assert "--no-deps" in args
|
|
|
|
|
|
def test_run_training_process_eagerly_installs_causal_conv1d_in_normal_mode():
|
|
"""Finding #4: SSM modeling files use lazy_load_kernel and never call
|
|
is_causal_conv1d_available(), so the hook won't fire; the orchestrator must
|
|
always run the eager installer regardless of hook mode. Reads the worker
|
|
source and asserts the eager install is OUTSIDE the if/else hook branch.
|
|
"""
|
|
import inspect
|
|
|
|
src = inspect.getsource(worker.run_training_process)
|
|
# Orchestration block.
|
|
assert "_ensure_causal_conv1d_fast_path(event_queue, model_name)" in src
|
|
assert "_install_fast_path_hooks(event_queue, model_name)" in src
|
|
# Eager causal_conv1d call must come BEFORE the hook-mode if/else, not
|
|
# nested inside the `if _FAST_PATH_HOOKS_SKIP_ENV` branch.
|
|
eager_pos = src.find("_ensure_causal_conv1d_fast_path(event_queue, model_name)")
|
|
skip_check_pos = src.find('os.getenv(_FAST_PATH_HOOKS_SKIP_ENV) == "1"')
|
|
assert eager_pos < skip_check_pos, (
|
|
"_ensure_causal_conv1d_fast_path must be called BEFORE the hook-mode "
|
|
"branch, so SSM models that bypass is_causal_conv1d_available() still "
|
|
"get the eager install"
|
|
)
|
|
|
|
|
|
# HIP / ROCm regression coverage (Strix Halo report).
|
|
# tilelang 0.1.8 has no HIP GEMM backend; FLA's TileLang dispatch crashes
|
|
# mid-backward on AMD ("Unsupported target for gemm: hip"). Fix: skip install on
|
|
# HIP torch AND setdefault FLA_TILELANG=0 so an existing tilelang isn't used.
|
|
|
|
|
|
def test_tilelang_platform_unsupported_on_hip_torch(monkeypatch):
|
|
"""Strix Halo / MI300 with ROCm torch: linux + x86_64 looks identical
|
|
to a CUDA box at the OS level, so the platform check must consult
|
|
torch.version.hip explicitly.
|
|
"""
|
|
monkeypatch.setattr(worker, "_torch_has_hip", lambda: True)
|
|
assert worker._tilelang_platform_supported() is False
|
|
|
|
|
|
def test_tilelang_install_skipped_on_hip_torch(monkeypatch):
|
|
"""End-to-end: the unconditional installer must not call pip on HIP torch."""
|
|
monkeypatch.delenv(worker._TILELANG_SKIP_ENV, raising = False)
|
|
monkeypatch.setattr(worker, "_torch_has_hip", lambda: True)
|
|
run_mock = mock.Mock(return_value = mock.Mock(returncode = 0, stdout = ""))
|
|
monkeypatch.setattr(worker._sp, "run", run_mock)
|
|
monkeypatch.setattr(worker, "_send_status", lambda *a, **k: None)
|
|
|
|
result = worker._ensure_tilelang_backend_unconditional(event_queue = [])
|
|
|
|
assert result is False
|
|
run_mock.assert_not_called()
|
|
|
|
|
|
def test_install_fast_path_hooks_sets_fla_tilelang_zero_on_hip(monkeypatch):
|
|
"""On HIP torch, the hook installer must setdefault FLA_TILELANG=0
|
|
(respecting user override) so a PRE-EXISTING tilelang install isn't
|
|
used by FLA's dispatcher.
|
|
"""
|
|
import os as _os
|
|
|
|
monkeypatch.delenv("FLA_TILELANG", raising = False)
|
|
monkeypatch.delenv(worker._FAST_PATH_HOOKS_SKIP_ENV, raising = False)
|
|
monkeypatch.setattr(worker, "_torch_has_hip", lambda: True)
|
|
monkeypatch.setattr(worker, "_ensure_flash_linear_attention_unconditional", lambda eq: True)
|
|
monkeypatch.setattr(worker, "_ensure_tilelang_backend_unconditional", lambda eq: True)
|
|
monkeypatch.setattr(worker, "_install_package_wheel_first", lambda **kw: True)
|
|
|
|
worker._install_fast_path_hooks(event_queue = _FakeQueue(), model_name = "unsloth/Qwen3.5-2B")
|
|
|
|
assert _os.environ.get("FLA_TILELANG") == "0"
|
|
|
|
|
|
def test_install_fast_path_hooks_respects_user_fla_tilelang_override(monkeypatch):
|
|
"""If the user set FLA_TILELANG (even on HIP), don't overwrite — they
|
|
may have a HIP-aware tilelang fork.
|
|
"""
|
|
import os as _os
|
|
|
|
monkeypatch.setenv("FLA_TILELANG", "1")
|
|
monkeypatch.delenv(worker._FAST_PATH_HOOKS_SKIP_ENV, raising = False)
|
|
monkeypatch.setattr(worker, "_torch_has_hip", lambda: True)
|
|
monkeypatch.setattr(worker, "_ensure_flash_linear_attention_unconditional", lambda eq: True)
|
|
monkeypatch.setattr(worker, "_ensure_tilelang_backend_unconditional", lambda eq: True)
|
|
monkeypatch.setattr(worker, "_install_package_wheel_first", lambda **kw: True)
|
|
|
|
worker._install_fast_path_hooks(event_queue = _FakeQueue(), model_name = "unsloth/Qwen3.5-2B")
|
|
|
|
assert _os.environ["FLA_TILELANG"] == "1"
|
|
|
|
|
|
def test_install_fast_path_hooks_does_not_set_fla_tilelang_on_cuda(monkeypatch):
|
|
"""CUDA path must NOT set FLA_TILELANG (tilelang is wanted there)."""
|
|
import os as _os
|
|
|
|
monkeypatch.delenv("FLA_TILELANG", raising = False)
|
|
monkeypatch.delenv(worker._FAST_PATH_HOOKS_SKIP_ENV, raising = False)
|
|
monkeypatch.setattr(worker, "_torch_has_hip", lambda: False)
|
|
monkeypatch.setattr(worker, "_ensure_flash_linear_attention_unconditional", lambda eq: True)
|
|
monkeypatch.setattr(worker, "_ensure_tilelang_backend_unconditional", lambda eq: True)
|
|
monkeypatch.setattr(worker, "_install_package_wheel_first", lambda **kw: True)
|
|
|
|
worker._install_fast_path_hooks(event_queue = _FakeQueue(), model_name = "unsloth/Qwen3.5-2B")
|
|
|
|
assert _os.environ.get("FLA_TILELANG") is None
|
|
|
|
|
|
# ───────────────────────────────────────────────────────────────────
|
|
# Auto-discovery of FLA model_types from the installed transformers
|
|
# ───────────────────────────────────────────────────────────────────
|
|
|
|
|
|
def _make_fake_transformers_tree(tmp_path, fla_types: list[str], non_fla_types: list[str]):
|
|
"""Lay out tmp dir as `transformers/models/{type}/modeling_{type}.py`."""
|
|
pkg = tmp_path / "transformers"
|
|
models = pkg / "models"
|
|
models.mkdir(parents = True)
|
|
(pkg / "__init__.py").write_text("")
|
|
for t in fla_types:
|
|
d = models / t
|
|
d.mkdir()
|
|
(d / f"modeling_{t}.py").write_text(
|
|
"from ...utils.import_utils import is_flash_linear_attention_available\n"
|
|
"if is_flash_linear_attention_available():\n"
|
|
" from fla.modules import FusedRMSNormGated\n"
|
|
" from fla.ops.gated_delta_rule import chunk_gated_delta_rule\n"
|
|
)
|
|
for t in non_fla_types:
|
|
d = models / t
|
|
d.mkdir()
|
|
(d / f"modeling_{t}.py").write_text("class Foo: pass\n")
|
|
return pkg
|
|
|
|
|
|
def _reset_fla_cache(monkeypatch):
|
|
monkeypatch.setattr(worker, "_TRANSFORMERS_FLA_MODEL_TYPES_CACHE", None)
|
|
|
|
|
|
def test_discover_fla_model_types_returns_only_fla_users(tmp_path, monkeypatch):
|
|
pkg = _make_fake_transformers_tree(
|
|
tmp_path,
|
|
fla_types = ["qwen3_5", "qwen3_5_moe", "qwen3_next"],
|
|
non_fla_types = ["llama", "gpt2", "mistral"],
|
|
)
|
|
fake = mock.MagicMock(__file__ = str(pkg / "__init__.py"))
|
|
monkeypatch.setitem(sys.modules, "transformers", fake)
|
|
_reset_fla_cache(monkeypatch)
|
|
|
|
result = worker._discover_fla_model_types()
|
|
assert result == frozenset({"qwen3_5", "qwen3_5_moe", "qwen3_next"})
|
|
assert "llama" not in result
|
|
assert "gpt2" not in result
|
|
|
|
|
|
def test_discover_fla_model_types_caches_across_calls(tmp_path, monkeypatch):
|
|
pkg = _make_fake_transformers_tree(tmp_path, fla_types = ["qwen3_5"], non_fla_types = [])
|
|
fake = mock.MagicMock(__file__ = str(pkg / "__init__.py"))
|
|
monkeypatch.setitem(sys.modules, "transformers", fake)
|
|
_reset_fla_cache(monkeypatch)
|
|
|
|
from pathlib import Path as _Path
|
|
|
|
read_calls = [0]
|
|
real_read = _Path.read_text
|
|
|
|
def counting_read(self, *a, **kw):
|
|
read_calls[0] += 1
|
|
return real_read(self, *a, **kw)
|
|
|
|
monkeypatch.setattr(_Path, "read_text", counting_read)
|
|
|
|
first = worker._discover_fla_model_types()
|
|
after_first = read_calls[0]
|
|
second = worker._discover_fla_model_types()
|
|
|
|
assert first == second
|
|
assert read_calls[0] == after_first # cache hit: no extra reads
|
|
|
|
|
|
def test_discover_fla_model_types_handles_missing_transformers(monkeypatch):
|
|
_reset_fla_cache(monkeypatch)
|
|
|
|
real_import = builtins.__import__
|
|
|
|
def fake_import(
|
|
name,
|
|
globals = None,
|
|
locals = None,
|
|
fromlist = (),
|
|
level = 0,
|
|
):
|
|
if name == "transformers":
|
|
raise ImportError("transformers not installed")
|
|
return real_import(name, globals, locals, fromlist, level)
|
|
|
|
monkeypatch.setattr(builtins, "__import__", fake_import)
|
|
result = worker._discover_fla_model_types()
|
|
assert result == frozenset()
|
|
|
|
|
|
def test_discover_fla_model_types_handles_unreadable_file(tmp_path, monkeypatch):
|
|
pkg = _make_fake_transformers_tree(tmp_path, fla_types = ["qwen3_5"], non_fla_types = [])
|
|
fake = mock.MagicMock(__file__ = str(pkg / "__init__.py"))
|
|
monkeypatch.setitem(sys.modules, "transformers", fake)
|
|
_reset_fla_cache(monkeypatch)
|
|
|
|
from pathlib import Path as _Path
|
|
|
|
real_read = _Path.read_text
|
|
|
|
def boom_read(self, *a, **kw):
|
|
if "modeling_qwen3_5.py" in str(self):
|
|
raise OSError("permission denied")
|
|
return real_read(self, *a, **kw)
|
|
|
|
monkeypatch.setattr(_Path, "read_text", boom_read)
|
|
result = worker._discover_fla_model_types()
|
|
assert result == frozenset() # unreadable file doesn't contribute
|
|
|
|
|
|
def test_model_wants_tilelang_handles_real_repo_names(monkeypatch):
|
|
monkeypatch.setattr(
|
|
worker,
|
|
"_discover_fla_model_types",
|
|
lambda: frozenset({"qwen3_5", "qwen3_5_moe", "qwen3_next"}),
|
|
)
|
|
cases = [
|
|
("unsloth/Qwen3.5-2B", True),
|
|
("Qwen/Qwen3.5-MoE-A3B", True),
|
|
("mlx-community/qwen3-next-80b", True),
|
|
("unsloth/qwen3_5_moe_a3b_lora", True),
|
|
("meta-llama/Llama-3.1-8B", False),
|
|
("nvidia/Nemotron-H-4B", False),
|
|
("mistralai/Mistral-7B-v0.3", False),
|
|
("", False),
|
|
]
|
|
for name, expected in cases:
|
|
assert worker._model_wants_tilelang(name) is expected, name
|
|
|
|
|
|
def test_model_wants_tilelang_empty_when_transformers_has_no_fla(monkeypatch):
|
|
monkeypatch.setattr(worker, "_discover_fla_model_types", lambda: frozenset())
|
|
assert worker._model_wants_tilelang("unsloth/Qwen3.5-2B") is False
|
|
assert worker._model_wants_tilelang("meta-llama/Llama-3.1-8B") is False
|
|
|
|
|
|
def test_model_wants_tilelang_normalizes_separators(monkeypatch):
|
|
monkeypatch.setattr(worker, "_discover_fla_model_types", lambda: frozenset({"qwen3_next"}))
|
|
for variant in (
|
|
"qwen3-next",
|
|
"Qwen3.Next",
|
|
"Qwen/Qwen3 Next",
|
|
"anyone/qwen3_next",
|
|
"qwen3.next-80b",
|
|
):
|
|
assert worker._model_wants_tilelang(variant) is True, variant
|
|
|
|
|
|
# HIP source-build gcc-install-dir coverage (Strix Halo).
|
|
# Ubuntu 24.04 ships gcc-14's runtime dir without /usr/include/c++/14, so ROCm
|
|
# clang-20 picks it and fails ('cstdlib' not found) building causal-conv1d.
|
|
# _hipcc_gcc_install_dir() finds a gcc dir with both halves; the HIP branch of
|
|
# _install_package_wheel_first passes it via HIPCC_COMPILE_FLAGS_APPEND.
|
|
# Parallels bbf004c's setup.sh fix for the llama.cpp HIP build (PR #5301).
|
|
|
|
|
|
def _isdir_for_layout(*existing: str):
|
|
"""os.path.isdir replacement treating only the given absolute paths as
|
|
directories, to simulate which gcc runtime / C++ header dirs exist."""
|
|
valid = set(existing)
|
|
|
|
def fake_isdir(path: str) -> bool:
|
|
return path in valid
|
|
|
|
return fake_isdir
|
|
|
|
|
|
def test_hipcc_gcc_install_dir_picks_highest_with_headers(monkeypatch):
|
|
"""gcc-14 has runtime but no /usr/include/c++/14; loop falls through
|
|
to gcc-13 which has both. The exact Ubuntu 24.04 layout."""
|
|
monkeypatch.setattr(sys, "platform", "linux")
|
|
import platform as _platform
|
|
|
|
monkeypatch.setattr(_platform, "machine", lambda: "x86_64")
|
|
monkeypatch.setattr(
|
|
worker.os.path,
|
|
"isdir",
|
|
_isdir_for_layout(
|
|
"/usr/lib/gcc/x86_64-linux-gnu/14/include", # runtime present
|
|
# but no /usr/include/c++/14 — typical Ubuntu 24.04 default
|
|
"/usr/lib/gcc/x86_64-linux-gnu/13/include",
|
|
"/usr/include/c++/13", # libstdc++-13-dev installed
|
|
),
|
|
)
|
|
assert worker._hipcc_gcc_install_dir() == "/usr/lib/gcc/x86_64-linux-gnu/13"
|
|
|
|
|
|
def test_hipcc_gcc_install_dir_picks_14_when_headers_exist(monkeypatch):
|
|
"""If the user has libstdc++-14-dev installed, prefer gcc-14."""
|
|
monkeypatch.setattr(sys, "platform", "linux")
|
|
import platform as _platform
|
|
|
|
monkeypatch.setattr(_platform, "machine", lambda: "x86_64")
|
|
monkeypatch.setattr(
|
|
worker.os.path,
|
|
"isdir",
|
|
_isdir_for_layout(
|
|
"/usr/lib/gcc/x86_64-linux-gnu/14/include",
|
|
"/usr/include/c++/14",
|
|
),
|
|
)
|
|
assert worker._hipcc_gcc_install_dir() == "/usr/lib/gcc/x86_64-linux-gnu/14"
|
|
|
|
|
|
def test_hipcc_gcc_install_dir_returns_none_when_no_match(monkeypatch):
|
|
"""No gcc dir has both halves → return None and skip env injection
|
|
rather than guessing wrong and causing a confusing build failure."""
|
|
monkeypatch.setattr(sys, "platform", "linux")
|
|
import platform as _platform
|
|
|
|
monkeypatch.setattr(_platform, "machine", lambda: "x86_64")
|
|
monkeypatch.setattr(worker.os.path, "isdir", lambda path: False)
|
|
assert worker._hipcc_gcc_install_dir() is None
|
|
|
|
|
|
def test_hipcc_gcc_install_dir_returns_none_on_non_linux(monkeypatch):
|
|
"""Don't probe gcc layout on macOS / Windows — early-return."""
|
|
monkeypatch.setattr(sys, "platform", "darwin")
|
|
|
|
def _isdir_should_not_be_called(_path):
|
|
raise AssertionError("isdir should not be called on non-Linux")
|
|
|
|
monkeypatch.setattr(worker.os.path, "isdir", _isdir_should_not_be_called)
|
|
assert worker._hipcc_gcc_install_dir() is None
|
|
|
|
|
|
def test_hipcc_gcc_install_dir_returns_none_on_non_x86_64(monkeypatch):
|
|
"""ROCm clang-20 on aarch64 has a different libstdc++ layout."""
|
|
monkeypatch.setattr(sys, "platform", "linux")
|
|
import platform as _platform
|
|
|
|
monkeypatch.setattr(_platform, "machine", lambda: "aarch64")
|
|
assert worker._hipcc_gcc_install_dir() is None
|
|
|
|
|
|
def _make_hip_install_env(monkeypatch, *, gcc_dir: str | None):
|
|
"""Scaffolding for end-to-end tests of the HIP source-build branch of
|
|
_install_package_wheel_first: package not installed, no prebuilt
|
|
wheel, hipcc on PATH, fake env reports HIP torch."""
|
|
monkeypatch.setattr(builtins, "__import__", _missing_module_import("causal_conv1d"))
|
|
monkeypatch.setattr(
|
|
worker,
|
|
"probe_torch_wheel_env",
|
|
lambda timeout = 30: {
|
|
"hip_version": "7.13.26176",
|
|
"python_tag": "cp312",
|
|
"torch_mm": "2.11",
|
|
"cxx11abi": "TRUE",
|
|
"platform_tag": "linux_x86_64",
|
|
},
|
|
)
|
|
monkeypatch.setattr(worker, "direct_wheel_url", lambda **kw: None)
|
|
monkeypatch.setattr(
|
|
worker.shutil,
|
|
"which",
|
|
lambda name: "/opt/rocm/bin/hipcc" if name == "hipcc" else None,
|
|
)
|
|
monkeypatch.setattr(worker, "_send_status", lambda *a, **k: None)
|
|
monkeypatch.setattr(worker, "_hipcc_gcc_install_dir", lambda: gcc_dir)
|
|
|
|
|
|
def test_install_injects_gcc_install_dir_on_hip_source_build(monkeypatch):
|
|
"""HIP source-build with no user-set HIPCC_COMPILE_FLAGS_APPEND →
|
|
subprocess env carries --gcc-install-dir=<detected path>."""
|
|
monkeypatch.delenv("HIPCC_COMPILE_FLAGS_APPEND", raising = False)
|
|
_make_hip_install_env(monkeypatch, gcc_dir = "/usr/lib/gcc/x86_64-linux-gnu/13")
|
|
|
|
captured: dict[str, str] = {}
|
|
|
|
def fake_run(cmd, **kwargs):
|
|
captured.update(kwargs.get("env") or {})
|
|
return subprocess.CompletedProcess(cmd, 0, "")
|
|
|
|
monkeypatch.setattr(worker._sp, "run", fake_run)
|
|
|
|
worker._install_package_wheel_first(
|
|
event_queue = [],
|
|
import_name = "causal_conv1d",
|
|
display_name = "causal-conv1d",
|
|
pypi_name = "causal-conv1d",
|
|
pypi_version = "1.6.2.post1",
|
|
filename_prefix = "causal_conv1d",
|
|
release_tag = "v1.6.2.post1",
|
|
release_base_url = "https://example.com",
|
|
)
|
|
|
|
assert (
|
|
captured.get("HIPCC_COMPILE_FLAGS_APPEND")
|
|
== "--gcc-install-dir=/usr/lib/gcc/x86_64-linux-gnu/13"
|
|
)
|
|
|
|
|
|
def test_install_appends_to_existing_hipcc_compile_flags(monkeypatch):
|
|
"""User has HIPCC_COMPILE_FLAGS_APPEND='-O3 -DFOO' → final value keeps
|
|
the user's flags AND appends --gcc-install-dir."""
|
|
monkeypatch.setenv("HIPCC_COMPILE_FLAGS_APPEND", "-O3 -DFOO")
|
|
_make_hip_install_env(monkeypatch, gcc_dir = "/usr/lib/gcc/x86_64-linux-gnu/13")
|
|
|
|
captured: dict[str, str] = {}
|
|
|
|
def fake_run(cmd, **kwargs):
|
|
captured.update(kwargs.get("env") or {})
|
|
return subprocess.CompletedProcess(cmd, 0, "")
|
|
|
|
monkeypatch.setattr(worker._sp, "run", fake_run)
|
|
|
|
worker._install_package_wheel_first(
|
|
event_queue = [],
|
|
import_name = "causal_conv1d",
|
|
display_name = "causal-conv1d",
|
|
pypi_name = "causal-conv1d",
|
|
pypi_version = "1.6.2.post1",
|
|
filename_prefix = "causal_conv1d",
|
|
release_tag = "v1.6.2.post1",
|
|
release_base_url = "https://example.com",
|
|
)
|
|
|
|
assert captured.get("HIPCC_COMPILE_FLAGS_APPEND") == (
|
|
"-O3 -DFOO --gcc-install-dir=/usr/lib/gcc/x86_64-linux-gnu/13"
|
|
)
|
|
|
|
|
|
def test_install_respects_user_gcc_install_dir(monkeypatch):
|
|
"""User explicitly set --gcc-install-dir=… already → don't touch it.
|
|
Avoids two competing --gcc-install-dir flags on the clang command line."""
|
|
monkeypatch.setenv(
|
|
"HIPCC_COMPILE_FLAGS_APPEND",
|
|
"--gcc-install-dir=/opt/custom/gcc-13",
|
|
)
|
|
_make_hip_install_env(monkeypatch, gcc_dir = "/usr/lib/gcc/x86_64-linux-gnu/13")
|
|
|
|
captured: dict[str, str] | None = {"_called": "no"}
|
|
|
|
def fake_run(cmd, **kwargs):
|
|
env = kwargs.get("env")
|
|
if env is not None:
|
|
captured.clear()
|
|
captured.update(env)
|
|
else:
|
|
captured["_called"] = "yes_no_env"
|
|
return subprocess.CompletedProcess(cmd, 0, "")
|
|
|
|
monkeypatch.setattr(worker._sp, "run", fake_run)
|
|
|
|
worker._install_package_wheel_first(
|
|
event_queue = [],
|
|
import_name = "causal_conv1d",
|
|
display_name = "causal-conv1d",
|
|
pypi_name = "causal-conv1d",
|
|
pypi_version = "1.6.2.post1",
|
|
filename_prefix = "causal_conv1d",
|
|
release_tag = "v1.6.2.post1",
|
|
release_base_url = "https://example.com",
|
|
)
|
|
|
|
# subprocess.run invoked without env override (user already set
|
|
# HIPCC_COMPILE_FLAGS_APPEND with --gcc-install-dir, so we left the
|
|
# env alone — the existing value is inherited).
|
|
assert captured == {"_called": "yes_no_env"}
|
|
|
|
|
|
def test_install_does_not_inject_env_on_cuda(monkeypatch):
|
|
"""CUDA path (no hip_version in env) → no env override at all."""
|
|
monkeypatch.delenv("HIPCC_COMPILE_FLAGS_APPEND", raising = False)
|
|
monkeypatch.setattr(builtins, "__import__", _missing_module_import("causal_conv1d"))
|
|
monkeypatch.setattr(
|
|
worker,
|
|
"probe_torch_wheel_env",
|
|
lambda timeout = 30: {
|
|
"python_tag": "cp312",
|
|
"torch_mm": "2.11",
|
|
"cuda_major": "12",
|
|
"cxx11abi": "TRUE",
|
|
"platform_tag": "linux_x86_64",
|
|
},
|
|
)
|
|
monkeypatch.setattr(worker, "direct_wheel_url", lambda **kw: None)
|
|
monkeypatch.setattr(worker.shutil, "which", lambda name: None)
|
|
monkeypatch.setattr(worker, "_send_status", lambda *a, **k: None)
|
|
# _hipcc_gcc_install_dir must not be called on CUDA.
|
|
monkeypatch.setattr(
|
|
worker,
|
|
"_hipcc_gcc_install_dir",
|
|
lambda: (_ for _ in ()).throw(AssertionError("must not run on CUDA")),
|
|
)
|
|
|
|
captured: dict[str, Any] = {}
|
|
|
|
def fake_run(cmd, **kwargs):
|
|
captured["env_in_kwargs"] = "env" in kwargs
|
|
return subprocess.CompletedProcess(cmd, 0, "")
|
|
|
|
monkeypatch.setattr(worker._sp, "run", fake_run)
|
|
|
|
worker._install_package_wheel_first(
|
|
event_queue = [],
|
|
import_name = "causal_conv1d",
|
|
display_name = "causal-conv1d",
|
|
pypi_name = "causal-conv1d",
|
|
pypi_version = "1.6.2.post1",
|
|
filename_prefix = "causal_conv1d",
|
|
release_tag = "v1.6.2.post1",
|
|
release_base_url = "https://example.com",
|
|
)
|
|
|
|
# CUDA branch never sets the env, never invokes the gcc helper.
|
|
assert captured.get("env_in_kwargs") is False
|