a1907fd4fe* feat(studio): add DoRA support to studio * fix: added use_dora fast encoder LoraConfig and gated use_dora on AdapterMethod * fix(studio) serverside normalization for use_dora=true - add note documenting use_dora is silently dropped on diffusion * fix: dora button disabled on mac, add preflight guard on GGUF lora export, mismatch now correctly falls through to existing error instead of silently no-opping * Studio: add dora to the WizardState LoRA variant union for consistency * Reject --use_dora on the MLX (Apple Silicon) CLI path --------- Co-authored-by: danielhanchen <unslothai@gmail.com>
110 lines
4.6 KiB
Python
110 lines
4.6 KiB
Python
# SPDX-License-Identifier: AGPL-3.0-only
|
|
# Copyright 2026-present the Unsloth AI Inc. team. All rights reserved. See /studio/LICENSE.AGPL-3.0
|
|
|
|
"""Source-level regression guards for the Training Config popover data source
|
|
(#6853).
|
|
|
|
The live Training Progress popover used to read the editable form store
|
|
(useTrainingConfigStore) while a run was active, so it showed stale/static
|
|
values whenever the user touched the form after starting the run; only the
|
|
History view read the run's saved config snapshot. These guards pin the fixed
|
|
wiring: both views feed ProgressSection a config override mapped from
|
|
GET /api/train/runs/{id}, and ProgressSection prefers that override whenever
|
|
one is present -- not only for historical views.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
from pathlib import Path
|
|
|
|
_STUDIO_FRONTEND = Path(__file__).resolve().parents[2] / "frontend" / "src" / "features" / "studio"
|
|
|
|
|
|
def _read(rel: str) -> str:
|
|
return (_STUDIO_FRONTEND / rel).read_text(encoding = "utf-8")
|
|
|
|
|
|
def test_progress_section_prefers_override_over_form_store():
|
|
src = _read("sections/progress-section.tsx")
|
|
# Fields key on the override's presence, not isHistorical: a live view passing
|
|
# an override wins over the store; without one, live keeps the store while
|
|
# History shows blanks rather than unrelated live form values.
|
|
assert "const cfg = configOverride ?? (isHistorical ? undefined : config)" in src
|
|
assert "const cfgEpochs = cfg?.epochs" in src
|
|
assert "isHistorical ? configOverride?.epochs" not in src
|
|
|
|
|
|
def test_live_view_fetches_the_active_run_config():
|
|
src = _read("live-training-view.tsx")
|
|
# Live view resolves the run's saved config snapshot by job id...
|
|
assert "getTrainingRun(" in src
|
|
assert "mapRunConfigToOverride(" in src
|
|
# ...and hands it to the popover.
|
|
assert "configOverride={runConfigOverride}" in src
|
|
|
|
|
|
def test_live_view_fetches_as_soon_as_the_job_id_exists():
|
|
# start_training() inserts the run row BEFORE the pump consumes any event, so
|
|
# the saved config is available during configuring/loading/downloading. The
|
|
# job id is therefore the whole readiness condition: gating on a first step
|
|
# or a terminal phase would show the wrong config for the entire pre-step
|
|
# window of a long load, or for a run adopted from another client.
|
|
src = _read("live-training-view.tsx")
|
|
assert "if (!runtime.jobId) {" in src
|
|
assert "[runtime.jobId, fetchedRunConfig, fetchAttempt]" in src
|
|
# No step/phase readiness gate may creep back in.
|
|
assert "runRowReady" not in src
|
|
|
|
|
|
def test_live_view_retries_the_transient_row_miss():
|
|
# start_training() creates the row before the pump, but a lookup racing that
|
|
# commit can still 404. Nothing else in the effect deps changes on failure, so
|
|
# the retry must be explicit and bounded, else a genuinely absent row would
|
|
# poll forever instead of falling back to the form store.
|
|
src = _read("live-training-view.tsx")
|
|
assert "RUN_CONFIG_FETCH_RETRIES" in src
|
|
assert "RUN_CONFIG_FETCH_RETRY_MS" in src
|
|
assert "setFetchAttempt(" in src
|
|
assert "attempts >= RUN_CONFIG_FETCH_RETRIES" in src
|
|
# The budget is keyed by job so a new run always starts fresh.
|
|
assert "fetchAttempt?.jobId === jobId ? fetchAttempt.count : 0" in src
|
|
# The pending retry must be cancelled with the effect.
|
|
assert "clearTimeout(retryTimer)" in src
|
|
|
|
|
|
def test_live_view_prefers_saved_training_method():
|
|
# The method label / LoRA-row visibility must come from the run snapshot,
|
|
# not the editable form (which may have changed since the run started).
|
|
src = _read("live-training-view.tsx")
|
|
assert "runConfigOverride?.trainingMethod ?? config.trainingMethod" in src
|
|
|
|
|
|
def test_history_view_uses_the_shared_mapper():
|
|
src = _read("historical-training-view.tsx")
|
|
# Shared mapper, not a re-inlined field-by-field copy that could drift.
|
|
assert "mapRunConfigToOverride(detail.config)" in src
|
|
assert "num_epochs" not in src
|
|
|
|
|
|
def test_shared_mapper_matches_backend_config_keys():
|
|
src = _read("sections/run-config-override.ts")
|
|
# The mapper reads the run config JSON the backend snapshots at job start;
|
|
# keep the key set pinned so a silent rename breaks loudly here.
|
|
for key in (
|
|
"training_type",
|
|
"load_in_4bit",
|
|
"num_epochs",
|
|
"batch_size",
|
|
"learning_rate",
|
|
"max_steps",
|
|
"max_seq_length",
|
|
"warmup_steps",
|
|
"optim",
|
|
"lora_r",
|
|
"lora_alpha",
|
|
"lora_dropout",
|
|
"use_rslora",
|
|
"use_loftq",
|
|
"use_dora",
|
|
):
|
|
assert key in src, f"run-config mapper lost backend key {key}"
|