* fix(studio): prevent ModuleNotFoundError in dataset.map() on Windows On Windows, dataset.map() uses "spawn", which requires workers to import compiled modules from disk. Previously, clear_unsloth_compiled_cache() deleted the entire directory, causing workers to crash when looking for UnslothSFTTrainer.py. Changes: 1. Added `preserve_patterns` to cache cleanup to keep `Unsloth*Trainer.py` on Windows while clearing model-specific files. 2. Added the cache directory to PYTHONPATH for spawn workers. Linux/macOS behavior is unchanged. * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Fix spawn-platform coverage, CWD path mismatch, and race condition for PR #4473 - Extend platform guard from win32-only to include macOS (also uses spawn since Python 3.8, same ModuleNotFoundError would occur) - Replace fragile CWD-based PYTHONPATH registration with centralized register_compiled_cache_on_path() that uses the same __file__-relative _CACHE_DIRS already used by cache_cleanup -- fixes path mismatch when studio is launched from a directory other than the repo root - Move PYTHONPATH registration to the top of _train_worker(), before any dataset.map() call (previously it ran late in config assembly, after dataset formatting which also calls dataset.map()) - Update inference.py model-unload to preserve trainer files on spawn platforms, preventing a race where unloading a model via inference tab would delete UnslothSFTTrainer.py while training workers are importing it * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Fix cache-dir precedence reversal in register_compiled_cache_on_path() Iterating _CACHE_DIRS in forward order while calling insert(0) each time reverses the declared priority: later entries shadow earlier ones. When multiple compiled-cache directories exist, spawned workers could import a stale trainer from the wrong cache. Fix: iterate in reverse so that the highest-priority entry (first in _CACHE_DIRS) is inserted last and ends up at position 0 in sys.path and PYTHONPATH. * fix: harden worker-count helpers against cpu_count=None and desired<=0 - safe_num_proc: guard os.cpu_count() with `or 1`, clamp multi-GPU path with max(1, min(4, desired)), clamp return with max(1, desired) - safe_thread_num_proc: same os.cpu_count() guard and return clamp - Add regression tests (31 L1 unit + 10 sandbox edge-case tests) * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * remove regression tests from PR --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Daniel Han <danielhanchen@users.noreply.github.com> Co-authored-by: Daniel Han <danielhanchen@gmail.com>
98 lines
3.6 KiB
Python
98 lines
3.6 KiB
Python
# SPDX-License-Identifier: AGPL-3.0-only
|
|
# Copyright 2026-present the Unsloth AI Inc. team. All rights reserved. See /studio/LICENSE.AGPL-3.0
|
|
|
|
"""
|
|
Utility for cleaning up the Unsloth compiled cache directory.
|
|
|
|
The unsloth_compiled_cache is created by unsloth_zoo/compiler.py during
|
|
FastModel.from_pretrained() and contains model-type-specific compiled Python
|
|
files. It should be selectively cleared between model loads to avoid stale
|
|
artefacts, while preserving model-agnostic components (like Trainers) needed
|
|
by spawned subprocesses.
|
|
"""
|
|
|
|
import shutil
|
|
import structlog
|
|
from loggers import get_logger
|
|
from pathlib import Path
|
|
from typing import List, Optional
|
|
|
|
logger = get_logger(__name__)
|
|
|
|
# Possible locations where unsloth_compiled_cache may appear
|
|
_BACKEND_DIR = Path(__file__).resolve().parent.parent # studio/backend
|
|
_PROJECT_ROOT = _BACKEND_DIR.parent.parent # repo root
|
|
|
|
_CACHE_DIRS = [
|
|
_BACKEND_DIR / "unsloth_compiled_cache",
|
|
_PROJECT_ROOT / "unsloth_compiled_cache",
|
|
_PROJECT_ROOT / "studio" / "tmp" / "unsloth_compiled_cache",
|
|
]
|
|
|
|
|
|
def get_existing_cache_dirs() -> List[Path]:
|
|
"""Return known compiled-cache directories that currently exist on disk."""
|
|
return [d for d in _CACHE_DIRS if d.exists()]
|
|
|
|
|
|
def register_compiled_cache_on_path() -> None:
|
|
"""Add all existing compiled-cache directories to sys.path and PYTHONPATH.
|
|
|
|
This ensures spawned workers (on platforms using the 'spawn' start method,
|
|
i.e. Windows and macOS) can import dynamically compiled modules such as
|
|
UnslothSFTTrainer.
|
|
"""
|
|
import os
|
|
import sys
|
|
|
|
pypath = os.environ.get("PYTHONPATH", "")
|
|
pypath_entries = [p for p in pypath.split(os.pathsep) if p]
|
|
|
|
# Iterate in reverse so that earlier _CACHE_DIRS entries (higher priority)
|
|
# are inserted last and therefore end up first in sys.path / PYTHONPATH.
|
|
for cache_dir in reversed(get_existing_cache_dirs()):
|
|
resolved = str(cache_dir.resolve())
|
|
if resolved not in sys.path:
|
|
sys.path.insert(0, resolved)
|
|
if resolved not in pypath_entries:
|
|
pypath_entries.insert(0, resolved)
|
|
|
|
os.environ["PYTHONPATH"] = os.pathsep.join(pypath_entries)
|
|
|
|
|
|
def clear_unsloth_compiled_cache(preserve_patterns: Optional[List[str]] = None) -> None:
|
|
"""
|
|
Remove compiled files from the cache directory (idempotent).
|
|
|
|
Args:
|
|
preserve_patterns: A list of glob patterns for files to keep
|
|
(e.g., ["Unsloth*Trainer.py"]). If None or empty,
|
|
the entire cache directory is deleted (legacy behavior).
|
|
"""
|
|
for cache_dir in _CACHE_DIRS:
|
|
if not cache_dir.exists():
|
|
continue
|
|
|
|
if preserve_patterns:
|
|
logger.info(
|
|
f"Cleaning unsloth compiled cache (preserving {preserve_patterns}): "
|
|
f"{cache_dir}"
|
|
)
|
|
|
|
for item in cache_dir.iterdir():
|
|
if item.is_file():
|
|
# Check if the file matches any of the patterns we want to keep
|
|
preserve = any(item.match(pattern) for pattern in preserve_patterns)
|
|
if not preserve:
|
|
try:
|
|
item.unlink()
|
|
except OSError as e:
|
|
logger.debug(f"Could not delete {item}: {e}")
|
|
|
|
elif item.is_dir():
|
|
# Always clear __pycache__ and other subdirectories
|
|
shutil.rmtree(item, ignore_errors = True)
|
|
else:
|
|
# Legacy behavior: nuke the entire directory
|
|
logger.info(f"Removing unsloth compiled cache: {cache_dir}")
|
|
shutil.rmtree(cache_dir, ignore_errors = True)
|