* Studio: show an actionable message when the GGUF runtime is missing Selecting a GGUF model with no llama-server installed surfaced a generic "Invalid model" in the UI, because validate_model's catch-all discarded the real cause. Add LlamaServerNotFoundError (a RuntimeError subclass) raised by the GGUF preflight in ModelConfig.from_identifier, and catch it in the validate route so users get an actionable message: run `unsloth studio setup` to download the prebuilt llama.cpp runtime. Other validation failures keep the safe generic message. Adds a regression test. * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Studio: also map missing GGUF runtime to a 400 in load_model validate_model already surfaces the actionable 'install the runtime' message for LlamaServerNotFoundError; load_model fell through to the generic 500 'Failed to load model'. Catch it there too so a GGUF load without llama-server gives the same install hint instead of a 500. * Trim comments for PR #6327 * Studio: fix stale validate test after #6398 and surface missing GGUF runtime on /load - test_other_runtime_errors_do_not_get_gguf_message: after merging #6398, validate_model surfaces a RuntimeError's own message, so a plain RuntimeError no longer returns "Invalid model". Assert it does not receive the GGUF install message instead (the prior assertion was stale after the main merge). - Raise LlamaServerNotFoundError (not a plain RuntimeError) at the backend load-time missing-binary branch, after diffusion routing, so /load returns the actionable 400 like remote validation, instead of a generic 500. - Share LLAMA_SERVER_NOT_FOUND_DETAIL between the from_identifier preflight and the load-time raise so the message stays in sync. - Add a propagation regression test for the non-tensor load path. * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
122 lines
5.6 KiB
Python
122 lines
5.6 KiB
Python
# SPDX-License-Identifier: AGPL-3.0-only
|
|
# Copyright 2026-present the Unsloth AI Inc. team. All rights reserved. See /studio/LICENSE.AGPL-3.0
|
|
|
|
"""/api/inference/validate and /load must surface an actionable "install the runtime"
|
|
message when a GGUF model's llama-server is missing, not a generic error."""
|
|
|
|
import asyncio
|
|
import importlib.util
|
|
import unittest
|
|
from pathlib import Path
|
|
from unittest.mock import MagicMock, patch
|
|
|
|
from fastapi import HTTPException
|
|
|
|
from core.inference.llama_cpp import LlamaServerNotFoundError
|
|
from models.inference import LoadRequest, ValidateModelRequest
|
|
|
|
_BACKEND_ROOT = Path(__file__).resolve().parent.parent
|
|
|
|
|
|
def _load_route_module(name: str, relative_path: str):
|
|
# Load routes/inference.py under a standalone name (mirrors test_gpu_selection).
|
|
spec = importlib.util.spec_from_file_location(name, _BACKEND_ROOT / relative_path)
|
|
module = importlib.util.module_from_spec(spec)
|
|
spec.loader.exec_module(module)
|
|
return module
|
|
|
|
|
|
_GGUF_MSG = (
|
|
"This is a GGUF model, but the llama.cpp runtime (llama-server) is not "
|
|
"installed. Run `unsloth studio setup` to download the prebuilt runtime, "
|
|
"then try again. (Advanced: set LLAMA_SERVER_PATH to an existing binary.)"
|
|
)
|
|
|
|
|
|
class TestValidateGgufRuntimeMessage(unittest.TestCase):
|
|
def _validate(self, route, model_path, side_effect):
|
|
request = ValidateModelRequest(model_path = model_path)
|
|
with (
|
|
patch.object(
|
|
route,
|
|
"_resolve_model_identifier_for_request",
|
|
return_value = (model_path, model_path, False),
|
|
),
|
|
patch.object(route.ModelConfig, "from_identifier", side_effect = side_effect),
|
|
):
|
|
with self.assertRaises(HTTPException) as exc:
|
|
asyncio.run(route.validate_model(request, current_subject = "test-user"))
|
|
return exc.exception
|
|
|
|
def test_missing_llama_server_returns_actionable_message(self):
|
|
route = _load_route_module("inf_route_runtime_msg_1", "routes/inference.py")
|
|
err = self._validate(route, "unsloth/Qwen3-1.7B-GGUF", LlamaServerNotFoundError(_GGUF_MSG))
|
|
self.assertEqual(err.status_code, 400)
|
|
self.assertIn("unsloth studio setup", err.detail)
|
|
self.assertIn("llama.cpp runtime", err.detail)
|
|
self.assertNotEqual(err.detail, "Invalid model")
|
|
|
|
def test_other_runtime_errors_do_not_get_gguf_message(self):
|
|
# LlamaServerNotFoundError subclasses RuntimeError, so a plain RuntimeError must not be
|
|
# routed to the GGUF "install the runtime" message. validate_model surfaces a RuntimeError's
|
|
# own message (#6398), so assert the GGUF install text is absent and the message is intact.
|
|
route = _load_route_module("inf_route_runtime_msg_2", "routes/inference.py")
|
|
err = self._validate(route, "not/a-real-model", RuntimeError("totally different failure"))
|
|
self.assertEqual(err.status_code, 400)
|
|
self.assertNotIn("unsloth studio setup", err.detail)
|
|
self.assertNotIn("llama.cpp runtime", err.detail)
|
|
self.assertEqual(err.detail, "totally different failure")
|
|
|
|
|
|
class TestLoadGgufRuntimeMessage(unittest.TestCase):
|
|
"""/api/inference/load surfaces the same message (not a 500) when the runtime is missing."""
|
|
|
|
def _load(self, route, model_path, side_effect):
|
|
request = LoadRequest(model_path = model_path)
|
|
backend = MagicMock(active_model_name = None) # no resident model -> reach from_identifier
|
|
with (
|
|
patch.object(
|
|
route,
|
|
"_resolve_model_identifier_for_request",
|
|
return_value = (model_path, model_path, False),
|
|
),
|
|
patch.object(route, "resolve_effective_chat_template_override", return_value = None),
|
|
patch.object(route, "get_inference_backend", return_value = backend),
|
|
patch.object(route, "get_llama_cpp_backend", return_value = MagicMock()),
|
|
patch.object(route.ModelConfig, "from_identifier", side_effect = side_effect),
|
|
):
|
|
with self.assertRaises(HTTPException) as exc:
|
|
asyncio.run(route.load_model(request, MagicMock(), current_subject = "test-user"))
|
|
return exc.exception
|
|
|
|
def test_missing_llama_server_returns_actionable_message(self):
|
|
route = _load_route_module("inf_route_load_runtime_msg_1", "routes/inference.py")
|
|
err = self._load(route, "unsloth/Qwen3-1.7B-GGUF", LlamaServerNotFoundError(_GGUF_MSG))
|
|
self.assertEqual(err.status_code, 400)
|
|
self.assertIn("unsloth studio setup", err.detail)
|
|
self.assertIn("llama.cpp runtime", err.detail)
|
|
|
|
def test_other_load_errors_still_500(self):
|
|
route = _load_route_module("inf_route_load_runtime_msg_2", "routes/inference.py")
|
|
err = self._load(route, "unsloth/some-model", RuntimeError("totally different failure"))
|
|
self.assertEqual(err.status_code, 500)
|
|
|
|
|
|
class TestLoadPathPropagatesRuntimeError(unittest.TestCase):
|
|
"""The backend GGUF load now raises LlamaServerNotFoundError when the runtime is
|
|
missing (after diffusion routing). The default (non-tensor) load must propagate it
|
|
to load_model's 400 arm, not swallow it into a generic 500."""
|
|
|
|
def test_tensor_fallback_propagates_missing_runtime(self):
|
|
from core.inference.tensor_fallback import load_with_tensor_fallback
|
|
async def _attempt(_tensor, _extra):
|
|
raise LlamaServerNotFoundError(_GGUF_MSG)
|
|
|
|
with self.assertRaises(LlamaServerNotFoundError):
|
|
asyncio.run(
|
|
load_with_tensor_fallback(_attempt, requested_tensor = False, extra_args = None)
|
|
)
|
|
|
|
|
|
if __name__ == "__main__":
|
|
unittest.main()
|