* Studio: report the real llama-server context window and add an opt-in overflow policy for OpenAI-compatible serving A community report showed OpenCode failing tool calls every few minutes against Studio's OpenAI-compatible API while the same GGUF was stable on LM Studio. Root cause: Studio advertises the requested context length, but llama-server can allocate less (memory-fit step on small GPUs, --parallel slot split), so clients budget against a window that does not exist. Their generations truncate mid tool call at the real wall (finish_reason=length with cut JSON arguments) and eventually the prompt itself exceeds the real window, returning a 400 that agentic clients treat as non-retryable. Changes: - After llama-server health, read default_generation_settings.n_ctx from /props and adopt it whenever it is below Studio's computed context, with a warning. The load response, status route, UI value, and the passthrough max_tokens ceiling all become honest automatically. - Expose context_length and max_context_length on /v1/models so clients can budget against the enforced window. - Accept empty role=tool content (commands with no output are routine in agentic loops; OpenAI and llama-server both accept it) instead of a 400. - Add context_overflow=truncate_middle (per request, or server-wide via UNSLOTH_CONTEXT_OVERFLOW=truncate_middle): on exceed_context_size_error the passthrough drops whole middle turn-groups (system prompt, first turn, and recent turns kept; tool calls stay paired with their results), clips oversized contents middle-out when group-dropping is not enough, clamps max_tokens to the generation headroom, and retries. Default stays 'error' with code=context_length_exceeded so clients running their own compaction keep full control. * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Studio: allocate the requested context for real (kv-unified, fit-ctx floor) Two launch-flag gaps caused the advertised vs allocated divergence at the source: - llama-server enables --kv-unified only when the slot count is auto; Studio always passes --parallel N, which silently splits -c into per-slot windows of -c/N. Pass --kv-unified when N > 1 so a single request can use the full advertised window (same total KV memory, shared pool). - with --fit on the fit step may set ctx as low as 4096; pass --fit-ctx <requested> for explicit requests so fit offloads or fails into the existing --fit off retry instead of silently shrinking the window. Both flags are gated on --help capability probing so older builds keep the current behavior, where the /props readback remains the backstop. Verified live: -c 98304 --parallel 4 now serves per-slot n_ctx 98304 (was 24576), 48k-token requests pass through the passthrough, and the readback warning no longer fires. * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
277 lines
9.6 KiB
Python
277 lines
9.6 KiB
Python
# SPDX-License-Identifier: AGPL-3.0-only
|
|
# Copyright 2026-present the Unsloth AI Inc. team. All rights reserved. See /studio/LICENSE.AGPL-3.0
|
|
|
|
"""Tests for the opt-in ``context_overflow="truncate_middle"`` passthrough policy.
|
|
|
|
On ``exceed_context_size_error`` the passthrough drops middle turn-groups and
|
|
retries inside the real window instead of surfacing a fatal 400. Truncation
|
|
keeps the system prompt, the first turn, and recent turns, and never orphans
|
|
a tool result from its tool_calls turn. Also covers ``/v1/models`` exposing
|
|
the real post-readback context window.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import sys
|
|
from pathlib import Path
|
|
|
|
import pytest
|
|
|
|
_BACKEND_DIR = str(Path(__file__).resolve().parent.parent)
|
|
if _BACKEND_DIR not in sys.path:
|
|
sys.path.insert(0, _BACKEND_DIR)
|
|
|
|
from routes.inference import (
|
|
_apply_overflow_truncation,
|
|
_clip_long_contents,
|
|
_CLIP_MARKER,
|
|
_estimate_message_tokens,
|
|
_openai_model_objects,
|
|
_overflow_truncation_requested,
|
|
_parse_overflow_counts,
|
|
_truncate_middle_messages,
|
|
)
|
|
import routes.inference as routes_mod
|
|
|
|
|
|
# Nick's actual error body from the Discord report logs.
|
|
_NICK_ERROR = (
|
|
'{"detail":"llama-server error: {\\"error\\":{\\"code\\":400,'
|
|
'\\"message\\":\\"request (70494 tokens) exceeds the available context size '
|
|
'(67584 tokens), try increasing it\\",\\"type\\":\\"exceed_context_size_error\\",'
|
|
'\\"n_prompt_tokens\\":70494,\\"n_ctx\\":67584}}"}'
|
|
)
|
|
|
|
|
|
def _tool_turn(i: int, result_chars: int = 400) -> list[dict]:
|
|
"""An assistant tool_calls turn paired with its tool result."""
|
|
return [
|
|
{
|
|
"role": "assistant",
|
|
"content": "",
|
|
"tool_calls": [
|
|
{
|
|
"id": f"call_{i}",
|
|
"type": "function",
|
|
"function": {"name": "read", "arguments": f'{{"filePath":"/f{i}"}}'},
|
|
}
|
|
],
|
|
},
|
|
{"role": "tool", "tool_call_id": f"call_{i}", "content": "x" * result_chars},
|
|
]
|
|
|
|
|
|
def _conversation(n_tool_turns: int = 12) -> list[dict]:
|
|
msgs = [
|
|
{"role": "system", "content": "You are an agent." * 20},
|
|
{"role": "user", "content": "Do the big task." * 20},
|
|
]
|
|
for i in range(n_tool_turns):
|
|
msgs.extend(_tool_turn(i))
|
|
msgs.append({"role": "assistant", "content": "halfway summary"})
|
|
msgs.append({"role": "user", "content": "keep going"})
|
|
return msgs
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# _parse_overflow_counts
|
|
# ---------------------------------------------------------------------------
|
|
|
|
|
|
def test_parse_overflow_counts_nick_error():
|
|
assert _parse_overflow_counts(_NICK_ERROR) == (70494, 67584)
|
|
|
|
|
|
def test_parse_overflow_counts_missing_fields():
|
|
assert _parse_overflow_counts('{"error":"something else"}') is None
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# _truncate_middle_messages
|
|
# ---------------------------------------------------------------------------
|
|
|
|
|
|
def test_truncation_drops_middle_keeps_anchors():
|
|
msgs = _conversation()
|
|
new, dropped = _truncate_middle_messages(msgs, keep_ratio = 0.5)
|
|
assert dropped > 0
|
|
assert len(new) == len(msgs) - dropped
|
|
# System prompt and task anchor survive.
|
|
assert new[0]["role"] == "system"
|
|
assert new[1] == msgs[1]
|
|
# The most recent turns survive verbatim.
|
|
assert new[-1] == msgs[-1]
|
|
assert new[-2] == msgs[-2]
|
|
|
|
|
|
def test_truncation_never_orphans_tool_results():
|
|
msgs = _conversation()
|
|
new, dropped = _truncate_middle_messages(msgs, keep_ratio = 0.4)
|
|
assert dropped > 0
|
|
surviving_call_ids = {
|
|
tc["id"] for m in new if m.get("role") == "assistant" for tc in (m.get("tool_calls") or [])
|
|
}
|
|
for m in new:
|
|
if m.get("role") == "tool":
|
|
assert m["tool_call_id"] in surviving_call_ids
|
|
|
|
|
|
def test_truncation_reduces_estimated_size_toward_target():
|
|
msgs = _conversation()
|
|
total = sum(_estimate_message_tokens(m) for m in msgs)
|
|
new, dropped = _truncate_middle_messages(msgs, keep_ratio = 0.5)
|
|
new_total = sum(_estimate_message_tokens(m) for m in new)
|
|
assert dropped > 0
|
|
assert new_total < total
|
|
# Should land at or below the requested share, modulo one whole group.
|
|
biggest_group = max(
|
|
_estimate_message_tokens(a) + _estimate_message_tokens(b)
|
|
for a, b in zip(msgs[2:-2:2], msgs[3:-2:2])
|
|
)
|
|
assert new_total <= int(total * 0.5) + biggest_group
|
|
|
|
|
|
def test_truncation_noop_when_keep_ratio_full():
|
|
msgs = _conversation()
|
|
new, dropped = _truncate_middle_messages(msgs, keep_ratio = 1.0)
|
|
assert dropped == 0
|
|
assert new == msgs
|
|
|
|
|
|
def test_truncation_noop_when_only_protected_turns_remain():
|
|
msgs = [
|
|
{"role": "system", "content": "sys"},
|
|
{"role": "user", "content": "task"},
|
|
*_tool_turn(0),
|
|
{"role": "user", "content": "latest"},
|
|
]
|
|
new, dropped = _truncate_middle_messages(msgs, keep_ratio = 0.1)
|
|
assert dropped == 0
|
|
assert new == msgs
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# _apply_overflow_truncation
|
|
# ---------------------------------------------------------------------------
|
|
|
|
|
|
def test_apply_overflow_truncation_mutates_body_and_clamps_max_tokens():
|
|
body = {"messages": _conversation(), "max_tokens": 32000}
|
|
assert _apply_overflow_truncation(body, _NICK_ERROR) is True
|
|
assert len(body["messages"]) < len(_conversation())
|
|
# Generation headroom: max_tokens clamped to the non-prompt share of n_ctx.
|
|
assert body["max_tokens"] <= max(1024, int(67584 * 0.25))
|
|
|
|
|
|
def test_apply_overflow_truncation_returns_false_when_nothing_droppable():
|
|
body = {
|
|
"messages": [
|
|
{"role": "system", "content": "sys"},
|
|
{"role": "user", "content": "task"},
|
|
{"role": "user", "content": "latest"},
|
|
],
|
|
"max_tokens": 32000,
|
|
}
|
|
assert _apply_overflow_truncation(body, _NICK_ERROR) is False
|
|
|
|
|
|
def test_apply_overflow_truncation_clips_giant_protected_tool_results():
|
|
"""One giant burst (few turn-groups, all protected) must still shrink:
|
|
stage 2 clips oversized tool contents instead of giving up."""
|
|
msgs = [
|
|
{"role": "system", "content": "sys"},
|
|
{"role": "user", "content": "task"},
|
|
*_tool_turn(0, result_chars = 60000),
|
|
*_tool_turn(1, result_chars = 60000),
|
|
]
|
|
body = {"messages": msgs, "max_tokens": 32000}
|
|
n_before = len(msgs)
|
|
assert _apply_overflow_truncation(body, _NICK_ERROR) is True
|
|
# No message disappeared (pairing intact), but contents were clipped.
|
|
assert len(body["messages"]) == n_before
|
|
clipped = [m for m in body["messages"] if _CLIP_MARKER in str(m.get("content"))]
|
|
assert clipped, "expected at least one clipped tool result"
|
|
surviving_call_ids = {
|
|
tc["id"]
|
|
for m in body["messages"]
|
|
if m.get("role") == "assistant"
|
|
for tc in (m.get("tool_calls") or [])
|
|
}
|
|
for m in body["messages"]:
|
|
if m.get("role") == "tool":
|
|
assert m["tool_call_id"] in surviving_call_ids
|
|
|
|
|
|
def test_clip_long_contents_reaches_target_and_keeps_structure():
|
|
msgs = [
|
|
{"role": "system", "content": "sys"},
|
|
{"role": "user", "content": "task"},
|
|
*_tool_turn(0, result_chars = 40000),
|
|
{"role": "user", "content": "latest question"},
|
|
]
|
|
total = sum(_estimate_message_tokens(m) for m in msgs)
|
|
clipped = _clip_long_contents(msgs, target_est = total // 4)
|
|
assert clipped >= 1
|
|
assert sum(_estimate_message_tokens(m) for m in msgs) <= total // 4
|
|
# Roles and count unchanged; the short final user message untouched.
|
|
assert [m["role"] for m in msgs] == ["system", "user", "assistant", "tool", "user"]
|
|
assert msgs[-1]["content"] == "latest question"
|
|
|
|
|
|
def test_overflow_truncation_requested_reads_field(monkeypatch):
|
|
monkeypatch.delenv("UNSLOTH_CONTEXT_OVERFLOW", raising = False)
|
|
|
|
class _P:
|
|
context_overflow = "truncate_middle"
|
|
|
|
class _Q:
|
|
context_overflow = None
|
|
|
|
assert _overflow_truncation_requested(_P()) is True
|
|
assert _overflow_truncation_requested(_Q()) is False
|
|
assert _overflow_truncation_requested(object()) is False
|
|
|
|
|
|
def test_overflow_truncation_server_default_env(monkeypatch):
|
|
"""UNSLOTH_CONTEXT_OVERFLOW enables the policy for clients that cannot
|
|
send custom body fields; an explicit per-request 'error' still wins."""
|
|
|
|
class _Unset:
|
|
context_overflow = None
|
|
|
|
class _ExplicitError:
|
|
context_overflow = "error"
|
|
|
|
monkeypatch.setenv("UNSLOTH_CONTEXT_OVERFLOW", "truncate_middle")
|
|
assert _overflow_truncation_requested(_Unset()) is True
|
|
assert _overflow_truncation_requested(_ExplicitError()) is False
|
|
monkeypatch.setenv("UNSLOTH_CONTEXT_OVERFLOW", "error")
|
|
assert _overflow_truncation_requested(_Unset()) is False
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# /v1/models context metadata
|
|
# ---------------------------------------------------------------------------
|
|
|
|
|
|
class _FakeLlamaBackend:
|
|
is_loaded = True
|
|
model_identifier = "unsloth/Qwen3.6-27B-GGUF"
|
|
context_length = 67584
|
|
max_context_length = 262144
|
|
|
|
|
|
class _FakeEmptyBackend:
|
|
active_model_name = None
|
|
|
|
|
|
def test_v1_models_exposes_real_context_window(monkeypatch):
|
|
monkeypatch.setattr(routes_mod, "get_llama_cpp_backend", lambda: _FakeLlamaBackend())
|
|
monkeypatch.setattr(routes_mod, "get_inference_backend", lambda: _FakeEmptyBackend())
|
|
models = _openai_model_objects()
|
|
assert len(models) == 1
|
|
entry = models[0]
|
|
assert entry["id"] == "unsloth/Qwen3.6-27B-GGUF"
|
|
# The REAL (post /props readback) window, not the requested one.
|
|
assert entry["context_length"] == 67584
|
|
assert entry["max_context_length"] == 262144
|