* CLI: stop `unsloth connect` from leaking Studio credentials to unverified servers
`unsloth connect` (and `unsloth chat`) discovered a Studio base URL from
UNSLOTH_STUDIO_URL or the default localhost port after only an unauthenticated
/api/health probe, then sent credentials to it:
- keyless connect iterated every cached API key and sent each as a bearer token
to {base}/v1/models, so a malicious or port-preempting endpoint could harvest
all of them;
- with no cached key it self-issued a Studio JWT and POSTed it to
{base}/api/auth/api-keys;
- unsloth chat sent the same self-issued JWT to the discovered base.
The key cache was a flat, global list with no binding to a server identity, so a
key minted for one Studio could be replayed to any other.
Changes:
- Scope the agent key cache per base URL so a key is only ever replayed to the
exact server it was minted for. Pre-scoping flat caches are ignored rather
than replayed (at most one extra local mint on the next launch).
- Gate every automatic credential flow to loopback bases. A non-loopback
UNSLOTH_STUDIO_URL now requires an explicit --api-key and nothing is sent
automatically. SSH-tunnelled Studios that land on 127.0.0.1 keep working.
- Mint the API key locally against the Studio auth DB instead of POSTing a
self-issued JWT over the network, so no bearer token leaves the process on the
local path.
- Apply the same loopback gate to connect_studio_server (used by unsloth chat).
Fully closing same-host loopback-port preemption needs a signed /api/health
handshake so the client can verify the server identity before sending anything;
that is tracked as a server-side follow-up.
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* CLI: verify Studio server identity before auto-sending credentials
Adds a challenge-response so `unsloth connect` and `unsloth chat` can confirm a
discovered loopback endpoint is really this install's Studio (not a process
that preempted the port) before sending it a cached or freshly minted
credential. This closes the same-host loopback-preemption gap left open by the
previous commit, which could only limit the blast radius.
Server:
- storage.get_or_create_identity_secret(): a dedicated server-wide secret in
app_secrets (kept separate from the per-user JWT secret), readable only by
the same OS user.
- storage.compute_identity_proof(nonce) = HMAC-SHA256(identity secret, nonce).
- GET /api/auth/identity?nonce=<base64url>: unauthenticated, returns the proof.
The nonce is opaque to the server and the proof reveals nothing about the
secret, so answering is safe.
Client:
- verify_studio_identity(base): sends a fresh 32-byte nonce, recomputes the
expected HMAC from the local same-user secret, and constant-time compares.
Fails closed on any error.
- connect._agent_api_key gates the loopback cached-key replay and the local
mint on it; connect_studio_server (used by unsloth chat) gates the
self-issued JWT on it.
A server that cannot read this install's secret (a different OS user, or a
remote/fake endpoint) cannot produce a matching proof, so the client refuses
and falls back to an explicit --api-key.
Tests: studio/backend/tests/test_identity.py (proof determinism, secret
persistence and caching, route response and nonce validation) and additions to
test_connect.py (the verify gate refuses when unverified, an explicit key skips
the check, and an end-to-end client plus server handshake against a stub HTTP
server).
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* CLI: mint through the verified server instead of the local auth DB
CodeQL (py/clear-text-storage-sensitive-data) flagged the API key written to
the per-server cache and the agent config files once it was sourced from
storage.create_api_key(); the original HTTP-minted key did not trip the query.
Now that the identity handshake cryptographically confirms the loopback
responder really is this Studio before anything is sent, minting through the
server's /api/auth/api-keys endpoint with a self-issued JWT is safe again and
restores the original, CodeQL-clean data flow. The local-DB mint path is
removed.
The security properties are unchanged: discovery is still loopback-gated and
identity-verified, the key cache is still scoped per server, and a credential
reaches the server only after the handshake has proven its identity. The only
difference from the previous commit is that the self-issued JWT is sent to the
already-verified loopback server rather than the key being minted in-process.
Tests updated to mint through the fake server again.
* CLI: address review feedback on connect credential handling
- Reuse a saved per-server key before the loopback/identity gate. Keys are
scoped per base URL, so a key the user saved with --api-key for a remote or
SSH-tunnelled Studio (whose identity secret the local handshake can't match)
is replayed only to that exact server. The loopback + identity-handshake gate
now guards just auto-minting (self-issuing a JWT and creating a new key),
which is the path that needs a cryptographically verified local Studio. Fixes
keyless reuse being impossible for remote/tunnelled Studios the user had
saved a key for.
- connect_studio_server (unsloth chat / inference): when the user explicitly set
UNSLOTH_STUDIO_URL but the server can't be safely attached (non-loopback, or
identity unverifiable), fail with a clear message instead of silently loading
the model locally. Opportunistic discovery of the local default still falls
back to a local load.
- Harden cache parsing: tolerate a corrupt or hand-edited cache where a base
maps to a non-list (which would otherwise iterate a string into
single-character "keys"), and read the cache as UTF-8.
Tests updated and added: saved-key replay without the handshake for both local
and remote bases, keyless mint still refused when the loopback server is
unverified, and connect_studio_server erroring on an explicit remote while
falling back locally on default discovery.
* CLI: harden connect handshake against relay and gate cached minted keys
Addresses review feedback on the credential handshake:
- Refuse HTTP redirects on credential-bearing requests (the identity handshake,
/v1/models, key minting, and the chat HTTP backend). A process squatting the
discovered port could 302 /api/auth/identity to the real Studio and relay its
valid proof, or bounce a bearer-token request to another base, and urllib
follows redirects by default. A shared no-redirect opener now treats any 3xx
as an error.
- Give cached keys provenance. Keys the user supplied with --api-key are "saved"
and replay without the handshake (needed for remote or SSH-tunnelled Studios
whose secret the local handshake can't match). Keys we auto-mint are "minted"
and replay only after the identity handshake, so a port squatter can't collect
a previously minted localhost key just by answering the health check. New cache
shape: servers[base] = {"saved": [...], "minted": [...]}.
Known residual: a different-OS-user process that squats the port and can also
reach a genuine same-secret Studio elsewhere on loopback can still manually relay
the identity challenge. Fully closing that needs the proof bound to the server's
real listening port, or OS-level peer-credential checks; tracked as follow-up. A
same-user attacker is out of scope, since it can already read the 0600 key cache.
Tests: redirect rejection in the handshake, minted-cache requiring the handshake
while saved-cache bypasses it, and the existing suites updated for the new cache
shape. unsloth_cli (206) and test_identity.py (5) pass.
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* CLI: keep urllib imports function-local in the no-redirect opener
The repo's import-hoist safety linter (scripts/verify_import_hoist.py) flags
hoisting urllib to module level because it re-points the 'urllib' name in the
pre-existing HttpChatBackend._request scope. Build the no-redirect opener lazily
with function-local urllib imports instead, matching this module's convention,
and restore the local 'import urllib.request' in _request and
verify_studio_identity.
* test(identity): skip route tests when routes.auth import chain is unavailable
The identity route tests build a TestClient from routes.auth, which pulls the
whole routes package (routes/__init__ -> inference -> llama_cpp, ...). In a
minimal test matrix without the heavy backend deps, or when another test in the
same process has already broken that import chain, importing it raised and the
two route tests hard-failed. Skip in that case instead: the proof crypto is
covered by the storage-level tests, and the full backend CI still exercises the
route. No behaviour change where the deps are present (5 passed in isolation).
* test(connect): make connect tests pass on native Windows
unsloth connect supports Windows: --no-launch prints PowerShell ($env:X =
"v" / Remove-Item Env:X) instead of POSIX (export/unset), and the launch
path bridges env into a Windows agent .exe over WSLENV. The tests hardcoded
the POSIX shell forms, so on a real windows-latest runner 12 of them failed on
the assertion string even though every command exited 0.
Add OS-aware assertion helpers (_assert_env_set / _assert_env_unset) that check
the right shell syntax for the host OS, and skip the two WSL-from-Linux shim
tests on native Windows (os.name is 'posix' inside WSL, so that path can't run
there). No change on Linux/macOS (57 passed); the connect command's behaviour
is untouched. Validated on a windows-latest staging runner.
* style(connect): tighten comments in the credential-leak fix
Condense the verbose explanatory comments and multi-line docstrings added by
this PR to one or two lines each, drop a few that just restated the code, and
keep the security rationale where it is load-bearing. Comment/whitespace only;
verified with unslothai/scripts comment_tools.py (check --strip-docstrings:
6/6 'code unchanged'). Tests unchanged: connect 57 passed, identity 5 passed.
* CLI/Studio: harden the identity handshake (review round)
Addresses the latest Codex/Gemini review of the handshake:
- Store the identity secret privately. sqlite3.connect created the auth DB
world-readable under a 022 umask, so another OS user could read app_secrets
and forge proofs, defeating the same-user assumption the handshake rests on.
The auth dir and DB are now restricted to owner-only (0700/0600); the JWT
secret and password hashes there get the same protection.
- Bind the proof to the server's listening port. The stateless HMAC(secret,
nonce) was relayable: a process squatting the discovered port could proxy the
challenge to the real Studio on another port and pass it back. The proof now
covers the port the server actually listens on (from the socket, never the
Host header) and the client checks it against the port it connected to, so a
relayed proof from a different port no longer matches. Closes the manual-relay
residual left after the redirect fix.
- Cap the identity response read (the server is still unverified at that point)
and serve the identity route from a sync def so its first-call SQLite read
runs in the threadpool instead of the event loop.
Tests: port-bound proof + relayed-proof rejection added; identity (5) and
unsloth_cli (58) suites pass. Verified end to end against a real backend
(auth DB owner-only, handshake + mint still succeed).
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* CLI/Studio: bind the identity proof to the connection address, not just port
Follow-up to the port binding from the last review. Binding only to the port
left a cross-address relay: a squatter on a different loopback address but the
same port (for example localhost resolving to a squatter on ::1 while the real
Studio is on 127.0.0.1) could proxy the nonce to the real Studio and pass back
a proof that still matched, since both share the port.
The proof now covers the address and the port the connection landed on:
- Server: takes the address+port from request.scope, which uvicorn populates
from getsockname, so it is the real local address the client reached even
when Studio is bound to 0.0.0.0 (verified empirically), never the
client-controlled Host header.
- Client: resolves the base host to one concrete IP, talks to exactly that IP,
and binds the proof to (IP, port). A proof relayed from a Studio on a
different address or port was computed for that other endpoint and no longer
matches the one the client dialed.
Both sides normalise the address through ipaddress so equivalent forms compare
equal. Together with the private-secret and redirect fixes, this closes the
cross-user loopback relay an attacker can mount without reading the secret.
Tests: proof now bound to host+port; relayed-proof rejection retained; identity
(5) and unsloth_cli (58) suites pass. Verified end to end against a real backend
(handshake + mint still succeed).
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* CLI: pick the loopback address at discovery so localhost does not regress
find_studio_server now resolves a bare localhost base to its concrete loopback
addresses and returns the first that answers /api/health, IPv4 127.0.0.1 first
(where unsloth studio binds by default). The whole flow (health probe, identity
check, credential send) then targets that one address instead of racing
IPv4/IPv6 resolution, where localhost could resolve ::1-first and hide a Studio
bound to 127.0.0.1. A literal IP or remote name is unchanged.
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
---------
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
954 lines
40 KiB
Python
954 lines
40 KiB
Python
# SPDX-License-Identifier: AGPL-3.0-only
|
|
# Copyright 2026-present the Unsloth AI Inc. team. All rights reserved. See /studio/LICENSE.AGPL-3.0
|
|
|
|
"""Tests for `unsloth connect` — config merging and launch env, no network."""
|
|
|
|
from __future__ import annotations
|
|
|
|
import json
|
|
import os
|
|
import sys
|
|
import urllib.error
|
|
from pathlib import Path
|
|
from types import SimpleNamespace
|
|
|
|
_REPO_ROOT = Path(__file__).resolve().parents[2]
|
|
if str(_REPO_ROOT) not in sys.path:
|
|
sys.path.insert(0, str(_REPO_ROOT))
|
|
|
|
|
|
import pytest
|
|
from typer.testing import CliRunner
|
|
|
|
import unsloth_cli.commands.connect as connect
|
|
|
|
BASE = "http://127.0.0.1:8888"
|
|
MODEL = {"id": "unsloth/gemma-4-26B-A4B-it-GGUF", "context_length": 131072}
|
|
|
|
|
|
# --no-launch prints shell setup as POSIX (export/unset) on Unix/WSL and
|
|
# PowerShell ($env:/Remove-Item) on native Windows; assert the host's form.
|
|
def _assert_env_set(output: str, name: str, value: str) -> None:
|
|
needle = f'$env:{name} = "{value}"' if os.name == "nt" else f"export {name}={value}"
|
|
assert needle in output, f"{needle!r} not found in:\n{output}"
|
|
|
|
|
|
def _assert_env_unset(output: str, name: str) -> None:
|
|
needle = f"Remove-Item Env:{name}" if os.name == "nt" else f"unset {name}"
|
|
assert needle in output, f"{needle!r} not found in:\n{output}"
|
|
|
|
|
|
@pytest.fixture()
|
|
def claude_settings(tmp_path, monkeypatch):
|
|
path = tmp_path / "claude" / "settings.json"
|
|
monkeypatch.setattr(connect, "claude_settings_path", lambda: path)
|
|
return path
|
|
|
|
|
|
def test_claude_settings_created_when_missing(claude_settings):
|
|
connect.ensure_claude_attribution_header()
|
|
settings = json.loads(claude_settings.read_text())
|
|
assert settings["env"]["CLAUDE_CODE_ATTRIBUTION_HEADER"] == "0"
|
|
|
|
|
|
def test_claude_settings_merge_preserves_existing(claude_settings):
|
|
claude_settings.parent.mkdir(parents = True)
|
|
claude_settings.write_text(
|
|
json.dumps({"effortLevel": "high", "env": {"CLAUDE_CODE_ENABLE_TELEMETRY": "0"}})
|
|
)
|
|
connect.ensure_claude_attribution_header()
|
|
settings = json.loads(claude_settings.read_text())
|
|
assert settings["effortLevel"] == "high"
|
|
assert settings["env"]["CLAUDE_CODE_ENABLE_TELEMETRY"] == "0"
|
|
assert settings["env"]["CLAUDE_CODE_ATTRIBUTION_HEADER"] == "0"
|
|
|
|
|
|
def test_claude_settings_already_set_untouched(claude_settings):
|
|
claude_settings.parent.mkdir(parents = True)
|
|
original = json.dumps({"env": {"CLAUDE_CODE_ATTRIBUTION_HEADER": "0"}})
|
|
claude_settings.write_text(original)
|
|
connect.ensure_claude_attribution_header()
|
|
assert claude_settings.read_text() == original
|
|
|
|
|
|
def test_claude_settings_bad_json_left_alone(claude_settings, capsys):
|
|
claude_settings.parent.mkdir(parents = True)
|
|
claude_settings.write_text("{not json")
|
|
connect.ensure_claude_attribution_header()
|
|
assert claude_settings.read_text() == "{not json"
|
|
assert "couldn't parse" in capsys.readouterr().err
|
|
|
|
|
|
def _fake_claude(monkeypatch, version_output: str) -> None:
|
|
monkeypatch.setattr(connect.shutil, "which", lambda _: "/usr/local/bin/claude")
|
|
monkeypatch.setattr(
|
|
connect.subprocess,
|
|
"run",
|
|
lambda *args, **kwargs: SimpleNamespace(stdout = version_output),
|
|
)
|
|
|
|
|
|
def test_cache_flags_passed_to_supported_claude(monkeypatch):
|
|
_fake_claude(monkeypatch, "2.1.98 (Claude Code)\n")
|
|
assert connect._claude_cache_flags() == ["--exclude-dynamic-system-prompt-sections"]
|
|
|
|
|
|
def test_cache_flags_skipped_on_old_claude(monkeypatch):
|
|
_fake_claude(monkeypatch, "2.0.14 (Claude Code)\n")
|
|
assert connect._claude_cache_flags() == []
|
|
|
|
|
|
def test_cache_flags_skipped_on_unparseable_version(monkeypatch):
|
|
_fake_claude(monkeypatch, "weird build string\n")
|
|
assert connect._claude_cache_flags() == []
|
|
|
|
|
|
def _parse_toml(text: str) -> dict:
|
|
tomllib = pytest.importorskip("tomllib")
|
|
return tomllib.loads(text)
|
|
|
|
|
|
def test_merge_codex_config_fresh():
|
|
merged = connect._merge_codex_config("", BASE)
|
|
parsed = _parse_toml(merged)
|
|
assert parsed["oss_provider"] == "unsloth_api"
|
|
provider = parsed["model_providers"]["unsloth_api"]
|
|
assert provider["base_url"] == f"{BASE}/v1"
|
|
assert provider["wire_api"] == "responses"
|
|
assert provider["requires_openai_auth"] is False
|
|
|
|
|
|
def test_merge_codex_config_replaces_stale_block():
|
|
existing = (
|
|
'model = "gpt-5"\n'
|
|
"\n"
|
|
"[model_providers.unsloth_api]\n"
|
|
'base_url = "http://old-host:9999/v1"\n'
|
|
'wire_api = "chat"\n'
|
|
"\n"
|
|
"[model_providers.unsloth_api.http_headers]\n"
|
|
'x-old = "1"\n'
|
|
"\n"
|
|
"[model_providers.ollama]\n"
|
|
'base_url = "http://localhost:11434/v1"\n'
|
|
)
|
|
merged = connect._merge_codex_config(existing, BASE)
|
|
parsed = _parse_toml(merged)
|
|
assert parsed["model"] == "gpt-5"
|
|
assert parsed["model_providers"]["unsloth_api"]["base_url"] == f"{BASE}/v1"
|
|
assert parsed["model_providers"]["unsloth_api"]["wire_api"] == "responses"
|
|
assert "http_headers" not in parsed["model_providers"]["unsloth_api"]
|
|
assert parsed["model_providers"]["ollama"]["base_url"] == "http://localhost:11434/v1"
|
|
assert connect._merge_codex_config(merged, BASE) == merged
|
|
|
|
|
|
def test_merge_codex_config_keeps_user_oss_provider():
|
|
merged = connect._merge_codex_config('oss_provider = "ollama"\n', BASE)
|
|
assert _parse_toml(merged)["oss_provider"] == "ollama"
|
|
|
|
|
|
def test_write_codex_config_profile(tmp_path, monkeypatch):
|
|
monkeypatch.setenv("CODEX_HOME", str(tmp_path))
|
|
connect.write_codex_config(BASE, MODEL)
|
|
profile = _parse_toml((tmp_path / "unsloth_api.config.toml").read_text())
|
|
assert profile["oss_provider"] == "unsloth_api"
|
|
assert profile["model_provider"] == "unsloth_api"
|
|
assert profile["model"] == MODEL["id"]
|
|
assert profile["model_context_window"] == 131072
|
|
config = _parse_toml((tmp_path / "config.toml").read_text())
|
|
assert config["model_providers"]["unsloth_api"]["env_key"] == "UNSLOTH_STUDIO_AUTH_TOKEN"
|
|
|
|
|
|
@pytest.fixture()
|
|
def fake_studio(tmp_path, monkeypatch, claude_settings):
|
|
calls = []
|
|
state = {"models": [MODEL]}
|
|
|
|
def http_json(
|
|
method,
|
|
url,
|
|
token,
|
|
payload = None,
|
|
timeout = 30,
|
|
error = None,
|
|
):
|
|
calls.append((method, url, payload))
|
|
if url.endswith("/v1/models"):
|
|
return {"object": "list", "data": state["models"]}
|
|
if url.endswith("/api/inference/status"):
|
|
return {"is_gguf": True, "model_identifier": state["models"][0]["id"]}
|
|
if url.endswith("/api/auth/api-keys"):
|
|
return {"key": "sk-unsloth-feedfacefeedface"}
|
|
if url.endswith("/api/inference/load"):
|
|
state["models"] = [{"id": payload["model_path"], "context_length": 4096}]
|
|
return {}
|
|
raise AssertionError(f"unexpected request: {method} {url}")
|
|
|
|
monkeypatch.setattr(connect, "find_studio_server", lambda: BASE)
|
|
# Identity handshake has its own tests; trust the loopback server here.
|
|
monkeypatch.setattr(connect, "verify_studio_identity", lambda base: True)
|
|
# _studio_token / api-keys are faked so the mint flow stays offline.
|
|
monkeypatch.setattr(connect, "_studio_token", lambda: "jwt-token")
|
|
monkeypatch.setattr(connect, "_http_json", http_json)
|
|
monkeypatch.setattr(connect, "_key_cache_path", lambda: tmp_path / "agent_api_key.json")
|
|
# No `claude` on PATH, so _claude_cache_flags never probes the real binary.
|
|
monkeypatch.setattr(connect.shutil, "which", lambda _: None)
|
|
monkeypatch.setenv("CODEX_HOME", str(tmp_path / "codex"))
|
|
monkeypatch.delenv("UNSLOTH_API_KEY", raising = False)
|
|
return calls
|
|
|
|
|
|
def test_connect_claude_no_launch(fake_studio, claude_settings):
|
|
result = CliRunner().invoke(connect.connect_app, ["claude", "--no-launch"])
|
|
assert result.exit_code == 0, result.output
|
|
_assert_env_unset(result.output, "ANTHROPIC_API_KEY")
|
|
_assert_env_unset(result.output, "CLAUDE_CODE_OAUTH_TOKEN")
|
|
_assert_env_set(result.output, "ANTHROPIC_BASE_URL", BASE)
|
|
_assert_env_set(result.output, "ANTHROPIC_AUTH_TOKEN", "sk-unsloth-feedfacefeedface")
|
|
_assert_env_set(result.output, "ANTHROPIC_MODEL", MODEL["id"])
|
|
_assert_env_set(result.output, "CLAUDE_CODE_DISABLE_NONESSENTIAL_TRAFFIC", "1")
|
|
_assert_env_set(result.output, "CLAUDE_CODE_DISABLE_EXPERIMENTAL_BETAS", "1")
|
|
assert f"claude --model {MODEL['id']} --exclude-dynamic-system-prompt-sections" in result.output
|
|
settings = json.loads(claude_settings.read_text())
|
|
assert settings["env"]["CLAUDE_CODE_ATTRIBUTION_HEADER"] == "0"
|
|
|
|
|
|
def test_connect_claude_launch_scrubs_conflicting_auth_env(fake_studio, monkeypatch):
|
|
captured = {}
|
|
monkeypatch.setenv("ANTHROPIC_API_KEY", "sk-anthropic-stale")
|
|
monkeypatch.setenv("CLAUDE_CODE_OAUTH_TOKEN", "oauth-stale")
|
|
monkeypatch.setattr(connect.shutil, "which", lambda _: "/usr/local/bin/claude")
|
|
monkeypatch.setattr(connect, "_claude_cache_flags", lambda: [])
|
|
|
|
def run(command, env):
|
|
captured["command"] = command
|
|
captured["env"] = env
|
|
return SimpleNamespace(returncode = 0)
|
|
|
|
monkeypatch.setattr(connect.subprocess, "run", run)
|
|
result = CliRunner().invoke(connect.connect_app, ["claude"])
|
|
|
|
assert result.exit_code == 0, result.output
|
|
assert captured["command"] == ["/usr/local/bin/claude", "--model", MODEL["id"]]
|
|
assert "ANTHROPIC_API_KEY" not in captured["env"]
|
|
assert "CLAUDE_CODE_OAUTH_TOKEN" not in captured["env"]
|
|
assert captured["env"]["ANTHROPIC_AUTH_TOKEN"] == "sk-unsloth-feedfacefeedface"
|
|
assert captured["env"]["ANTHROPIC_BASE_URL"] == BASE
|
|
assert captured["env"]["ANTHROPIC_MODEL"] == MODEL["id"]
|
|
|
|
|
|
@pytest.mark.skipif(
|
|
os.name == "nt",
|
|
reason = "WSL-from-Linux scenario (calling a Windows agent .exe from inside WSL); "
|
|
"os.name is 'posix' under WSL, so this path can't run on a native Windows runner.",
|
|
)
|
|
def test_connect_claude_windows_shim_from_wsl_bridges_env(fake_studio, monkeypatch):
|
|
captured = {}
|
|
monkeypatch.setenv("WSL_DISTRO_NAME", "Ubuntu")
|
|
monkeypatch.setenv("ANTHROPIC_API_KEY", "sk-anthropic-stale")
|
|
monkeypatch.setenv("CLAUDE_CODE_OAUTH_TOKEN", "oauth-stale")
|
|
monkeypatch.setattr(
|
|
connect.shutil, "which", lambda _: "/mnt/c/Users/samle/AppData/Roaming/npm/claude"
|
|
)
|
|
monkeypatch.setattr(connect, "_claude_cache_flags", lambda: [])
|
|
|
|
def run(command, env):
|
|
captured["command"] = command
|
|
captured["env"] = env
|
|
return SimpleNamespace(returncode = 0)
|
|
|
|
monkeypatch.setattr(connect.subprocess, "run", run)
|
|
result = CliRunner().invoke(connect.connect_app, ["claude"])
|
|
|
|
assert result.exit_code == 0, result.output
|
|
assert captured["command"] == [
|
|
"/mnt/c/Users/samle/AppData/Roaming/npm/claude",
|
|
"--model",
|
|
MODEL["id"],
|
|
]
|
|
assert captured["env"]["ANTHROPIC_API_KEY"] == ""
|
|
assert captured["env"]["CLAUDE_CODE_OAUTH_TOKEN"] == ""
|
|
assert captured["env"]["ANTHROPIC_AUTH_TOKEN"] == "sk-unsloth-feedfacefeedface"
|
|
assert captured["env"]["ANTHROPIC_BASE_URL"] == BASE
|
|
assert captured["env"]["ANTHROPIC_MODEL"] == MODEL["id"]
|
|
for name in (
|
|
"ANTHROPIC_AUTH_TOKEN",
|
|
"ANTHROPIC_BASE_URL",
|
|
"ANTHROPIC_MODEL",
|
|
"ANTHROPIC_API_KEY",
|
|
"CLAUDE_CODE_OAUTH_TOKEN",
|
|
):
|
|
assert name in captured["env"]["WSLENV"].split(":")
|
|
|
|
|
|
@pytest.mark.skipif(
|
|
os.name == "nt",
|
|
reason = "WSL-from-Linux scenario (calling a Windows agent .exe from inside WSL); "
|
|
"os.name is 'posix' under WSL, so this path can't run on a native Windows runner.",
|
|
)
|
|
def test_connect_claude_no_launch_windows_shim_from_wsl_prints_wslenv(fake_studio, monkeypatch):
|
|
monkeypatch.setenv("WSL_DISTRO_NAME", "Ubuntu")
|
|
monkeypatch.setattr(
|
|
connect.shutil, "which", lambda _: "/mnt/c/Users/samle/AppData/Roaming/npm/claude"
|
|
)
|
|
|
|
result = CliRunner().invoke(connect.connect_app, ["claude", "--no-launch"])
|
|
|
|
assert result.exit_code == 0, result.output
|
|
assert "export ANTHROPIC_API_KEY=" in result.output
|
|
assert "export CLAUDE_CODE_OAUTH_TOKEN=" in result.output
|
|
assert "export WSLENV=" in result.output
|
|
assert "ANTHROPIC_AUTH_TOKEN" in result.output
|
|
assert "CLAUDE_CODE_OAUTH_TOKEN" in result.output
|
|
|
|
|
|
def test_connect_codex_no_launch(fake_studio, tmp_path):
|
|
result = CliRunner().invoke(connect.connect_app, ["codex", "--no-launch"])
|
|
assert result.exit_code == 0, result.output
|
|
_assert_env_set(result.output, "UNSLOTH_STUDIO_AUTH_TOKEN", "sk-unsloth-feedfacefeedface")
|
|
assert "codex --oss --profile unsloth_api" in result.output
|
|
assert (tmp_path / "codex" / "config.toml").exists()
|
|
assert (tmp_path / "codex" / "unsloth_api.config.toml").exists()
|
|
|
|
|
|
def test_connect_key_minted_once_then_cached(fake_studio, tmp_path):
|
|
CliRunner().invoke(connect.connect_app, ["claude", "--no-launch"])
|
|
CliRunner().invoke(connect.connect_app, ["claude", "--no-launch"])
|
|
# First run mints; second reuses the minted key cached for this server.
|
|
mints = [c for c in fake_studio if c[1].endswith("/api/auth/api-keys")]
|
|
assert len(mints) == 1
|
|
cached = json.loads((tmp_path / "agent_api_key.json").read_text())
|
|
assert cached["servers"][BASE]["minted"] == ["sk-unsloth-feedfacefeedface"]
|
|
|
|
|
|
def test_connect_explicit_key_remembered_for_keyless_runs(fake_studio, tmp_path):
|
|
CliRunner().invoke(
|
|
connect.connect_app,
|
|
["claude", "--no-launch", "--api-key", "sk-unsloth-deadbeefdeadbeef"],
|
|
)
|
|
result = CliRunner().invoke(connect.connect_app, ["claude", "--no-launch"])
|
|
assert result.exit_code == 0, result.output
|
|
# Reused, not re-minted (a mint would return the feedface stand-in).
|
|
_assert_env_set(result.output, "ANTHROPIC_AUTH_TOKEN", "sk-unsloth-deadbeefdeadbeef")
|
|
cached = json.loads((tmp_path / "agent_api_key.json").read_text())
|
|
# An explicit key is remembered as "saved" so it replays without the handshake.
|
|
assert cached["servers"][BASE]["saved"] == ["sk-unsloth-deadbeefdeadbeef"]
|
|
|
|
|
|
def test_connect_skips_cached_keys_the_server_rejects(fake_studio, tmp_path, monkeypatch):
|
|
cache = tmp_path / "agent_api_key.json"
|
|
cache.write_text(
|
|
json.dumps(
|
|
{"servers": {BASE: {"minted": ["sk-unsloth-stale", "sk-unsloth-feedfacefeedface"]}}}
|
|
)
|
|
)
|
|
inner = connect._http_json
|
|
|
|
def http_json(
|
|
method,
|
|
url,
|
|
token,
|
|
payload = None,
|
|
timeout = 30,
|
|
error = None,
|
|
):
|
|
if url.endswith("/v1/models") and token == "sk-unsloth-stale":
|
|
raise urllib.error.HTTPError(url, 401, "Unauthorized", None, None)
|
|
return inner(method, url, token, payload, timeout, error)
|
|
|
|
monkeypatch.setattr(connect, "_http_json", http_json)
|
|
result = CliRunner().invoke(connect.connect_app, ["claude", "--no-launch"])
|
|
assert result.exit_code == 0, result.output
|
|
_assert_env_set(result.output, "ANTHROPIC_AUTH_TOKEN", "sk-unsloth-feedfacefeedface")
|
|
# The working key moves to the front so the next run tries it first.
|
|
cached = json.loads(cache.read_text())
|
|
assert cached["servers"][BASE]["minted"] == ["sk-unsloth-feedfacefeedface", "sk-unsloth-stale"]
|
|
|
|
|
|
def test_connect_legacy_unscoped_cache_not_replayed(fake_studio, tmp_path):
|
|
# Legacy unscoped caches have no server binding (could leak across servers),
|
|
# so they're ignored: a fresh key is minted and stored scoped to this server.
|
|
(tmp_path / "agent_api_key.json").write_text(json.dumps({"key": "sk-unsloth-oldformat"}))
|
|
result = CliRunner().invoke(connect.connect_app, ["claude", "--no-launch"])
|
|
assert result.exit_code == 0, result.output
|
|
_assert_env_set(result.output, "ANTHROPIC_AUTH_TOKEN", "sk-unsloth-feedfacefeedface")
|
|
cached = json.loads((tmp_path / "agent_api_key.json").read_text())
|
|
assert cached["servers"][BASE]["minted"] == ["sk-unsloth-feedfacefeedface"]
|
|
assert "key" not in cached # legacy field collapsed away
|
|
|
|
|
|
def test_connect_model_flag_loads_on_server(fake_studio):
|
|
result = CliRunner().invoke(
|
|
connect.connect_app, ["claude", "--no-launch", "--model", "unsloth/Qwen3.5-35B-A3B"]
|
|
)
|
|
assert result.exit_code == 0, result.output
|
|
loads = [c for c in fake_studio if c[1].endswith("/api/inference/load")]
|
|
assert loads == [
|
|
("POST", f"{BASE}/api/inference/load", {"model_path": "unsloth/Qwen3.5-35B-A3B"})
|
|
]
|
|
_assert_env_set(result.output, "ANTHROPIC_MODEL", "unsloth/Qwen3.5-35B-A3B")
|
|
|
|
|
|
def test_connect_model_flag_matches_canonical_id(fake_studio, monkeypatch):
|
|
# Studio registers a loaded model under a canonical id (resolved identifier
|
|
# / casing) that can differ from the path we passed. The agent must connect
|
|
# to that model, not silently fall through to the first loaded one.
|
|
requested = "Unsloth/Qwen3.5-35B-A3B"
|
|
canonical = "unsloth/Qwen3.5-35B-A3B"
|
|
inner = connect._http_json
|
|
|
|
def http_json(
|
|
method,
|
|
url,
|
|
token,
|
|
payload = None,
|
|
timeout = 30,
|
|
error = None,
|
|
):
|
|
if url.endswith("/api/inference/load"):
|
|
return {"model": canonical, "display_name": canonical}
|
|
if url.endswith("/v1/models"):
|
|
# Decoy sorts first, so models[0] is the wrong pick on the old code.
|
|
return {"object": "list", "data": [MODEL, {"id": canonical, "context_length": 4096}]}
|
|
return inner(method, url, token, payload, timeout, error)
|
|
|
|
monkeypatch.setattr(connect, "_http_json", http_json)
|
|
result = CliRunner().invoke(
|
|
connect.connect_app, ["claude", "--no-launch", "--model", requested]
|
|
)
|
|
assert result.exit_code == 0, result.output
|
|
_assert_env_set(result.output, "ANTHROPIC_MODEL", canonical)
|
|
|
|
|
|
def test_connect_no_model_loaded_errors(fake_studio, monkeypatch):
|
|
monkeypatch.setattr(
|
|
connect,
|
|
"_http_json",
|
|
lambda method, url, token, payload = None, timeout = 30, error = None: (
|
|
{"key": "sk-unsloth-feedfacefeedface"}
|
|
if url.endswith("/api/auth/api-keys")
|
|
else {"object": "list", "data": []}
|
|
),
|
|
)
|
|
result = CliRunner().invoke(connect.connect_app, ["claude", "--no-launch"])
|
|
assert result.exit_code == 1
|
|
assert "No model is loaded" in result.output
|
|
|
|
|
|
def test_connect_requested_model_not_loaded_fails(fake_studio, monkeypatch):
|
|
# Studio never surfaces the requested model; fail loudly rather than
|
|
# silently connecting to whatever else happens to be loaded.
|
|
inner = connect._http_json
|
|
|
|
def http_json(
|
|
method,
|
|
url,
|
|
token,
|
|
payload = None,
|
|
timeout = 30,
|
|
error = None,
|
|
):
|
|
if url.endswith("/api/inference/load"):
|
|
return {}
|
|
if url.endswith("/v1/models"):
|
|
return {"object": "list", "data": [MODEL]} # decoy; request never appears
|
|
return inner(method, url, token, payload, timeout, error)
|
|
|
|
monkeypatch.setattr(connect, "_http_json", http_json)
|
|
result = CliRunner().invoke(
|
|
connect.connect_app, ["claude", "--no-launch", "--model", "unsloth/Missing-7B"]
|
|
)
|
|
assert result.exit_code == 1
|
|
assert "unsloth/Missing-7B" in result.output
|
|
|
|
|
|
def test_connect_codex_rejects_non_gguf_model(fake_studio, monkeypatch):
|
|
inner = connect._http_json
|
|
|
|
def http_json(
|
|
method,
|
|
url,
|
|
token,
|
|
payload = None,
|
|
timeout = 30,
|
|
error = None,
|
|
):
|
|
if url.endswith("/api/inference/status"):
|
|
return {"is_gguf": False, "model_identifier": "unsloth/Qwen3-0.6B"}
|
|
return inner(method, url, token, payload, timeout, error)
|
|
|
|
monkeypatch.setattr(connect, "_http_json", http_json)
|
|
result = CliRunner().invoke(connect.connect_app, ["codex", "--no-launch"])
|
|
assert result.exit_code == 1
|
|
assert "GGUF" in result.output
|
|
result = CliRunner().invoke(connect.connect_app, ["claude", "--no-launch"])
|
|
assert result.exit_code == 0, result.output
|
|
|
|
|
|
def test_connect_nonloopback_keyless_refuses_to_send_credential(fake_studio, monkeypatch):
|
|
# A server known only by URL + health check is unverified: keyless connect
|
|
# must refuse and make no request at all.
|
|
monkeypatch.setattr(connect, "find_studio_server", lambda: "http://studio.evil.example:8888")
|
|
result = CliRunner().invoke(connect.connect_app, ["opencode", "--no-launch"])
|
|
assert result.exit_code == 1
|
|
assert "Settings → API" in result.output
|
|
assert "--api-key" in result.output
|
|
assert fake_studio == [] # no HTTP request of any kind (no mint, no /v1/models)
|
|
|
|
|
|
def test_connect_nonloopback_explicit_key_is_allowed(fake_studio, monkeypatch):
|
|
# User named both server and key, so it's their choice; only auto-send is blocked.
|
|
monkeypatch.setattr(connect, "find_studio_server", lambda: "http://studio.example:8888")
|
|
result = CliRunner().invoke(
|
|
connect.connect_app,
|
|
["opencode", "--no-launch", "--api-key", "sk-unsloth-deadbeefdeadbeef"],
|
|
)
|
|
assert result.exit_code == 0, result.output
|
|
|
|
|
|
def test_connect_nonloopback_replays_saved_key(fake_studio, tmp_path, monkeypatch):
|
|
# A key saved for a remote (non-loopback) Studio is replayed on keyless runs;
|
|
# auto-minting stays blocked for non-loopback.
|
|
remote = "http://studio.example:8888"
|
|
monkeypatch.setattr(connect, "find_studio_server", lambda: remote)
|
|
(tmp_path / "agent_api_key.json").write_text(
|
|
json.dumps({"servers": {remote: {"saved": ["sk-unsloth-deadbeefdeadbeef"]}}})
|
|
)
|
|
result = CliRunner().invoke(connect.connect_app, ["claude", "--no-launch"])
|
|
assert result.exit_code == 0, result.output
|
|
_assert_env_set(result.output, "ANTHROPIC_AUTH_TOKEN", "sk-unsloth-deadbeefdeadbeef")
|
|
assert not any(c[1].endswith("/api/auth/api-keys") for c in fake_studio) # never minted
|
|
|
|
|
|
def test_connect_studio_server_errors_on_explicit_remote(monkeypatch):
|
|
# A user who pointed UNSLOTH_STUDIO_URL at a remote Studio should get an
|
|
# error, not a silent local model load (which they did not ask for).
|
|
import typer
|
|
|
|
import unsloth_cli._inference as inference
|
|
|
|
monkeypatch.setenv("UNSLOTH_STUDIO_URL", "http://studio.example:8888")
|
|
monkeypatch.setattr(
|
|
inference, "find_studio_server", lambda *a, **k: "http://studio.example:8888"
|
|
)
|
|
with pytest.raises(typer.Exit):
|
|
inference.connect_studio_server("m", hf_token = None, max_seq_length = 4096, load_in_4bit = False)
|
|
|
|
|
|
def test_connect_studio_server_falls_back_locally_on_default_discovery(monkeypatch):
|
|
# Opportunistic local discovery (no UNSLOTH_STUDIO_URL): if the loopback
|
|
# server can't be verified, fall back to a local load rather than erroring.
|
|
import unsloth_cli._inference as inference
|
|
|
|
monkeypatch.delenv("UNSLOTH_STUDIO_URL", raising = False)
|
|
monkeypatch.setattr(inference, "find_studio_server", lambda *a, **k: "http://127.0.0.1:8888")
|
|
monkeypatch.setattr(inference, "verify_studio_identity", lambda *a, **k: False)
|
|
assert (
|
|
inference.connect_studio_server("m", hf_token = None, max_seq_length = 4096, load_in_4bit = False)
|
|
is None
|
|
)
|
|
|
|
|
|
def test_connect_unverified_loopback_without_cached_key_refuses_to_mint(
|
|
fake_studio, tmp_path, monkeypatch
|
|
):
|
|
# With no saved key, the next step would auto-mint; an unverified loopback
|
|
# server (port squatter) must be refused, with nothing sent.
|
|
monkeypatch.setattr(connect, "verify_studio_identity", lambda base: False)
|
|
result = CliRunner().invoke(connect.connect_app, ["claude", "--no-launch"])
|
|
assert result.exit_code == 1
|
|
assert "--api-key" in result.output
|
|
assert not any(c[1].endswith("/api/auth/api-keys") for c in fake_studio) # never minted
|
|
|
|
|
|
def test_connect_replays_saved_key_without_identity_check(fake_studio, tmp_path, monkeypatch):
|
|
# A "saved" key (e.g. for an SSH-tunnelled Studio the handshake can't match)
|
|
# replays on keyless runs without the handshake, scoped to its own base.
|
|
cache = tmp_path / "agent_api_key.json"
|
|
cache.write_text(json.dumps({"servers": {BASE: {"saved": ["sk-unsloth-deadbeefdeadbeef"]}}}))
|
|
monkeypatch.setattr(connect, "verify_studio_identity", lambda base: False)
|
|
result = CliRunner().invoke(connect.connect_app, ["claude", "--no-launch"])
|
|
assert result.exit_code == 0, result.output
|
|
_assert_env_set(result.output, "ANTHROPIC_AUTH_TOKEN", "sk-unsloth-deadbeefdeadbeef")
|
|
assert not any(c[1].endswith("/api/auth/api-keys") for c in fake_studio) # reused, not minted
|
|
|
|
|
|
def test_connect_minted_cache_requires_identity_check(fake_studio, tmp_path, monkeypatch):
|
|
# A "minted" key is NOT replayed to an unverified loopback server: minting and
|
|
# minted-key replay both sit behind the handshake, so a squatter can't grab it.
|
|
cache = tmp_path / "agent_api_key.json"
|
|
cache.write_text(json.dumps({"servers": {BASE: {"minted": ["sk-unsloth-feedfacefeedface"]}}}))
|
|
monkeypatch.setattr(connect, "verify_studio_identity", lambda base: False)
|
|
result = CliRunner().invoke(connect.connect_app, ["claude", "--no-launch"])
|
|
assert result.exit_code == 1
|
|
assert "--api-key" in result.output
|
|
assert not any(c[1].endswith("/v1/models") for c in fake_studio) # minted key never sent
|
|
|
|
|
|
def test_connect_explicit_key_skips_identity_check(fake_studio, monkeypatch):
|
|
# An explicit key is the user's deliberate choice, so it does not require
|
|
# the automatic identity handshake.
|
|
monkeypatch.setattr(connect, "verify_studio_identity", lambda base: False)
|
|
result = CliRunner().invoke(
|
|
connect.connect_app,
|
|
["claude", "--no-launch", "--api-key", "sk-unsloth-deadbeefdeadbeef"],
|
|
)
|
|
assert result.exit_code == 0, result.output
|
|
_assert_env_set(result.output, "ANTHROPIC_AUTH_TOKEN", "sk-unsloth-deadbeefdeadbeef")
|
|
|
|
|
|
def _serve_identity(proof_for):
|
|
"""Start a localhost HTTP server answering /api/auth/identity with
|
|
proof_for(nonce_bytes). Returns (base_url, shutdown)."""
|
|
import base64
|
|
import threading
|
|
from http.server import BaseHTTPRequestHandler, HTTPServer
|
|
from urllib.parse import parse_qs, urlparse
|
|
|
|
class Handler(BaseHTTPRequestHandler):
|
|
def do_GET(self):
|
|
parsed = urlparse(self.path)
|
|
if parsed.path != "/api/auth/identity":
|
|
self.send_response(404)
|
|
self.end_headers()
|
|
return
|
|
nonce = base64.urlsafe_b64decode(parse_qs(parsed.query)["nonce"][0])
|
|
host, port = self.server.server_address[0], self.server.server_address[1]
|
|
body = json.dumps({"proof": proof_for(nonce, host, port)}).encode()
|
|
self.send_response(200)
|
|
self.send_header("Content-Type", "application/json")
|
|
self.end_headers()
|
|
self.wfile.write(body)
|
|
|
|
def log_message(self, *a):
|
|
pass
|
|
|
|
server = HTTPServer(("127.0.0.1", 0), Handler)
|
|
threading.Thread(target = server.serve_forever, daemon = True).start()
|
|
base = f"http://127.0.0.1:{server.server_address[1]}"
|
|
return base, server.shutdown
|
|
|
|
|
|
def test_verify_studio_identity_end_to_end(tmp_path, monkeypatch):
|
|
# Real crypto end to end: verify_studio_identity reads the install secret from
|
|
# an isolated DB; a "good" server proves the same secret, a spoofing one can't.
|
|
import unsloth_cli._inference as inference
|
|
|
|
inference.ensure_studio_backend_path()
|
|
try:
|
|
from studio.backend.auth import storage
|
|
except Exception as exc: # backend not importable here (e.g. missing deps)
|
|
pytest.skip(f"studio backend not importable: {exc}")
|
|
|
|
monkeypatch.setattr(storage, "DB_PATH", tmp_path / "auth.db")
|
|
monkeypatch.setattr(storage, "_identity_secret_cache", None)
|
|
|
|
good = lambda nonce, host, port: storage.compute_identity_proof(
|
|
nonce, host, port
|
|
) # real secret
|
|
bad = lambda nonce, host, port: "00" * 32 # spoofer without the secret
|
|
base_ok, stop_ok = _serve_identity(good)
|
|
base_bad, stop_bad = _serve_identity(bad)
|
|
try:
|
|
assert inference.verify_studio_identity(base_ok) is True
|
|
assert inference.verify_studio_identity(base_bad) is False
|
|
finally:
|
|
stop_ok()
|
|
stop_bad()
|
|
|
|
|
|
def _serve_redirect(target):
|
|
"""Start a localhost server that 302-redirects every GET to target+path."""
|
|
import threading
|
|
from http.server import BaseHTTPRequestHandler, HTTPServer
|
|
|
|
class Handler(BaseHTTPRequestHandler):
|
|
def do_GET(self):
|
|
self.send_response(302)
|
|
self.send_header("Location", target + self.path)
|
|
self.end_headers()
|
|
|
|
def log_message(self, *a):
|
|
pass
|
|
|
|
server = HTTPServer(("127.0.0.1", 0), Handler)
|
|
threading.Thread(target = server.serve_forever, daemon = True).start()
|
|
base = f"http://127.0.0.1:{server.server_address[1]}"
|
|
return base, server.shutdown
|
|
|
|
|
|
def test_verify_studio_identity_rejects_redirect(tmp_path, monkeypatch):
|
|
# A squatter could 302 /api/auth/identity to the real Studio and relay its
|
|
# proof; redirects must be refused so the squatter's base isn't accepted.
|
|
import unsloth_cli._inference as inference
|
|
|
|
inference.ensure_studio_backend_path()
|
|
try:
|
|
from studio.backend.auth import storage
|
|
except Exception as exc:
|
|
pytest.skip(f"studio backend not importable: {exc}")
|
|
|
|
monkeypatch.setattr(storage, "DB_PATH", tmp_path / "auth.db")
|
|
monkeypatch.setattr(storage, "_identity_secret_cache", None)
|
|
|
|
real_base, stop_real = _serve_identity(
|
|
lambda nonce, host, port: storage.compute_identity_proof(nonce, host, port)
|
|
)
|
|
squatter_base, stop_squatter = _serve_redirect(real_base)
|
|
try:
|
|
assert inference.verify_studio_identity(real_base) is True # direct: ok
|
|
assert inference.verify_studio_identity(squatter_base) is False # relayed: refused
|
|
finally:
|
|
stop_real()
|
|
stop_squatter()
|
|
|
|
|
|
def test_verify_studio_identity_rejects_relayed_proof(tmp_path, monkeypatch):
|
|
# A squatter that proxies the nonce to the real Studio on another port gets a
|
|
# proof bound to *that* port; the client expects one bound to the port it
|
|
# connected to, so the relayed proof is rejected.
|
|
import unsloth_cli._inference as inference
|
|
|
|
inference.ensure_studio_backend_path()
|
|
try:
|
|
from studio.backend.auth import storage
|
|
except Exception as exc:
|
|
pytest.skip(f"studio backend not importable: {exc}")
|
|
|
|
monkeypatch.setattr(storage, "DB_PATH", tmp_path / "auth.db")
|
|
monkeypatch.setattr(storage, "_identity_secret_cache", None)
|
|
|
|
real_base, stop_real = _serve_identity(
|
|
lambda nonce, host, port: storage.compute_identity_proof(nonce, host, port)
|
|
)
|
|
real_port = int(real_base.rsplit(":", 1)[1])
|
|
# The squatter answers on its own port but returns the proof for the real port.
|
|
squatter_base, stop_squatter = _serve_identity(
|
|
lambda nonce, host, port: storage.compute_identity_proof(nonce, host, real_port)
|
|
)
|
|
try:
|
|
assert inference.verify_studio_identity(real_base) is True
|
|
assert inference.verify_studio_identity(squatter_base) is False
|
|
finally:
|
|
stop_real()
|
|
stop_squatter()
|
|
|
|
|
|
@pytest.mark.parametrize(
|
|
"url, loopback",
|
|
[
|
|
("http://127.0.0.1:8888", True),
|
|
("http://localhost:8888", True),
|
|
("http://[::1]:8888", True),
|
|
("http://127.0.0.5:9001", True), # SSH tunnels can land anywhere in 127/8
|
|
("http://0.0.0.0:8888", False),
|
|
("http://10.0.0.5:8888", False),
|
|
("http://studio.evil.example:8888", False),
|
|
("https://studio.example.com", False),
|
|
],
|
|
)
|
|
def test_is_loopback_url(url, loopback):
|
|
assert connect.is_loopback_url(url) is loopback
|
|
|
|
|
|
def test_connect_no_studio_errors(fake_studio, monkeypatch):
|
|
monkeypatch.setattr(connect, "find_studio_server", lambda: None)
|
|
result = CliRunner().invoke(connect.connect_app, ["claude", "--no-launch"])
|
|
assert result.exit_code == 1
|
|
assert "No running Studio server" in result.output
|
|
|
|
|
|
def test_connect_explicit_api_key_skips_mint(fake_studio):
|
|
result = CliRunner().invoke(
|
|
connect.connect_app,
|
|
["claude", "--no-launch", "--api-key", "sk-unsloth-deadbeefdeadbeef"],
|
|
)
|
|
assert result.exit_code == 0, result.output
|
|
_assert_env_set(result.output, "ANTHROPIC_AUTH_TOKEN", "sk-unsloth-deadbeefdeadbeef")
|
|
assert not any(c[1].endswith("/api/auth/api-keys") for c in fake_studio)
|
|
|
|
|
|
# ── OpenClaw (Anthropic /v1/messages) ────────────────────────────────
|
|
|
|
|
|
def test_write_openclaw_config_fresh(tmp_path, monkeypatch):
|
|
path = tmp_path / "openclaw.json"
|
|
monkeypatch.setattr(connect, "openclaw_config_path", lambda: path)
|
|
connect.write_openclaw_config(BASE, "sk-unsloth-abc", MODEL)
|
|
config = json.loads(path.read_text())
|
|
provider = config["models"]["providers"]["unsloth"]
|
|
assert provider["baseUrl"] == f"{BASE}/v1"
|
|
assert provider["apiKey"] == "sk-unsloth-abc"
|
|
assert provider["api"] == "openai-completions"
|
|
assert provider["models"] == [
|
|
{"id": MODEL["id"], "name": MODEL["id"], "contextWindow": MODEL["context_length"]}
|
|
]
|
|
# The default model must be pinned or OpenClaw has nothing active.
|
|
assert config["agents"]["defaults"]["model"]["primary"] == f"unsloth/{MODEL['id']}"
|
|
assert config["gateway"]["mode"] == "local"
|
|
assert config["gateway"]["auth"]["mode"] == "none" # unauth loopback gateway
|
|
if os.name != "nt": # the file holds an API key
|
|
assert path.stat().st_mode & 0o777 == 0o600
|
|
|
|
|
|
def test_write_openclaw_config_preserves_and_idempotent(tmp_path, monkeypatch):
|
|
path = tmp_path / "openclaw.json"
|
|
monkeypatch.setattr(connect, "openclaw_config_path", lambda: path)
|
|
path.write_text(
|
|
json.dumps(
|
|
{
|
|
"theme": "dark",
|
|
"agents": {"defaults": {"temperature": 0.5}},
|
|
"models": {"mode": "replace", "providers": {"openrouter": {"baseUrl": "x"}}},
|
|
}
|
|
)
|
|
)
|
|
connect.write_openclaw_config(BASE, "sk-unsloth-abc", MODEL)
|
|
config = json.loads(path.read_text())
|
|
assert config["theme"] == "dark"
|
|
assert config["agents"]["defaults"]["temperature"] == 0.5 # other agent defaults kept
|
|
assert config["agents"]["defaults"]["model"]["primary"] == f"unsloth/{MODEL['id']}"
|
|
assert config["models"]["mode"] == "replace" # user's mode is left as-is
|
|
assert config["models"]["providers"]["openrouter"]["baseUrl"] == "x"
|
|
assert config["models"]["providers"]["unsloth"]["baseUrl"] == f"{BASE}/v1"
|
|
before = path.read_text()
|
|
connect.write_openclaw_config(BASE, "sk-unsloth-abc", MODEL)
|
|
assert path.read_text() == before
|
|
|
|
|
|
def test_write_openclaw_config_corrupt_left_alone(tmp_path, monkeypatch, capsys):
|
|
path = tmp_path / "openclaw.json"
|
|
monkeypatch.setattr(connect, "openclaw_config_path", lambda: path)
|
|
path.write_text("{not json")
|
|
connect.write_openclaw_config(BASE, "sk-unsloth-abc", MODEL)
|
|
assert path.read_text() == "{not json"
|
|
assert "couldn't parse" in capsys.readouterr().err
|
|
|
|
|
|
def test_connect_openclaw_no_launch(fake_studio, tmp_path, monkeypatch):
|
|
path = tmp_path / "openclaw.json"
|
|
monkeypatch.setattr(connect, "openclaw_config_path", lambda: path)
|
|
result = CliRunner().invoke(connect.connect_app, ["openclaw", "--no-launch"])
|
|
assert result.exit_code == 0, result.output
|
|
assert "openclaw" in result.output
|
|
assert "export" not in result.output # key lives in the config, not the env
|
|
config = json.loads(path.read_text())
|
|
assert config["models"]["providers"]["unsloth"]["apiKey"] == "sk-unsloth-feedfacefeedface"
|
|
assert config["agents"]["defaults"]["model"]["primary"] == f"unsloth/{MODEL['id']}"
|
|
# OpenAI /v1/chat/completions works on either backend — no GGUF gate.
|
|
assert not any(c[1].endswith("/api/inference/status") for c in fake_studio)
|
|
|
|
|
|
# ── OpenCode (OpenAI /v1/chat/completions) ───────────────────────────
|
|
|
|
|
|
def test_write_opencode_config_fresh(tmp_path, monkeypatch):
|
|
path = tmp_path / "opencode.json"
|
|
monkeypatch.setattr(connect, "opencode_config_path", lambda: path)
|
|
connect.write_opencode_config(BASE, "sk-unsloth-abc", MODEL)
|
|
config = json.loads(path.read_text())
|
|
provider = config["provider"]["unsloth"]
|
|
assert provider["npm"] == "@ai-sdk/openai-compatible"
|
|
assert provider["options"] == {"baseURL": f"{BASE}/v1", "apiKey": "sk-unsloth-abc"}
|
|
assert provider["models"] == {MODEL["id"]: {"name": MODEL["id"]}}
|
|
assert config["model"] == f"unsloth/{MODEL['id']}"
|
|
|
|
|
|
def test_write_opencode_config_preserves_and_idempotent(tmp_path, monkeypatch):
|
|
path = tmp_path / "opencode.json"
|
|
monkeypatch.setattr(connect, "opencode_config_path", lambda: path)
|
|
path.write_text(
|
|
json.dumps({"theme": "tokyonight", "provider": {"anthropic": {"name": "Anthropic"}}})
|
|
)
|
|
connect.write_opencode_config(BASE, "sk-unsloth-abc", MODEL)
|
|
config = json.loads(path.read_text())
|
|
assert config["theme"] == "tokyonight"
|
|
assert config["provider"]["anthropic"]["name"] == "Anthropic"
|
|
assert config["provider"]["unsloth"]["options"]["baseURL"] == f"{BASE}/v1"
|
|
before = path.read_text()
|
|
connect.write_opencode_config(BASE, "sk-unsloth-abc", MODEL)
|
|
assert path.read_text() == before
|
|
|
|
|
|
def test_connect_opencode_no_launch(fake_studio, tmp_path, monkeypatch):
|
|
path = tmp_path / "opencode.json"
|
|
monkeypatch.setattr(connect, "opencode_config_path", lambda: path)
|
|
result = CliRunner().invoke(connect.connect_app, ["opencode", "--no-launch"])
|
|
assert result.exit_code == 0, result.output
|
|
assert "opencode" in result.output
|
|
config = json.loads(path.read_text())
|
|
assert config["provider"]["unsloth"]["options"]["apiKey"] == "sk-unsloth-feedfacefeedface"
|
|
assert config["model"] == f"unsloth/{MODEL['id']}"
|
|
assert not any(c[1].endswith("/api/inference/status") for c in fake_studio)
|
|
|
|
|
|
# ── Hermes (OpenAI /v1/chat/completions, key via env) ────────────────
|
|
|
|
|
|
@pytest.fixture()
|
|
def hermes_config(tmp_path, monkeypatch):
|
|
path = tmp_path / "config.yaml"
|
|
monkeypatch.setattr(connect, "hermes_config_path", lambda: path)
|
|
return path
|
|
|
|
|
|
def test_write_hermes_config_fresh(hermes_config):
|
|
yaml = pytest.importorskip("yaml")
|
|
connect.write_hermes_config(BASE, MODEL)
|
|
config = yaml.safe_load(hermes_config.read_text())
|
|
# Hermes only honors the key for a *named* custom provider, so the endpoint
|
|
# is registered under providers.* and model.provider points at it.
|
|
assert config["model"]["provider"] == "custom:unsloth"
|
|
assert config["model"]["default"] == MODEL["id"]
|
|
assert config["model"]["api_mode"] == "openai"
|
|
provider = config["providers"]["unsloth"]
|
|
assert provider["base_url"] == f"{BASE}/v1"
|
|
assert provider["api_mode"] == "openai"
|
|
assert provider["key_env"] == "UNSLOTH_API_KEY"
|
|
# The key is resolved from the launch env, never written to disk.
|
|
assert "sk-unsloth" not in hermes_config.read_text()
|
|
|
|
|
|
def test_write_hermes_config_preserves_and_idempotent(hermes_config):
|
|
yaml = pytest.importorskip("yaml")
|
|
hermes_config.write_text(
|
|
yaml.safe_dump(
|
|
{
|
|
"terminal": {"backend": "local"},
|
|
"model": {"temperature": 0.7},
|
|
"providers": {"openrouter": {"base_url": "https://openrouter.ai/api/v1"}},
|
|
}
|
|
)
|
|
)
|
|
connect.write_hermes_config(BASE, MODEL)
|
|
config = yaml.safe_load(hermes_config.read_text())
|
|
assert config["terminal"] == {"backend": "local"} # unrelated sections kept
|
|
assert config["model"]["temperature"] == 0.7 # unrelated model keys kept
|
|
assert config["model"]["provider"] == "custom:unsloth"
|
|
assert config["providers"]["openrouter"]["base_url"] == "https://openrouter.ai/api/v1"
|
|
assert config["providers"]["unsloth"]["base_url"] == f"{BASE}/v1"
|
|
before = hermes_config.read_text()
|
|
connect.write_hermes_config(BASE, MODEL)
|
|
assert hermes_config.read_text() == before
|
|
|
|
|
|
def test_write_hermes_config_preserves_non_mapping_file(hermes_config, capsys):
|
|
pytest.importorskip("yaml")
|
|
original = "- just\n- a\n- list\n" # valid YAML, but not a mapping
|
|
hermes_config.write_text(original)
|
|
connect.write_hermes_config(BASE, MODEL)
|
|
assert hermes_config.read_text() == original # user-managed file left untouched
|
|
assert "couldn't parse" in capsys.readouterr().err
|
|
|
|
|
|
def test_connect_hermes_no_launch(fake_studio, hermes_config):
|
|
yaml = pytest.importorskip("yaml")
|
|
result = CliRunner().invoke(connect.connect_app, ["hermes", "--no-launch"])
|
|
assert result.exit_code == 0, result.output
|
|
_assert_env_set(result.output, "UNSLOTH_API_KEY", "sk-unsloth-feedfacefeedface")
|
|
assert "hermes" in result.output
|
|
config = yaml.safe_load(hermes_config.read_text())
|
|
assert config["model"]["provider"] == "custom:unsloth"
|
|
assert config["providers"]["unsloth"]["base_url"] == f"{BASE}/v1"
|
|
assert config["model"]["default"] == MODEL["id"]
|
|
assert not any(c[1].endswith("/api/inference/status") for c in fake_studio)
|