diff --git a/tests/studio/install/test_rocm_support.py b/tests/studio/install/test_rocm_support.py new file mode 100644 index 0000000000..62ceece457 --- /dev/null +++ b/tests/studio/install/test_rocm_support.py @@ -0,0 +1,930 @@ +"""Tests for AMD ROCm support across install pathways. + +Verifies that ROCm detection and installation logic works correctly +WITHOUT breaking existing CUDA, CPU, macOS, and Windows pathways. +All tests use mocks -- no AMD hardware required. +""" + +import importlib.util +import os +import subprocess +import sys +from pathlib import Path +from unittest.mock import MagicMock, patch, PropertyMock + +import pytest + + +# ── Load modules under test ────────────────────────────────────────────────── + +PACKAGE_ROOT = Path(__file__).resolve().parents[3] + +# install_llama_prebuilt.py +_PREBUILT_PATH = PACKAGE_ROOT / "studio" / "install_llama_prebuilt.py" +_PREBUILT_SPEC = importlib.util.spec_from_file_location( + "studio_install_llama_prebuilt", _PREBUILT_PATH +) +assert _PREBUILT_SPEC is not None and _PREBUILT_SPEC.loader is not None +prebuilt_mod = importlib.util.module_from_spec(_PREBUILT_SPEC) +sys.modules[_PREBUILT_SPEC.name] = prebuilt_mod +_PREBUILT_SPEC.loader.exec_module(prebuilt_mod) + +HostInfo = prebuilt_mod.HostInfo +AssetChoice = prebuilt_mod.AssetChoice +PrebuiltFallback = prebuilt_mod.PrebuiltFallback +resolve_upstream_asset_choice = prebuilt_mod.resolve_upstream_asset_choice +runtime_patterns_for_choice = prebuilt_mod.runtime_patterns_for_choice + +# install_python_stack.py +_STACK_PATH = PACKAGE_ROOT / "studio" / "install_python_stack.py" +_STACK_SPEC = importlib.util.spec_from_file_location( + "studio_install_python_stack", _STACK_PATH +) +assert _STACK_SPEC is not None and _STACK_SPEC.loader is not None +stack_mod = importlib.util.module_from_spec(_STACK_SPEC) +sys.modules[_STACK_SPEC.name] = stack_mod +_STACK_SPEC.loader.exec_module(stack_mod) + +_detect_rocm_version = stack_mod._detect_rocm_version +_ensure_rocm_torch = stack_mod._ensure_rocm_torch +_ROCM_TORCH_INDEX = stack_mod._ROCM_TORCH_INDEX + + +# ── Helper: build HostInfo for different scenarios ────────────────────────── + + +def nvidia_host(**overrides) -> HostInfo: + """NVIDIA Linux x86_64 host.""" + defaults = dict( + system = "Linux", + machine = "x86_64", + is_windows = False, + is_linux = True, + is_macos = False, + is_x86_64 = True, + is_arm64 = False, + nvidia_smi = "/usr/bin/nvidia-smi", + driver_cuda_version = (12, 6), + compute_caps = ["89"], + visible_cuda_devices = None, + has_physical_nvidia = True, + has_usable_nvidia = True, + has_rocm = False, + ) + defaults.update(overrides) + return HostInfo(**defaults) + + +def rocm_host(**overrides) -> HostInfo: + """AMD ROCm Linux x86_64 host (no NVIDIA).""" + defaults = dict( + system = "Linux", + machine = "x86_64", + is_windows = False, + is_linux = True, + is_macos = False, + is_x86_64 = True, + is_arm64 = False, + nvidia_smi = None, + driver_cuda_version = None, + compute_caps = [], + visible_cuda_devices = None, + has_physical_nvidia = False, + has_usable_nvidia = False, + has_rocm = True, + ) + defaults.update(overrides) + return HostInfo(**defaults) + + +def cpu_host(**overrides) -> HostInfo: + """CPU-only Linux x86_64 host.""" + defaults = dict( + system = "Linux", + machine = "x86_64", + is_windows = False, + is_linux = True, + is_macos = False, + is_x86_64 = True, + is_arm64 = False, + nvidia_smi = None, + driver_cuda_version = None, + compute_caps = [], + visible_cuda_devices = None, + has_physical_nvidia = False, + has_usable_nvidia = False, + has_rocm = False, + ) + defaults.update(overrides) + return HostInfo(**defaults) + + +def macos_host(**overrides) -> HostInfo: + """macOS arm64 host.""" + defaults = dict( + system = "Darwin", + machine = "arm64", + is_windows = False, + is_linux = False, + is_macos = True, + is_x86_64 = False, + is_arm64 = True, + nvidia_smi = None, + driver_cuda_version = None, + compute_caps = [], + visible_cuda_devices = None, + has_physical_nvidia = False, + has_usable_nvidia = False, + has_rocm = False, + ) + defaults.update(overrides) + return HostInfo(**defaults) + + +def windows_host(**overrides) -> HostInfo: + """Windows x86_64 host.""" + defaults = dict( + system = "Windows", + machine = "amd64", + is_windows = True, + is_linux = False, + is_macos = False, + is_x86_64 = True, + is_arm64 = False, + nvidia_smi = None, + driver_cuda_version = None, + compute_caps = [], + visible_cuda_devices = None, + has_physical_nvidia = False, + has_usable_nvidia = False, + has_rocm = False, + ) + defaults.update(overrides) + return HostInfo(**defaults) + + +def windows_rocm_host(**overrides) -> HostInfo: + """Windows x86_64 host with ROCm.""" + defaults = dict( + system = "Windows", + machine = "amd64", + is_windows = True, + is_linux = False, + is_macos = False, + is_x86_64 = True, + is_arm64 = False, + nvidia_smi = None, + driver_cuda_version = None, + compute_caps = [], + visible_cuda_devices = None, + has_physical_nvidia = False, + has_usable_nvidia = False, + has_rocm = True, + ) + defaults.update(overrides) + return HostInfo(**defaults) + + +# ── Upstream asset fixture ─────────────────────────────────────────────────── + +LLAMA_TAG = "b8508" + +UPSTREAM_ASSETS = { + f"llama-{LLAMA_TAG}-bin-ubuntu-x64.tar.gz": f"https://example.com/{LLAMA_TAG}-linux-cpu.tar.gz", + f"llama-{LLAMA_TAG}-bin-ubuntu-rocm-7.2-x64.tar.gz": f"https://example.com/{LLAMA_TAG}-linux-rocm.tar.gz", + f"llama-{LLAMA_TAG}-bin-win-cpu-x64.zip": f"https://example.com/{LLAMA_TAG}-win-cpu.zip", + f"llama-{LLAMA_TAG}-bin-win-cuda-12.4-x64.zip": f"https://example.com/{LLAMA_TAG}-win-cuda.zip", + f"llama-{LLAMA_TAG}-bin-win-hip-radeon-x64.zip": f"https://example.com/{LLAMA_TAG}-win-hip.zip", + f"llama-{LLAMA_TAG}-bin-macos-arm64.tar.gz": f"https://example.com/{LLAMA_TAG}-macos-arm64.tar.gz", + f"llama-{LLAMA_TAG}-bin-macos-x64.tar.gz": f"https://example.com/{LLAMA_TAG}-macos-x64.tar.gz", +} + + +# ============================================================================= +# TEST: install_llama_prebuilt.py -- resolve_upstream_asset_choice +# ============================================================================= + + +class TestResolveUpstreamAssetChoice: + """Verify that the asset selection logic picks the right binary for each platform.""" + + @patch.object(prebuilt_mod, "github_release_assets", return_value = UPSTREAM_ASSETS) + def test_nvidia_linux_gets_cpu_asset(self, mock_assets): + """NVIDIA host should NOT hit the ROCm path -- gets CPU asset (CUDA handled elsewhere).""" + host = nvidia_host() + choice = resolve_upstream_asset_choice(host, LLAMA_TAG) + assert choice.install_kind == "linux-cpu" + assert "ubuntu-x64" in choice.name + assert "rocm" not in choice.name + + @patch.object(prebuilt_mod, "github_release_assets", return_value = UPSTREAM_ASSETS) + def test_rocm_linux_gets_rocm_prebuilt(self, mock_assets): + """AMD ROCm Linux host should get the ROCm prebuilt.""" + host = rocm_host() + choice = resolve_upstream_asset_choice(host, LLAMA_TAG) + assert choice.install_kind == "linux-rocm" + assert "rocm" in choice.name + + @patch.object(prebuilt_mod, "github_release_assets", return_value = UPSTREAM_ASSETS) + def test_cpu_linux_gets_cpu_asset(self, mock_assets): + """CPU-only Linux host should get CPU asset.""" + host = cpu_host() + choice = resolve_upstream_asset_choice(host, LLAMA_TAG) + assert choice.install_kind == "linux-cpu" + assert "ubuntu-x64" in choice.name + + @patch.object(prebuilt_mod, "github_release_assets", return_value = UPSTREAM_ASSETS) + def test_macos_arm64_gets_macos_asset(self, mock_assets): + """macOS arm64 host should get macOS asset.""" + host = macos_host() + choice = resolve_upstream_asset_choice(host, LLAMA_TAG) + assert choice.install_kind == "macos-arm64" + assert "macos-arm64" in choice.name + + @patch.object(prebuilt_mod, "github_release_assets", return_value = UPSTREAM_ASSETS) + def test_windows_cpu_gets_cpu_asset(self, mock_assets): + """Windows CPU-only host should get Windows CPU asset.""" + host = windows_host() + choice = resolve_upstream_asset_choice(host, LLAMA_TAG) + assert choice.install_kind == "windows-cpu" + assert "win-cpu" in choice.name + + @patch.object(prebuilt_mod, "github_release_assets", return_value = UPSTREAM_ASSETS) + def test_windows_rocm_gets_hip_asset(self, mock_assets): + """Windows ROCm host should get Windows HIP asset.""" + host = windows_rocm_host() + choice = resolve_upstream_asset_choice(host, LLAMA_TAG) + assert choice.install_kind == "windows-hip" + assert "hip" in choice.name + + @patch.object(prebuilt_mod, "github_release_assets", return_value = UPSTREAM_ASSETS) + def test_mixed_nvidia_rocm_prefers_nvidia(self, mock_assets): + """Host with both NVIDIA and ROCm should use NVIDIA (CPU path here, CUDA elsewhere).""" + host = nvidia_host(has_rocm = True) + choice = resolve_upstream_asset_choice(host, LLAMA_TAG) + # NVIDIA hosts go through the normal path (CUDA handled by resolve_linux_cuda_choice) + assert choice.install_kind == "linux-cpu" + assert "rocm" not in choice.name + + @patch.object(prebuilt_mod, "github_release_assets") + def test_rocm_linux_no_prebuilt_falls_back(self, mock_assets): + """AMD ROCm host should fall back to source build when no ROCm prebuilt exists.""" + # Remove the ROCm asset from available assets + assets_without_rocm = { + k: v for k, v in UPSTREAM_ASSETS.items() if "rocm" not in k + } + mock_assets.return_value = assets_without_rocm + host = rocm_host() + with pytest.raises(PrebuiltFallback, match = "ROCm detected"): + resolve_upstream_asset_choice(host, LLAMA_TAG) + + @patch.object(prebuilt_mod, "github_release_assets") + def test_windows_rocm_no_hip_falls_to_cpu(self, mock_assets): + """Windows+ROCm with HIP prebuilt missing should fall through to CPU.""" + assets_no_hip = {k: v for k, v in UPSTREAM_ASSETS.items() if "hip" not in k} + mock_assets.return_value = assets_no_hip + host = windows_rocm_host() + choice = resolve_upstream_asset_choice(host, LLAMA_TAG) + assert choice.install_kind == "windows-cpu" + + @patch.object(prebuilt_mod, "github_release_assets", return_value = UPSTREAM_ASSETS) + def test_macos_rocm_impossible_has_rocm_false(self, mock_assets): + """macOS host should never have has_rocm=True in practice; verify it gets macOS asset.""" + host = macos_host(has_rocm = True) + choice = resolve_upstream_asset_choice(host, LLAMA_TAG) + assert choice.install_kind == "macos-arm64" + + @patch.object(prebuilt_mod, "github_release_assets", return_value = UPSTREAM_ASSETS) + def test_linux_aarch64_rocm_gets_prebuilt_fallback(self, mock_assets): + """Linux aarch64 with ROCm -- no x86_64 match, should raise PrebuiltFallback.""" + host = rocm_host(machine = "aarch64", is_x86_64 = False, is_arm64 = True) + with pytest.raises(PrebuiltFallback): + resolve_upstream_asset_choice(host, LLAMA_TAG) + + +# ============================================================================= +# TEST: install_llama_prebuilt.py -- runtime_patterns_for_choice +# ============================================================================= + + +class TestRuntimePatterns: + """Verify runtime file patterns for all install kinds.""" + + def test_linux_cpu_patterns(self): + choice = AssetChoice( + repo = "", tag = "", name = "", url = "", source_label = "", install_kind = "linux-cpu" + ) + patterns = runtime_patterns_for_choice(choice) + assert "llama-server" in patterns + assert "llama-quantize" in patterns + + def test_linux_cuda_patterns(self): + choice = AssetChoice( + repo = "", tag = "", name = "", url = "", source_label = "", install_kind = "linux-cuda" + ) + patterns = runtime_patterns_for_choice(choice) + assert "libggml-cuda.so*" in patterns + + def test_linux_rocm_patterns(self): + choice = AssetChoice( + repo = "", tag = "", name = "", url = "", source_label = "", install_kind = "linux-rocm" + ) + patterns = runtime_patterns_for_choice(choice) + assert "libggml-hip.so*" in patterns + assert "llama-server" in patterns + + def test_windows_hip_patterns(self): + choice = AssetChoice( + repo = "", + tag = "", + name = "", + url = "", + source_label = "", + install_kind = "windows-hip", + ) + patterns = runtime_patterns_for_choice(choice) + assert "*.exe" in patterns + assert "*.dll" in patterns + + def test_macos_patterns(self): + choice = AssetChoice( + repo = "", + tag = "", + name = "", + url = "", + source_label = "", + install_kind = "macos-arm64", + ) + patterns = runtime_patterns_for_choice(choice) + assert "lib*.dylib" in patterns + + +# ============================================================================= +# TEST: install_llama_prebuilt.py -- HostInfo.has_rocm field +# ============================================================================= + + +class TestHostInfoRocm: + """Verify has_rocm field does not affect other HostInfo behavior.""" + + def test_has_rocm_default_false(self): + host = HostInfo( + system = "Linux", + machine = "x86_64", + is_windows = False, + is_linux = True, + is_macos = False, + is_x86_64 = True, + is_arm64 = False, + nvidia_smi = None, + driver_cuda_version = None, + compute_caps = [], + visible_cuda_devices = None, + has_physical_nvidia = False, + has_usable_nvidia = False, + ) + assert host.has_rocm is False + + def test_has_rocm_explicit_true(self): + host = rocm_host() + assert host.has_rocm is True + + def test_nvidia_host_no_rocm(self): + host = nvidia_host() + assert host.has_rocm is False + assert host.has_usable_nvidia is True + + def test_detect_host_with_rocm_path_env(self): + """detect_host() checks ROCM_PATH env var for ROCm detection.""" + # Verify the detect_host function source references ROCM_PATH + import inspect + + source = inspect.getsource(prebuilt_mod.detect_host) + assert "ROCM_PATH" in source or "rocm" in source.lower() + + +# ============================================================================= +# TEST: install_python_stack.py -- _detect_rocm_version +# ============================================================================= + + +class TestDetectRocmVersion: + """Verify ROCm version detection from various sources.""" + + def test_no_rocm_returns_none(self, tmp_path): + """No ROCm installed should return None.""" + with patch.dict(os.environ, {"ROCM_PATH": str(tmp_path / "nonexistent")}): + with patch("shutil.which", return_value = None): + result = _detect_rocm_version() + assert result is None + + def test_version_from_file(self, tmp_path): + """Reads version from /opt/rocm/.info/version.""" + info_dir = tmp_path / ".info" + info_dir.mkdir() + (info_dir / "version").write_text("7.1.0-12345\n") + with patch.dict(os.environ, {"ROCM_PATH": str(tmp_path)}): + result = _detect_rocm_version() + assert result == (7, 1) + + def test_version_62(self, tmp_path): + """Reads ROCm 6.2 version.""" + info_dir = tmp_path / ".info" + info_dir.mkdir() + (info_dir / "version").write_text("6.2.0\n") + with patch.dict(os.environ, {"ROCM_PATH": str(tmp_path)}): + result = _detect_rocm_version() + assert result == (6, 2) + + def test_hipconfig_fallback(self, tmp_path): + """Falls back to hipconfig --version when file not found.""" + with patch.dict(os.environ, {"ROCM_PATH": str(tmp_path / "nonexistent")}): + mock_result = MagicMock() + mock_result.returncode = 0 + mock_result.stdout = b"6.3.21234.2\n" + with patch("shutil.which", return_value = "/usr/bin/hipconfig"): + with patch("subprocess.run", return_value = mock_result): + result = _detect_rocm_version() + assert result == (6, 3) + + def test_empty_version_file(self, tmp_path): + """Empty version file should return None.""" + info_dir = tmp_path / ".info" + info_dir.mkdir() + (info_dir / "version").write_text("") + with patch.dict(os.environ, {"ROCM_PATH": str(tmp_path)}): + with patch("shutil.which", return_value = None): + result = _detect_rocm_version() + assert result is None + + def test_version_with_epoch_prefix(self, tmp_path): + """Debian epoch prefix (2:6.2.0) -- version file has no epoch, so should parse.""" + info_dir = tmp_path / ".info" + info_dir.mkdir() + # Version files don't typically have epoch prefix, but lib/rocm_version might + (info_dir / "version").write_text("6.2.0\n") + with patch.dict(os.environ, {"ROCM_PATH": str(tmp_path)}): + result = _detect_rocm_version() + assert result == (6, 2) + + def test_multiple_version_sources_first_wins(self, tmp_path): + """When both .info/version and lib/rocm_version exist, first found wins.""" + info_dir = tmp_path / ".info" + info_dir.mkdir() + (info_dir / "version").write_text("7.1.0\n") + lib_dir = tmp_path / "lib" + lib_dir.mkdir() + (lib_dir / "rocm_version").write_text("6.3.0\n") + with patch.dict(os.environ, {"ROCM_PATH": str(tmp_path)}): + result = _detect_rocm_version() + assert result == (7, 1) # .info/version checked first + + def test_hipconfig_multiline_output(self, tmp_path): + """hipconfig with multi-line output -- should use first line.""" + with patch.dict(os.environ, {"ROCM_PATH": str(tmp_path / "nonexistent")}): + mock_result = MagicMock() + mock_result.returncode = 0 + mock_result.stdout = b"6.3.21234.2\nSome extra info\n" + with patch("shutil.which", return_value = "/usr/bin/hipconfig"): + with patch("subprocess.run", return_value = mock_result): + result = _detect_rocm_version() + assert result == (6, 3) + + def test_hipconfig_timeout(self, tmp_path): + """hipconfig that times out should return None.""" + with patch.dict(os.environ, {"ROCM_PATH": str(tmp_path / "nonexistent")}): + with patch("shutil.which", return_value = "/usr/bin/hipconfig"): + with patch( + "subprocess.run", + side_effect = subprocess.TimeoutExpired("hipconfig", 5), + ): + result = _detect_rocm_version() + assert result is None + + +# ============================================================================= +# TEST: install_python_stack.py -- _ensure_rocm_torch +# ============================================================================= + + +class TestEnsureRocmTorch: + """Verify ROCm torch reinstall logic.""" + + @patch.object(stack_mod, "pip_install") + def test_no_rocm_skips(self, mock_pip): + """No ROCm toolchain should skip entirely.""" + with patch("os.path.isdir", return_value = False): + with patch("shutil.which", return_value = None): + _ensure_rocm_torch() + mock_pip.assert_not_called() + + @patch.object(stack_mod, "pip_install") + @patch.object(stack_mod, "_detect_rocm_version", return_value = (7, 1)) + def test_torch_already_has_cuda_skips(self, mock_ver, mock_pip): + """If torch already has CUDA, should skip ROCm reinstall.""" + mock_probe = MagicMock() + mock_probe.returncode = 0 + mock_probe.stdout = b"12.6\n" # CUDA version string + with patch("os.path.isdir", return_value = True): + with patch("subprocess.run", return_value = mock_probe): + _ensure_rocm_torch() + mock_pip.assert_not_called() + + @patch.object(stack_mod, "pip_install") + @patch.object(stack_mod, "_detect_rocm_version", return_value = (7, 1)) + def test_torch_already_has_hip_skips(self, mock_ver, mock_pip): + """If torch already has HIP, should skip ROCm reinstall.""" + mock_probe = MagicMock() + mock_probe.returncode = 0 + mock_probe.stdout = b"7.1.12345\n" # HIP version string + with patch("os.path.isdir", return_value = True): + with patch("subprocess.run", return_value = mock_probe): + _ensure_rocm_torch() + mock_pip.assert_not_called() + + @patch.object(stack_mod, "pip_install") + @patch.object(stack_mod, "_detect_rocm_version", return_value = (7, 1)) + def test_cpu_torch_gets_rocm_reinstall(self, mock_ver, mock_pip): + """CPU-only torch on ROCm host should trigger reinstall.""" + mock_probe = MagicMock() + mock_probe.returncode = 0 + mock_probe.stdout = b"\n" # empty = no GPU backend + with patch("os.path.isdir", return_value = True): + with patch("subprocess.run", return_value = mock_probe): + _ensure_rocm_torch() + # Should call pip_install twice: once for torch, once for bitsandbytes + assert mock_pip.call_count == 2 + torch_call = mock_pip.call_args_list[0] + assert "rocm7.1" in str(torch_call) + bnb_call = mock_pip.call_args_list[1] + assert "bitsandbytes" in str(bnb_call) + + @patch.object(stack_mod, "pip_install") + @patch.object(stack_mod, "_detect_rocm_version", return_value = (6, 3)) + def test_rocm_63_selects_correct_tag(self, mock_ver, mock_pip): + """ROCm 6.3 should select rocm6.3 tag.""" + mock_probe = MagicMock() + mock_probe.returncode = 0 + mock_probe.stdout = b"\n" + with patch("os.path.isdir", return_value = True): + with patch("subprocess.run", return_value = mock_probe): + _ensure_rocm_torch() + torch_call = mock_pip.call_args_list[0] + assert "rocm6.3" in str(torch_call) + + @patch.object(stack_mod, "pip_install") + @patch.object(stack_mod, "_detect_rocm_version", return_value = (5, 0)) + def test_old_rocm_skips(self, mock_ver, mock_pip): + """ROCm version too old (below 6.0) should skip.""" + mock_probe = MagicMock() + mock_probe.returncode = 0 + mock_probe.stdout = b"\n" + with patch("os.path.isdir", return_value = True): + with patch("subprocess.run", return_value = mock_probe): + _ensure_rocm_torch() + mock_pip.assert_not_called() + + @patch.object(stack_mod, "pip_install") + @patch.object(stack_mod, "_detect_rocm_version", return_value = None) + def test_version_unreadable_prints_warning(self, mock_ver, mock_pip, capsys): + """ROCm detected but version unreadable should print warning and skip.""" + with patch("os.path.isdir", return_value = True): + _ensure_rocm_torch() + mock_pip.assert_not_called() + captured = capsys.readouterr() + assert "unreadable" in captured.out + + @patch.object(stack_mod, "pip_install") + @patch.object(stack_mod, "_detect_rocm_version", return_value = (7, 2)) + def test_rocm_72_selects_71_tag(self, mock_ver, mock_pip): + """ROCm 7.2 should select rocm7.1 tag (capped, not in mapping).""" + mock_probe = MagicMock() + mock_probe.returncode = 0 + mock_probe.stdout = b"\n" + with patch("os.path.isdir", return_value = True): + with patch("subprocess.run", return_value = mock_probe): + _ensure_rocm_torch() + torch_call = mock_pip.call_args_list[0] + assert "rocm7.1" in str(torch_call) + + @patch.object(stack_mod, "pip_install") + @patch.object(stack_mod, "_detect_rocm_version", return_value = (7, 1)) + def test_probe_timeout_handled(self, mock_ver, mock_pip): + """Probe subprocess timeout should be handled gracefully.""" + with patch("os.path.isdir", return_value = True): + with patch( + "subprocess.run", side_effect = subprocess.TimeoutExpired("python", 30) + ): + # Should not crash -- timeout on probe means torch not importable + # The function will get an exception from subprocess.run and + # proceed to reinstall + try: + _ensure_rocm_torch() + except subprocess.TimeoutExpired: + pass # Acceptable -- the fix is about the timeout being set + + +# ============================================================================= +# TEST: install_python_stack.py -- _ROCM_TORCH_INDEX mapping +# ============================================================================= + + +class TestRocmTorchIndex: + """Verify the ROCm version -> torch index tag mapping.""" + + def test_mapping_is_sorted_descending(self): + """Keys should be in descending order for the next() iteration to work.""" + keys = list(_ROCM_TORCH_INDEX.keys()) + assert keys == sorted(keys, reverse = True) + + def test_rocm_72_not_in_mapping(self): + """ROCm 7.2 should NOT be in the active mapping (torch 2.11.0 exceeds bound).""" + assert (7, 2) not in _ROCM_TORCH_INDEX + + def test_rocm_71_maps_correctly(self): + assert _ROCM_TORCH_INDEX[(7, 1)] == "rocm7.1" + + def test_rocm_63_maps_correctly(self): + assert _ROCM_TORCH_INDEX[(6, 3)] == "rocm6.3" + + def test_rocm_60_maps_correctly(self): + assert _ROCM_TORCH_INDEX[(6, 0)] == "rocm6.0" + + def test_all_tags_use_download_pytorch(self): + """All tags should be for download.pytorch.org, not repo.radeon.com.""" + for tag in _ROCM_TORCH_INDEX.values(): + assert tag.startswith("rocm") + assert "radeon" not in tag + + def test_newer_rocm_selects_best_match(self): + """ROCm 7.2 (not in map) should select rocm7.1 via >= comparison.""" + ver = (7, 2) + tag = next( + (t for (maj, mn), t in _ROCM_TORCH_INDEX.items() if ver >= (maj, mn)), + None, + ) + assert tag == "rocm7.1" + + def test_rocm_64_selects_64(self): + ver = (6, 4) + tag = next( + (t for (maj, mn), t in _ROCM_TORCH_INDEX.items() if ver >= (maj, mn)), + None, + ) + assert tag == "rocm6.4" + + +# ============================================================================= +# TEST: hardware.py -- IS_ROCM flag and detect_hardware +# ============================================================================= + + +class TestHardwareRocmFlag: + """Verify IS_ROCM flag behavior without importing the full hardware module.""" + + def test_hardware_py_has_is_rocm(self): + """hardware.py should define IS_ROCM.""" + hw_path = ( + PACKAGE_ROOT / "studio" / "backend" / "utils" / "hardware" / "hardware.py" + ) + source = hw_path.read_text() + assert "IS_ROCM: bool = False" in source + + def test_hardware_py_sets_is_rocm_on_hip(self): + """detect_hardware() should set IS_ROCM when torch.version.hip is set.""" + hw_path = ( + PACKAGE_ROOT / "studio" / "backend" / "utils" / "hardware" / "hardware.py" + ) + source = hw_path.read_text() + assert 'torch.version, "hip"' in source or "torch.version.hip" in source + + def test_hardware_py_still_returns_cuda_for_rocm(self): + """DeviceType should remain CUDA even on ROCm -- no DeviceType.ROCM.""" + hw_path = ( + PACKAGE_ROOT / "studio" / "backend" / "utils" / "hardware" / "hardware.py" + ) + source = hw_path.read_text() + # Ensure ROCM is NOT a DeviceType member + enum_section = source.split("class DeviceType")[1].split("\n\n")[0] + assert "ROCM" not in enum_section + + def test_hardware_py_has_rocm_in_package_versions(self): + """get_package_versions() should include 'rocm' key.""" + hw_path = ( + PACKAGE_ROOT / "studio" / "backend" / "utils" / "hardware" / "hardware.py" + ) + source = hw_path.read_text() + assert '"rocm"' in source + + def test_hardware_py_device_type_cuda_references_intact(self): + """All existing DeviceType.CUDA references should still be present.""" + hw_path = ( + PACKAGE_ROOT / "studio" / "backend" / "utils" / "hardware" / "hardware.py" + ) + source = hw_path.read_text() + # Key functions that must still reference DeviceType.CUDA + assert "DeviceType.CUDA" in source + assert "DEVICE = DeviceType.CUDA" in source + + def test_is_rocm_exported_from_init(self): + """IS_ROCM should be exported from hardware __init__.py.""" + init_path = ( + PACKAGE_ROOT / "studio" / "backend" / "utils" / "hardware" / "__init__.py" + ) + source = init_path.read_text() + assert "IS_ROCM" in source + + def test_is_rocm_in_all_list(self): + """IS_ROCM should be in __all__ list in __init__.py.""" + init_path = ( + PACKAGE_ROOT / "studio" / "backend" / "utils" / "hardware" / "__init__.py" + ) + source = init_path.read_text() + # Extract __all__ section + assert '"IS_ROCM"' in source + + def test_get_package_versions_returns_rocm_key(self): + """get_package_versions() source should return both 'cuda' and 'rocm' keys.""" + hw_path = ( + PACKAGE_ROOT / "studio" / "backend" / "utils" / "hardware" / "hardware.py" + ) + source = hw_path.read_text() + # Find the get_package_versions function body + func_start = source.find("def get_package_versions") + func_body = source[func_start : source.find("\ndef ", func_start + 1)] + assert '"cuda"' in func_body + assert '"rocm"' in func_body + + +# ============================================================================= +# TEST: tokenizer_utils.py -- error message +# ============================================================================= + + +class TestTokenizerErrorMessage: + """Verify the AMD error message is updated.""" + + def test_no_old_amd_message(self): + """Old 'We do not support AMD' message should be gone.""" + tu_path = PACKAGE_ROOT / "unsloth" / "tokenizer_utils.py" + source = tu_path.read_text() + assert "We do not support AMD" not in source + + def test_new_message_has_docs_link(self): + """New message should point to Unsloth AMD docs.""" + tu_path = PACKAGE_ROOT / "unsloth" / "tokenizer_utils.py" + source = tu_path.read_text() + assert "docs.unsloth.ai" in source or "No GPU detected" in source + + +# ============================================================================= +# TEST: install.sh -- structural checks +# ============================================================================= + + +class TestInstallShStructure: + """Verify install.sh structural properties without running it.""" + + def test_no_here_strings(self): + """install.sh must not use <<< (not POSIX).""" + sh_path = PACKAGE_ROOT / "install.sh" + source = sh_path.read_text() + # <<< is bash-only; breaks dash + for i, line in enumerate(source.splitlines(), 1): + stripped = line.lstrip() + if stripped.startswith("#"): + continue + assert "<<<" not in line, f"install.sh:{i} uses non-POSIX <<< here-string" + + def test_rocm_detection_present(self): + """install.sh should have ROCm detection in get_torch_index_url.""" + sh_path = PACKAGE_ROOT / "install.sh" + source = sh_path.read_text() + assert "amd-smi" in source + assert "rocm" in source.lower() + + def test_cuda_precedence(self): + """ROCm detection should only run when nvidia-smi is absent.""" + sh_path = PACKAGE_ROOT / "install.sh" + source = sh_path.read_text() + # The ROCm block should be inside the "if [ -z "$_smi" ]" branch + smi_block_start = source.find('if [ -z "$_smi" ]') + rocm_block_start = source.find("amd-smi") + assert ( + smi_block_start < rocm_block_start + ), "ROCm detection should be inside the 'no nvidia-smi' branch" + + def test_bitsandbytes_amd_install(self): + """install.sh should install bitsandbytes for AMD when ROCm detected.""" + sh_path = PACKAGE_ROOT / "install.sh" + source = sh_path.read_text() + assert "bitsandbytes" in source + assert "rocm*)" in source # case pattern for ROCm URLs + + def test_cpu_hint_mentions_amd(self): + """CPU-only hint should mention AMD ROCm.""" + sh_path = PACKAGE_ROOT / "install.sh" + source = sh_path.read_text() + assert "ROCm" in source + + def test_rocm72_capped_to_71(self): + """ROCm 7.2+ should fall back to rocm7.1 index.""" + sh_path = PACKAGE_ROOT / "install.sh" + source = sh_path.read_text() + assert "rocm7.2" in source # case pattern + assert 'echo "$_base/rocm7.1"' in source # fallback + + def test_rocm_tag_validation_guard_exists(self): + """install.sh should validate _rocm_tag with a case guard.""" + sh_path = PACKAGE_ROOT / "install.sh" + source = sh_path.read_text() + assert "rocm[0-9]*.[0-9]*)" in source + assert '_rocm_tag=""' in source # rejection path + + def test_dpkg_epoch_handling(self): + """install.sh should strip Debian epoch prefix from dpkg-query output.""" + sh_path = PACKAGE_ROOT / "install.sh" + source = sh_path.read_text() + assert "sed 's/^[0-9]*://' " in source or "sed 's/^[0-9]*://'" in source + + def test_no_double_bracket_in_rocm_block(self): + """ROCm detection block should not use [[ ]] (bash-only, not POSIX). + Note: [[:space:]], [[:digit:]] etc. are valid POSIX character classes, not bash [[ ]].""" + sh_path = PACKAGE_ROOT / "install.sh" + source = sh_path.read_text() + func_start = source.find("get_torch_index_url()") + func_end = source.find("\n}", func_start) + func_body = source[func_start:func_end] + import re + + for i, line in enumerate(func_body.splitlines(), 1): + stripped = line.lstrip() + if stripped.startswith("#"): + continue + # Remove POSIX character classes [[:foo:]] before checking for [[ ]] + cleaned = re.sub(r"\[\[:[a-z]+:\]\]", "", line) + assert ( + "[[" not in cleaned + ), f"get_torch_index_url line {i} uses non-POSIX [[" + + def test_no_arithmetic_expansion_in_rocm_block(self): + """ROCm detection block should not use (( )) (bash-only).""" + sh_path = PACKAGE_ROOT / "install.sh" + source = sh_path.read_text() + func_start = source.find("get_torch_index_url()") + func_end = source.find("\n}", func_start) + func_body = source[func_start:func_end] + for i, line in enumerate(func_body.splitlines(), 1): + stripped = line.lstrip() + if stripped.startswith("#"): + continue + assert ( + "((" not in line or "))" not in line or "$(()" in line + ), f"get_torch_index_url line {i} may use non-POSIX (( ))" + + def test_macos_returns_cpu_before_rocm_check(self): + """macOS should return CPU immediately (before any ROCm check).""" + sh_path = PACKAGE_ROOT / "install.sh" + source = sh_path.read_text() + func_start = source.find("get_torch_index_url()") + func_body = source[func_start:] + darwin_pos = func_body.find("Darwin") + rocm_pos = func_body.find("amd-smi") + assert darwin_pos < rocm_pos, "macOS check should come before ROCm detection" + + +# ============================================================================= +# TEST: Live regression on current host (NVIDIA B200 expected) +# ============================================================================= + + +class TestLiveRegression: + """Live checks that run on the actual host -- skip if no NVIDIA GPU.""" + + def test_get_torch_index_url_returns_cuda_on_nvidia(self): + """On an NVIDIA machine, get_torch_index_url should return a CUDA URL.""" + import shutil + + if not shutil.which("nvidia-smi"): + pytest.skip("No nvidia-smi available") + sh_path = PACKAGE_ROOT / "install.sh" + # Extract just the function (don't source the whole installer) + result = subprocess.run( + [ + "bash", + "-c", + f"eval \"$(sed -n '/^get_torch_index_url()/,/^}}/p' '{sh_path}')\"; " + "get_torch_index_url", + ], + capture_output = True, + text = True, + timeout = 30, + ) + if result.returncode != 0: + pytest.skip("Could not extract get_torch_index_url for live test") + url = result.stdout.strip() + assert "cu1" in url or "cuda" in url.lower(), f"Expected CUDA URL, got: {url}" + + +if __name__ == "__main__": + pytest.main([__file__, "-v"])