ceos/unsloth
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: call response.aclose() before lines_gen.aclose() to prevent httpcore RuntimeError on Python 3.13

Browse source
This commit is contained in:
Roland Tannous 2026-03-30 18:50:24 +00:00
commit fc441a01df
1 changed files with 26 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

33
studio/backend/core/inference/external_provider.py
View file

@ -117,13 +117,22 @@ class ExternalProviderClient:
)
return
lines_iter = response.aiter_lines()
lines_gen = response.aiter_lines().__aiter__()
try:
async for line in lines_iter:
while True:
try:
line = await lines_gen.__anext__()
except StopAsyncIteration:
break
if line.strip():
yield line
except GeneratorExit:
await response.aclose() # set PoolByteStream._closed=True FIRST
await lines_gen.aclose() # now safe — aclose() is a no-op
raise
finally:
await lines_iter.aclose()
await response.aclose()
await lines_gen.aclose()
except httpx.ConnectError as exc:
logger.error("Connection error to %s: %s", self.provider_type, exc)
@ -242,9 +251,13 @@ class ExternalProviderClient:
yield _error_sse_line(response.status_code, error_text, self.provider_type)
return
lines_iter = response.aiter_lines()
lines_gen = response.aiter_lines().__aiter__()
try:
async for line in lines_iter:
while True:
try:
line = await lines_gen.__anext__()
except StopAsyncIteration:
break
if not line or line.startswith("event:"):
continue
if not line.startswith("data:"):
@ -291,9 +304,15 @@ class ExternalProviderClient:
elif event_type == "message_stop":
yield "data: [DONE]"
return
await response.aclose() # set PoolByteStream._closed=True FIRST
break
except GeneratorExit:
await response.aclose() # set PoolByteStream._closed=True FIRST
await lines_gen.aclose() # now safe — aclose() is a no-op
raise
finally:
await lines_iter.aclose()
await response.aclose()
await lines_gen.aclose()
except httpx.ConnectError as exc:
logger.error("Connection error to %s: %s", self.provider_type, exc)