ceos/unsloth
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Tighten the clean-machine CI comments

Browse source 
Comments only, no assertion logic, pins or leg definitions touched.

Reflowed every rationale block to denser wording and removed the
duplication that had built up across repeated steps: the desktop
workflow repeated the fork-PR skip, the desktop-v* tag resolution and
the restore-runner note once per platform, and the installer workflow
repeated its path-filter rationale in both the pull_request and push
blocks. Those now point at the first copy.

Every WHY is kept: why the masked legs avoid install.sh --local, what
UNSLOTH_CI_SOURCE_OVERLAY is for, why `absent` tests "must not work"
rather than command -v, why the .venv_t5_* sidecars are in the macho
scan scope, why the signature check is main-executables-only, why each
nobuild allowlist entry is a pure-Python sdist, why the WSL job gates
and what the pipe truncation was, and why the virgin container's
overlay=false row is still pinned.

Proved comments-only three ways: both workflow revisions parsed with
yaml.safe_load_all and every leaf walked (only `run:` scalars differ);
every changed bash body and .sh compared byte-for-byte after
`bash --pretty-print -n`; every changed pwsh body and .ps1 compared as
a token stream with Comment and NewLine tokens dropped. A negative
control injecting one non-comment line into each layer makes all of
them fail.
This commit is contained in:
danielhanchen 2026-07-29 06:33:16 +00:00
commit f09a1e71a9
11 changed files with 620 additions and 680 deletions
Download patch file Download diff file Expand all files Collapse all files

16
studio/install_python_stack.py
View file

@ -2790,8 +2790,7 @@ def pip_install_try(
env = _install_env_for_cmd(cmd),
)
if result.returncode == 0:
# Same reasoning as pip_install below: `nobuild` can only catch a source
# build that reaches the log.
# As pip_install below: `nobuild` only catches a build that reaches the log.
if VERBOSE and result.stdout:
print(_redact_install_output(result.stdout))
return True
@ -2849,14 +2848,13 @@ def pip_install(
**_windows_hidden_subprocess_kwargs(),
)
if result.returncode == 0:
# Echo successful output under UNSLOTH_VERBOSE, as install.sh's
# Echo success under UNSLOTH_VERBOSE, as install.sh's
# run_install_cmd does. Without it the dependency phase never
# reached the install log, and clean-machine-assert.sh's `nobuild`
# greps that log for uv's "Building <pkg>==<ver>" -- so a source
# build in this step, the one installing studio.txt where an
# sdist-only dependency actually shows up, reported "built: none"
# and the leg stayed green. Redacted: uv echoes index URLs with
# credentials.
# reached the install log that clean-machine-assert.sh's `nobuild`
# greps for uv's "Building <pkg>==<ver>", so a source build in this
# step -- the studio.txt install, where sdist-only dependencies
# actually show up -- reported "built: none" and stayed green.
# Redacted: uv echoes index URLs with credentials.
if VERBOSE and result.stdout:
print(_redact_install_output(result.stdout))
return