Fix Windows no-torch setup (#7511)
* Fix Windows no-torch setup * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Fix no-torch env normalization on Windows * Accept on for Windows no-torch mode * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Keep no-torch mode across studio update on Windows Guarding the direct torch/Triton install made `install.ps1 --no-torch` actually produce a torch-free venv, which then broke the next `unsloth studio update`. That path exports no UNSLOTH_NO_TORCH, so $NoTorchMode was false, the stale-venv check read the missing torch as a broken venv, and setup tried to delete the venv it was running out of: [ERROR] Could not remove stale venv: Access to the path 'python.exe' is denied. That teardown can never succeed there, because setup.ps1 runs via unsloth.exe out of that same venv. The same gap also let the shared dependency pass reinstall torch from PyPI, unpinned, into a GGUF-only environment. install_python_stack.py now records the mode in the install manifest and setup.ps1 reads it back when no env var is exported, then re-exports a canonical value for the dependency pass (setup.ps1 drops the manifest before invoking it, so the child cannot repeat the lookup). The key is additive and MANIFEST_SCHEMA is unchanged, so existing manifests stay valid and a missing key keeps today's behaviour. Also: - read_manifest() caught only OSError, but UnicodeDecodeError is a ValueError. That is now on the installer's import path, so a manifest re-saved as ANSI or truncated mid-write would abort every install. - The env predicate now trims surrounding whitespace, matching the Python side. - The Windows update smoke workflow asserts the update leaves the venv GGUF-only, which is what would have caught this. Known follow-up, pre-existing: an install killed between the manifest drop and the dependency pass leaves no recorded mode, so a later update still walks the stale-venv path. Closing that needs a marker the installer never drops. * Persist no-torch mode in a marker the dependency pass cannot drop The install manifest alone was not enough. Both setup.ps1 and install_python_stack.py remove it before every dependency pass, and it is only rewritten on success, so a no-torch install interrupted in between left nothing recording the mode. The next update then resolved no-torch as false, read the expected missing torch as a stale venv, and tried to delete the environment whose python.exe was running it, which leaves the install unrepairable from the CLI. Add .unsloth-no-torch next to the existing .unsloth-studio-owned marker, written before the pass and cleared when torch is wanted. setup.ps1 writes it as soon as the mode resolves, so the window between the manifest drop and its own torch install is covered too. Read order stays manifest key first, then marker, so migrating out of no-torch is never blocked by a marker an earlier run left behind. Neither present still reads as "install torch", so nothing changes for installs made before either existed. Also adds the AGPL-3.0 header the new test file was missing. --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: danielhanchen <unslothai@gmail.com>
This commit is contained in:
parent
6818318867
commit
d7594ec10f
9 changed files with 540 additions and 9 deletions
|
|
@ -198,6 +198,31 @@ jobs:
|
|||
fi
|
||||
echo "update path took the prebuilt fast path"
|
||||
|
||||
- name: Update must keep the --no-torch install GGUF-only
|
||||
run: |
|
||||
# `unsloth studio update` exports no UNSLOTH_NO_TORCH, so setup.ps1 has
|
||||
# to recover the mode from the install manifest. Without that it reads
|
||||
# the missing torch as a stale venv and tries to delete the venv it is
|
||||
# running out of, and the shared dependency pass pulls torch back in.
|
||||
# The skip line only prints when the dependency pass actually runs, so
|
||||
# don't demand it if the fast path short-circuited that pass.
|
||||
if grep -q "running ordered dependency installation" logs/update.log \
|
||||
&& ! grep -q "skipping direct PyTorch and Triton installation (no-torch mode)" logs/update.log; then
|
||||
echo "::error::studio update left no-torch mode; it would reinstall PyTorch."
|
||||
grep -iE "no-torch|stale venv|PyTorch" logs/update.log | tail -40
|
||||
exit 1
|
||||
fi
|
||||
PY="$HOME/.unsloth/studio/unsloth_studio/Scripts/python.exe"
|
||||
if [ ! -f "$PY" ]; then
|
||||
echo "::error::studio venv interpreter missing at $PY"
|
||||
exit 1
|
||||
fi
|
||||
if "$PY" -c "import torch" 2>/dev/null; then
|
||||
echo "::error::torch was reinstalled into the --no-torch venv."
|
||||
exit 1
|
||||
fi
|
||||
echo "update preserved no-torch mode"
|
||||
|
||||
- name: Second update must also be a no-op
|
||||
env:
|
||||
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue