ceos/unsloth
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #180 from unslothai/fix/dropdown-menu-prefill

Browse source 
Fix: model and dataset dropdowns selecting stale value on Enter
This commit is contained in:
Roland Tannous 2026-02-20 22:01:35 +04:00 • committed by GitHub
commit bf34ede725
2 changed files with 31 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

22
studio/frontend/src/features/studio/sections/dataset-section.tsx
View file

@ -114,7 +114,7 @@ export function DatasetSection() {
const resultIds = useMemo(() => {
const ids = hfResults.map((r) => r.id);
if (dataset && !ids.includes(dataset)) {
ids.unshift(dataset);
ids.push(dataset);
}
return ids;
}, [hfResults, dataset]);
@ -164,7 +164,20 @@ export function DatasetSection() {
</TooltipContent>
</Tooltip>
</span>
<div ref={comboboxAnchorRef}>
<div
ref={comboboxAnchorRef}
onKeyDown={(event) => {
if (event.key !== "Enter") return;
if (!(event.target instanceof HTMLInputElement)) return;
event.preventDefault();
if (hfResults.length > 0) {
handleDatasetSelect(hfResults[0].id);
} else {
const text = event.target.value.trim();
if (text) handleDatasetSelect(text);
}
}}
>
<Combobox
items={resultIds}
filteredItems={resultIds}
@ -175,10 +188,7 @@ export function DatasetSection() {
itemToStringValue={(id) => id}
autoHighlight={true}
>
<ComboboxInput
placeholder="Search datasets..."
className="w-full"
>
<ComboboxInput placeholder="Search datasets..." className="w-full">
<InputGroupAddon>
<HugeiconsIcon icon={Search01Icon} className="size-4" />
</InputGroupAddon>

17
studio/frontend/src/features/studio/sections/model-section.tsx
View file

@ -165,7 +165,7 @@ export function ModelSection() {
const resultIds = useMemo(() => {
const ids = hfResults.map((r) => r.id);
if (selectedModel && !ids.includes(selectedModel)) {
ids.unshift(selectedModel);
ids.push(selectedModel);
}
return ids;
}, [hfResults, selectedModel]);
@ -380,7 +380,20 @@ export function ModelSection() {
</TooltipContent>
</Tooltip>
</span>
<div ref={comboboxAnchorRef}>
<div
ref={comboboxAnchorRef}
onKeyDown={(event) => {
if (event.key !== "Enter") return;
if (!(event.target instanceof HTMLInputElement)) return;
event.preventDefault();
if (hfResults.length > 0) {
handleModelSelect(hfResults[0].id);
} else {
const text = event.target.value.trim();
if (text) handleModelSelect(text);
}
}}
>
<Combobox
items={resultIds}
filteredItems={resultIds}