diff --git a/.github/workflows/notebooks-ci.yml b/.github/workflows/notebooks-ci.yml index bc8226121d..3ac6fe185d 100644 --- a/.github/workflows/notebooks-ci.yml +++ b/.github/workflows/notebooks-ci.yml @@ -103,11 +103,21 @@ jobs: - name: Drift check (re-run update_all_notebooks.py + git diff) working-directory: ${{ github.workspace }} + # Reported as non-blocking until the upstream `unslothai/notebooks` + # tree is regenerated. The first run on @main surfaces ~463 files + # of drift (7359 / 9634 line delta), which is a real backlog the + # notebooks-side maintainers need to clear in their own repo -- + # this PR's role is to surface the count, not auto-fix it. + continue-on-error: true run: | python unsloth/scripts/notebook_validator.py drift \ --notebooks-dir notebooks - name: Convert sanity (every nb / kaggle / original_template -> .py) + # Same rationale as Drift: a handful of upstream notebooks fail + # the converter (custom magics, malformed JSON, etc). Surface + # the count without blocking; the team triages in unslothai/notebooks. + continue-on-error: true run: | python unsloth/scripts/notebook_validator.py convert \ --notebooks-dir notebooks \ @@ -180,7 +190,7 @@ jobs: - uses: actions/setup-python@a26af69be951a213d495a4c3e4e4022e16d87065 # v5.6.0 with: { python-version: '3.12', cache: 'pip' } - - name: Install CPU torch + pinned unsloth + trl + - name: Install CPU torch + pinned unsloth + trl + converter deps run: | python -m pip install --upgrade pip pip install --index-url https://download.pytorch.org/whl/cpu 'torch>=2.8,<2.11' @@ -190,9 +200,13 @@ jobs: pip install 'transformers>=4.56,<5.6' 'trl>=0.22,<0.26' 'accelerate>=1.0' \ 'datasets>=3.4,<5' 'peft>=0.15,<0.20' \ 'bitsandbytes>=0.43' 'sentencepiece' 'protobuf' + # Converter deps (nbformat for notebook_to_python.py). + pip install 'nbformat>=5.10' 'nbconvert>=7.16' pip install --no-deps unsloth_zoo unsloth - name: Convert notebooks for AST scan + # Same upstream-conversion-error tolerance as the static job. + continue-on-error: true run: | python unsloth/scripts/notebook_validator.py convert \ --notebooks-dir notebooks --out _converted