ceos/unsloth
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

test: keep the fake-gefen constructor tests torch-free

Browse source 
The NVIDIA-CUDA gate imports torch, so the fake-gefen constructor-mapping tests
(loaded via file path to stay dependency-free) hit `import torch` before the
fake gefen module is used and failed with ModuleNotFoundError in a torch-less
environment. Stub `gefenx._require_nvidia_cuda` in the fake_gefen fixture, and
move gate coverage to test_gate_rejects_rocm_hip_build which exercises the real
gate directly (no fake_gefen). 35 tests pass; the 14 fake-gefen tests pass with
torch import blocked.
This commit is contained in:
thad0ctor 2026-07-10 09:22:04 -07:00
commit 9e1a0d8242
1 changed files with 10 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

13
tests/python/test_gefenx_optimizer.py
View file

@ -111,6 +111,10 @@ def fake_gefen(monkeypatch):
module.Gefen = _FakeGefen
module.GefenMuonHybrid = _FakeHybrid
monkeypatch.setitem(sys.modules, "gefen", module)
# The CUDA gate imports torch; these constructor-mapping tests are torch-free
# by design, so stub it out here. The real gate is exercised by the dedicated
# test_gate_* tests (which do require torch).
monkeypatch.setattr(gefenx, "_require_nvidia_cuda", lambda: None)
return captured
@ -403,10 +407,15 @@ def test_build_gefenx_muon_passes_lr_weight_decay_and_backup_substrings(fake_gef
# --------------------------------------------------------------------------- #
# Device gate: NVIDIA CUDA only (AMD/ROCm and Intel XPU rejected)
# --------------------------------------------------------------------------- #
def test_gate_rejects_rocm_hip_build(fake_gefen, monkeypatch):
def test_gate_rejects_rocm_hip_build(monkeypatch):
# No fake_gefen here: this must exercise the REAL gate. gefen is never stubbed,
# so a RuntimeError (not ModuleNotFoundError) proves the gate fires before any
# `from gefen import ...`.
torch = pytest.importorskip("torch")
# Simulate an AMD/ROCm PyTorch build by tagging torch.version.hip.
monkeypatch.setattr(torch.version, "hip", "6.0.0", raising = False)
with pytest.raises(RuntimeError, match = "ROCm|HIP|CUDA"):
gefenx._require_nvidia_cuda()
model = _FakeModel([("w", _FakeParam())])
with pytest.raises(RuntimeError, match = "ROCm|HIP|CUDA"):
gefenx.build_gefenx_optimizer(
@ -426,8 +435,6 @@ def test_gate_rejects_rocm_hip_build(fake_gefen, monkeypatch):
betas = (0.9, 0.999),
eps = 1e-8,
)
# The gate fires before gefen is even imported/constructed.
assert "gefen" not in fake_gefen and "muon" not in fake_gefen
def test_gate_allows_non_hip(monkeypatch):