ceos/unsloth
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Studio: fix artifact panel for local threads and surface tool errors

Browse source
This commit is contained in:
wasimysaid 2026-05-25 23:47:04 +02:00
commit 9b4d6256d3
2 changed files with 25 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

23
studio/frontend/src/components/assistant-ui/tool-ui-render-html.tsx
View file

@ -21,6 +21,7 @@ type RenderHtmlArgs = Record<string, unknown> & {
const RenderHtmlToolUIImpl: ToolCallMessagePartComponent = ({
args,
result,
status,
toolCallId,
}) => {
@ -46,6 +47,16 @@ const RenderHtmlToolUIImpl: ToolCallMessagePartComponent = ({
);
}
// Surface the backend error when the tool call completed with invalid
// args. Backend success results start with "Rendered HTML artifact";
// error results start with "Error:".
const errorText =
status?.type === "complete" &&
typeof result === "string" &&
result.startsWith("Error:")
? result
: null;
return (
<div className="relative my-2 flex min-h-[52px] w-full max-w-md items-center overflow-hidden rounded-lg border border-border/70 bg-muted/15 px-3 py-2 text-left dark:bg-muted/10">
<div className="relative z-10 flex min-w-0 flex-1 items-center gap-2.5">
@ -56,15 +67,17 @@ const RenderHtmlToolUIImpl: ToolCallMessagePartComponent = ({
/>
<span className="grid min-w-0 flex-1 gap-1">
<span className="truncate text-sm font-medium leading-tight text-foreground">
Generating artifact
{errorText ? "Artifact error" : "Generating artifact"}
</span>
<span className="truncate text-[11px] leading-none text-muted-foreground">
HTML artifact
{errorText ?? "HTML artifact"}
</span>
</span>
<span className="shimmer shrink-0 rounded-full bg-primary/10 px-2 py-0.5 text-[10px] font-medium text-primary motion-reduce:animate-none">
Generating
</span>
{errorText ? null : (
<span className="shimmer shrink-0 rounded-full bg-primary/10 px-2 py-0.5 text-[10px] font-medium text-primary motion-reduce:animate-none">
Generating
</span>
)}
</div>
</div>
);

10
studio/frontend/src/features/chat/chat-page.tsx
View file

@ -970,8 +970,12 @@ export function ChatPage(): ReactElement {
useEffect(() => {
if (view.mode !== "single") return;
if (view.threadId || view.newThreadNonce || !selectedArtifact) return;
// view intentionally excludes __LOCALID_ threads (they fall through to
// { mode: "single" } with no threadId/nonce). Don't close an artifact
// whose thread is the currently active local thread.
if (selectedArtifact.threadId && selectedArtifact.threadId === activeThreadId) return;
closeArtifactSurface();
}, [closeArtifactSurface, selectedArtifact, view]);
}, [activeThreadId, closeArtifactSurface, selectedArtifact, view]);
const hasActiveModel = Boolean(inferenceParams.checkpoint);
const loadNativeModelIntent = useCallback(
@ -1645,8 +1649,8 @@ export function ChatPage(): ReactElement {
{view.mode === "single" ? (
<SingleContent
key={view.threadId ?? "single"}
threadId={view.threadId}
key={view.threadId ?? activeThreadId ?? "single"}
threadId={view.threadId ?? activeThreadId ?? undefined}
newThreadNonce={view.newThreadNonce}
artifact={selectedArtifact}
artifactSurface={artifactSurface}