From 917245e34a1ce6b2dae5dd108dda1c728f01068a Mon Sep 17 00:00:00 2001 From: Unsloth Date: Sat, 25 Jul 2026 05:00:49 -0700 Subject: [PATCH] Images and Video: tighten code comments --- .../src/features/images/images-page.tsx | 25 +++++++------------ .../images/train/diffusion-train-panel.tsx | 14 +++++------ .../images/train/example-dataset-cards.tsx | 6 ++--- .../src/features/video/video-page.tsx | 7 +++--- 4 files changed, 20 insertions(+), 32 deletions(-) diff --git a/studio/frontend/src/features/images/images-page.tsx b/studio/frontend/src/features/images/images-page.tsx index 2d3846dc44..748296040e 100644 --- a/studio/frontend/src/features/images/images-page.tsx +++ b/studio/frontend/src/features/images/images-page.tsx @@ -23,8 +23,7 @@ import { ZoomInAreaIcon, } from "@hugeicons/core-free-icons"; import { HugeiconsIcon } from "@hugeicons/react"; -// The raw Radix trigger: the app's TooltipTrigger adds a click-to-toggle handler that -// has no business inside a menu row. +// Raw Radix trigger: the app's adds a click-to-toggle, wrong inside a menu row. import { Tooltip as TooltipPrimitive } from "radix-ui"; import { TestTubeOutlineIcon } from "@/lib/hugeicons-derived"; @@ -2339,18 +2338,15 @@ export function ImagesPage({ active = true }: { active?: boolean }) { onDeploy={handleDeployAdapter} /> ) : ( - /* ── Controls rail + preview canvas. No card: both sit on the page background - like the Hub, divided by a rule, so nothing is spent on box chrome. Same - centered measure as the Hub (mx-auto, max-w-1100, px-5 / sm:px-8). No bottom - padding, so the rule runs the full page height; the panes pad their own - content instead. ── */ + /* ── Controls rail + preview canvas. No cards: both sit on the page background, + split by a rule, on the Hub's centered measure. No bottom padding, so the rule + runs the full page height; each pane pads its own content. ── */
{/* pl-0.5 keeps focus rings off the scroll container's edge. */}
- {/* Workflow picker. Seven workflows don't fit a segmented strip in this rail, - so it's a dropdown; a row stays disabled until the loaded model supports - it (status.workflows). New workflows slot in without shrinking anything. */} + {/* Seven workflows don't fit a segmented strip in this rail, so: a dropdown. + A row stays disabled until the loaded model supports it (status.workflows). */}
@@ -2376,10 +2372,8 @@ export function ImagesPage({ active = true }: { active?: boolean }) { {WORKFLOW_TABS.map((t) => { const enabled = workflowEnabled(t); return ( - // Rows stay one line; what the workflow does (or why it is - // unavailable) arrives as a tooltip after a short hover. The - // trigger wraps the row rather than being the row: a disabled item - // has pointer-events: none, so it would never hover. + // Rows stay one line; the description arrives on hover. The trigger + // wraps the row: a disabled item has pointer-events: none.
@@ -2851,8 +2845,7 @@ export function ImagesPage({ active = true }: { active?: boolean }) { aria-label="Flip width and height" onClick={flipDimensions} > - {/* The arrows turn with the orientation, so the button shows - which way the flip goes. */} + {/* Arrows turn with the orientation, showing which way it flips. */} - {/* Left: configure. No card here or on the right: both panes sit on the page - background like the Hub, divided by a rule that runs the full page height. */} + {/* Left: configure. No cards: both panes sit on the page background, split by a + rule that runs the full page height. */}
{/* pl-0.5 keeps focus rings off the scroll container's edge. */}
@@ -1107,8 +1107,7 @@ export function DiffusionTrainPanel({ - {/* Rows stay short: name plus image count. Caption counts show under the - picker, and an example's license shows on its card below. */} + {/* Name plus image count only; captions and license show elsewhere. */} {(info?.datasets ?? []).map((d) => ( {d.name} - {d.image_count} image{d.image_count === 1 ? "" : "s"} @@ -1168,8 +1167,7 @@ export function DiffusionTrainPanel({ > Choose images - {/* Nothing to upload until files are picked, so the count and Upload - only appear then. */} + {/* Count and Upload appear only once files are picked. */} {pickedFileCount > 0 && ( <> diff --git a/studio/frontend/src/features/images/train/example-dataset-cards.tsx b/studio/frontend/src/features/images/train/example-dataset-cards.tsx index d68671436b..f3680f79ae 100644 --- a/studio/frontend/src/features/images/train/example-dataset-cards.tsx +++ b/studio/frontend/src/features/images/train/example-dataset-cards.tsx @@ -55,8 +55,7 @@ async function fetchPreviews(repo: string): Promise { return p; } -// "Dog (DreamBooth subject)" -> "Dog". The parenthetical is context, not a name, so -// one-line picker rows and card titles drop it. +// "Dog (DreamBooth subject)" -> "Dog": one-line rows drop the parenthetical. export function shortExampleLabel(label: string): string { return label.replace(/\s*\(.*$/, ""); } @@ -135,8 +134,7 @@ export function ExampleDatasetCards({

{ex.description}

- {/* Import is the card's action, so it sits at the bottom right, on the - thumbnail row, instead of floating beside the text. */} + {/* The card's action, so: bottom right, on the thumbnail row. */}
- {/* ── Controls rail + preview canvas, matching the Images tabs: no cards, the Hub's - centered measure, and a rule that runs the full page height. ── */} + {/* ── Controls rail + preview canvas, as on the Images tabs: no cards, the Hub's + centered measure, a rule that runs the full page height. ── */}
{/* pl-0.5 keeps focus rings off the scroll container's edge. */}