ceos/unsloth
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Reduce comments across recent fixes (#6776)

Browse source 
Condense the verbose comments and docstrings added by the recent
chat template, GPT-OSS detection, PEFT tensor-parallel, and Studio
inference proxy fixes. Comments and whitespace only; no code changes.
This commit is contained in:
Daniel Han 2026-06-30 23:13:36 -07:00 • committed by GitHub
commit 8cc05ac89c
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
5 changed files with 20 additions and 35 deletions
Download patch file Download diff file Expand all files Collapse all files

19
tests/python/test_change_system_message.py
View file

@ -7,9 +7,7 @@ import pytest
def _load_change_system_message():
# Extract just _change_system_message from chat_templates.py so the test runs
# without importing unsloth (which needs unsloth_zoo / a GPU). Same pattern as
# tests/saving/test_is_gpt_oss_detection.py.
# Extract _change_system_message without importing unsloth (needs unsloth_zoo / a GPU).
source = Path(__file__).parents[2] / "unsloth" / "chat_templates.py"
tree = ast.parse(source.read_text(encoding = "utf-8"))
funcs = [
@ -28,12 +26,11 @@ def _load_change_system_message():
return namespace["_change_system_message"]
CUSTOM = "mycustom" # not in DEFAULT_SYSTEM_MESSAGE -> no predefined default
CUSTOM = "mycustom" # no predefined default
def test_custom_template_fills_placeholder():
# A custom template with a {system_message} placeholder must be filled, not
# left with the literal placeholder.
# A {system_message} placeholder must be filled, not left literal.
fn = _load_change_system_message()
template, used = fn("System: {system_message}\nUser:", CUSTOM, "You are a pirate")
assert template == "System: You are a pirate\nUser:"
@ -42,9 +39,8 @@ def test_custom_template_fills_placeholder():
def test_custom_template_preserves_backslashes():
# Why str.replace and not re.sub: a system message with backslashes (Windows
# paths, LaTeX, group-like text) must be inserted verbatim. re.sub treats the
# replacement specially -- r"C:\Users" raises bad-escape, r"\1" is a group ref.
# str.replace not re.sub: re.sub treats backslashes specially (r"C:\Users"
# bad-escape, r"\1" group ref), so messages must be inserted verbatim.
fn = _load_change_system_message()
for msg in (r"C:\Users\me", r"\frac{a}{b}", r"see \1 here"):
template, used = fn("System: {system_message}", CUSTOM, msg)
@ -53,8 +49,7 @@ def test_custom_template_preserves_backslashes():
def test_custom_template_requires_system_message():
# A custom template with a placeholder but no system message must raise,
# rather than silently leaving the placeholder in.
# A placeholder with no system message must raise, not stay literal.
fn = _load_change_system_message()
with pytest.raises(ValueError):
fn("System: {system_message}", CUSTOM, None)
@ -67,7 +62,7 @@ def test_custom_template_without_placeholder_unchanged():
def test_predefined_template_uses_default_then_override():
# Predefined templates with a default are unaffected by the change.
# Predefined templates with a default are unaffected.
fn = _load_change_system_message()
t1, u1 = fn("System: {system_message}", "unsloth", None)
assert t1 == "System: You are a helpful assistant to the user"