From 81534ddd696fa77821d4af57c8a4ccfd171df452 Mon Sep 17 00:00:00 2001 From: Daniel Han Date: Fri, 8 May 2026 11:25:27 +0000 Subject: [PATCH] ci(consolidated): prune electra from KNOWN_BROKEN_COMPILE post-zoo#632 After unsloth-zoo#632 (compiler unblock for transformers 4.57.6 + 5.x) merged on main, re-ran the full transformers.models.* compile sweep: transformers 4.57.6 -> 359/383 ok, 0 compile failures, 0 verify failures transformers 5.8.0 -> 413/438 ok, 27 compile failures, 0 verify failures Every entry in KNOWN_BROKEN_COMPILE except `electra` still fails on tf 5.x. Drop `electra` so the safety net catches a future regression on it, and update the leading comment to reflect that the list now tracks the tf-5.x residue (not the tf-4.57.6 set, which is empty). --- .github/workflows/consolidated-tests-ci.yml | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/.github/workflows/consolidated-tests-ci.yml b/.github/workflows/consolidated-tests-ci.yml index 35cc57bff9..9f4f09a0c3 100644 --- a/.github/workflows/consolidated-tests-ci.yml +++ b/.github/workflows/consolidated-tests-ci.yml @@ -852,10 +852,12 @@ jobs: # ---------- Full transformers.models.* compile sweep ---------- - # Track the 21 model_types that currently break the compiler on - # transformers 4.57.6 (verified locally). New breakage on any - # OTHER model_type fails the cell. Each entry is a tracking item - # for a follow-up unsloth-zoo PR. + # Track the model_types that currently break the compiler on + # transformers >=5,<6. After unsloth-zoo#632 landed, transformers + # 4.57.6 has zero failures across all model_types; the 27 entries + # below are the residual failures on the tf 5.x line. New breakage + # on any OTHER model_type fails the cell. Each entry is a + # tracking item for a follow-up unsloth-zoo PR. KNOWN_BROKEN_COMPILE = { # Category A: `string index out of range` in source rewriter. "colpali": "string index out of range", @@ -868,7 +870,6 @@ jobs: "timm_backbone": "string index out of range", # Category B: rewriter emits invalid Python source. "clvp": "emitted file: unexpected indent", - "electra": "emitted file: expected ':'", "falcon_mamba": "emitted file: unexpected indent", "gpt2": "emitted file: unexpected indent", "imagegpt": "emitted file: unexpected indent",