ceos/unsloth
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Skip the desktop jobs on fork PRs instead of failing them

Browse source 
Every desktop-v* release in this repo is a draft, and GitHub lists drafts only
to a token with push access, which is why resolving one needs contents: write.
A pull request from a fork receives a read-only token no matter what the
workflow declares, so on those runs the resolver cannot see any release and the
job died on "no desktop-v* release visible", accusing the repo of having no
bundle when the real cause is the trigger.

This workflow runs on pull_request for changes to itself and the stripping
scripts, so an outside contributor editing either would have hit that. Guard the
three jobs on the head repo not being a fork. A skipped job is honest here: it
does not claim to have tested a bundle it was never able to download, and it is
not reported as a pass.
This commit is contained in:
Daniel Han 2026-07-29 01:11:10 +00:00
commit 7d4311fe58
1 changed files with 12 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

12
.github/workflows/desktop-app-clean-machine-ci.yml vendored
View file

@ -74,6 +74,10 @@ env:
jobs:
# ── macOS: .dmg, Apple Silicon ────────────────────────────────────────────
macos:
# A fork PR's token is read-only however this workflow declares permissions, so it
# cannot list the draft releases every desktop-v* bundle is published as. Skip
# rather than fail: it is a property of the trigger, not a broken release.
if: github.event.pull_request.head.repo.fork != true
name: desktop macOS ${{ matrix.os }}
runs-on: ${{ matrix.os }}
timeout-minutes: 45
@ -258,6 +262,10 @@ jobs:
# ── Linux: .deb and .AppImage, with a real webview under Xvfb ────────────
linux:
# A fork PR's token is read-only however this workflow declares permissions, so it
# cannot list the draft releases every desktop-v* bundle is published as. Skip
# rather than fail: it is a property of the trigger, not a broken release.
if: github.event.pull_request.head.repo.fork != true
name: desktop linux ${{ matrix.kind }}
runs-on: ubuntu-22.04
timeout-minutes: 45
@ -426,6 +434,10 @@ jobs:
# ── Windows: NSIS setup.exe, silent install ──────────────────────────────
windows:
# A fork PR's token is read-only however this workflow declares permissions, so it
# cannot list the draft releases every desktop-v* bundle is published as. Skip
# rather than fail: it is a property of the trigger, not a broken release.
if: github.event.pull_request.head.repo.fork != true
name: desktop windows
runs-on: windows-latest
# 60, not 45: this job runs the bundled installer, and a full torch install on a