ceos/unsloth
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: reject negative manual dataset slices

Browse source 
Prevent negative Train Split Start/End values in the dataset advanced UI and sanitize payload mapping so negative slice values are never sent to the backend.

Made-with: Cursor
This commit is contained in:
imagineer99 2026-03-10 20:13:34 +00:00
commit 5dcbf86d09
2 changed files with 16 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

17
studio/frontend/src/features/studio/sections/dataset-section.tsx
View file

@ -89,6 +89,13 @@ function formatUpdatedDate(timestamp: number | null): string {
return new Date(timestamp * 1000).toLocaleDateString();
}
function normalizeSliceInput(value: string): string | null {
const trimmed = value.trim();
if (!trimmed) return null;
if (!/^\d+$/.test(trimmed)) return null;
return trimmed;
}
export function DatasetSection() {
const {
dataset,
@ -783,11 +790,14 @@ export function DatasetSection() {
</Tooltip>
</span>
<Input
type="number"
inputMode="numeric"
min={0}
step={1}
placeholder="0"
value={datasetSliceStart ?? ""}
onChange={(e) =>
setDatasetSliceStart(e.target.value || null)
setDatasetSliceStart(normalizeSliceInput(e.target.value))
}
/>
</div>
@ -815,11 +825,14 @@ export function DatasetSection() {
</Tooltip>
</span>
<Input
type="number"
inputMode="numeric"
min={0}
step={1}
placeholder="End"
value={datasetSliceEnd ?? ""}
onChange={(e) =>
setDatasetSliceEnd(e.target.value || null)
setDatasetSliceEnd(normalizeSliceInput(e.target.value))
}
/>
</div>

2
studio/frontend/src/features/training/api/mappers.ts
View file

@ -12,7 +12,7 @@ function parseSliceValue(value: string | null): number | null {
const trimmed = value.trim();
if (!trimmed) return null;
const num = Number(trimmed);
if (!Number.isFinite(num) || !Number.isInteger(num)) return null;
if (!Number.isFinite(num) || !Number.isInteger(num) || num < 0) return null;
return num;
}