diff --git a/unsloth/save.py b/unsloth/save.py index 1759d86fb1..178178980d 100644 --- a/unsloth/save.py +++ b/unsloth/save.py @@ -2777,19 +2777,79 @@ def unsloth_generic_save( elif save_method == "merged_4bit_forced": save_method = "merged_4bit" - merge_and_overwrite_lora( - get_model_name, - model = model, - tokenizer = tokenizer, - save_directory = save_directory, - push_to_hub = push_to_hub, - private = private, - token = token, - save_method = save_method, - output_dtype = None, - low_disk_space_usage = True, - use_temp_file = False, - ) + # Full-finetuned models (no LoRA) cannot use merge_and_overwrite_lora + # since there are no adapters to merge. Fall back to save_pretrained. + # This mirrors the non-PeftModel handling in save_pretrained_torchao + # and the GGUF save path. + _is_peft = isinstance(model, PeftModel) + if not _is_peft: + if not is_main_process: + return + + # Honor merged_16bit by casting to the target dtype if needed + _save_kwargs = dict( + safe_serialization = safe_serialization, + max_shard_size = max_shard_size, + variant = variant, + ) + if "16bit" in save_method: + _target_dtype = ( + torch.bfloat16 if torch.cuda.is_bf16_supported() else torch.float16 + ) + _save_kwargs["state_dict"] = { + k: v.to(dtype = _target_dtype) if v.is_floating_point() else v + for k, v in model.state_dict().items() + } + + if push_to_hub: + print(f"Unsloth: Pushing full fine-tuned model to '{save_directory}' ...") + model.push_to_hub( + repo_id = save_directory, + token = token, + private = private, + commit_message = commit_message, + create_pr = create_pr, + revision = revision, + commit_description = commit_description, + tags = tags, + **_save_kwargs, + ) + if tokenizer is not None: + old_padding_side = tokenizer.padding_side + tokenizer.padding_side = "left" + tokenizer.push_to_hub( + save_directory, + token = token, + private = private, + commit_message = commit_message, + create_pr = create_pr, + revision = revision, + ) + tokenizer.padding_side = old_padding_side + else: + print(f"Unsloth: Saving full fine-tuned model to '{save_directory}' ...") + model.save_pretrained(save_directory, **_save_kwargs) + if tokenizer is not None: + old_padding_side = tokenizer.padding_side + tokenizer.padding_side = "left" + tokenizer.save_pretrained(save_directory) + tokenizer.padding_side = old_padding_side + + print(f"Unsloth: Model saved successfully to '{save_directory}'") + else: + merge_and_overwrite_lora( + get_model_name, + model = model, + tokenizer = tokenizer, + save_directory = save_directory, + push_to_hub = push_to_hub, + private = private, + token = token, + save_method = save_method, + output_dtype = None, + low_disk_space_usage = True, + use_temp_file = False, + ) if push_to_hub and datasets: try: