ceos/unsloth
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix: model and dataset dropdowns selecting stale value on Enter

Browse source
This commit is contained in:
imagineer99 2026-02-20 11:33:20 +00:00
commit 48ddbd96f9
2 changed files with 31 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

22
studio/frontend/src/features/studio/sections/dataset-section.tsx
View file

@ -109,7 +109,7 @@ export function DatasetSection() {
const resultIds = useMemo(() => {
const ids = hfResults.map((r) => r.id);
if (dataset && !ids.includes(dataset)) {
ids.unshift(dataset);
ids.push(dataset);
}
return ids;
}, [hfResults, dataset]);
@ -159,7 +159,20 @@ export function DatasetSection() {
</TooltipContent>
</Tooltip>
</span>
<div ref={comboboxAnchorRef}>
<div
ref={comboboxAnchorRef}
onKeyDown={(event) => {
if (event.key !== "Enter") return;
if (!(event.target instanceof HTMLInputElement)) return;
event.preventDefault();
if (hfResults.length > 0) {
handleDatasetSelect(hfResults[0].id);
} else {
const text = event.target.value.trim();
if (text) handleDatasetSelect(text);
}
}}
>
<Combobox
items={resultIds}
filteredItems={resultIds}
@ -170,10 +183,7 @@ export function DatasetSection() {
itemToStringValue={(id) => id}
autoHighlight={true}
>
<ComboboxInput
placeholder="Search datasets..."
className="w-full"
>
<ComboboxInput placeholder="Search datasets..." className="w-full">
<InputGroupAddon>
<HugeiconsIcon icon={Search01Icon} className="size-4" />
</InputGroupAddon>

17
studio/frontend/src/features/studio/sections/model-section.tsx
View file

@ -160,7 +160,7 @@ export function ModelSection() {
const resultIds = useMemo(() => {
const ids = hfResults.map((r) => r.id);
if (selectedModel && !ids.includes(selectedModel)) {
ids.unshift(selectedModel);
ids.push(selectedModel);
}
return ids;
}, [hfResults, selectedModel]);
@ -375,7 +375,20 @@ export function ModelSection() {
</TooltipContent>
</Tooltip>
</span>
<div ref={comboboxAnchorRef}>
<div
ref={comboboxAnchorRef}
onKeyDown={(event) => {
if (event.key !== "Enter") return;
if (!(event.target instanceof HTMLInputElement)) return;
event.preventDefault();
if (hfResults.length > 0) {
handleModelSelect(hfResults[0].id);
} else {
const text = event.target.value.trim();
if (text) handleModelSelect(text);
}
}}
>
<Combobox
items={resultIds}
filteredItems={resultIds}