From 460f2cf6ad80d0eb28912516036d26ed225bb3ad Mon Sep 17 00:00:00 2001 From: mk0walsk Date: Thu, 27 Nov 2025 04:15:27 +0200 Subject: [PATCH] Fix indefinite article usage in comments and docstrings (#3648) --- unsloth/chat_templates.py | 4 ++-- unsloth/models/falcon_h1.py | 2 +- unsloth/ollama_template_mappers.py | 2 +- unsloth/tokenizer_utils.py | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/unsloth/chat_templates.py b/unsloth/chat_templates.py index 823ce0ee6c..63d310af8e 100644 --- a/unsloth/chat_templates.py +++ b/unsloth/chat_templates.py @@ -2593,7 +2593,7 @@ default_system_message = \ extra_eos_tokens = None, ): """ - Creates a Ollama modelfile and a HF Jinja template from a custom + Creates an Ollama modelfile and a HF Jinja template from a custom template. You must provide 2x examples of an input & output. There is an optional system message as well. @@ -2930,7 +2930,7 @@ extra_eos_tokens = None, ): """ - Creates a Ollama modelfile and a HF Jinja template from a custom + Creates an Ollama modelfile and a HF Jinja template from a custom template. You must provide 2x examples of an input & output. There is an optional system message as well. diff --git a/unsloth/models/falcon_h1.py b/unsloth/models/falcon_h1.py index 3010d37163..c6a413ee40 100644 --- a/unsloth/models/falcon_h1.py +++ b/unsloth/models/falcon_h1.py @@ -57,7 +57,7 @@ try: FalconH1Attention, ) except ModuleNotFoundError: - # if we are on a old version of transformers technically it should fail in the try except above + # if we are on an old version of transformers technically it should fail in the try except above # but if somehow we make it here, we need to raise an error since FalconH1Attention is not available # or renamed raise ImportError( diff --git a/unsloth/ollama_template_mappers.py b/unsloth/ollama_template_mappers.py index 3ad0e334d2..ea1882e117 100644 --- a/unsloth/ollama_template_mappers.py +++ b/unsloth/ollama_template_mappers.py @@ -1520,7 +1520,7 @@ Loop over messages and look for a user-provided system message and documents {{- /* NOTE: Since Ollama collates consecutive roles, for control and documents, we - work around this by allowing the role to contain an qualifier after the + work around this by allowing the role to contain a qualifier after the role string. */ -}} diff --git a/unsloth/tokenizer_utils.py b/unsloth/tokenizer_utils.py index af6bba9de2..99651643a8 100644 --- a/unsloth/tokenizer_utils.py +++ b/unsloth/tokenizer_utils.py @@ -600,7 +600,7 @@ def load_correct_tokenizer( ### 1. Fixup tokenizer's chat_template old_chat_template = getattr(tokenizer, "chat_template", None) - # Ignore mistral type models since they don't have a add_generation_prompt + # Ignore mistral type models since they don't have an add_generation_prompt if "mistral" in str(getattr(tokenizer, "name_or_path", "")).lower(): chat_template = old_chat_template