From 3be49070cc02ef4932b2e67fecf050ce574b858d Mon Sep 17 00:00:00 2001 From: Nilay <118994073+NilayYadav@users.noreply.github.com> Date: Thu, 16 Jul 2026 19:40:30 +0530 Subject: [PATCH] fix config cards clipping content at narrow window widths (#7146) --- .../src/features/studio/sections/dataset-section.tsx | 6 +----- .../src/features/studio/sections/params-section.tsx | 7 +------ .../src/features/studio/sections/training-section.tsx | 3 +-- studio/frontend/src/index.css | 6 +----- 4 files changed, 4 insertions(+), 18 deletions(-) diff --git a/studio/frontend/src/features/studio/sections/dataset-section.tsx b/studio/frontend/src/features/studio/sections/dataset-section.tsx index d00d192bb2..bb74b0d061 100644 --- a/studio/frontend/src/features/studio/sections/dataset-section.tsx +++ b/studio/frontend/src/features/studio/sections/dataset-section.tsx @@ -683,11 +683,7 @@ export function DatasetSection() { title={t("studio.dataset.title")} description={t("studio.dataset.description")} accent="indigo" - className={`dark:shadow-border ${ - advancedOpen || (datasetSource === "upload" && uploadedFile) - ? "min-h-studio-config-column" - : "h-studio-config-column" - }`} + className="dark:shadow-border min-h-studio-config-column" >
{(() => { diff --git a/studio/frontend/src/features/studio/sections/params-section.tsx b/studio/frontend/src/features/studio/sections/params-section.tsx index 8d6e18b83f..ad438f63f1 100644 --- a/studio/frontend/src/features/studio/sections/params-section.tsx +++ b/studio/frontend/src/features/studio/sections/params-section.tsx @@ -192,7 +192,6 @@ export function ParamsSection(): ReactElement { const showVisionImageSize = showVisionLora && !isDeepseekOcr; const [loraOpen, setLoraOpen] = useState(false); const [hyperOpen, setHyperOpen] = useState(false); - const needsExpandedHeight = isCpt || (isLora && loraOpen) || hyperOpen; const [ctxInput, setCtxInput] = useState(String(store.contextLength)); const ctxAnchorRef = useRef(null); const ctxItems = CONTEXT_LENGTHS.map(String); @@ -233,11 +232,7 @@ export function ParamsSection(): ReactElement { title={t("studio.params.title")} description={t("studio.params.description")} accent="orange" - className={`${ - needsExpandedHeight - ? "min-h-studio-config-column" - : "h-studio-config-column" - } duration-150`} + className="min-h-studio-config-column" >
diff --git a/studio/frontend/src/features/studio/sections/training-section.tsx b/studio/frontend/src/features/studio/sections/training-section.tsx index 6d1ee9411b..5650b9c145 100644 --- a/studio/frontend/src/features/studio/sections/training-section.tsx +++ b/studio/frontend/src/features/studio/sections/training-section.tsx @@ -53,7 +53,6 @@ export function TrainingSection() { ((!store.isVisionModel && store.isDatasetImage === true) || (!store.isAudioModel && store.isDatasetAudio === true)); const configValidation = validateTrainingConfig(store); - const hasMessage = !!(startError || isIncompatible || (!configValidation.ok && configValidation.message)); const fileInputRef = useRef(null); const handleFileUpload = (e: React.ChangeEvent) => { @@ -125,7 +124,7 @@ export function TrainingSection() { title={t("studio.training.title")} description={t("studio.training.description")} accent="blue" - className={hasMessage ? "min-h-studio-config-column" : "h-studio-config-column"} + className="min-h-studio-config-column" >
{/* Loss chart */} diff --git a/studio/frontend/src/index.css b/studio/frontend/src/index.css index 159eba743f..333ed70f6a 100644 --- a/studio/frontend/src/index.css +++ b/studio/frontend/src/index.css @@ -2048,15 +2048,11 @@ html[data-chat-font] .aui-root { } } - /* Fine-tuning Studio: equal default height, expandable when needed (md+) */ + /* Fine-tuning Studio: equal minimum card height, grows with content (md+) */ .min-h-studio-config-column { @apply md:min-h-[520px]; } - .h-studio-config-column { - @apply md:h-[520px]; - } - [data-streamdown="unordered-list"] { list-style-type: disc; list-style-position: outside;