ceos/unsloth
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fixed parameters (finetune language, vision, attention layers, and mlp_modules) not updating

Browse source
This commit is contained in:
sshah229 2026-01-21 02:40:25 -07:00
commit 30c75e6d41
1 changed files with 4 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

6
cli/config.py
View file

@ -77,9 +77,11 @@ class Config(BaseModel):
"""Return kwargs for trainer.prepare_model_for_training()."""
# Determine target modules based on model type
if use_lora and is_vision:
target_modules = "all-linear" if self.lora.vision_all_linear else []
# Vision models expect a string (e.g., "all-linear"); fall back to None to use trainer defaults
target_modules = "all-linear" if self.lora.vision_all_linear else None
else:
target_modules = [m.strip() for m in self.lora.target_modules.split(",") if m.strip()]
parsed = [m.strip() for m in str(self.lora.target_modules).split(",") if m and m.strip()]
target_modules = parsed or None
return {
"use_lora": use_lora,