docker: round-3 review fixes (concurrency, lockfile wording)
- docker-publish.yml: add `concurrency: docker-publish-${{ github.ref }}`
(cancel-in-progress: false) so two pushes to main never race the
`:latest` retag. Don't cancel in-progress runs -- the build is
expensive and a half-built image left around is worse than a stale
:latest for a few minutes.
- Dockerfile: soften the requirements.lock.txt comment. `pip freeze`
captures versions but not wheel hashes, and several deps resolve
from VCS / nightly indexes that float, so the file is not actually
byte-reproducible. Reword as an "informational pin record".
This commit is contained in:
parent
cceeeb1e1b
commit
2faf827f42
2 changed files with 15 additions and 4 deletions
9
.github/workflows/docker-publish.yml
vendored
9
.github/workflows/docker-publish.yml
vendored
|
|
@ -49,6 +49,15 @@ env:
|
|||
REGISTRY: docker.io
|
||||
IMAGE_NAME: unsloth/unsloth
|
||||
|
||||
# Serialise per-ref runs so two pushes to main (or two scheduled
|
||||
# fires racing a manual dispatch) don't both retag `:latest` from
|
||||
# different commits. Don't cancel in-progress runs -- the build is
|
||||
# expensive and a half-built image left around in Docker Hub is
|
||||
# worse than a slightly stale `:latest` for a few minutes.
|
||||
concurrency:
|
||||
group: docker-publish-${{ github.ref }}
|
||||
cancel-in-progress: false
|
||||
|
||||
jobs:
|
||||
# ---------------------------------------------------------------------------
|
||||
# Per-arch build. The matrix fans out two parallel jobs on the matching
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue