ceos/unsloth
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

CI(ui): drop nonexistent username locator (auth form is password-only)

Browse source 
studio/frontend/src/features/auth/components/auth-form.tsx hard-codes
the login username to HIDDEN_LOGIN_USERNAME = "unsloth"; the only
visible input is #password. The previous Playwright step waited 30s
for `input[name='username'], #username` and timed out on every CI run.

I caught this locally and patched the test script during validation
but didn't bring the fix back to the workflow file -- this commit
applies it. Wait for #password only, fill the rotated password, click
submit. Verified locally end-to-end against a fresh Studio.
This commit is contained in:
Daniel Han 2026-05-07 02:10:14 +00:00
commit 2f219615ad
1 changed files with 4 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

10
.github/workflows/studio-ui-smoke.yml vendored
View file

@ -211,16 +211,14 @@ jobs:
# ─────────────────────────────────────────────────────
# 1. Login form (password already rotated by CI step).
# auth-form.tsx hard-codes the username to
# HIDDEN_LOGIN_USERNAME = "unsloth", so the form has only
# a `#password` field -- no username input to fill.
# ─────────────────────────────────────────────────────
step("login form sign-in")
page.goto(f"{BASE}/login")
# Username field is `username` or `#username`; password is
# `password` or `#password`. Try a few common patterns.
uname = page.locator("input[name='username'], #username").first
pword = page.locator("input[name='password'], #password").first
uname.wait_for(state = "visible", timeout = 30_000)
pword = page.locator("#password").first
pword.wait_for(state = "visible", timeout = 30_000)
uname.fill("unsloth")
pword.fill(NEW)
shoot("login-filled")
page.locator('button[type="submit"]').click()