From 18a60b930a8d905d58c437df19e9a607dc2d6862 Mon Sep 17 00:00:00 2001 From: Shine1i Date: Tue, 10 Mar 2026 20:27:11 +0100 Subject: [PATCH] chore/fix(studio): add placeholder dropdowns for dataset subset and splits in disabled state --- .../studio/sections/dataset-section.tsx | 13 +++++ .../hf-dataset-subset-split-selectors.tsx | 53 +++++++++++++++++-- 2 files changed, 62 insertions(+), 4 deletions(-) diff --git a/studio/frontend/src/features/studio/sections/dataset-section.tsx b/studio/frontend/src/features/studio/sections/dataset-section.tsx index c61565cbd9..7ff9e675ab 100644 --- a/studio/frontend/src/features/studio/sections/dataset-section.tsx +++ b/studio/frontend/src/features/studio/sections/dataset-section.tsx @@ -641,6 +641,19 @@ export function DatasetSection() { datasetEvalSplit={datasetEvalSplit} setDatasetEvalSplit={setDatasetEvalSplit} /> + ) : !selectedDatasetName ? ( + ) : datasetSource === "upload" && selectedLocalDataset ? (
diff --git a/studio/frontend/src/features/training/components/hf-dataset-subset-split-selectors.tsx b/studio/frontend/src/features/training/components/hf-dataset-subset-split-selectors.tsx index 0dab4685be..b177a41999 100644 --- a/studio/frontend/src/features/training/components/hf-dataset-subset-split-selectors.tsx +++ b/studio/frontend/src/features/training/components/hf-dataset-subset-split-selectors.tsx @@ -56,6 +56,8 @@ export function HfDatasetSubsetSplitSelectors({ } = useHfDatasetSplits(enabled ? datasetName : null, datasetSubset, { accessToken, }); + const showPlaceholderDropdowns = + variant === "studio" && !enabled && !datasetName; // Auto-select subset and split in one pass to avoid racing effects useEffect(() => { @@ -83,12 +85,48 @@ export function HfDatasetSubsetSplitSelectors({ setDatasetSplit, ]); - if (!enabled || !datasetName) return null; - const showDropdowns = !isLoading && !error && hfSubsets.length > 0; return ( <> + {showPlaceholderDropdowns && ( + <> +
+ + +
+ + + )} + {isLoading && (
@@ -217,8 +260,9 @@ function SelectorDropdown({ onChange(v === "_none" ? null : v)} + disabled={disabled} >