ceos/unsloth
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

docker/test_locally.sh: fail fast + pin notebook fetch to immutable SHA

Browse source 
Two small fixes:

1. The fallback build-context refresh used `git pull --ff-only | tail`,
   which on this script (set -uo pipefail, no -e) silently masked any
   non-zero exit from pull. A failed refresh would then quietly build
   from a stale clone. Wrap both clone and pull in `if ! ...; then fail`
   so refresh failures abort the run with a clear message.

2. The gpt-oss-20B notebook was fetched from notebooks/main, which is
   mutable. Pin to the current immutable SHA (efe20c9) via NB_REPO_REF
   so reruns of this script don't silently change semantics when
   notebooks/main rolls forward. Override via env when you want to
   verify a newer notebook.
This commit is contained in:
Daniel Han 2026-05-27 15:56:30 +00:00
commit 10f0a03c8f
1 changed files with 15 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

19
docker/test_locally.sh
View file

@ -148,10 +148,17 @@ else
BUILD_CTX="/tmp/unsloth-pr/docker"
if [[ ! -d /tmp/unsloth-pr/.git ]]; then
echo " cloning docker-blackwell-build branch..."
git clone --depth 1 -b docker-blackwell-build \
https://github.com/unslothai/unsloth.git /tmp/unsloth-pr 2>&1 | tail -3
if ! git clone --depth 1 -b docker-blackwell-build \
https://github.com/unslothai/unsloth.git /tmp/unsloth-pr 2>&1 | tail -3; then
fail "could not clone docker-blackwell-build into /tmp/unsloth-pr; refusing to build from stale context"
fi
else
git -C /tmp/unsloth-pr pull --ff-only 2>&1 | tail -2
# `set -e` is not active in this script, so a failing pull would
# otherwise be silently masked and we'd build from a stale clone.
# Explicitly fail loudly when the fast-forward refresh cannot run.
if ! git -C /tmp/unsloth-pr pull --ff-only 2>&1 | tail -2; then
fail "git pull --ff-only failed in /tmp/unsloth-pr; refusing to build from stale context (delete /tmp/unsloth-pr to reclone)"
fi
fi
fi
echo " build context: $BUILD_CTX"
@ -304,7 +311,11 @@ echo "=== fetch + convert notebook ==="
# ...` lines) that nbformat dumps verbatim and Python cannot parse.
# 2. Comment out any stray !cmd / %magic lines in non-install cells.
pip install -q nbformat
curl -fsSL 'https://raw.githubusercontent.com/unslothai/notebooks/main/nb/gpt-oss-(20B)-Fine-tuning.ipynb' -o nb.ipynb
# Pin to an immutable commit so this validation script doesn't silently
# change semantics when notebooks/main rolls forward. Bump deliberately
# when the upstream notebook gets a fix you want to verify against.
NB_REPO_REF="${NB_REPO_REF:-efe20c97a5bba3088b25fe068a4b1c98c0cf3a3a}"
curl -fsSL "https://raw.githubusercontent.com/unslothai/notebooks/${NB_REPO_REF}/nb/gpt-oss-(20B)-Fine-tuning.ipynb" -o nb.ipynb
test -s nb.ipynb || { echo "FAIL: nb.ipynb was not downloaded"; exit 1; }
python - <<'PY'
import nbformat, re