diff --git a/studio/frontend/src/features/studio/sections/dataset-section.tsx b/studio/frontend/src/features/studio/sections/dataset-section.tsx index 00ee520120..338a264579 100644 --- a/studio/frontend/src/features/studio/sections/dataset-section.tsx +++ b/studio/frontend/src/features/studio/sections/dataset-section.tsx @@ -13,7 +13,6 @@ import { ComboboxItem, ComboboxList, } from "@/components/ui/combobox"; -import { Input } from "@/components/ui/input"; import { InputGroupAddon } from "@/components/ui/input-group"; import { Select, @@ -291,6 +290,10 @@ export function DatasetSection() { setDatasetSplit={setDatasetSplit} datasetEvalSplit={datasetEvalSplit} setDatasetEvalSplit={setDatasetEvalSplit} + datasetSliceStart={datasetSliceStart} + setDatasetSliceStart={setDatasetSliceStart} + datasetSliceEnd={datasetSliceEnd} + setDatasetSliceEnd={setDatasetSliceEnd} /> @@ -302,93 +305,51 @@ export function DatasetSection() { Advanced -
-
- - Target Format - - - - - - Format of your training data. Auto-detect works for most - datasets.{" "} - - Read more - - - - - -
-
- - Index Range - - - - - - Slice the dataset by row index. Both start and end are - inclusive. Leave empty to use all rows. - - - -
- - setDatasetSliceStart(e.target.value || null) - } - /> - - setDatasetSliceEnd(e.target.value || null) - } - /> -
-
+
+ + Target Format + + + + + + Format of your training data. Auto-detect works for most + datasets.{" "} + + Read more + + + + +
diff --git a/studio/frontend/src/features/training/components/hf-dataset-subset-split-selectors.tsx b/studio/frontend/src/features/training/components/hf-dataset-subset-split-selectors.tsx index d21fd55ff4..5a21ec6d83 100644 --- a/studio/frontend/src/features/training/components/hf-dataset-subset-split-selectors.tsx +++ b/studio/frontend/src/features/training/components/hf-dataset-subset-split-selectors.tsx @@ -5,6 +5,7 @@ import { SelectTrigger, SelectValue, } from "@/components/ui/select"; +import { Input } from "@/components/ui/input"; import { Spinner } from "@/components/ui/spinner"; import { Tooltip, @@ -31,6 +32,10 @@ type Props = { setDatasetSplit: (v: string | null) => void; datasetEvalSplit: string | null; setDatasetEvalSplit: (v: string | null) => void; + datasetSliceStart?: string | null; + setDatasetSliceStart?: (v: string | null) => void; + datasetSliceEnd?: string | null; + setDatasetSliceEnd?: (v: string | null) => void; }; export function HfDatasetSubsetSplitSelectors({ @@ -44,6 +49,10 @@ export function HfDatasetSubsetSplitSelectors({ setDatasetSplit, datasetEvalSplit, setDatasetEvalSplit, + datasetSliceStart, + setDatasetSliceStart, + datasetSliceEnd, + setDatasetSliceEnd, }: Props) { const { subsets: hfSubsets, @@ -155,16 +164,89 @@ export function HfDatasetSubsetSplitSelectors({ /> )} - + {variant === "studio" && setDatasetSliceStart && setDatasetSliceEnd ? ( +
+ +
+ + Slice Start + + + + + + Inclusive start row index. Leave empty to start from the beginning. + + + + + setDatasetSliceStart(e.target.value || null) + } + /> +
+
+ + Slice End + + + + + + Inclusive end row index. Leave empty to use all remaining rows. + + + + + setDatasetSliceEnd(e.target.value || null) + } + /> +
+
+ ) : ( + + )} )}