From 01142074719b7fb04a775c563d19f4bf4e2cc59b Mon Sep 17 00:00:00 2001 From: Daniel Han Date: Thu, 7 May 2026 11:46:31 +0000 Subject: [PATCH] CI(notebooks): mark lint step continue-on-error until backlog clears The first run on unslothai/notebooks@main surfaces 27 errors + 6 warnings, all real (peft 0.19+ / torchao floor missing in 6 nb/ notebooks the previous template fixes did not reach, 14 git+ HEAD installs in hand-tuned exception notebooks, 6 torch/torchcodec ABI mismatches, 1 transformers/tokenizers --no-deps drift). Mirror the same continue-on-error pattern PR #5298 used for biome:check on the frontend so the count surfaces in the PR check UI without forcing the backlog to be cleaned in the same change. Drop continue-on-error once the count hits zero. --- .github/workflows/notebooks-ci.yml | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/.github/workflows/notebooks-ci.yml b/.github/workflows/notebooks-ci.yml index 90271877ba..bc8226121d 100644 --- a/.github/workflows/notebooks-ci.yml +++ b/.github/workflows/notebooks-ci.yml @@ -114,6 +114,16 @@ jobs: --out _converted - name: Lint (install cells + AST scan, env-scoped) + # Reported as non-blocking (continue-on-error: true) until the + # backlog of pre-existing findings on unslothai/notebooks@main is + # cleared. Same pattern PR #5298 used for biome:check on the + # frontend. As of this commit the live tree surfaces 27 errors + + # 6 warnings, all real (peft/torchao floor missing in 6 nb/ + # notebooks, 14 git+ HEAD installs in hand-tuned exception + # notebooks, 6 torch/torchcodec ABI mismatches, 1 + # transformers/tokenizers --no-deps drift). The count surfaces + # in the PR check UI. Drop continue-on-error once it hits zero. + continue-on-error: true run: | python unsloth/scripts/notebook_validator.py lint \ --notebooks-dir notebooks \